[GitHub] [hudi] yui2010 commented on pull request #2256: [HUDI-1398] Align insert file size for reducing IO

2020-12-28 Thread GitBox
yui2010 commented on pull request #2256: URL: https://github.com/apache/hudi/pull/2256#issuecomment-751981155 Hi @nsivabalan I missed the flink/java client also have UpsertPartitioner . and synchronised modify in

[GitHub] [hudi] codecov-io commented on pull request #2390: [MINOR] sync UpsertPartitioner modify of HUDI-1398 to flink/java

2020-12-28 Thread GitBox
codecov-io commented on pull request #2390: URL: https://github.com/apache/hudi/pull/2390#issuecomment-751980478 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2390?src=pr=h1) Report > Merging [#2390](https://codecov.io/gh/apache/hudi/pull/2390?src=pr=desc) (0beb995) into

[GitHub] [hudi] yui2010 opened a new pull request #2390: [MINOR] sync UpsertPartitioner modify of HUDI-1398 to flink/java

2020-12-28 Thread GitBox
yui2010 opened a new pull request #2390: URL: https://github.com/apache/hudi/pull/2390 ## *Tips* - *Thank you very much for contributing to Apache Hudi.* - *Please review https://hudi.apache.org/contributing.html before opening a pull request.* ## What is the purpose of the

[GitHub] [hudi] codecov-io edited a comment on pull request #2379: [HUDI-1399] support a independent clustering spark job to asynchronously clustering

2020-12-28 Thread GitBox
codecov-io edited a comment on pull request #2379: URL: https://github.com/apache/hudi/pull/2379#issuecomment-751244130 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2379?src=pr=h1) Report > Merging [#2379](https://codecov.io/gh/apache/hudi/pull/2379?src=pr=desc) (e457785) into

[GitHub] [hudi] codecov-io edited a comment on pull request #2045: [HUDI-1147] Modify GenericRecordFullPayloadGenerator to generate vali…

2020-12-28 Thread GitBox
codecov-io edited a comment on pull request #2045: URL: https://github.com/apache/hudi/pull/2045#issuecomment-751953148 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2045?src=pr=h1) Report > Merging [#2045](https://codecov.io/gh/apache/hudi/pull/2045?src=pr=desc) (0eea618) into

[GitHub] [hudi] codecov-io edited a comment on pull request #2045: [HUDI-1147] Modify GenericRecordFullPayloadGenerator to generate vali…

2020-12-28 Thread GitBox
codecov-io edited a comment on pull request #2045: URL: https://github.com/apache/hudi/pull/2045#issuecomment-751953148 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2045?src=pr=h1) Report > Merging [#2045](https://codecov.io/gh/apache/hudi/pull/2045?src=pr=desc) (27726a9) into

[GitHub] [hudi] codecov-io edited a comment on pull request #2379: [HUDI-1399] support a independent clustering spark job to asynchronously clustering

2020-12-28 Thread GitBox
codecov-io edited a comment on pull request #2379: URL: https://github.com/apache/hudi/pull/2379#issuecomment-751244130 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2379?src=pr=h1) Report > Merging [#2379](https://codecov.io/gh/apache/hudi/pull/2379?src=pr=desc) (e457785) into

[GitHub] [hudi] codecov-io edited a comment on pull request #2045: [HUDI-1147] Modify GenericRecordFullPayloadGenerator to generate vali…

2020-12-28 Thread GitBox
codecov-io edited a comment on pull request #2045: URL: https://github.com/apache/hudi/pull/2045#issuecomment-751953148 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2045?src=pr=h1) Report > Merging [#2045](https://codecov.io/gh/apache/hudi/pull/2045?src=pr=desc) (0eea618) into

[GitHub] [hudi] codecov-io commented on pull request #2045: [HUDI-1147] Modify GenericRecordFullPayloadGenerator to generate vali…

2020-12-28 Thread GitBox
codecov-io commented on pull request #2045: URL: https://github.com/apache/hudi/pull/2045#issuecomment-751953148 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2045?src=pr=h1) Report > Merging [#2045](https://codecov.io/gh/apache/hudi/pull/2045?src=pr=desc) (27726a9) into

[jira] [Updated] (HUDI-1474) Add additional unit tests to TestHBaseIndex

2020-12-28 Thread sivabalan narayanan (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sivabalan narayanan updated HUDI-1474: -- Status: Open (was: New) > Add additional unit tests to TestHBaseIndex >

[hudi] branch master updated (b83d1d3 -> da51aa6)

2020-12-28 Thread sivabalan
This is an automated email from the ASF dual-hosted git repository. sivabalan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git. from b83d1d3 [HUDI-1484] Escape the partition value in HiveSyncTool (#2363) add da51aa6 [HUDI-1474] Add

[GitHub] [hudi] nsivabalan merged pull request #2349: [HUDI-1474] Add additional unit tests to TestHBaseIndex

2020-12-28 Thread GitBox
nsivabalan merged pull request #2349: URL: https://github.com/apache/hudi/pull/2349 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hudi] nsivabalan merged pull request #2363: [HUDI-1484] Escape the partition value in HiveSyncTool

2020-12-28 Thread GitBox
nsivabalan merged pull request #2363: URL: https://github.com/apache/hudi/pull/2363 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (HUDI-1484) Escape the partition value in HiveSyncTool

2020-12-28 Thread sivabalan narayanan (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sivabalan narayanan resolved HUDI-1484. --- Resolution: Fixed > Escape the partition value in HiveSyncTool >

[hudi] branch master updated (4c17528 -> b83d1d3)

2020-12-28 Thread sivabalan
This is an automated email from the ASF dual-hosted git repository. sivabalan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git. from 4c17528 [HUDI-1398] Align insert file size for reducing IO (#2256) add b83d1d3 [HUDI-1484] Escape the

[GitHub] [hudi] Nieal-Yang commented on pull request #2375: [HUDI-1332] Introduce FlinkHoodieBloomIndex to hudi-flink-client

2020-12-28 Thread GitBox
Nieal-Yang commented on pull request #2375: URL: https://github.com/apache/hudi/pull/2375#issuecomment-751938482 Hi @garyli1019. Maybe I think the current implementation is OK. Beacause even in streaming job, we need to accumulate batch records in memory during the check-point cycle and

[jira] [Resolved] (HUDI-1490) Incremental Query fails if there are partitions that have no incremental changes

2020-12-28 Thread sivabalan narayanan (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sivabalan narayanan resolved HUDI-1490. --- Resolution: Fixed > Incremental Query fails if there are partitions that have no

[GitHub] [hudi] lw309637554 edited a comment on pull request #2389: [HUDI-1498] Read clustering plan from requested for inflight instant

2020-12-28 Thread GitBox
lw309637554 edited a comment on pull request #2389: URL: https://github.com/apache/hudi/pull/2389#issuecomment-751936111 @satishkotha LGTM, just one minor comment . Yesterday when i do https://github.com/apache/hudi/pull/2379, also meet this issue. In

[GitHub] [hudi] lw309637554 removed a comment on pull request #2389: [HUDI-1498] Read clustering plan from requested for inflight instant

2020-12-28 Thread GitBox
lw309637554 removed a comment on pull request #2389: URL: https://github.com/apache/hudi/pull/2389#issuecomment-751937383 > @satishkotha LGTM, just one minor comment. Yesterday when i do #2379, also meet this issue. > In #2379 i have fix two others issue when async clustering.

[GitHub] [hudi] lw309637554 commented on pull request #2389: [HUDI-1498] Read clustering plan from requested for inflight instant

2020-12-28 Thread GitBox
lw309637554 commented on pull request #2389: URL: https://github.com/apache/hudi/pull/2389#issuecomment-751937383 > @satishkotha LGTM, just one minor comment. Yesterday when i do #2379, also meet this issue. > In #2379 i have fix two others issue when async clustering.

[jira] [Assigned] (HUDI-1490) Incremental Query fails if there are partitions that have no incremental changes

2020-12-28 Thread sivabalan narayanan (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sivabalan narayanan reassigned HUDI-1490: - Assignee: Balaji Varadarajan > Incremental Query fails if there are partitions

[jira] [Updated] (HUDI-1490) Incremental Query fails if there are partitions that have no incremental changes

2020-12-28 Thread sivabalan narayanan (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sivabalan narayanan updated HUDI-1490: -- Status: In Progress (was: Open) > Incremental Query fails if there are partitions that

[hudi] branch master updated (0ecdec3 -> 4c17528)

2020-12-28 Thread sivabalan
This is an automated email from the ASF dual-hosted git repository. sivabalan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git. from 0ecdec3 [MINOR] Remove the duplicate code in AbstractHoodieWriteClient.startCommit (#2385) add 4c17528

[GitHub] [hudi] nsivabalan merged pull request #2256: [HUDI-1398] Align insert file size for reducing IO

2020-12-28 Thread GitBox
nsivabalan merged pull request #2256: URL: https://github.com/apache/hudi/pull/2256 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (HUDI-1481) support inline clustering unit tests for spark datasource and deltastreamer

2020-12-28 Thread liwei (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liwei resolved HUDI-1481. - Resolution: Fixed > support inline clustering unit tests for spark datasource and deltastreamer >

[jira] [Resolved] (HUDI-1354) Block updates and replace on file groups in clustering

2020-12-28 Thread liwei (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liwei resolved HUDI-1354. - Resolution: Fixed > Block updates and replace on file groups in clustering >

[jira] [Resolved] (HUDI-1350) Support Partition level delete API in HUDI on top on Insert Overwrite

2020-12-28 Thread liwei (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liwei resolved HUDI-1350. - Resolution: Fixed > Support Partition level delete API in HUDI on top on Insert Overwrite >

[jira] [Updated] (HUDI-1354) Block updates and replace on file groups in clustering

2020-12-28 Thread liwei (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liwei updated HUDI-1354: Status: Closed (was: Patch Available) > Block updates and replace on file groups in clustering >

[jira] [Updated] (HUDI-1354) Block updates and replace on file groups in clustering

2020-12-28 Thread liwei (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liwei updated HUDI-1354: Status: Patch Available (was: In Progress) > Block updates and replace on file groups in clustering >

[jira] [Reopened] (HUDI-1354) Block updates and replace on file groups in clustering

2020-12-28 Thread liwei (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liwei reopened HUDI-1354: - > Block updates and replace on file groups in clustering > -- > >

[jira] [Updated] (HUDI-1498) Always read clustering plan from requested file

2020-12-28 Thread liwei (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liwei updated HUDI-1498: Status: Open (was: New) > Always read clustering plan from requested file >

[jira] [Updated] (HUDI-1350) Support Partition level delete API in HUDI on top on Insert Overwrite

2020-12-28 Thread liwei (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liwei updated HUDI-1350: Status: Patch Available (was: In Progress) > Support Partition level delete API in HUDI on top on Insert Overwrite

[jira] [Updated] (HUDI-1350) Support Partition level delete API in HUDI on top on Insert Overwrite

2020-12-28 Thread liwei (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liwei updated HUDI-1350: Status: Closed (was: Patch Available) > Support Partition level delete API in HUDI on top on Insert Overwrite >

[jira] [Reopened] (HUDI-1350) Support Partition level delete API in HUDI on top on Insert Overwrite

2020-12-28 Thread liwei (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liwei reopened HUDI-1350: - > Support Partition level delete API in HUDI on top on Insert Overwrite >

[GitHub] [hudi] codecov-io edited a comment on pull request #2379: [HUDI-1399] support a independent clustering spark job to asynchronously clustering

2020-12-28 Thread GitBox
codecov-io edited a comment on pull request #2379: URL: https://github.com/apache/hudi/pull/2379#issuecomment-751244130 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2379?src=pr=h1) Report > Merging [#2379](https://codecov.io/gh/apache/hudi/pull/2379?src=pr=desc) (c825980) into

[GitHub] [hudi] lw309637554 commented on a change in pull request #2389: [HUDI-1498] Read clustering plan from requested for inflight instant

2020-12-28 Thread GitBox
lw309637554 commented on a change in pull request #2389: URL: https://github.com/apache/hudi/pull/2389#discussion_r549557534 ## File path: hudi-common/src/main/java/org/apache/hudi/common/util/ClusteringUtils.java ## @@ -68,21 +69,27 @@

[GitHub] [hudi] lw309637554 commented on pull request #2389: [HUDI-1498] Read clustering plan from requested for inflight instant

2020-12-28 Thread GitBox
lw309637554 commented on pull request #2389: URL: https://github.com/apache/hudi/pull/2389#issuecomment-751936111 @satishkotha LGTM, great . Yesterday when i do https://github.com/apache/hudi/pull/2379, also meet this issue. In https://github.com/apache/hudi/pull/2379 i have fix two

[jira] [Commented] (HUDI-1444) fix the error when rollback commit that belong to a non partition table

2020-12-28 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17255787#comment-17255787 ] Vinoth Chandar commented on HUDI-1444: -- we can get it, if possible. not sure I ll call it a blocker.

[GitHub] [hudi] vinothchandar commented on a change in pull request #2374: [WIP] [HUDI-845] Added locking capability to allow multiple writers

2020-12-28 Thread GitBox
vinothchandar commented on a change in pull request #2374: URL: https://github.com/apache/hudi/pull/2374#discussion_r549550664 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieClient.java ## @@ -48,6 +50,7 @@ protected final

[GitHub] [hudi] codecov-io edited a comment on pull request #2389: [HUDI-1498] Read clustering plan from requested for inflight instant

2020-12-28 Thread GitBox
codecov-io edited a comment on pull request #2389: URL: https://github.com/apache/hudi/pull/2389#issuecomment-751923506 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hudi] garyli1019 commented on issue #2377: Hive query hudi table, but selected all update history datas

2020-12-28 Thread GitBox
garyli1019 commented on issue #2377: URL: https://github.com/apache/hudi/issues/2377#issuecomment-751928967 Looks like the flink streamer doesn't support the hive sync tool yet. This is an automated message from the Apache

[GitHub] [hudi] vinothchandar commented on pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

2020-12-28 Thread GitBox
vinothchandar commented on pull request #2359: URL: https://github.com/apache/hudi/pull/2359#issuecomment-751928701 @n3nash I have left my first round of comments. Main call out: https://github.com/apache/hudi/pull/2359#discussion_r549550003

[GitHub] [hudi] vinothchandar commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

2020-12-28 Thread GitBox
vinothchandar commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r549549304 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTimelineArchiveLog.java ## @@ -180,7 +186,14 @@ public boolean

[GitHub] [hudi] yanghua merged pull request #2385: [MINOR] Remove the duplicate code in AbstractHoodieWriteClient.startC…

2020-12-28 Thread GitBox
yanghua merged pull request #2385: URL: https://github.com/apache/hudi/pull/2385 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[hudi] branch master updated (76faf59 -> 0ecdec3)

2020-12-28 Thread vinoyang
This is an automated email from the ASF dual-hosted git repository. vinoyang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git. from 76faf59 [HUDI-1495] Upgrade Flink version to 1.12.0 (#2384) add 0ecdec3 [MINOR] Remove the duplicate code in

[GitHub] [hudi] codecov-io edited a comment on pull request #2260: [HUDI-1381] Schedule compaction based on time elapsed

2020-12-28 Thread GitBox
codecov-io edited a comment on pull request #2260: URL: https://github.com/apache/hudi/pull/2260#issuecomment-729530724 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2260?src=pr=h1) Report > Merging [#2260](https://codecov.io/gh/apache/hudi/pull/2260?src=pr=desc) (7b63729) into

[GitHub] [hudi] vinothchandar commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

2020-12-28 Thread GitBox
vinothchandar commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r549547956 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTimelineArchiveLog.java ## @@ -165,13 +167,17 @@ public

[GitHub] [hudi] vinothchandar commented on pull request #2366: [HUDI-1312] [RFC-15] Support for metadata listing for snapshot queries through Hive/SparkSQL

2020-12-28 Thread GitBox
vinothchandar commented on pull request #2366: URL: https://github.com/apache/hudi/pull/2366#issuecomment-751925963 @rmpifer This is kind of the last PR to merge, before I raise the large PR against master. Please let me know if you are working on the fixes in the next day or so. Happy to

[GitHub] [hudi] codecov-io edited a comment on pull request #2188: [HUDI-1347]fix Hbase index partition changes cause data duplication p…

2020-12-28 Thread GitBox
codecov-io edited a comment on pull request #2188: URL: https://github.com/apache/hudi/pull/2188#issuecomment-711139438 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2188?src=pr=h1) Report > Merging [#2188](https://codecov.io/gh/apache/hudi/pull/2188?src=pr=desc) (1573c9d) into

[GitHub] [hudi] danny0405 commented on pull request #2309: [HUDI-1441] - HoodieAvroUtils - rewrite() is not handling evolution o…

2020-12-28 Thread GitBox
danny0405 commented on pull request #2309: URL: https://github.com/apache/hudi/pull/2309#issuecomment-751925335 @nbalajee You may need to rebase your branch first in order to avoid unnecessary commits. This is an automated

[GitHub] [hudi] codecov-io edited a comment on pull request #2389: [HUDI-1498] Read clustering plan from requested for inflight instant

2020-12-28 Thread GitBox
codecov-io edited a comment on pull request #2389: URL: https://github.com/apache/hudi/pull/2389#issuecomment-751923506 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2389?src=pr=h1) Report > Merging [#2389](https://codecov.io/gh/apache/hudi/pull/2389?src=pr=desc) (6f24a49) into

[GitHub] [hudi] codecov-io edited a comment on pull request #2260: [HUDI-1381] Schedule compaction based on time elapsed

2020-12-28 Thread GitBox
codecov-io edited a comment on pull request #2260: URL: https://github.com/apache/hudi/pull/2260#issuecomment-729530724 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2260?src=pr=h1) Report > Merging [#2260](https://codecov.io/gh/apache/hudi/pull/2260?src=pr=desc) (7b63729) into

[GitHub] [hudi] codecov-io commented on pull request #2389: [HUDI-1498] Read clustering plan from requested for inflight instant

2020-12-28 Thread GitBox
codecov-io commented on pull request #2389: URL: https://github.com/apache/hudi/pull/2389#issuecomment-751923506 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2389?src=pr=h1) Report > Merging [#2389](https://codecov.io/gh/apache/hudi/pull/2389?src=pr=desc) (a70b324) into

[jira] [Closed] (HUDI-1495) Upgrade Flink version to 1.12.0

2020-12-28 Thread vinoyang (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang closed HUDI-1495. -- Fix Version/s: 0.7.0 Resolution: Done Done via master branch: 76faf59652468e9d6b8507216e52f282c585841d

[jira] [Updated] (HUDI-1495) Upgrade Flink version to 1.12.0

2020-12-28 Thread vinoyang (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang updated HUDI-1495: --- Status: Open (was: New) > Upgrade Flink version to 1.12.0 > --- > >

[GitHub] [hudi] yanghua merged pull request #2384: [HUDI-1495] Upgrade Flink version to 1.12.0

2020-12-28 Thread GitBox
yanghua merged pull request #2384: URL: https://github.com/apache/hudi/pull/2384 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[hudi] branch master updated (e177466 -> 76faf59)

2020-12-28 Thread vinoyang
This is an automated email from the ASF dual-hosted git repository. vinoyang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git. from e177466 [HUDI-1350] Support Partition level delete API in HUDI (#2254) add 76faf59 [HUDI-1495] Upgrade Flink

[GitHub] [hudi] hj2016 commented on a change in pull request #2188: [HUDI-1347]fix Hbase index partition changes cause data duplication p…

2020-12-28 Thread GitBox
hj2016 commented on a change in pull request #2188: URL: https://github.com/apache/hudi/pull/2188#discussion_r549543525 ## File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/SparkWriteHelper.java ## @@ -62,7 +62,7 @@ public static

[GitHub] [hudi] satishkotha opened a new pull request #2389: [HUDI-1498] Read clustering plan from requested for inflight instant

2020-12-28 Thread GitBox
satishkotha opened a new pull request #2389: URL: https://github.com/apache/hudi/pull/2389 ## What is the purpose of the pull request Inflight replacecommit has no content for clustering. Read corresponding ClusteringPlan from requested instant. ## Brief change log

[GitHub] [hudi] Karl-WangSK commented on a change in pull request #2260: [HUDI-1381] Schedule compaction based on time elapsed

2020-12-28 Thread GitBox
Karl-WangSK commented on a change in pull request #2260: URL: https://github.com/apache/hudi/pull/2260#discussion_r549539352 ## File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/compact/SparkScheduleCompactionActionExecutor.java ## @@ -90,4

[jira] [Updated] (HUDI-1498) Always read clustering plan from requested file

2020-12-28 Thread satish (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] satish updated HUDI-1498: - Description: Clustering inflight doesnt have 'ClusteringPlan'. Read content from corresponding requested file to

[jira] [Created] (HUDI-1498) Always read clustering plan from requested file

2020-12-28 Thread satish (Jira)
satish created HUDI-1498: Summary: Always read clustering plan from requested file Key: HUDI-1498 URL: https://issues.apache.org/jira/browse/HUDI-1498 Project: Apache Hudi Issue Type: Sub-task

[GitHub] [hudi] wangxianghu commented on a change in pull request #2260: [HUDI-1381] Schedule compaction based on time elapsed

2020-12-28 Thread GitBox
wangxianghu commented on a change in pull request #2260: URL: https://github.com/apache/hudi/pull/2260#discussion_r549538945 ## File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/compact/SparkScheduleCompactionActionExecutor.java ## @@ -90,4

[GitHub] [hudi] hj2016 commented on pull request #2188: [HUDI-1347]fix Hbase index partition changes cause data duplication p…

2020-12-28 Thread GitBox
hj2016 commented on pull request #2188: URL: https://github.com/apache/hudi/pull/2188#issuecomment-751916612 @n3nash @nsivabalan @leesf I have completed the suggested changes above. You can review if there are other problems.

[GitHub] [hudi] codecov-io edited a comment on pull request #2188: [HUDI-1347]fix Hbase index partition changes cause data duplication p…

2020-12-28 Thread GitBox
codecov-io edited a comment on pull request #2188: URL: https://github.com/apache/hudi/pull/2188#issuecomment-711139438 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2188?src=pr=h1) Report > Merging [#2188](https://codecov.io/gh/apache/hudi/pull/2188?src=pr=desc) (1573c9d) into

[GitHub] [hudi] vinothchandar commented on pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

2020-12-28 Thread GitBox
vinothchandar commented on pull request #2359: URL: https://github.com/apache/hudi/pull/2359#issuecomment-751916181 also, the writer should check if heartbeat has expired before commiting. This is an automated message from

[jira] [Updated] (HUDI-1444) fix the error when rollback commit that belong to a non partition table

2020-12-28 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinoth Chandar updated HUDI-1444: - Fix Version/s: 0.7.0 > fix the error when rollback commit that belong to a non partition table >

[GitHub] [hudi] codecov-io edited a comment on pull request #2388: [HUDI-1353] add incremental timeline support for pending clustering ops

2020-12-28 Thread GitBox
codecov-io edited a comment on pull request #2388: URL: https://github.com/apache/hudi/pull/2388#issuecomment-751907604 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2388?src=pr=h1) Report > Merging [#2388](https://codecov.io/gh/apache/hudi/pull/2388?src=pr=desc) (500ad3d) into

[GitHub] [hudi] vinothchandar commented on pull request #2227: [HUDI-1367] Make delastreamer transition from dfsSouce to kafkasouce

2020-12-28 Thread GitBox
vinothchandar commented on pull request #2227: URL: https://github.com/apache/hudi/pull/2227#issuecomment-751914927 yeah we can get this in, if possible This is an automated message from the Apache Git Service. To respond to

[GitHub] [hudi] hj2016 commented on a change in pull request #2188: [HUDI-1347]fix Hbase index partition changes cause data duplication p…

2020-12-28 Thread GitBox
hj2016 commented on a change in pull request #2188: URL: https://github.com/apache/hudi/pull/2188#discussion_r549536583 ## File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/index/hbase/TestHBaseIndex.java ## @@ -263,6 +265,66 @@ public void

[GitHub] [hudi] vinothchandar commented on pull request #2384: [HUDI-1495] Upgrade Flink version to 1.12.0

2020-12-28 Thread GitBox
vinothchandar commented on pull request #2384: URL: https://github.com/apache/hudi/pull/2384#issuecomment-751913527 I think this is good to go. small PR . Please merge when ready This is an automated message from the Apache

[jira] [Updated] (HUDI-1497) Timeout Exception during getFileStatus()

2020-12-28 Thread Balaji Varadarajan (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balaji Varadarajan updated HUDI-1497: - Status: Open (was: New) > Timeout Exception during getFileStatus() >

[jira] [Created] (HUDI-1497) Timeout Exception during getFileStatus()

2020-12-28 Thread Balaji Varadarajan (Jira)
Balaji Varadarajan created HUDI-1497: Summary: Timeout Exception during getFileStatus() Key: HUDI-1497 URL: https://issues.apache.org/jira/browse/HUDI-1497 Project: Apache Hudi Issue

[GitHub] [hudi] codecov-io commented on pull request #2388: [HUDI-1353] add incremental timeline support for pending clustering ops

2020-12-28 Thread GitBox
codecov-io commented on pull request #2388: URL: https://github.com/apache/hudi/pull/2388#issuecomment-751907604 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2388?src=pr=h1) Report > Merging [#2388](https://codecov.io/gh/apache/hudi/pull/2388?src=pr=desc) (500ad3d) into

[jira] [Assigned] (HUDI-1353) Incremental timeline support for pending clustering operations

2020-12-28 Thread satish (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] satish reassigned HUDI-1353: Assignee: satish > Incremental timeline support for pending clustering operations >

[jira] [Updated] (HUDI-1353) Incremental timeline support for pending clustering operations

2020-12-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-1353: - Labels: pull-request-available (was: ) > Incremental timeline support for pending clustering

[GitHub] [hudi] satishkotha opened a new pull request #2388: [HUDI-1353] add incremental timeline support for pending clustering ops

2020-12-28 Thread GitBox
satishkotha opened a new pull request #2388: URL: https://github.com/apache/hudi/pull/2388 ## What is the purpose of the pull request * Add incremental timeline support to update pending clustering operations * Fix timeline to include information in inflight clustering operations

[GitHub] [hudi] xushiyan commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

2020-12-28 Thread GitBox
xushiyan commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r549528498 ## File path: hudi-common/src/test/java/org/apache/hudi/common/testutils/FileCreateUtils.java ## @@ -83,6 +83,17 @@ private static void

[GitHub] [hudi] xushiyan commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

2020-12-28 Thread GitBox
xushiyan commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r549528012 ## File path: hudi-common/src/test/java/org/apache/hudi/common/testutils/FileCreateUtils.java ## @@ -83,6 +83,17 @@ private static void

[GitHub] [hudi] n3nash commented on a change in pull request #2349: [HUDI-1474] Add additional unit tests to TestHBaseIndex

2020-12-28 Thread GitBox
n3nash commented on a change in pull request #2349: URL: https://github.com/apache/hudi/pull/2349#discussion_r549525014 ## File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/index/hbase/TestHBaseIndex.java ## @@ -307,6 +308,125 @@ public void

[GitHub] [hudi] vinothchandar commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

2020-12-28 Thread GitBox
vinothchandar commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r549432592 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieClient.java ## @@ -70,6 +72,7 @@ protected

[hudi] branch master updated: [HUDI-1350] Support Partition level delete API in HUDI (#2254)

2020-12-28 Thread satish
This is an automated email from the ASF dual-hosted git repository. satish pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/master by this push: new e177466 [HUDI-1350] Support Partition level

[GitHub] [hudi] satishkotha merged pull request #2254: [HUDI-1350] Support Partition level delete API in HUDI

2020-12-28 Thread GitBox
satishkotha merged pull request #2254: URL: https://github.com/apache/hudi/pull/2254 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hudi] vinothchandar commented on a change in pull request #2300: [HUDI-1434] fix incorrect log file path in HoodieWriteStat

2020-12-28 Thread GitBox
vinothchandar commented on a change in pull request #2300: URL: https://github.com/apache/hudi/pull/2300#discussion_r549510240 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java ## @@ -203,31 +213,136 @@ private void

[GitHub] [hudi] vinothchandar commented on a change in pull request #2300: [HUDI-1434] fix incorrect log file path in HoodieWriteStat

2020-12-28 Thread GitBox
vinothchandar commented on a change in pull request #2300: URL: https://github.com/apache/hudi/pull/2300#discussion_r549509916 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java ## @@ -203,31 +213,136 @@ private void

[GitHub] [hudi] vinothchandar commented on a change in pull request #2300: [HUDI-1434] fix incorrect log file path in HoodieWriteStat

2020-12-28 Thread GitBox
vinothchandar commented on a change in pull request #2300: URL: https://github.com/apache/hudi/pull/2300#discussion_r549509736 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java ## @@ -303,8 +404,8 @@ private Writer

[GitHub] [hudi] vinothchandar commented on pull request #2387: [RFC-15] Fix partition key in metadata table when bootstrapping from file system

2020-12-28 Thread GitBox
vinothchandar commented on pull request #2387: URL: https://github.com/apache/hudi/pull/2387#issuecomment-751887044 cc @prashantwason This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hudi] vinothchandar merged pull request #2387: [RFC-15] Fix partition key in metadata table when bootstrapping from file system

2020-12-28 Thread GitBox
vinothchandar merged pull request #2387: URL: https://github.com/apache/hudi/pull/2387 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[hudi] branch rfc-15 updated: [RFC-15] Fix partition key in metadata table when bootstrapping from file system (#2387)

2020-12-28 Thread vinoth
This is an automated email from the ASF dual-hosted git repository. vinoth pushed a commit to branch rfc-15 in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/rfc-15 by this push: new 4a4a291 [RFC-15] Fix partition key in metadata

[GitHub] [hudi] codecov-io edited a comment on pull request #2387: [RFC-15] Fix partition key in metadata table when bootstrapping from file system

2020-12-28 Thread GitBox
codecov-io edited a comment on pull request #2387: URL: https://github.com/apache/hudi/pull/2387#issuecomment-751868007 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2387?src=pr=h1) Report > Merging [#2387](https://codecov.io/gh/apache/hudi/pull/2387?src=pr=desc) (db3cea9) into

[GitHub] [hudi] codecov-io commented on pull request #2387: [RFC-15] Fix partition key in metadata table when bootstrapping from file system

2020-12-28 Thread GitBox
codecov-io commented on pull request #2387: URL: https://github.com/apache/hudi/pull/2387#issuecomment-751868007 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2387?src=pr=h1) Report > Merging [#2387](https://codecov.io/gh/apache/hudi/pull/2387?src=pr=desc) (db3cea9) into

[GitHub] [hudi] rmpifer opened a new pull request #2387: [RFC-15] Fix partition key in metadata table when bootstrapping from file system

2020-12-28 Thread GitBox
rmpifer opened a new pull request #2387: URL: https://github.com/apache/hudi/pull/2387 ## *Tips* - *Thank you very much for contributing to Apache Hudi.* - *Please review https://hudi.apache.org/contributing.html before opening a pull request.* ## What is the purpose of the

[GitHub] [hudi] rswagatika edited a comment on issue #2373: [SUPPORT] - Hudi Read ,Partition Filter is coming empty.

2020-12-28 Thread GitBox
rswagatika edited a comment on issue #2373: URL: https://github.com/apache/hudi/issues/2373#issuecomment-751848219 Hi , I have added the config for hive style partitioning and in my partition I could see the hive style partitons.

[GitHub] [hudi] rswagatika commented on issue #2373: [SUPPORT] - Hudi Read ,Partition Filter is coming empty.

2020-12-28 Thread GitBox
rswagatika commented on issue #2373: URL: https://github.com/apache/hudi/issues/2373#issuecomment-751848219 Hi , I have added the config for hive style partitioning and in my partition I could see the hive style partitons.

[GitHub] [hudi] nbalajee commented on a change in pull request #2349: [HUDI-1474] Add additional unit tests to TestHBaseIndex

2020-12-28 Thread GitBox
nbalajee commented on a change in pull request #2349: URL: https://github.com/apache/hudi/pull/2349#discussion_r549458976 ## File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/index/hbase/TestHBaseIndex.java ## @@ -307,6 +308,125 @@ public void

[GitHub] [hudi] codecov-io edited a comment on pull request #2309: [HUDI-1441] - HoodieAvroUtils - rewrite() is not handling evolution o…

2020-12-28 Thread GitBox
codecov-io edited a comment on pull request #2309: URL: https://github.com/apache/hudi/pull/2309#issuecomment-741038401 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2309?src=pr=h1) Report > Merging [#2309](https://codecov.io/gh/apache/hudi/pull/2309?src=pr=desc) (f90f65f) into

[GitHub] [hudi] codecov-io edited a comment on pull request #2309: [HUDI-1441] - HoodieAvroUtils - rewrite() is not handling evolution o…

2020-12-28 Thread GitBox
codecov-io edited a comment on pull request #2309: URL: https://github.com/apache/hudi/pull/2309#issuecomment-741038401 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2309?src=pr=h1) Report > Merging [#2309](https://codecov.io/gh/apache/hudi/pull/2309?src=pr=desc) (f90f65f) into

[GitHub] [hudi] codecov-io edited a comment on pull request #2309: [HUDI-1441] - HoodieAvroUtils - rewrite() is not handling evolution o…

2020-12-28 Thread GitBox
codecov-io edited a comment on pull request #2309: URL: https://github.com/apache/hudi/pull/2309#issuecomment-741038401 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2309?src=pr=h1) Report > Merging [#2309](https://codecov.io/gh/apache/hudi/pull/2309?src=pr=desc) (97e31ec) into

[GitHub] [hudi] codecov-io edited a comment on pull request #2309: [HUDI-1441] - HoodieAvroUtils - rewrite() is not handling evolution o…

2020-12-28 Thread GitBox
codecov-io edited a comment on pull request #2309: URL: https://github.com/apache/hudi/pull/2309#issuecomment-741038401 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2309?src=pr=h1) Report > Merging [#2309](https://codecov.io/gh/apache/hudi/pull/2309?src=pr=desc) (f90f65f) into

[GitHub] [hudi] nbalajee commented on a change in pull request #2309: [HUDI-1441] - HoodieAvroUtils - rewrite() is not handling evolution o…

2020-12-28 Thread GitBox
nbalajee commented on a change in pull request #2309: URL: https://github.com/apache/hudi/pull/2309#discussion_r549443776 ## File path: hudi-common/src/test/java/org/apache/hudi/avro/TestHoodieAvroUtils.java ## @@ -207,4 +208,82 @@ public void

  1   2   >