[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-25 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r278764328 ## File path: hoodie-client/src/main/java/com/uber/hoodie/HoodieWriteClient.java ## @@

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-25 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r278764253 ## File path: hoodie-client/src/main/java/com/uber/hoodie/HoodieReadClient.java ## @@

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-10 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r274220577 ## File path:

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-10 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r274223360 ## File path: hoodie-common/src/main/java/com/uber/hoodie/common/util/RocksDBSchemaHelper.java

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-10 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r274218850 ## File path:

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-10 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r274220242 ## File path:

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-10 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r274221323 ## File path:

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-10 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r274219345 ## File path:

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-10 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r274224252 ## File path:

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-10 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r274221364 ## File path:

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-10 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r274219949 ## File path:

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-10 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r274219635 ## File path:

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-10 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r274224378 ## File path:

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-10 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r274219318 ## File path:

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-10 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r274222871 ## File path:

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-10 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r274221885 ## File path:

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-10 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r274221173 ## File path:

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-10 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r274224728 ## File path:

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-10 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r274217845 ## File path:

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-10 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r274223908 ## File path:

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-10 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r274224638 ## File path:

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-08 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r273214618 ## File path:

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-03 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271948421 ## File path:

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-03 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271928501 ## File path:

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-03 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271928501 ## File path:

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-03 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271928350 ## File path:

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-03 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271927580 ## File path:

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-03 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271927078 ## File path: hoodie-common/src/main/java/com/uber/hoodie/common/table/TableFileSystemView.java

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-03 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271926261 ## File path: hoodie-common/src/main/java/com/uber/hoodie/common/table/HoodieView.java

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-03 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271925979 ## File path: hoodie-common/src/main/java/com/uber/hoodie/common/table/HoodieView.java

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-03 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271925460 ## File path: hoodie-common/src/main/java/com/uber/hoodie/common/table/HoodieTimeline.java

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-03 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271925460 ## File path: hoodie-common/src/main/java/com/uber/hoodie/common/table/HoodieTimeline.java

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-03 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271925335 ## File path: hoodie-common/src/main/java/com/uber/hoodie/common/table/HoodieTimeline.java

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-03 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271924252 ## File path: hoodie-common/src/main/java/com/uber/hoodie/common/model/HoodieLogFile.java

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-03 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271924427 ## File path: hoodie-common/src/main/java/com/uber/hoodie/common/model/HoodieLogFile.java

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-03 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271923395 ## File path: hoodie-common/src/main/java/com/uber/hoodie/common/model/HoodieDataFile.java

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-03 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271923395 ## File path: hoodie-common/src/main/java/com/uber/hoodie/common/model/HoodieDataFile.java

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-03 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271922608 ## File path: hoodie-client/src/test/java/com/uber/hoodie/table/TestMergeOnReadTable.java

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-03 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271922431 ## File path: hoodie-client/src/test/java/com/uber/hoodie/io/strategy/TestHoodieDataFile.java

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-03 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271921122 ## File path:

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-03 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271918483 ## File path:

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-03 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271917051 ## File path: hoodie-client/src/main/java/com/uber/hoodie/io/HoodieCleanHelper.java ##

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-03 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271915076 ## File path: hoodie-client/src/main/java/com/uber/hoodie/io/HoodieAppendHandle.java ##

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-03 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271914607 ## File path: hoodie-client/src/main/java/com/uber/hoodie/func/EmbeddedTimelineServer.java

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-03 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271913778 ## File path: hoodie-client/src/main/java/com/uber/hoodie/func/EmbeddedTimelineServer.java

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-03 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271913114 ## File path: hoodie-client/src/main/java/com/uber/hoodie/func/EmbeddedTimelineServer.java

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-03 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271911256 ## File path: hoodie-client/src/main/java/com/uber/hoodie/HoodieWriteClient.java ## @@

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-03 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271906279 ## File path: hoodie-client/src/main/java/com/uber/hoodie/HoodieBaseClient.java ## @@

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-03 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271905880 ## File path: hoodie-client/src/main/java/com/uber/hoodie/HoodieBaseClient.java ## @@

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-03 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271905565 ## File path: hoodie-client/src/main/java/com/uber/hoodie/HoodieBaseClient.java ## @@

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support

2019-04-03 Thread GitBox
n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271905131 ## File path: hoodie-client/src/main/java/com/uber/hoodie/HoodieBaseClient.java ## @@