[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting

2019-09-30 Thread GitBox
vinothchandar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting URL: https://github.com/apache/incubator-hudi/pull/918#discussion_r329526470 ## File path: docker/hoodie/hadoop/historyserver/NOTICE ## @@ -0,0 +1,5 @@ +Apache HUDI

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting

2019-09-24 Thread GitBox
vinothchandar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting URL: https://github.com/apache/incubator-hudi/pull/918#discussion_r327884211 ## File path: pom.xml ## @@ -174,31 +174,6 @@ - -

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting

2019-09-24 Thread GitBox
vinothchandar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting URL: https://github.com/apache/incubator-hudi/pull/918#discussion_r327884376 ## File path: pom.xml ## @@ -394,18 +369,18 @@

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting

2019-09-24 Thread GitBox
vinothchandar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting URL: https://github.com/apache/incubator-hudi/pull/918#discussion_r327884558 ## File path: release/scripts/generate_notice.sh ## @@ -0,0 +1,36 @@ +#!/usr/bin/env bash

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting

2019-09-24 Thread GitBox
vinothchandar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting URL: https://github.com/apache/incubator-hudi/pull/918#discussion_r327884674 ## File path: release/scripts/validate_staged_release.sh ## @@ -0,0 +1,125 @@

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting

2019-09-24 Thread GitBox
vinothchandar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting URL: https://github.com/apache/incubator-hudi/pull/918#discussion_r327885178 ## File path: packaging/hudi-timeline-server-bundle/run_server.sh ## @@ -19,13 +19,35 @@

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting

2019-09-24 Thread GitBox
vinothchandar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting URL: https://github.com/apache/incubator-hudi/pull/918#discussion_r327884124 ## File path: release/scripts/preparation_before_release.sh ## @@ -22,9 +22,9 @@ set -e

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting

2019-09-24 Thread GitBox
vinothchandar commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting URL: https://github.com/apache/incubator-hudi/pull/918#discussion_r327884106 ## File path: release/scripts/preparation_before_release.sh ## @@ -22,9 +22,9 @@ set -e

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #918: HUDI-121 : Address comments during RC2 voting

2019-09-23 Thread GitBox
vinothchandar commented on a change in pull request #918: HUDI-121 : Address comments during RC2 voting URL: https://github.com/apache/incubator-hudi/pull/918#discussion_r327377354 ## File path: CHANGELOG.md ## @@ -1,3 +1,20 @@ + + # Change Log Review comment: we

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #918: HUDI-121 : Address comments during RC2 voting

2019-09-23 Thread GitBox
vinothchandar commented on a change in pull request #918: HUDI-121 : Address comments during RC2 voting URL: https://github.com/apache/incubator-hudi/pull/918#discussion_r327378727 ## File path: packaging/hudi-timeline-server-bundle/pom.xml ## @@ -170,12 +170,96 @@

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #918: HUDI-121 : Address comments during RC2 voting

2019-09-23 Thread GitBox
vinothchandar commented on a change in pull request #918: HUDI-121 : Address comments during RC2 voting URL: https://github.com/apache/incubator-hudi/pull/918#discussion_r327378580 ## File path: packaging/hudi-timeline-server-bundle/pom.xml ## @@ -170,12 +170,96 @@

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #918: HUDI-121 : Address comments during RC2 voting

2019-09-23 Thread GitBox
vinothchandar commented on a change in pull request #918: HUDI-121 : Address comments during RC2 voting URL: https://github.com/apache/incubator-hudi/pull/918#discussion_r327378404 ## File path: packaging/hudi-hadoop-mr-bundle/pom.xml ## @@ -52,6 +52,17 @@