ChaiBapchya commented on pull request #18632:
URL: https://github.com/apache/incubator-mxnet/pull/18632#issuecomment-652227203
I don't think that's the case.
@szha @leezu can confirm if code-cov is a blocker.
If its not a blocker, lets get this PR merged.
Also I'm guessing since
ciyongch commented on pull request #18632:
URL: https://github.com/apache/incubator-mxnet/pull/18632#issuecomment-652226348
Hi @ChaiBapchya , I saw the codecov test cases failed and the mxnet-bot
doesn't support re-trigger. Not sure if they're a merge blocker or not, I just
re-trigger the
This is an automated email from the ASF dual-hosted git repository.
aaronmarkham pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git
The following commit(s) were added to refs/heads/asf-site by this push:
new f3f4a51 Publish trigger
This is an automated email from the ASF dual-hosted git repository.
aaronmarkham pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 27d2838 Bump the publis
ChaiBapchya commented on pull request #18632:
URL: https://github.com/apache/incubator-mxnet/pull/18632#issuecomment-652220819
It passed all 11 why did we have to retrigger? Is codecov blocking merge?
Also we should try to use mxnet-bot for re-triggering specific pipelines if
any.
szha commented on pull request #18634:
URL: https://github.com/apache/incubator-mxnet/pull/18634#issuecomment-652216592
+1 for option 1 since the integration indeed needs fix. Thanks for driving
this.
This is an automated me
sxjscience commented on pull request #17645:
URL: https://github.com/apache/incubator-mxnet/pull/17645#issuecomment-652216359
@ciyongch Would this go to v1.7? I come up to this commit when I'm
cherry-picking the related commits one by one
--
hzfan commented on a change in pull request #18614:
URL: https://github.com/apache/incubator-mxnet/pull/18614#discussion_r448136696
##
File path: src/api/operator/numpy/np_matrix_op.cc
##
@@ -74,6 +74,68 @@ MXNET_REGISTER_API("_npi.expand_dims")
*ret = ndoutputs[0];
});
+
wkcn commented on pull request #18504:
URL: https://github.com/apache/incubator-mxnet/pull/18504#issuecomment-652212670
> @wkcn, do you have any performance number?
Sorry that I do not have any performance table. I have only a laptop
computer with i7-7500u 2C4T. Could you help me for
hzfan commented on a change in pull request #18614:
URL: https://github.com/apache/incubator-mxnet/pull/18614#discussion_r448133071
##
File path: src/api/operator/numpy/np_matrix_op.cc
##
@@ -74,6 +74,68 @@ MXNET_REGISTER_API("_npi.expand_dims")
*ret = ndoutputs[0];
});
+
ciyongch commented on issue #18641:
URL:
https://github.com/apache/incubator-mxnet/issues/18641#issuecomment-652205754
Wow... can you help to evaluate how many PRs are related to enable this
feature? Then we can decide the time needed and whether to include them or not?
Thanks!
ciyongch commented on issue #18641:
URL:
https://github.com/apache/incubator-mxnet/issues/18641#issuecomment-652204662
Thanks @sxjscience for your prompt help on this. I've already ping the
author for https://github.com/apache/incubator-mxnet/pull/18523, do you need
any help for this PR
xidulu commented on a change in pull request #18403:
URL: https://github.com/apache/incubator-mxnet/pull/18403#discussion_r448127519
##
File path: python/mxnet/gluon/probability/block/stochastic_block.py
##
@@ -0,0 +1,127 @@
+# Licensed to the Apache Software Foundation (ASF) u
TaoLv commented on pull request #18645:
URL: https://github.com/apache/incubator-mxnet/pull/18645#issuecomment-652198544
Please refer to
https://software.intel.com/content/www/us/en/develop/documentation/mkl-macos-developer-guide/top/linking-your-application-with-the-intel-math-kernel-libra
szha commented on pull request #18602:
URL: https://github.com/apache/incubator-mxnet/pull/18602#issuecomment-652197512
@TaoLv no it's not enforced at the moment. feel free to merge when ready
This is an automated message fro
TaoLv commented on pull request #18602:
URL: https://github.com/apache/incubator-mxnet/pull/18602#issuecomment-652196505
@szha @leezu do we need to fix the codecov status before merging?
This is an automated message from the
TaoLv commented on pull request #18504:
URL: https://github.com/apache/incubator-mxnet/pull/18504#issuecomment-652195820
@wkcn, do you have any performance number?
This is an automated message from the Apache Git Service.
To
mxnet-bot commented on pull request #18648:
URL: https://github.com/apache/incubator-mxnet/pull/18648#issuecomment-652193277
Hey @sxjscience , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one
or more tests again with the following
sxjscience opened a new pull request #18648:
URL: https://github.com/apache/incubator-mxnet/pull/18648
## Description ##
(Brief description on what this PR is about)
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] The PR
access2rohit commented on issue #18166:
URL:
https://github.com/apache/incubator-mxnet/issues/18166#issuecomment-652183845
Still causing failures :
http://jenkins.mxnet-ci.amazon-ml.com/blue/rest/organizations/jenkins/pipelines/mxnet-validation/pipelines/unix-cpu/branches/PR-18625/runs/7/n
DongfeiJi commented on issue #18643:
URL:
https://github.com/apache/incubator-mxnet/issues/18643#issuecomment-652163234
> Hi @DongfeiJi ,
> It works for me on MXNet 2.0.
> Note that `boolean_mask` doesn't work when mask are all `zero/false`,
since the traditional operator
DongfeiJi commented on issue #18643:
URL:
https://github.com/apache/incubator-mxnet/issues/18643#issuecomment-652161754
> Hi @DongfeiJi ,
> It works for me on MXNet 2.0.
> Note that `boolean_mask` doesn't work when mask are all `zero/false`,
since the traditional operator doesn't sup
yuantangliang opened a new pull request #18647:
URL: https://github.com/apache/incubator-mxnet/pull/18647
## Description ##
add visualization support for qualization operator
### Changes ###
the plot_network function will crash when plot quantization symbol. this pr
fixed this
mxnet-bot commented on pull request #18647:
URL: https://github.com/apache/incubator-mxnet/pull/18647#issuecomment-652160331
Hey @yuantangliang , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one
or more tests again with the follow
ciyongch commented on pull request #18080:
URL: https://github.com/apache/incubator-mxnet/pull/18080#issuecomment-652139046
Hi @haojin2 @sxjscience , could you please help to backport this PR to
v1.7.x? thanks!
This is an au
ciyongch commented on pull request #18523:
URL: https://github.com/apache/incubator-mxnet/pull/18523#issuecomment-652138648
Hi @BenjaminCHEN2016 , could you please help to backport this PR to v1.7.x
branch as suggested by @sxjscience and @szha in
https://github.com/apache/incubator-mxnet/i
ciyongch commented on issue #18641:
URL:
https://github.com/apache/incubator-mxnet/issues/18641#issuecomment-652137950
Hi @sxjscience may I know if you're going to backport the above two PR into
1.7 as @szha suggested? We're waiting for them to be merged and tag rc0 now,
thanks!
---
This is an automated email from the ASF dual-hosted git repository.
skm pushed a change to branch v1.6.x
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git.
from 31ec0f0 Increase staggered build timeout to 180 min (#18568) (#18586)
add fb3fea4 [CI][v1.6.x] Fix faili
ciyongch commented on pull request #18597:
URL: https://github.com/apache/incubator-mxnet/pull/18597#issuecomment-652136352
Thanks you @ChaiBapchya for the prompt fix, I will rebase my PR
https://github.com/apache/incubator-mxnet/pull/18632.
---
This is an automated email from the ASF dual-hosted git repository.
skm pushed a commit to branch v1.6.x
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git
The following commit(s) were added to refs/heads/v1.6.x by this push:
new fb3fea4 [CI][v1.6.x] Fix failing CI pipel
sandeep-krishnamurthy merged pull request #18597:
URL: https://github.com/apache/incubator-mxnet/pull/18597
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
sandeep-krishnamurthy commented on pull request #18597:
URL: https://github.com/apache/incubator-mxnet/pull/18597#issuecomment-652135618
Thank you @ChaiBapchya
This is an automated message from the Apache Git Service.
To resp
mxnet-bot commented on pull request #18642:
URL: https://github.com/apache/incubator-mxnet/pull/18642#issuecomment-652126161
Jenkins CI successfully triggered : [unix-cpu, centos-cpu]
This is an automated message from the Apa
Yiyan66 commented on pull request #18642:
URL: https://github.com/apache/incubator-mxnet/pull/18642#issuecomment-652126133
@mxnet-bot run ci [centos-cpu, unix-cpu]
This is an automated message from the Apache Git Service.
To
Kh4L commented on a change in pull request #18490:
URL: https://github.com/apache/incubator-mxnet/pull/18490#discussion_r448057212
##
File path: src/operator/subgraph/tensorrt/tensorrt-inl.h
##
@@ -267,6 +267,24 @@ class TensorrtProperty : public SubgraphProperty {
return
This is an automated email from the ASF dual-hosted git repository.
aaronmarkham pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 63d72b4 Bump the publis
This is an automated email from the ASF dual-hosted git repository.
aaronmarkham pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 800590a Publish trigger
szha commented on pull request #18504:
URL: https://github.com/apache/incubator-mxnet/pull/18504#issuecomment-652113639
👌🏻
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
wkcn commented on pull request #18504:
URL: https://github.com/apache/incubator-mxnet/pull/18504#issuecomment-652112636
Hi @szha , could the PR be merged before replacing mkldnn_off and cudnn_off
attributes with environment variables? I can remove the attribute mkldnn_off.
---
stu1130 commented on issue #18646:
URL:
https://github.com/apache/incubator-mxnet/issues/18646#issuecomment-652111953
@wkcn Thanks for you detailed explanation.
So I think there are two phrases.
1. enable cuDNN when axis is not 1
2. use `cudnnBatchNormalizationForwardTrainingEx`
wkcn edited a comment on issue #18646:
URL:
https://github.com/apache/incubator-mxnet/issues/18646#issuecomment-652109101
The reason is that MKLDNN and CuDNN are only applied when axis = 1.
The open PR https://github.com/apache/incubator-mxnet/pull/18504 fixes it.
However, we will
wkcn commented on issue #18646:
URL:
https://github.com/apache/incubator-mxnet/issues/18646#issuecomment-652109101
The reason is that MKLDNN and CuDNN are only applied when axis = 1.
The open PR https://github.com/apache/incubator-mxnet/pull/18504 fixes it.
However, we will add en
mxnet-bot commented on pull request #18639:
URL: https://github.com/apache/incubator-mxnet/pull/18639#issuecomment-652107031
Jenkins CI successfully triggered : [unix-cpu]
This is an automated message from the Apache Git Serv
ys2843 edited a comment on pull request #18639:
URL: https://github.com/apache/incubator-mxnet/pull/18639#issuecomment-651529674
@mxnet-bot run ci [unix-cpu ]
This is an automated message from the Apache Git Service.
To respo
ys2843 edited a comment on pull request #18605:
URL: https://github.com/apache/incubator-mxnet/pull/18605#issuecomment-649792399
@mxnet-bot run ci [unix-cpu ]
This is an automated message from the Apache Git Service.
To respo
mxnet-bot commented on pull request #18605:
URL: https://github.com/apache/incubator-mxnet/pull/18605#issuecomment-652105367
Jenkins CI successfully triggered : [unix-cpu]
This is an automated message from the Apache Git Serv
access2rohit closed pull request #18612:
URL: https://github.com/apache/incubator-mxnet/pull/18612
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
ChaiBapchya commented on a change in pull request #18597:
URL: https://github.com/apache/incubator-mxnet/pull/18597#discussion_r448021132
##
File path: ci/docker/Dockerfile.build.jetson
##
@@ -37,6 +37,8 @@ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get
install -
ChaiBapchya commented on a change in pull request #18597:
URL: https://github.com/apache/incubator-mxnet/pull/18597#discussion_r448020644
##
File path: ci/docker/Dockerfile.build.jetson
##
@@ -78,5 +80,8 @@ ARG GROUP_ID=0
COPY install/ubuntu_adduser.sh /work/
RUN /work/ubuntu
mseth10 commented on a change in pull request #18597:
URL: https://github.com/apache/incubator-mxnet/pull/18597#discussion_r448019514
##
File path: ci/docker/Dockerfile.build.jetson
##
@@ -37,6 +37,8 @@ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get
install -y \
mseth10 commented on a change in pull request #18597:
URL: https://github.com/apache/incubator-mxnet/pull/18597#discussion_r448019369
##
File path: ci/docker/Dockerfile.build.jetson
##
@@ -78,5 +80,8 @@ ARG GROUP_ID=0
COPY install/ubuntu_adduser.sh /work/
RUN /work/ubuntu_add
ChaiBapchya commented on pull request #18597:
URL: https://github.com/apache/incubator-mxnet/pull/18597#issuecomment-652077634
@mxnet-label-bot add [pr-awaiting-review]
This is an automated message from the Apache Git Service
ChaiBapchya commented on pull request #18597:
URL: https://github.com/apache/incubator-mxnet/pull/18597#issuecomment-652077425
@leezu @sandeep-krishnamurthy @PatricZhao @szha
Please review.
This unblocks https://github.com/apache/incubator-mxnet/pull/18632
--
mxnet-bot commented on pull request #18597:
URL: https://github.com/apache/incubator-mxnet/pull/18597#issuecomment-65207
Jenkins CI successfully triggered : [unix-gpu]
This is an automated message from the Apache Git Serv
ChaiBapchya commented on pull request #18597:
URL: https://github.com/apache/incubator-mxnet/pull/18597#issuecomment-652074410
@mxnet-bot run ci [unix-gpu]
This is an automated message from the Apache Git Service.
To respond
ChaiBapchya commented on issue #14994:
URL:
https://github.com/apache/incubator-mxnet/issues/14994#issuecomment-652074321
PR #18597
http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-gpu/detail/PR-18597/9/pipeline
stu1130 opened a new issue #18646:
URL: https://github.com/apache/incubator-mxnet/issues/18646
## Description
```
import mxnet as mx
from mxnet import autograd, np, npx, gluon, init
from mxnet.gluon import nn
import time
npx.set_np()
data = mx.np.random.uniform(s
ChaiBapchya commented on pull request #18597:
URL: https://github.com/apache/incubator-mxnet/pull/18597#issuecomment-651996528
Found the root-cause of this issue
| Function | Dockerfile| Base Docker
Image | Python
This is an automated email from the ASF dual-hosted git repository.
aaronmarkham pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 71979c0 Bump the publis
This is an automated email from the ASF dual-hosted git repository.
aaronmarkham pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 6e48c7a Publish trigger
xidulu commented on issue #18638:
URL:
https://github.com/apache/incubator-mxnet/issues/18638#issuecomment-651856471
I believe the reason behind is that we would like to keep the documentation
and feature consistent with the origin NumPy, so this magic api is not supposed
to be known by u
wkcn commented on a change in pull request #18644:
URL: https://github.com/apache/incubator-mxnet/pull/18644#discussion_r447749228
##
File path: tests/python/unittest/test_gluon.py
##
@@ -665,6 +665,34 @@ def transpose(shape):
assert (layer(x).shape==ceil_out_shape)
wkcn commented on a change in pull request #18644:
URL: https://github.com/apache/incubator-mxnet/pull/18644#discussion_r447749228
##
File path: tests/python/unittest/test_gluon.py
##
@@ -665,6 +665,34 @@ def transpose(shape):
assert (layer(x).shape==ceil_out_shape)
wkcn commented on a change in pull request #18644:
URL: https://github.com/apache/incubator-mxnet/pull/18644#discussion_r447749228
##
File path: tests/python/unittest/test_gluon.py
##
@@ -665,6 +665,34 @@ def transpose(shape):
assert (layer(x).shape==ceil_out_shape)
wkcn commented on a change in pull request #18644:
URL: https://github.com/apache/incubator-mxnet/pull/18644#discussion_r447742251
##
File path: tests/python/unittest/test_gluon.py
##
@@ -665,6 +665,34 @@ def transpose(shape):
assert (layer(x).shape==ceil_out_shape)
wkcn commented on issue #18643:
URL:
https://github.com/apache/incubator-mxnet/issues/18643#issuecomment-651837537
Hi @DongfeiJi ,
It works for me on MXNet 2.0.
Note that `boolean_mask` doesn't work when mask are all `zero/false`, since
the traditional operator doesn't support zero-s
Yiyan66 commented on pull request #18642:
URL: https://github.com/apache/incubator-mxnet/pull/18642#issuecomment-651801224
@mxnet-bot run ci [centos-cpu, unix-cpu]
This is an automated message from the Apache Git Service.
To
mxnet-bot commented on pull request #18642:
URL: https://github.com/apache/incubator-mxnet/pull/18642#issuecomment-651801318
Jenkins CI successfully triggered : [centos-cpu, unix-cpu]
This is an automated message from the Apa
This is an automated email from the ASF dual-hosted git repository.
aaronmarkham pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 3ef65df Publish trigger
This is an automated email from the ASF dual-hosted git repository.
aaronmarkham pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 25e1fa1 Bump the publis
anko-intel opened a new pull request #18644:
URL: https://github.com/apache/incubator-mxnet/pull/18644
## Description ##
Fix the issue #18610 - synchronization problem with running variables for
backward pass of BatchNorm
## Checklist ##
### Essentials ###
- [ ] Changes are
mxnet-bot commented on pull request #18644:
URL: https://github.com/apache/incubator-mxnet/pull/18644#issuecomment-651723999
Hey @anko-intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one
or more tests again with the following
DongfeiJi commented on issue #18643:
URL:
https://github.com/apache/incubator-mxnet/issues/18643#issuecomment-651723106
This problem will occur when this operation is used in loss
This is an automated message from the Apache
DongfeiJi commented on issue #18643:
URL:
https://github.com/apache/incubator-mxnet/issues/18643#issuecomment-651722037
> provide a minimal reproduce examp
This is an automated message from the Apache Git Service.
To
DongfeiJi closed issue #18643:
URL: https://github.com/apache/incubator-mxnet/issues/18643
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
DongfeiJi removed a comment on issue #18643:
URL:
https://github.com/apache/incubator-mxnet/issues/18643#issuecomment-651722037
> provide a minimal reproduce examp
This is an automated message from the Apache Git Ser
DongfeiJi commented on issue #18643:
URL:
https://github.com/apache/incubator-mxnet/issues/18643#issuecomment-651721010
> Could you provide a minimal reproduce example?
>
> In MXNet unittest, The test of hybridized `boolean_mask` works.
>
https://github.com/apache/incubator-mxnet
wkcn commented on issue #18643:
URL:
https://github.com/apache/incubator-mxnet/issues/18643#issuecomment-651715706
Could you provide a minimal reproduce example?
In MXNet unittest, The test of hybridized `boolean_mask` works.
https://github.com/apache/incubator-mxnet/blob/master/
DongfeiJi opened a new issue #18643:
URL: https://github.com/apache/incubator-mxnet/issues/18643
## Description
ndarray.contrib.boolean_mask can not be hybridize
Gluon does not support infer shape ndarray.contrib.boolean_mask
--
mxnet-bot commented on pull request #18642:
URL: https://github.com/apache/incubator-mxnet/pull/18642#issuecomment-651677650
Hey @Yiyan66 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one
or more tests again with the following co
Yiyan66 opened a new pull request #18642:
URL: https://github.com/apache/incubator-mxnet/pull/18642
## Description ##
1. FFI greater
2. Fix a bug in ufunc op: less/greater/less_equal/great_equal
described in #18594
## Checklist ##
### Essentials ###
Please feel free
ciyongch commented on issue #18600:
URL:
https://github.com/apache/incubator-mxnet/issues/18600#issuecomment-651638346
As discussed
[here](https://github.com/apache/incubator-mxnet/issues/18641#issuecomment-651487181),
we'll mark numpy operator as experimental in v1.7 release and probably
xidulu commented on a change in pull request #18403:
URL: https://github.com/apache/incubator-mxnet/pull/18403#discussion_r447495416
##
File path: python/mxnet/gluon/probability/block/stochastic_block.py
##
@@ -0,0 +1,127 @@
+# Licensed to the Apache Software Foundation (ASF) u
ma-hei commented on pull request #18445:
URL: https://github.com/apache/incubator-mxnet/pull/18445#issuecomment-651616085
here's whats going on with onnx 1.7: https://github.com/onnx/onnx/issues/2865
We just need to use the newer way of instantiating a Pad node.
bgawrych removed a comment on pull request #18602:
URL: https://github.com/apache/incubator-mxnet/pull/18602#issuecomment-651597245
@mxnet-bot run ci [codecov/project]
This is an automated message from the Apache Git Service.
bgawrych commented on pull request #18602:
URL: https://github.com/apache/incubator-mxnet/pull/18602#issuecomment-651597245
@mxnet-bot run ci [codecov/project]
This is an automated message from the Apache Git Service.
To resp
mxnet-bot commented on pull request #18602:
URL: https://github.com/apache/incubator-mxnet/pull/18602#issuecomment-651597278
None of the jobs entered are supported.
Jobs entered by user: [codecov/project]
CI supported Jobs: [website, unix-cpu, centos-gpu, miscellaneous, edge,
windows
87 matches
Mail list logo