[GitHub] [incubator-mxnet] ciyongch commented on pull request #18649: [v1.7.x] backport mixed type binary ops to v1.7.x

2020-07-04 Thread GitBox
ciyongch commented on pull request #18649: URL: https://github.com/apache/incubator-mxnet/pull/18649#issuecomment-653845257 Thanks a lot @BenjaminCHEN2016 for your effort to make this patch pass all the CI tests. So we already have all we need for 1.7 release right now. @leezu

[GitHub] [incubator-mxnet] ciyongch commented on pull request #18649: [v1.7.x] backport mixed type binary ops to v1.7.x

2020-07-03 Thread GitBox
ciyongch commented on pull request #18649: URL: https://github.com/apache/incubator-mxnet/pull/18649#issuecomment-653418261 Thanks for your information @wkcn , according to @BenjaminCHEN2016 the failure only happened in MXNet windows CI pipeline but not his local environment. There's a

[GitHub] [incubator-mxnet] ciyongch commented on pull request #18649: [v1.7.x] backport mixed type binary ops to v1.7.x

2020-07-03 Thread GitBox
ciyongch commented on pull request #18649: URL: https://github.com/apache/incubator-mxnet/pull/18649#issuecomment-653369808 Hi @BenjaminCHEN2016 , it looks more like a compilation error which probably introduced by the current complex expressions or something like that which ran out of

[GitHub] [incubator-mxnet] ciyongch commented on pull request #18649: [v1.7.x] backport mixed type binary ops to v1.7.x

2020-07-02 Thread GitBox
ciyongch commented on pull request #18649: URL: https://github.com/apache/incubator-mxnet/pull/18649#issuecomment-653279462 @BenjaminCHEN2016 @sxjscience there's some build error on windows platform as below, please help to take a look. It'll be great if it can be solved within 24h,

[GitHub] [incubator-mxnet] ciyongch commented on pull request #18649: [v1.7.x] backport mixed type binary ops to v1.7.x

2020-07-02 Thread GitBox
ciyongch commented on pull request #18649: URL: https://github.com/apache/incubator-mxnet/pull/18649#issuecomment-652955823 Thank you @BenjaminCHEN2016 to backport these fixes. If I understand correctly, this is the only remaining PR that fix the numpy operator and targeting to 1.7