[GitHub] [incubator-mxnet] connorgoggins commented on a change in pull request #17542: [OpPerf] Add norm, cast ops, remaining optimizer ops

2020-02-12 Thread GitBox
connorgoggins commented on a change in pull request #17542: [OpPerf] Add norm, cast ops, remaining optimizer ops URL: https://github.com/apache/incubator-mxnet/pull/17542#discussion_r378416896 ## File path: benchmark/opperf/rules/default_params.py ## @@ -31,6 +31,7 @@

[GitHub] [incubator-mxnet] connorgoggins commented on a change in pull request #17542: [OpPerf] Add norm, cast ops, remaining optimizer ops

2020-02-11 Thread GitBox
connorgoggins commented on a change in pull request #17542: [OpPerf] Add norm, cast ops, remaining optimizer ops URL: https://github.com/apache/incubator-mxnet/pull/17542#discussion_r377966866 ## File path: benchmark/opperf/rules/default_params.py ## @@ -31,6 +31,7 @@

[GitHub] [incubator-mxnet] connorgoggins commented on a change in pull request #17542: [OpPerf] Add norm, cast ops, remaining optimizer ops

2020-02-11 Thread GitBox
connorgoggins commented on a change in pull request #17542: [OpPerf] Add norm, cast ops, remaining optimizer ops URL: https://github.com/apache/incubator-mxnet/pull/17542#discussion_r377967894 ## File path: benchmark/opperf/utils/benchmark_utils.py ## @@ -31,28 +31,72 @@

[GitHub] [incubator-mxnet] connorgoggins commented on a change in pull request #17542: [OpPerf] Add norm, cast ops, remaining optimizer ops

2020-02-10 Thread GitBox
connorgoggins commented on a change in pull request #17542: [OpPerf] Add norm, cast ops, remaining optimizer ops URL: https://github.com/apache/incubator-mxnet/pull/17542#discussion_r377333613 ## File path: benchmark/opperf/utils/ndarray_utils.py ## @@ -75,10 +75,14 @@

[GitHub] [incubator-mxnet] connorgoggins commented on a change in pull request #17542: [OpPerf] Add norm, cast ops, remaining optimizer ops

2020-02-10 Thread GitBox
connorgoggins commented on a change in pull request #17542: [OpPerf] Add norm, cast ops, remaining optimizer ops URL: https://github.com/apache/incubator-mxnet/pull/17542#discussion_r377333153 ## File path: benchmark/opperf/utils/benchmark_utils.py ## @@ -67,28 +61,17 @@

[GitHub] [incubator-mxnet] connorgoggins commented on a change in pull request #17542: [OpPerf] Add norm, cast ops, remaining optimizer ops

2020-02-10 Thread GitBox
connorgoggins commented on a change in pull request #17542: [OpPerf] Add norm, cast ops, remaining optimizer ops URL: https://github.com/apache/incubator-mxnet/pull/17542#discussion_r377333553 ## File path: benchmark/opperf/utils/ndarray_utils.py ## @@ -44,10 +42,14 @@