[GitHub] marcoabreu commented on issue #10354: Expose the number of GPUs.

2018-04-18 Thread GitBox
marcoabreu commented on issue #10354: Expose the number of GPUs. URL: https://github.com/apache/incubator-mxnet/pull/10354#issuecomment-382564700 Exactly This is an automated message from the Apache Git Service. To respond to

[GitHub] marcoabreu commented on issue #10354: Expose the number of GPUs.

2018-04-12 Thread GitBox
marcoabreu commented on issue #10354: Expose the number of GPUs. URL: https://github.com/apache/incubator-mxnet/pull/10354#issuecomment-380864744 What do you think about something along the lines of: ``` try assert get_num_cpu() > 0, "Expected exception on a CPU only build"

[GitHub] marcoabreu commented on issue #10354: Expose the number of GPUs.

2018-04-10 Thread GitBox
marcoabreu commented on issue #10354: Expose the number of GPUs. URL: https://github.com/apache/incubator-mxnet/pull/10354#issuecomment-380253789 I think we can't use assertRaises because we don't have CPU-only tests (besides the MKL ones) as of now. Instead, we'd have to go with a try

[GitHub] marcoabreu commented on issue #10354: Expose the number of GPUs.

2018-04-10 Thread GitBox
marcoabreu commented on issue #10354: Expose the number of GPUs. URL: https://github.com/apache/incubator-mxnet/pull/10354#issuecomment-380244822 I think that we should be returning 0 since that's the actual number of GPUs present. Additionally, we could return a special value like

[GitHub] marcoabreu commented on issue #10354: Expose the number of GPUs.

2018-04-10 Thread GitBox
marcoabreu commented on issue #10354: Expose the number of GPUs. URL: https://github.com/apache/incubator-mxnet/pull/10354#issuecomment-380244822 I think that we should be returning 0 since that's the actual number of GPUs present. Additionally, we could return a special value like

[GitHub] marcoabreu commented on issue #10354: Expose the number of GPUs.

2018-04-10 Thread GitBox
marcoabreu commented on issue #10354: Expose the number of GPUs. URL: https://github.com/apache/incubator-mxnet/pull/10354#issuecomment-380238440 I think the right place would be in the general unit test directory as well as in the GPU directory. Otherwise, we don't have coverage on

[GitHub] marcoabreu commented on issue #10354: Expose the number of GPUs.

2018-03-31 Thread GitBox
marcoabreu commented on issue #10354: Expose the number of GPUs. URL: https://github.com/apache/incubator-mxnet/pull/10354#issuecomment-377733428 Hey Tobias, definitely helpful - I've seen myself requiring that information quite a few times :) I'm currently thinking about a way how