marcoabreu commented on issue #11493: Fix MXPredReshape in the c_predict_api
URL: https://github.com/apache/incubator-mxnet/pull/11493#issuecomment-412866571
Looks good, thank you.
Unfortunately, I don't have time to review his pr right now. Could somebody
else take it over please?
marcoabreu commented on issue #11493: Fix MXPredReshape in the c_predict_api
URL: https://github.com/apache/incubator-mxnet/pull/11493#issuecomment-412311230
No worries, thanks for your contribution and addressing the comments. Seems
like you hit a flaky test. Please just make an empty
marcoabreu commented on issue #11493: Fix MXPredReshape in the c_predict_api
URL: https://github.com/apache/incubator-mxnet/pull/11493#issuecomment-412233719
The default is atol=e-20 and rtol=e-5. I don't know by how much we can
expect a derivation here.
I think the default values
marcoabreu commented on issue #11493: Fix MXPredReshape in the c_predict_api
URL: https://github.com/apache/incubator-mxnet/pull/11493#issuecomment-412146573
The default values of almost equals are too low and could result in flaky
behavior. We should address it first
marcoabreu commented on issue #11493: Fix MXPredReshape in the c_predict_api
URL: https://github.com/apache/incubator-mxnet/pull/11493#issuecomment-412060232
Hi @hqucms, sorry for the late response. Would you mind addressing the
review? We're ready to merge then.
