[GitHub] piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-05 Thread GitBox
piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r166079802 ## File path: src/engine/threaded_engine.h ## @@ -338,33 +346,46 @@ class ThreadedEngine : public

[GitHub] piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165731530 ## File path: src/engine/threaded_engine.h ## @@ -476,6 +507,9 @@ class ThreadedEngine : public

[GitHub] piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165731112 ## File path: src/storage/gpu_device_storage.h ## @@ -62,7 +62,7 @@ inline void*

[GitHub] piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165731019 ## File path: src/storage/cpu_device_storage.h ## @@ -61,10 +61,10 @@ inline void*

[GitHub] piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165730863 ## File path: src/engine/threaded_engine.h ## @@ -338,33 +346,46 @@ class ThreadedEngine : public

[GitHub] piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165728531 ## File path: src/engine/threaded_engine.h ## @@ -338,33 +346,46 @@ class ThreadedEngine : public

[GitHub] piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165728359 ## File path: src/engine/threaded_engine.h ## @@ -338,33 +346,46 @@ class ThreadedEngine : public

[GitHub] piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165727816 ## File path: src/engine/threaded_engine.h ## @@ -175,6 +175,8 @@ class ThreadedVar final

[GitHub] piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165727071 ## File path: src/engine/threaded_engine.cc ## @@ -403,7 +417,11 @@ inline void

[GitHub] piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165727071 ## File path: src/engine/threaded_engine.cc ## @@ -403,7 +417,11 @@ inline void

[GitHub] piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165727071 ## File path: src/engine/threaded_engine.cc ## @@ -403,7 +417,11 @@ inline void

[GitHub] piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165726239 ## File path: src/engine/threaded_engine.cc ## @@ -403,7 +417,11 @@ inline void

[GitHub] piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165726063 ## File path: src/engine/threaded_engine.cc ## @@ -391,6 +400,11 @@ void

[GitHub] piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165726063 ## File path: src/engine/threaded_engine.cc ## @@ -391,6 +400,11 @@ void

[GitHub] piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165725747 ## File path: src/engine/threaded_engine.cc ## @@ -356,7 +357,11 @@ void

[GitHub] piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165725474 ## File path: include/mxnet/engine.h ## @@ -182,7 +182,7 @@ class MXNET_API Engine {