[GitHub] samskalicky commented on a change in pull request #12904: support upper triangular matrices in linalg

2018-11-01 Thread GitBox
samskalicky commented on a change in pull request #12904: support upper triangular matrices in linalg URL: https://github.com/apache/incubator-mxnet/pull/12904#discussion_r230099457 ## File path: src/operator/tensor/la_op.cc ## @@ -227,10 +231,11 @@

[GitHub] samskalicky commented on a change in pull request #12904: support upper triangular matrices in linalg

2018-10-31 Thread GitBox
samskalicky commented on a change in pull request #12904: support upper triangular matrices in linalg URL: https://github.com/apache/incubator-mxnet/pull/12904#discussion_r229846687 ## File path: src/operator/tensor/la_op_inline.h ## @@ -493,11 +519,11 @@ struct

[GitHub] samskalicky commented on a change in pull request #12904: support upper triangular matrices in linalg

2018-10-31 Thread GitBox
samskalicky commented on a change in pull request #12904: support upper triangular matrices in linalg URL: https://github.com/apache/incubator-mxnet/pull/12904#discussion_r229846545 ## File path: src/operator/tensor/la_op_inline.h ## @@ -458,14 +483,15 @@ struct

[GitHub] samskalicky commented on a change in pull request #12904: support upper triangular matrices in linalg

2018-10-31 Thread GitBox
samskalicky commented on a change in pull request #12904: support upper triangular matrices in linalg URL: https://github.com/apache/incubator-mxnet/pull/12904#discussion_r229846402 ## File path: src/operator/tensor/la_op_inline.h ## @@ -430,14 +447,22 @@ struct

[GitHub] samskalicky commented on a change in pull request #12904: support upper triangular matrices in linalg

2018-10-31 Thread GitBox
samskalicky commented on a change in pull request #12904: support upper triangular matrices in linalg URL: https://github.com/apache/incubator-mxnet/pull/12904#discussion_r229846100 ## File path: src/operator/tensor/la_op_inline.h ## @@ -403,15 +417,18 @@ struct

[GitHub] samskalicky commented on a change in pull request #12904: support upper triangular matrices in linalg

2018-10-31 Thread GitBox
samskalicky commented on a change in pull request #12904: support upper triangular matrices in linalg URL: https://github.com/apache/incubator-mxnet/pull/12904#discussion_r229842788 ## File path: src/operator/tensor/la_op.cc ## @@ -227,10 +231,11 @@

[GitHub] samskalicky commented on a change in pull request #12904: support upper triangular matrices in linalg

2018-10-31 Thread GitBox
samskalicky commented on a change in pull request #12904: support upper triangular matrices in linalg URL: https://github.com/apache/incubator-mxnet/pull/12904#discussion_r229844162 ## File path: src/operator/tensor/la_op.h ## @@ -93,6 +104,9 @@ struct

[GitHub] samskalicky commented on a change in pull request #12904: support upper triangular matrices in linalg

2018-10-31 Thread GitBox
samskalicky commented on a change in pull request #12904: support upper triangular matrices in linalg URL: https://github.com/apache/incubator-mxnet/pull/12904#discussion_r229843925 ## File path: src/operator/tensor/la_op.h ## @@ -81,10 +81,21 @@ struct LaMatrixMultParam