[GitHub] zheng-da commented on a change in pull request #11831: [MXNET-484] MKLDNN C++ test for LRN operator

2018-08-17 Thread GitBox
zheng-da commented on a change in pull request #11831: [MXNET-484] MKLDNN C++ test for LRN operator URL: https://github.com/apache/incubator-mxnet/pull/11831#discussion_r211028890 ## File path: src/operator/nn/mkldnn/mkldnn_lrn-inl.h ## @@ -218,17 +231,18 @@ void

[GitHub] zheng-da commented on a change in pull request #11831: [MXNET-484] MKLDNN C++ test for LRN operator

2018-08-13 Thread GitBox
zheng-da commented on a change in pull request #11831: [MXNET-484] MKLDNN C++ test for LRN operator URL: https://github.com/apache/incubator-mxnet/pull/11831#discussion_r209792689 ## File path: tests/cpp/operator/mkldnn.cc ## @@ -1094,6 +1191,99 @@ void TestConcatOp(const

[GitHub] zheng-da commented on a change in pull request #11831: [MXNET-484] MKLDNN C++ test for LRN operator

2018-08-13 Thread GitBox
zheng-da commented on a change in pull request #11831: [MXNET-484] MKLDNN C++ test for LRN operator URL: https://github.com/apache/incubator-mxnet/pull/11831#discussion_r209792297 ## File path: tests/cpp/operator/mkldnn.cc ## @@ -1094,6 +1191,99 @@ void TestConcatOp(const

[GitHub] zheng-da commented on a change in pull request #11831: [MXNET-484] MKLDNN C++ test for LRN operator

2018-08-13 Thread GitBox
zheng-da commented on a change in pull request #11831: [MXNET-484] MKLDNN C++ test for LRN operator URL: https://github.com/apache/incubator-mxnet/pull/11831#discussion_r209792228 ## File path: tests/cpp/operator/mkldnn.cc ## @@ -1094,6 +1191,99 @@ void TestConcatOp(const

[GitHub] zheng-da commented on a change in pull request #11831: [MXNET-484] MKLDNN C++ test for LRN operator

2018-08-13 Thread GitBox
zheng-da commented on a change in pull request #11831: [MXNET-484] MKLDNN C++ test for LRN operator URL: https://github.com/apache/incubator-mxnet/pull/11831#discussion_r209790288 ## File path: src/operator/nn/mkldnn/mkldnn_lrn-inl.h ## @@ -229,6 +232,7 @@ void

[GitHub] zheng-da commented on a change in pull request #11831: [MXNET-484] MKLDNN C++ test for LRN operator

2018-08-13 Thread GitBox
zheng-da commented on a change in pull request #11831: [MXNET-484] MKLDNN C++ test for LRN operator URL: https://github.com/apache/incubator-mxnet/pull/11831#discussion_r209790531 ## File path: tests/cpp/operator/mkldnn.cc ## @@ -535,6 +552,40 @@ void PrintVerifyMsg(const

[GitHub] zheng-da commented on a change in pull request #11831: [MXNET-484] MKLDNN C++ test for LRN operator

2018-08-13 Thread GitBox
zheng-da commented on a change in pull request #11831: [MXNET-484] MKLDNN C++ test for LRN operator URL: https://github.com/apache/incubator-mxnet/pull/11831#discussion_r209791360 ## File path: tests/cpp/operator/mkldnn.cc ## @@ -610,8 +670,12 @@ std::vector

[GitHub] zheng-da commented on a change in pull request #11831: [MXNET-484] MKLDNN C++ test for LRN operator

2018-08-13 Thread GitBox
zheng-da commented on a change in pull request #11831: [MXNET-484] MKLDNN C++ test for LRN operator URL: https://github.com/apache/incubator-mxnet/pull/11831#discussion_r209790490 ## File path: tests/cpp/operator/mkldnn.cc ## @@ -535,6 +552,40 @@ void PrintVerifyMsg(const