apeforest commented on a change in pull request #16654: Multithreaded Inference
Support
URL: https://github.com/apache/incubator-mxnet/pull/16654#discussion_r365507513
##
File path: tests/cpp/operator/mkldnn_operator_test.cc
##
@@ -719,7 +707,10 @@ void TestOpEx(const
apeforest commented on a change in pull request #16654: Multithreaded Inference
Support
URL: https://github.com/apache/incubator-mxnet/pull/16654#discussion_r365507376
##
File path: src/imperative/cached_op_threadsafe.h
##
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache
leezu commented on issue #17272: [Numpy] Add infra for performing constraint
check
URL: https://github.com/apache/incubator-mxnet/pull/17272#issuecomment-573299951
Could you improve the documentation to clarify how to ensure that the
constraint check is executed?
leezu commented on issue #17262: Unable to build / link mxnet against cuda 10.2
URL:
https://github.com/apache/incubator-mxnet/issues/17262#issuecomment-573300257
I suppose you are not building on a GPU machine? Currently, in this case,
our cmake build setup will fall-back to building for
xidulu commented on issue #17272: [Numpy] Add infra for performing constraint
check
URL: https://github.com/apache/incubator-mxnet/pull/17272#issuecomment-573311442
> Could you improve the documentation to clarify how to ensure that the
constraint check is executed?
@leezu
I
tonyng1707 opened a new issue #17274: Is Mxnet 1.5 (with GPU) available on Conda
URL: https://github.com/apache/incubator-mxnet/issues/17274
For the mxnet-gpu package (https://anaconda.org/anaconda/mxnet-gpu), only
v1.2.1 is available so far. Is MXNet v1.5 (with GPU) available on Conda? If
xidulu edited a comment on issue #17272: [Numpy] Add infra for performing
constraint check
URL: https://github.com/apache/incubator-mxnet/pull/17272#issuecomment-573311442
> Could you improve the documentation to clarify how to ensure that the
constraint check is executed?
@leezu
xidulu edited a comment on issue #17272: [Numpy] Add infra for performing
constraint check
URL: https://github.com/apache/incubator-mxnet/pull/17272#issuecomment-573311442
> Could you improve the documentation to clarify how to ensure that the
constraint check is executed?
@leezu
xidulu edited a comment on issue #17272: [Numpy] Add infra for performing
constraint check
URL: https://github.com/apache/incubator-mxnet/pull/17272#issuecomment-573311442
> Could you improve the documentation to clarify how to ensure that the
constraint check is executed?
@leezu
litaotju commented on a change in pull request #17271: Fix #17267, add expected
and got datatype for concat error msgs
URL: https://github.com/apache/incubator-mxnet/pull/17271#discussion_r365509263
##
File path: src/operator/nn/concat.cc
##
@@ -149,9 +149,10 @@ bool
leezu commented on a change in pull request #17229: Fix and clean up Ubuntu
build from source instructions
URL: https://github.com/apache/incubator-mxnet/pull/17229#discussion_r365510911
##
File path: docs/static_site/src/pages/get_started/ubuntu_setup.md
##
@@ -147,67
ZhennanQin commented on a change in pull request #17265: Add bfloat16
floating-point format support based on AMP
URL: https://github.com/apache/incubator-mxnet/pull/17265#discussion_r365518924
##
File path: example/quantization/imagenet_inference.py
##
@@ -99,7 +100,34
apeforest commented on issue #16654: Multithreaded Inference Support
URL: https://github.com/apache/incubator-mxnet/pull/16654#issuecomment-573293669
Thanks for this big contribution! In the future, it might be easier for
reviewers if the PR can be broken into smaller pieces :)
leezu opened a new pull request #17273: Improve ubuntu_setup.md cmake
instructions
URL: https://github.com/apache/incubator-mxnet/pull/17273
## Description ##
See
https://github.com/apache/incubator-mxnet/pull/17229#pullrequestreview-341371159
This is an automated email from the ASF dual-hosted git repository.
aaronmarkham pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git
The following commit(s) were added to refs/heads/asf-site by this push:
new f9a4b47 Bump the
dithyrambe opened a new issue #17275: CosineEmbeddingLoss won't work after
hybridize (ie. with symbol API)
URL: https://github.com/apache/incubator-mxnet/issues/17275
## Description
`CosineEmbeddingLoss` seems to have issue in its symbol API implementation.
Loss works fine until I
ZhennanQin commented on a change in pull request #17265: Add bfloat16
floating-point format support based on AMP
URL: https://github.com/apache/incubator-mxnet/pull/17265#discussion_r365518893
##
File path: 3rdparty/mshadow/mshadow/bfloat.h
##
@@ -0,0 +1,167 @@
+/*!
+ *
ZhennanQin commented on a change in pull request #17265: Add bfloat16
floating-point format support based on AMP
URL: https://github.com/apache/incubator-mxnet/pull/17265#discussion_r365518812
##
File path: 3rdparty/mshadow/mshadow/base.h
##
@@ -312,6 +338,11 @@ enum
This is an automated email from the ASF dual-hosted git repository.
aaronmarkham pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git
The following commit(s) were added to refs/heads/asf-site by this push:
new f7e37da Bump the
QueensGambit commented on issue #17216: how to compile mxnet with cpp and gpu
support in the docker ?
URL:
https://github.com/apache/incubator-mxnet/issues/17216#issuecomment-57270
> it gave : fatal error mxnet/op.h . No such file
Yes, I don't really like the procedure either
haojin2 commented on a change in pull request #17254: [numpy] change unary
infer type
URL: https://github.com/apache/incubator-mxnet/pull/17254#discussion_r365556763
##
File path: tests/python/unittest/test_numpy_op.py
##
@@ -1865,15 +1890,53 @@ def hybrid_forward(self,
This is an automated email from the ASF dual-hosted git repository.
haibin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git
The following commit(s) were added to refs/heads/master by this push:
new 2002d60 fix typo (#17277)
2002d60 is
eric-haibin-lin merged pull request #17277: fix typo continugous to contiguous
URL: https://github.com/apache/incubator-mxnet/pull/17277
This is an automated message from the Apache Git Service.
To respond to the message,
eric-haibin-lin commented on a change in pull request #17271: Fix #17267, add
expected and got datatype for concat error msgs
URL: https://github.com/apache/incubator-mxnet/pull/17271#discussion_r365558618
##
File path: src/operator/nn/concat.cc
##
@@ -149,9 +149,10 @@
eric-haibin-lin closed issue #10881: mx.sym.dot() performance on CPU
URL: https://github.com/apache/incubator-mxnet/issues/10881
This is an automated message from the Apache Git Service.
To respond to the message, please log
haojin2 commented on a change in pull request #17254: [numpy] change unary
infer type
URL: https://github.com/apache/incubator-mxnet/pull/17254#discussion_r365556490
##
File path: tests/python/unittest/test_numpy_op.py
##
@@ -1865,15 +1890,53 @@ def hybrid_forward(self,
haojin2 commented on a change in pull request #17254: [numpy] change unary
infer type
URL: https://github.com/apache/incubator-mxnet/pull/17254#discussion_r365556923
##
File path: src/operator/tensor/elemwise_binary_op.h
##
@@ -525,6 +525,68 @@ class ElemwiseBinaryOp :
haojin2 commented on a change in pull request #17254: [numpy] change unary
infer type
URL: https://github.com/apache/incubator-mxnet/pull/17254#discussion_r365556934
##
File path: src/operator/tensor/elemwise_binary_op.h
##
@@ -525,6 +525,68 @@ class ElemwiseBinaryOp :
haojin2 commented on a change in pull request #17254: [numpy] change unary
infer type
URL: https://github.com/apache/incubator-mxnet/pull/17254#discussion_r365556939
##
File path: src/operator/tensor/elemwise_binary_op.h
##
@@ -525,6 +525,68 @@ class ElemwiseBinaryOp :
eric-haibin-lin commented on a change in pull request #16654: Multithreaded
Inference Support
URL: https://github.com/apache/incubator-mxnet/pull/16654#discussion_r365560553
##
File path: src/imperative/cached_op.cc
##
@@ -32,247 +32,12 @@
This is an automated email from the ASF dual-hosted git repository.
aaronmarkham pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git
The following commit(s) were added to refs/heads/asf-site by this push:
new b91cfa1 Bump the
eric-haibin-lin opened a new issue #17278: [Performance] CachedOp/Gluon
performance thread
URL: https://github.com/apache/incubator-mxnet/issues/17278
Starting a thread to collect performance problems of cached_op/gluon hybrid
blocks. If you compared module with gluon and found
eric-haibin-lin commented on issue #14137: [Feature Request] turning off cudnn
autotune
URL:
https://github.com/apache/incubator-mxnet/issues/14137#issuecomment-573388105
@ptrendx @DickJC123 can we get rid of these backend specific flags in the
operator interface, targeting mxnet 2.0?
eric-haibin-lin commented on issue #13634: Slow CPU inference in Gluon GRU
module
URL:
https://github.com/apache/incubator-mxnet/issues/13634#issuecomment-573388054
CPU kernels were added: https://github.com/apache/incubator-mxnet/pull/9977
eric-haibin-lin closed issue #13634: Slow CPU inference in Gluon GRU module
URL: https://github.com/apache/incubator-mxnet/issues/13634
This is an automated message from the Apache Git Service.
To respond to the message,
haojin2 commented on a change in pull request #17254: [numpy] change unary
infer type
URL: https://github.com/apache/incubator-mxnet/pull/17254#discussion_r365562549
##
File path: src/operator/tensor/elemwise_binary_op.h
##
@@ -525,6 +525,68 @@ class ElemwiseBinaryOp :
ZhennanQin commented on a change in pull request #17265: Add bfloat16
floating-point format support based on AMP
URL: https://github.com/apache/incubator-mxnet/pull/17265#discussion_r365519649
##
File path: python/mxnet/contrib/amp/amp.py
##
@@ -43,14 +44,17 @@
from ...
haojin2 commented on a change in pull request #17254: [numpy] change unary
infer type
URL: https://github.com/apache/incubator-mxnet/pull/17254#discussion_r365556412
##
File path: tests/python/unittest/test_numpy_op.py
##
@@ -1832,6 +1832,36 @@ def hybrid_forward(self, F,
haojin2 commented on a change in pull request #17254: [numpy] change unary
infer type
URL: https://github.com/apache/incubator-mxnet/pull/17254#discussion_r365556446
##
File path: tests/python/unittest/test_numpy_op.py
##
@@ -1832,6 +1832,36 @@ def hybrid_forward(self, F,
haojin2 commented on a change in pull request #17254: [numpy] change unary
infer type
URL: https://github.com/apache/incubator-mxnet/pull/17254#discussion_r365556919
##
File path: src/operator/tensor/elemwise_binary_op.h
##
@@ -525,6 +525,68 @@ class ElemwiseBinaryOp :
haojin2 commented on a change in pull request #17254: [numpy] change unary
infer type
URL: https://github.com/apache/incubator-mxnet/pull/17254#discussion_r365556902
##
File path: src/operator/numpy/np_elemwise_unary_op_basic.cu
##
@@ -39,6 +39,10 @@
haojin2 commented on a change in pull request #17254: [numpy] change unary
infer type
URL: https://github.com/apache/incubator-mxnet/pull/17254#discussion_r365556852
##
File path: src/operator/numpy/np_elemwise_unary_op_basic.cc
##
@@ -82,6 +82,39 @@
haojin2 commented on a change in pull request #17254: [numpy] change unary
infer type
URL: https://github.com/apache/incubator-mxnet/pull/17254#discussion_r365556866
##
File path: src/operator/numpy/np_elemwise_unary_op_basic.cc
##
@@ -82,6 +82,39 @@
haojin2 commented on a change in pull request #17254: [numpy] change unary
infer type
URL: https://github.com/apache/incubator-mxnet/pull/17254#discussion_r365556838
##
File path: src/operator/numpy/np_elemwise_unary_op_basic.cc
##
@@ -82,6 +82,39 @@
haojin2 commented on a change in pull request #17254: [numpy] change unary
infer type
URL: https://github.com/apache/incubator-mxnet/pull/17254#discussion_r365556884
##
File path: src/operator/numpy/np_elemwise_unary_op_basic.cc
##
@@ -82,6 +82,39 @@
haojin2 commented on a change in pull request #17254: [numpy] change unary
infer type
URL: https://github.com/apache/incubator-mxnet/pull/17254#discussion_r365557162
##
File path: src/operator/tensor/elemwise_binary_op.h
##
@@ -525,6 +525,68 @@ class ElemwiseBinaryOp :
eric-haibin-lin commented on issue #17241: Add CustomOp tutorial doc
URL: https://github.com/apache/incubator-mxnet/pull/17241#issuecomment-573384290
There are multiple docs on writing operators. Shall we consolidate them?
- python op:
eric-haibin-lin commented on a change in pull request #17265: Add bfloat16
floating-point format support based on AMP
URL: https://github.com/apache/incubator-mxnet/pull/17265#discussion_r365559408
##
File path: python/mxnet/ndarray/ndarray.py
##
@@ -83,6 +84,7 @@
eric-haibin-lin commented on a change in pull request #17265: Add bfloat16
floating-point format support based on AMP
URL: https://github.com/apache/incubator-mxnet/pull/17265#discussion_r365559445
##
File path: src/engine/naive_engine.cc
##
@@ -55,7 +55,7 @@ class
eric-haibin-lin commented on a change in pull request #17265: Add bfloat16
floating-point format support based on AMP
URL: https://github.com/apache/incubator-mxnet/pull/17265#discussion_r365559345
##
File path: include/mxnet/ndarray.h
##
@@ -770,6 +770,12 @@ class
ChaiBapchya commented on a change in pull request #16654: Multithreaded
Inference Support
URL: https://github.com/apache/incubator-mxnet/pull/16654#discussion_r365559546
##
File path: example/multi_threaded_inference/multi_threaded_inference.cc
##
@@ -0,0 +1,351 @@
+/*
+
ChaiBapchya commented on a change in pull request #16654: Multithreaded
Inference Support
URL: https://github.com/apache/incubator-mxnet/pull/16654#discussion_r365559520
##
File path: example/multi_threaded_inference/multi_threaded_inference.cc
##
@@ -0,0 +1,351 @@
+/*
+
ChaiBapchya commented on a change in pull request #16654: Multithreaded
Inference Support
URL: https://github.com/apache/incubator-mxnet/pull/16654#discussion_r365559263
##
File path:
docs/static_site/src/pages/api/cpp/docs/tutorials/multi_threaded_inference.md
##
@@
ChaiBapchya commented on a change in pull request #16654: Multithreaded
Inference Support
URL: https://github.com/apache/incubator-mxnet/pull/16654#discussion_r365559227
##
File path:
docs/static_site/src/pages/api/cpp/docs/tutorials/multi_threaded_inference.md
##
@@
ChaiBapchya commented on a change in pull request #16654: Multithreaded
Inference Support
URL: https://github.com/apache/incubator-mxnet/pull/16654#discussion_r365560367
##
File path: tests/cpp/thread_safety/thread_safety_test.cc
##
@@ -0,0 +1,667 @@
+/*
+ * Licensed to
ChaiBapchya commented on a change in pull request #16654: Multithreaded
Inference Support
URL: https://github.com/apache/incubator-mxnet/pull/16654#discussion_r365559640
##
File path: src/imperative/cached_op.h
##
@@ -26,8 +26,195 @@
#include
#include
#include
ChaiBapchya commented on a change in pull request #16654: Multithreaded
Inference Support
URL: https://github.com/apache/incubator-mxnet/pull/16654#discussion_r365560252
##
File path: tests/cpp/engine/thread_local_test.cc
##
@@ -56,7 +56,7 @@ static int
ChaiBapchya commented on a change in pull request #16654: Multithreaded
Inference Support
URL: https://github.com/apache/incubator-mxnet/pull/16654#discussion_r365552811
##
File path:
docs/static_site/src/pages/api/cpp/docs/tutorials/multi_threaded_inference.md
##
@@
ChaiBapchya commented on a change in pull request #16654: Multithreaded
Inference Support
URL: https://github.com/apache/incubator-mxnet/pull/16654#discussion_r365559671
##
File path: src/imperative/cached_op.h
##
@@ -26,8 +26,195 @@
#include
#include
#include
ChaiBapchya commented on a change in pull request #16654: Multithreaded
Inference Support
URL: https://github.com/apache/incubator-mxnet/pull/16654#discussion_r365559294
##
File path:
docs/static_site/src/pages/api/cpp/docs/tutorials/multi_threaded_inference.md
##
@@
ChaiBapchya commented on a change in pull request #16654: Multithreaded
Inference Support
URL: https://github.com/apache/incubator-mxnet/pull/16654#discussion_r365559971
##
File path: src/imperative/cached_op_threadsafe.cc
##
@@ -0,0 +1,342 @@
+/*
+ * Licensed to the
ChaiBapchya commented on a change in pull request #16654: Multithreaded
Inference Support
URL: https://github.com/apache/incubator-mxnet/pull/16654#discussion_r365545467
##
File path: CMakeLists.txt
##
@@ -825,7 +829,6 @@ if(MSVC AND USE_MXNET_LIB_NAMING)
ChaiBapchya commented on a change in pull request #16654: Multithreaded
Inference Support
URL: https://github.com/apache/incubator-mxnet/pull/16654#discussion_r365558868
##
File path: example/multi_threaded_inference/Makefile
##
@@ -0,0 +1,67 @@
+# Licensed to the Apache
ChaiBapchya commented on a change in pull request #16654: Multithreaded
Inference Support
URL: https://github.com/apache/incubator-mxnet/pull/16654#discussion_r365559045
##
File path: example/multi_threaded_inference/multi_threaded_inference.cc
##
@@ -0,0 +1,351 @@
+/*
+
ChaiBapchya commented on a change in pull request #16654: Multithreaded
Inference Support
URL: https://github.com/apache/incubator-mxnet/pull/16654#discussion_r365551135
##
File path: cpp-package/include/mxnet-cpp/symbol.hpp
##
@@ -151,6 +151,18 @@ inline std::vector
ChaiBapchya commented on a change in pull request #16654: Multithreaded
Inference Support
URL: https://github.com/apache/incubator-mxnet/pull/16654#discussion_r365559328
##
File path:
docs/static_site/src/pages/api/cpp/docs/tutorials/multi_threaded_inference.md
##
@@
eric-haibin-lin closed issue #10907: #10820 NaiveEngine regression
URL: https://github.com/apache/incubator-mxnet/issues/10907
This is an automated message from the Apache Git Service.
To respond to the message, please log
apeforest commented on issue #17239: Cmake with NCCL flag does not work.
URL:
https://github.com/apache/incubator-mxnet/issues/17239#issuecomment-573390637
@mjsML Thanks, using that flag worked for me. @guanxinq interested in fixing
FindNCCL.cmake as suggested? :)
apeforest edited a comment on issue #17239: Cmake with NCCL flag does not work.
URL:
https://github.com/apache/incubator-mxnet/issues/17239#issuecomment-573390637
@mjsML Thanks, using that flag worked for me. @guanxinq or @ChaiBapchya
interested in fixing FindNCCL.cmake as suggested? :)
haojin2 commented on issue #15383: [numpy] np.random.multinomial is different
from _np
URL:
https://github.com/apache/incubator-mxnet/issues/15383#issuecomment-573391078
@TomasBahnik Sorry, just discovered that the fix was previously merged into
the numpy branch, we'll port that fix to
haojin2 edited a comment on issue #15383: [numpy] np.random.multinomial is
different from _np
URL:
https://github.com/apache/incubator-mxnet/issues/15383#issuecomment-573391078
@TomasBahnik Sorry, just discovered that the fix was previously merged into
the numpy branch, we'll port that
haojin2 edited a comment on issue #15383: [numpy] np.random.multinomial is
different from _np
URL:
https://github.com/apache/incubator-mxnet/issues/15383#issuecomment-573391078
@TomasBahnik Sorry, just discovered that the fix is somehow not reflected in
the current master branch, will
This is an automated email from the ASF dual-hosted git repository.
haoj pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git.
from 0b26914 Improve ubuntu_setup.md cmake instructions (#17273)
add 25dc909 bump atol in backward test for
haojin2 merged pull request #17276: Bump atol in backward test for softmax with
length only for fp16
URL: https://github.com/apache/incubator-mxnet/pull/17276
This is an automated message from the Apache Git Service.
To
haojin2 closed issue #16252: [Flaky] test_softmax_with_length asserts equality
near zero
URL: https://github.com/apache/incubator-mxnet/issues/16252
This is an automated message from the Apache Git Service.
To respond to
This is an automated email from the ASF dual-hosted git repository.
apeforest pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git
The following commit(s) were added to refs/heads/master by this push:
new 0b26914 Improve ubuntu_setup.md
apeforest merged pull request #17273: Improve ubuntu_setup.md cmake instructions
URL: https://github.com/apache/incubator-mxnet/pull/17273
This is an automated message from the Apache Git Service.
To respond to the message,
haojin2 opened a new pull request #17276: Bump atol in backward test for
softmax with length only for fp16
URL: https://github.com/apache/incubator-mxnet/pull/17276
## Description ##
Fix #16252.
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable
haojin2 commented on a change in pull request #17272: [Numpy] Add infra for
performing constraint check
URL: https://github.com/apache/incubator-mxnet/pull/17272#discussion_r365550130
##
File path: src/operator/numpy/np_constraint_check.cc
##
@@ -0,0 +1,99 @@
+/*
+ *
haojin2 commented on a change in pull request #17272: [Numpy] Add infra for
performing constraint check
URL: https://github.com/apache/incubator-mxnet/pull/17272#discussion_r365550120
##
File path: src/operator/numpy/np_constraint_check.cc
##
@@ -0,0 +1,99 @@
+/*
+ *
haojin2 commented on a change in pull request #17272: [Numpy] Add infra for
performing constraint check
URL: https://github.com/apache/incubator-mxnet/pull/17272#discussion_r365550264
##
File path: src/operator/numpy/np_constraint_check.cc
##
@@ -0,0 +1,99 @@
+/*
+ *
haojin2 commented on a change in pull request #17272: [Numpy] Add infra for
performing constraint check
URL: https://github.com/apache/incubator-mxnet/pull/17272#discussion_r365550300
##
File path: src/operator/numpy/np_constraint_check.h
##
@@ -0,0 +1,71 @@
+/*
+ *
TomasBahnik commented on issue #15383: [numpy] np.random.multinomial is
different from _np
URL:
https://github.com/apache/incubator-mxnet/issues/15383#issuecomment-573361735
Issue is still present in Windows `mxnet 1.6.0b20191125` updates today by
`pip install -U --pre mxnet`
TomasBahnik edited a comment on issue #15383: [numpy] np.random.multinomial is
different from _np
URL:
https://github.com/apache/incubator-mxnet/issues/15383#issuecomment-573361735
Issue is still present in Windows `mxnet 1.6.0b20191125` updated today by
`pip install -U --pre mxnet`
ChaiBapchya opened a new pull request #17277: fix typo continugous to contiguous
URL: https://github.com/apache/incubator-mxnet/pull/17277
## Description ##
Title
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] Changes
This is an automated email from the ASF dual-hosted git repository.
aaronmarkham pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 51f075b Bump the
This is an automated email from the ASF dual-hosted git repository.
haoj pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git.
from 0b26914 Improve ubuntu_setup.md cmake instructions (#17273)
add 25dc909 bump atol in backward test for
87 matches
Mail list logo