eric-haibin-lin commented on a change in pull request #17265: Add bfloat16
floating-point format support based on AMP
URL: https://github.com/apache/incubator-mxnet/pull/17265#discussion_r365559345
##########
File path: include/mxnet/ndarray.h
##########
@@ -770,6 +770,12 @@ class NDArray {
*/
NDArray Reorder2Default() const;
+ /*
+ * This creates a new NDArray using f32 with the reordered data.
+ * It doesn't affect the data of the original NDArray.
+ */
+ NDArray Reorder2DefaultFp32() const;
Review comment:
Adding dtype specific interface looks very ad-hoc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
