[GitHub] masahi commented on issue #6773: Deadlock and crashes during shutdown

2017-12-09 Thread GitBox
masahi commented on issue #6773: Deadlock and crashes during shutdown URL: https://github.com/apache/incubator-mxnet/pull/6773#issuecomment-350529830 @lialie @cjolivier01 We are seeing the same problem with Windows 7. On Win 8 and 10, there is no issue during shutdown.

[GitHub] reminisce commented on issue #9007: float16 argmax breaks on negative inputs

2017-12-09 Thread GitBox
reminisce commented on issue #9007: float16 argmax breaks on negative inputs URL: https://github.com/apache/incubator-mxnet/issues/9007#issuecomment-350529028 Unary reduce ops have the problem of handling float16 correctly. For example, ```python a = mx.nd.array([-2, 0],

[GitHub] reminisce commented on issue #9007: float16 argmax breaks on negative inputs

2017-12-09 Thread GitBox
reminisce commented on issue #9007: float16 argmax breaks on negative inputs URL: https://github.com/apache/incubator-mxnet/issues/9007#issuecomment-350527843 Looks like a bug of the `argmax` operator itself, not about `simple_bind`, because the following test on `maximum` op could

[GitHub] anirudh2290 commented on a change in pull request #8938: Add operator for dot(dns, csr) = csr

2017-12-09 Thread GitBox
anirudh2290 commented on a change in pull request #8938: Add operator for dot(dns, csr) = csr URL: https://github.com/apache/incubator-mxnet/pull/8938#discussion_r155939068 ## File path: src/operator/tensor/dot-inl.h ## @@ -811,6 +891,94 @@ inline void

[GitHub] anirudh2290 commented on a change in pull request #8938: Add operator for dot(dns, csr) = csr

2017-12-09 Thread GitBox
anirudh2290 commented on a change in pull request #8938: Add operator for dot(dns, csr) = csr URL: https://github.com/apache/incubator-mxnet/pull/8938#discussion_r155939071 ## File path: src/operator/tensor/dot-inl.h ## @@ -231,6 +231,12 @@ inline bool

[GitHub] anirudh2290 commented on a change in pull request #8938: Add operator for dot(dns, csr) = csr

2017-12-09 Thread GitBox
anirudh2290 commented on a change in pull request #8938: Add operator for dot(dns, csr) = csr URL: https://github.com/apache/incubator-mxnet/pull/8938#discussion_r155939067 ## File path: src/operator/tensor/dot-inl.h ## @@ -811,6 +891,94 @@ inline void

[GitHub] cjolivier01 commented on issue #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc.

2017-12-09 Thread GitBox
cjolivier01 commented on issue #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc. URL: https://github.com/apache/incubator-mxnet/pull/8972#issuecomment-350523576 In latest commits, all of the stuff in cpp unit test files edits due to conflicts rebasing from

[GitHub] astonzhang commented on a change in pull request #8763: [WIP] Add text apis

2017-12-09 Thread GitBox
astonzhang commented on a change in pull request #8763: [WIP] Add text apis URL: https://github.com/apache/incubator-mxnet/pull/8763#discussion_r155937321 ## File path: python/mxnet/text/glossary.py ## @@ -0,0 +1,654 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] astonzhang commented on a change in pull request #8763: [WIP] Add text apis

2017-12-09 Thread GitBox
astonzhang commented on a change in pull request #8763: [WIP] Add text apis URL: https://github.com/apache/incubator-mxnet/pull/8763#discussion_r155937212 ## File path: python/mxnet/text/glossary.py ## @@ -0,0 +1,654 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] cjolivier01 commented on issue #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc.

2017-12-09 Thread GitBox
cjolivier01 commented on issue #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc. URL: https://github.com/apache/incubator-mxnet/pull/8972#issuecomment-350520637 Ok, I thought of a way to simplify some of the API's

[GitHub] ArmageddonKnight opened a new issue #9010: get_next_state parameter in FusedRNN constructor

2017-12-09 Thread GitBox
ArmageddonKnight opened a new issue #9010: get_next_state parameter in FusedRNN constructor URL: https://github.com/apache/incubator-mxnet/issues/9010 Sorry but I am confused about the `get_next_state` parameter in the

[GitHub] astonzhang commented on a change in pull request #8763: [WIP] Add text apis

2017-12-09 Thread GitBox
astonzhang commented on a change in pull request #8763: [WIP] Add text apis URL: https://github.com/apache/incubator-mxnet/pull/8763#discussion_r155936371 ## File path: python/mxnet/text/glossary.py ## @@ -0,0 +1,654 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] astonzhang commented on a change in pull request #8763: [WIP] Add text apis

2017-12-09 Thread GitBox
astonzhang commented on a change in pull request #8763: [WIP] Add text apis URL: https://github.com/apache/incubator-mxnet/pull/8763#discussion_r155936352 ## File path: python/mxnet/text/glossary.py ## @@ -0,0 +1,654 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] astonzhang commented on a change in pull request #8763: [WIP] Add text apis

2017-12-09 Thread GitBox
astonzhang commented on a change in pull request #8763: [WIP] Add text apis URL: https://github.com/apache/incubator-mxnet/pull/8763#discussion_r155936277 ## File path: python/mxnet/text/glossary.py ## @@ -0,0 +1,654 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] astonzhang commented on a change in pull request #8763: [WIP] Add text apis

2017-12-09 Thread GitBox
astonzhang commented on a change in pull request #8763: [WIP] Add text apis URL: https://github.com/apache/incubator-mxnet/pull/8763#discussion_r155936254 ## File path: python/mxnet/text/glossary.py ## @@ -0,0 +1,654 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] astonzhang commented on a change in pull request #8763: [WIP] Add text apis

2017-12-09 Thread GitBox
astonzhang commented on a change in pull request #8763: [WIP] Add text apis URL: https://github.com/apache/incubator-mxnet/pull/8763#discussion_r155936128 ## File path: python/mxnet/text/glossary.py ## @@ -0,0 +1,654 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] astonzhang commented on a change in pull request #8763: [WIP] Add text apis

2017-12-09 Thread GitBox
astonzhang commented on a change in pull request #8763: [WIP] Add text apis URL: https://github.com/apache/incubator-mxnet/pull/8763#discussion_r155936104 ## File path: python/mxnet/text/glossary.py ## @@ -0,0 +1,654 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] cjolivier01 commented on a change in pull request #8989: Symbol __getitem__ using list_outputs() is too expensive

2017-12-09 Thread GitBox
cjolivier01 commented on a change in pull request #8989: Symbol __getitem__ using list_outputs() is too expensive URL: https://github.com/apache/incubator-mxnet/pull/8989#discussion_r155935864 ## File path: include/mxnet/c_api.h ## @@ -1051,6 +1051,16 @@ MXNET_DLL int

[GitHub] cjolivier01 commented on a change in pull request #8989: Symbol __getitem__ using list_outputs() is too expensive

2017-12-09 Thread GitBox
cjolivier01 commented on a change in pull request #8989: Symbol __getitem__ using list_outputs() is too expensive URL: https://github.com/apache/incubator-mxnet/pull/8989#discussion_r155935848 ## File path: python/mxnet/symbol/symbol.py ## @@ -745,6 +747,25 @@ def

[GitHub] szha commented on issue #7804: Enhance For DataLoad Directly from folder

2017-12-09 Thread GitBox
szha commented on issue #7804: Enhance For DataLoad Directly from folder URL: https://github.com/apache/incubator-mxnet/issues/7804#issuecomment-350515880 This issue is closed due to lack of activity in the last 90 days. Feel free to ping me to reopen if this is still an active issue.

[GitHub] szha commented on issue #7824: How to partition a computing graph among multiple machines?

2017-12-09 Thread GitBox
szha commented on issue #7824: How to partition a computing graph among multiple machines? URL: https://github.com/apache/incubator-mxnet/issues/7824#issuecomment-350515881 This issue is closed due to lack of activity in the last 90 days. Feel free to ping me to reopen if this is still

[GitHub] szha commented on issue #6186: cudnn_deconvolution-inl.h

2017-12-09 Thread GitBox
szha commented on issue #6186: cudnn_deconvolution-inl.h URL: https://github.com/apache/incubator-mxnet/issues/6186#issuecomment-350515878 This issue is closed due to lack of activity in the last 90 days. Feel free to ping me to reopen if this is still an active issue. Thanks! Also, do

[GitHub] szha closed issue #7804: Enhance For DataLoad Directly from folder

2017-12-09 Thread GitBox
szha closed issue #7804: Enhance For DataLoad Directly from folder URL: https://github.com/apache/incubator-mxnet/issues/7804 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] szha closed issue #7824: How to partition a computing graph among multiple machines?

2017-12-09 Thread GitBox
szha closed issue #7824: How to partition a computing graph among multiple machines? URL: https://github.com/apache/incubator-mxnet/issues/7824 This is an automated message from the Apache Git Service. To respond to the

[GitHub] szha closed issue #6186: cudnn_deconvolution-inl.h

2017-12-09 Thread GitBox
szha closed issue #6186: cudnn_deconvolution-inl.h URL: https://github.com/apache/incubator-mxnet/issues/6186 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] bradcar commented on issue #2856: PReLU problem

2017-12-09 Thread GitBox
bradcar commented on issue #2856: PReLU problem URL: https://github.com/apache/incubator-mxnet/issues/2856#issuecomment-350512780 Hi taoari, I have been unable to find out how to properly use prelu in MXNet: x = F.LeakyReLU(self.conv4(x), act_type='prelu') I get this error:

[GitHub] srochel opened a new pull request #9009: Delete recommendation_systems.md

2017-12-09 Thread GitBox
srochel opened a new pull request #9009: Delete recommendation_systems.md URL: https://github.com/apache/incubator-mxnet/pull/9009 Tutorial for recommender system to be provided with Zach's book. ## Description ## remove file. Tutorial for recommender system to be provided with

[GitHub] cjolivier01 commented on issue #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc.

2017-12-09 Thread GitBox
cjolivier01 commented on issue #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc. URL: https://github.com/apache/incubator-mxnet/pull/8972#issuecomment-350503085 I mean, it can get as compact as being a couple of calls that take enumerated and optional

[GitHub] cjolivier01 commented on a change in pull request #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc.

2017-12-09 Thread GitBox
cjolivier01 commented on a change in pull request #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc. URL: https://github.com/apache/incubator-mxnet/pull/8972#discussion_r155930949 ## File path: python/mxnet/profiler.py ## @@ -56,3 +69,237 @@

[GitHub] cjolivier01 commented on issue #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc.

2017-12-09 Thread GitBox
cjolivier01 commented on issue #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc. URL: https://github.com/apache/incubator-mxnet/pull/8972#issuecomment-350501238 I suppose crate start and stop can take an enumeration on type, but that gets sort of cryptic.

[GitHub] szha commented on a change in pull request #8763: [WIP] Add text apis

2017-12-09 Thread GitBox
szha commented on a change in pull request #8763: [WIP] Add text apis URL: https://github.com/apache/incubator-mxnet/pull/8763#discussion_r155930401 ## File path: python/mxnet/text/glossary.py ## @@ -0,0 +1,654 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] szha commented on a change in pull request #8763: [WIP] Add text apis

2017-12-09 Thread GitBox
szha commented on a change in pull request #8763: [WIP] Add text apis URL: https://github.com/apache/incubator-mxnet/pull/8763#discussion_r155930408 ## File path: python/mxnet/text/glossary.py ## @@ -0,0 +1,654 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] szha commented on a change in pull request #8763: [WIP] Add text apis

2017-12-09 Thread GitBox
szha commented on a change in pull request #8763: [WIP] Add text apis URL: https://github.com/apache/incubator-mxnet/pull/8763#discussion_r155930401 ## File path: python/mxnet/text/glossary.py ## @@ -0,0 +1,654 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] szha commented on a change in pull request #8763: [WIP] Add text apis

2017-12-09 Thread GitBox
szha commented on a change in pull request #8763: [WIP] Add text apis URL: https://github.com/apache/incubator-mxnet/pull/8763#discussion_r155930353 ## File path: python/mxnet/text/glossary.py ## @@ -0,0 +1,654 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] szha commented on a change in pull request #8763: [WIP] Add text apis

2017-12-09 Thread GitBox
szha commented on a change in pull request #8763: [WIP] Add text apis URL: https://github.com/apache/incubator-mxnet/pull/8763#discussion_r155930318 ## File path: python/mxnet/text/glossary.py ## @@ -0,0 +1,654 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] szha commented on a change in pull request #8763: [WIP] Add text apis

2017-12-09 Thread GitBox
szha commented on a change in pull request #8763: [WIP] Add text apis URL: https://github.com/apache/incubator-mxnet/pull/8763#discussion_r155930259 ## File path: python/mxnet/text/glossary.py ## @@ -0,0 +1,654 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] szha commented on a change in pull request #8763: [WIP] Add text apis

2017-12-09 Thread GitBox
szha commented on a change in pull request #8763: [WIP] Add text apis URL: https://github.com/apache/incubator-mxnet/pull/8763#discussion_r155930205 ## File path: python/mxnet/text/glossary.py ## @@ -0,0 +1,654 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] piiswrong commented on issue #9007: float16 argmax breaks on negative inputs

2017-12-09 Thread GitBox
piiswrong commented on issue #9007: float16 argmax breaks on negative inputs URL: https://github.com/apache/incubator-mxnet/issues/9007#issuecomment-350498289 @reminisce This is an automated message from the Apache Git

[GitHub] piiswrong commented on a change in pull request #8989: Symbol __getitem__ using list_outputs() is too expensive

2017-12-09 Thread GitBox
piiswrong commented on a change in pull request #8989: Symbol __getitem__ using list_outputs() is too expensive URL: https://github.com/apache/incubator-mxnet/pull/8989#discussion_r155929444 ## File path: python/mxnet/symbol/symbol.py ## @@ -745,6 +747,25 @@ def

[GitHub] piiswrong commented on a change in pull request #8989: Symbol __getitem__ using list_outputs() is too expensive

2017-12-09 Thread GitBox
piiswrong commented on a change in pull request #8989: Symbol __getitem__ using list_outputs() is too expensive URL: https://github.com/apache/incubator-mxnet/pull/8989#discussion_r155929437 ## File path: include/mxnet/c_api.h ## @@ -1051,6 +1051,16 @@ MXNET_DLL int

[GitHub] piiswrong commented on issue #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc.

2017-12-09 Thread GitBox
piiswrong commented on issue #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc. URL: https://github.com/apache/incubator-mxnet/pull/8972#issuecomment-350497570 This adds too many CAPIs is there a better approach?

[GitHub] piiswrong commented on a change in pull request #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc.

2017-12-09 Thread GitBox
piiswrong commented on a change in pull request #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc. URL: https://github.com/apache/incubator-mxnet/pull/8972#discussion_r155929416 ## File path: python/mxnet/profiler.py ## @@ -56,3 +69,237 @@