[GitHub] szha commented on a change in pull request #10511: add naming tutorial

2018-04-12 Thread GitBox
szha commented on a change in pull request #10511: add naming tutorial URL: https://github.com/apache/incubator-mxnet/pull/10511#discussion_r181286454 ## File path: python/mxnet/gluon/block.py ## @@ -187,17 +187,17 @@ def __setattr__(self, name, value):

[GitHub] piiswrong commented on issue #10525: Fix NNPACK header file position error

2018-04-12 Thread GitBox
piiswrong commented on issue #10525: Fix NNPACK header file position error URL: https://github.com/apache/incubator-mxnet/pull/10525#issuecomment-381024773 It's a major work item. We'll need to plan it This is an automated

[GitHub] piiswrong commented on a change in pull request #10511: add naming tutorial

2018-04-12 Thread GitBox
piiswrong commented on a change in pull request #10511: add naming tutorial URL: https://github.com/apache/incubator-mxnet/pull/10511#discussion_r181286250 ## File path: python/mxnet/gluon/block.py ## @@ -187,17 +187,17 @@ def __setattr__(self, name, value):

[GitHub] haojin2 commented on a change in pull request #10371: [MXNET-263] Support for dot(dns, csr) = dns and dot(dns, csr.T) = dns on GPU

2018-04-12 Thread GitBox
haojin2 commented on a change in pull request #10371: [MXNET-263] Support for dot(dns, csr) = dns and dot(dns, csr.T) = dns on GPU URL: https://github.com/apache/incubator-mxnet/pull/10371#discussion_r181283102 ## File path: src/operator/tensor/dot-inl.cuh ## @@ -442,6

[GitHub] haojin2 commented on a change in pull request #10371: [MXNET-263] Support for dot(dns, csr) = dns and dot(dns, csr.T) = dns on GPU

2018-04-12 Thread GitBox
haojin2 commented on a change in pull request #10371: [MXNET-263] Support for dot(dns, csr) = dns and dot(dns, csr.T) = dns on GPU URL: https://github.com/apache/incubator-mxnet/pull/10371#discussion_r181282944 ## File path: src/operator/tensor/dot-inl.cuh ## @@ -442,6

[GitHub] szha commented on a change in pull request #10511: add naming tutorial

2018-04-12 Thread GitBox
szha commented on a change in pull request #10511: add naming tutorial URL: https://github.com/apache/incubator-mxnet/pull/10511#discussion_r181282688 ## File path: python/mxnet/gluon/block.py ## @@ -187,17 +187,17 @@ def __setattr__(self, name, value):

[GitHub] eric-haibin-lin commented on a change in pull request #10371: [MXNET-263] Support for dot(dns, csr) = dns and dot(dns, csr.T) = dns on GPU

2018-04-12 Thread GitBox
eric-haibin-lin commented on a change in pull request #10371: [MXNET-263] Support for dot(dns, csr) = dns and dot(dns, csr.T) = dns on GPU URL: https://github.com/apache/incubator-mxnet/pull/10371#discussion_r181282408 ## File path: tests/python/unittest/test_sparse_operator.py

[GitHub] eric-haibin-lin commented on a change in pull request #10371: [MXNET-263] Support for dot(dns, csr) = dns and dot(dns, csr.T) = dns on GPU

2018-04-12 Thread GitBox
eric-haibin-lin commented on a change in pull request #10371: [MXNET-263] Support for dot(dns, csr) = dns and dot(dns, csr.T) = dns on GPU URL: https://github.com/apache/incubator-mxnet/pull/10371#discussion_r181282253 ## File path: src/operator/tensor/dot-inl.cuh ## @@

[GitHub] eric-haibin-lin closed pull request #10535: render fix

2018-04-12 Thread GitBox
eric-haibin-lin closed pull request #10535: render fix URL: https://github.com/apache/incubator-mxnet/pull/10535 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[incubator-mxnet] branch master updated: render fix (#10535)

2018-04-12 Thread haibin
This is an automated email from the ASF dual-hosted git repository. haibin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new fb50257 render fix (#10535) fb50257

[GitHub] piiswrong commented on a change in pull request #10511: add naming tutorial

2018-04-12 Thread GitBox
piiswrong commented on a change in pull request #10511: add naming tutorial URL: https://github.com/apache/incubator-mxnet/pull/10511#discussion_r181280172 ## File path: docs/tutorials/gluon/naming.md ## @@ -0,0 +1,236 @@ + +# Naming of Gluon Parameter and Blocks + +In

[GitHub] eric-haibin-lin commented on a change in pull request #10435: [MXNET-289] Update example to resize data iterator to fix hang in dist sync for last epoch

2018-04-12 Thread GitBox
eric-haibin-lin commented on a change in pull request #10435: [MXNET-289] Update example to resize data iterator to fix hang in dist sync for last epoch URL: https://github.com/apache/incubator-mxnet/pull/10435#discussion_r181279912 ## File path:

[GitHub] kpmurali commented on issue #10449: [MXNET-293] Navigation updates

2018-04-12 Thread GitBox
kpmurali commented on issue #10449: [MXNET-293] Navigation updates URL: https://github.com/apache/incubator-mxnet/pull/10449#issuecomment-381008978 So can this be merged now? This is an automated message from the Apache Git

[GitHub] kpmurali commented on a change in pull request #10534: [MXNET-315] Fix the version select in the navbar to be independent of order

2018-04-12 Thread GitBox
kpmurali commented on a change in pull request #10534: [MXNET-315] Fix the version select in the navbar to be independent of order URL: https://github.com/apache/incubator-mxnet/pull/10534#discussion_r181276577 ## File path: docs/build_version_doc/update_all_version.sh ##

[GitHub] szha commented on issue #10535: render fix

2018-04-12 Thread GitBox
szha commented on issue #10535: render fix URL: https://github.com/apache/incubator-mxnet/pull/10535#issuecomment-381007837 http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-10535/2/tutorials/scala/mxnet_scala_on_intellij.html

[GitHub] kpmurali commented on issue #10415: [MXNET-284] Update release version text to 1.2.0

2018-04-12 Thread GitBox
kpmurali commented on issue #10415: [MXNET-284] Update release version text to 1.2.0 URL: https://github.com/apache/incubator-mxnet/pull/10415#issuecomment-381007230 This PR is no longer WIP. This is an automated message

[GitHub] anirudh2290 commented on a change in pull request #10538: [MXNET-318] Allow dot for fp16 on GPU

2018-04-12 Thread GitBox
anirudh2290 commented on a change in pull request #10538: [MXNET-318] Allow dot for fp16 on GPU URL: https://github.com/apache/incubator-mxnet/pull/10538#discussion_r181274419 ## File path: src/operator/tensor/dot-inl.h ## @@ -69,9 +69,10 @@ void DotForward_(const

[GitHub] rahul003 commented on a change in pull request #10435: [MXNET-289] Update example to resize data iterator to fix hang in dist sync for last epoch

2018-04-12 Thread GitBox
rahul003 commented on a change in pull request #10435: [MXNET-289] Update example to resize data iterator to fix hang in dist sync for last epoch URL: https://github.com/apache/incubator-mxnet/pull/10435#discussion_r181272232 ## File path: example/image-classification/common/fit.py

[GitHub] mengyuest commented on issue #9533: Cannot find engine branch for minpy package

2018-04-12 Thread GitBox
mengyuest commented on issue #9533: Cannot find engine branch for minpy package URL: https://github.com/apache/incubator-mxnet/issues/9533#issuecomment-380999710 I used this and it worked well (though the function is very simple). ```python import mxnet as mx from mxnet import

[GitHub] harusametime commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors

2018-04-12 Thread GitBox
harusametime commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors URL: https://github.com/apache/incubator-mxnet/pull/10528#issuecomment-380967400 @ThomasDelteil I created a ticket and added the label [MXNET-316] to the title of my PR. Do you mean you need my

[GitHub] rahul003 commented on issue #10531: Float16 Support for dot

2018-04-12 Thread GitBox
rahul003 commented on issue #10531: Float16 Support for dot URL: https://github.com/apache/incubator-mxnet/issues/10531#issuecomment-380997060 Dot for fp16 on GPU was supported internally but a (probably older) CHECK was blocking it. Created a PR to fix this.

[GitHub] rahul003 opened a new pull request #10538: [MXNET-318] Allow dot for fp16 on GPU

2018-04-12 Thread GitBox
rahul003 opened a new pull request #10538: [MXNET-318] Allow dot for fp16 on GPU URL: https://github.com/apache/incubator-mxnet/pull/10538 ## Description ## Dot for fp16 on GPU is supported internally by the BLASEngine , but a check was blocking that.

[GitHub] harusametime commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors

2018-04-12 Thread GitBox
harusametime commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors URL: https://github.com/apache/incubator-mxnet/pull/10528#issuecomment-380967400 @ThomasDelteil I created a ticket and added the label [MXNET-316] to the title of my PR. Sorry, I am not familiar

[GitHub] zhanghang1989 commented on issue #10536: [MXNET-317] Add Data Parallel

2018-04-12 Thread GitBox
zhanghang1989 commented on issue #10536: [MXNET-317] Add Data Parallel URL: https://github.com/apache/incubator-mxnet/pull/10536#issuecomment-380994417 @pengzhao-intel This PR is mainly for Synchronized Cross GPU Batch Norm https://github.com/zhanghang1989/MXNet-Gluon-SyncBN

[GitHub] pengzhao-intel commented on issue #10536: [MXNET-317] Add Data Parallel

2018-04-12 Thread GitBox
pengzhao-intel commented on issue #10536: [MXNET-317] Add Data Parallel URL: https://github.com/apache/incubator-mxnet/pull/10536#issuecomment-380991886 @zhanghang1989 I am interested in this PR. Could you elaborate what this PR is for?

[GitHub] spidyDev commented on issue #10425: [MXNET-175] Raise user warning on mismatch between module data_names and data iter names

2018-04-12 Thread GitBox
spidyDev commented on issue #10425: [MXNET-175] Raise user warning on mismatch between module data_names and data iter names URL: https://github.com/apache/incubator-mxnet/pull/10425#issuecomment-380990561 @piiswrong Could you review ?

[GitHub] sugi1229 commented on issue #10516: How to run model trained with python on Scala

2018-04-12 Thread GitBox
sugi1229 commented on issue #10516: How to run model trained with python on Scala URL: https://github.com/apache/incubator-mxnet/issues/10516#issuecomment-380990318 @BenLag2906 Thanks, I changed it, it worked!! This is

[GitHub] rahul003 commented on a change in pull request #10537: [MX-307] Add .md tutorials to .ipynb for CI integration

2018-04-12 Thread GitBox
rahul003 commented on a change in pull request #10537: [MX-307] Add .md tutorials to .ipynb for CI integration URL: https://github.com/apache/incubator-mxnet/pull/10537#discussion_r181262665 ## File path: tests/nightly/test_tutorial_config.txt ## @@ -1,20 +1,31 @@

[GitHub] ThomasDelteil opened a new pull request #10537: [MX-307] Add .md tutorials to .ipynb for CI integration

2018-04-12 Thread GitBox
ThomasDelteil opened a new pull request #10537: [MX-307] Add .md tutorials to .ipynb for CI integration URL: https://github.com/apache/incubator-mxnet/pull/10537 ## Description ## - **+11** tutorials downloadable as jupyter notebooks and ready to integrate in the CI - Added where

[GitHub] ThomasDelteil commented on issue #10537: [MX-307] Add .md tutorials to .ipynb for CI integration

2018-04-12 Thread GitBox
ThomasDelteil commented on issue #10537: [MX-307] Add .md tutorials to .ipynb for CI integration URL: https://github.com/apache/incubator-mxnet/pull/10537#issuecomment-380988861 @thomelane if you have time for a review 

[GitHub] haojin2 commented on a change in pull request #10371: [MXNET-263] Support for dot(dns, csr) = dns and dot(dns, csr.T) = dns on GPU

2018-04-12 Thread GitBox
haojin2 commented on a change in pull request #10371: [MXNET-263] Support for dot(dns, csr) = dns and dot(dns, csr.T) = dns on GPU URL: https://github.com/apache/incubator-mxnet/pull/10371#discussion_r181261640 ## File path: src/operator/tensor/dot-inl.cuh ## @@ -895,6

[GitHub] aaronmarkham commented on issue #10535: render fix

2018-04-12 Thread GitBox
aaronmarkham commented on issue #10535: render fix URL: https://github.com/apache/incubator-mxnet/pull/10535#issuecomment-380986807 Old view: http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-10488/2/tutorials/scala/mxnet_scala_on_intellij.html New view:

[GitHub] zhanghang1989 commented on a change in pull request #10536: [MXNET-317] Add Data Parallel

2018-04-12 Thread GitBox
zhanghang1989 commented on a change in pull request #10536: [MXNET-317] Add Data Parallel URL: https://github.com/apache/incubator-mxnet/pull/10536#discussion_r181260210 ## File path: python/mxnet/gluon/contrib/parallel.py ## @@ -0,0 +1,241 @@ +# Licensed to the Apache

[GitHub] eric-haibin-lin commented on a change in pull request #10536: [MXNET-317] Add Data Parallel

2018-04-12 Thread GitBox
eric-haibin-lin commented on a change in pull request #10536: [MXNET-317] Add Data Parallel URL: https://github.com/apache/incubator-mxnet/pull/10536#discussion_r181259393 ## File path: python/mxnet/gluon/contrib/parallel.py ## @@ -0,0 +1,241 @@ +# Licensed to the Apache

[GitHub] haojin2 commented on a change in pull request #10533: [MXNET-314] [WIP] Support Integer Type parsing in CSVIter

2018-04-12 Thread GitBox
haojin2 commented on a change in pull request #10533: [MXNET-314] [WIP] Support Integer Type parsing in CSVIter URL: https://github.com/apache/incubator-mxnet/pull/10533#discussion_r181259524 ## File path: src/io/iter_csv.cc ## @@ -88,6 +154,34 @@ class CSVIter: public

[GitHub] zhanghang1989 commented on a change in pull request #10536: [MXNET-317] Add Data Parallel

2018-04-12 Thread GitBox
zhanghang1989 commented on a change in pull request #10536: [MXNET-317] Add Data Parallel URL: https://github.com/apache/incubator-mxnet/pull/10536#discussion_r181257729 ## File path: python/mxnet/gluon/contrib/parallel.py ## @@ -0,0 +1,245 @@ +# Licensed to the Apache

[GitHub] eric-haibin-lin commented on a change in pull request #10536: [MXNET-317] Add Data Parallel

2018-04-12 Thread GitBox
eric-haibin-lin commented on a change in pull request #10536: [MXNET-317] Add Data Parallel URL: https://github.com/apache/incubator-mxnet/pull/10536#discussion_r181257318 ## File path: python/mxnet/gluon/contrib/parallel.py ## @@ -0,0 +1,245 @@ +# Licensed to the Apache

[GitHub] eric-haibin-lin commented on a change in pull request #10536: [MXNET-317] Add Data Parallel

2018-04-12 Thread GitBox
eric-haibin-lin commented on a change in pull request #10536: [MXNET-317] Add Data Parallel URL: https://github.com/apache/incubator-mxnet/pull/10536#discussion_r181257221 ## File path: python/mxnet/gluon/contrib/parallel.py ## @@ -0,0 +1,245 @@ +# Licensed to the Apache

[GitHub] zhanghang1989 commented on issue #10536: [MXNET-317] Add Data Parallel

2018-04-12 Thread GitBox
zhanghang1989 commented on issue #10536: [MXNET-317] Add Data Parallel URL: https://github.com/apache/incubator-mxnet/pull/10536#issuecomment-380982207 Hi @eric-haibin-lin @piiswrong , DataParallel and Barrier (ParallelState) are included as discussed. Barrier is renamed =>

[GitHub] eric-haibin-lin commented on issue #10531: Float16 Support for dot

2018-04-12 Thread GitBox
eric-haibin-lin commented on issue #10531: Float16 Support for dot URL: https://github.com/apache/incubator-mxnet/issues/10531#issuecomment-380981624 @rahul003 @haojin2 are you guys working on that? This is an automated

[GitHub] rahul003 commented on issue #10531: Float16 Support for dot

2018-04-12 Thread GitBox
rahul003 commented on issue #10531: Float16 Support for dot URL: https://github.com/apache/incubator-mxnet/issues/10531#issuecomment-380977138 Removing my earlier comment. Actually float16 dot does seem supported for GPU. What error did you encounter?

[GitHub] rahul003 commented on issue #10531: Float16 Support for dot

2018-04-12 Thread GitBox
rahul003 commented on issue #10531: Float16 Support for dot URL: https://github.com/apache/incubator-mxnet/issues/10531#issuecomment-380977138 Removing my earlier comment. Actually float16 dot does seem supported for GPU. What error did you encounter?

[GitHub] rahul003 commented on issue #10531: Float16 Support for dot

2018-04-12 Thread GitBox
rahul003 commented on issue #10531: Float16 Support for dot URL: https://github.com/apache/incubator-mxnet/issues/10531#issuecomment-380956997 @haojin2 Looks like we missed this. I went through dot-inl.h. Looks like that's disabled for no reason the GPU through the check. Could you take a

[GitHub] zhanghang1989 opened a new pull request #10536: Add Data Parallel

2018-04-12 Thread GitBox
zhanghang1989 opened a new pull request #10536: Add Data Parallel URL: https://github.com/apache/incubator-mxnet/pull/10536 ## Description ## (Brief description on what this PR is about) ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for

[GitHub] rahul003 commented on a change in pull request #10533: [MXNET-314] [WIP] Support Integer Type parsing in CSVIter

2018-04-12 Thread GitBox
rahul003 commented on a change in pull request #10533: [MXNET-314] [WIP] Support Integer Type parsing in CSVIter URL: https://github.com/apache/incubator-mxnet/pull/10533#discussion_r181238273 ## File path: src/io/iter_csv.cc ## @@ -128,23 +229,45 @@ class CSVIter: public

[GitHub] aaronmarkham commented on a change in pull request #10534: [MXNET-315] Fix the version select in the navbar to be independent of order

2018-04-12 Thread GitBox
aaronmarkham commented on a change in pull request #10534: [MXNET-315] Fix the version select in the navbar to be independent of order URL: https://github.com/apache/incubator-mxnet/pull/10534#discussion_r181246453 ## File path: docs/build_version_doc/update_all_version.sh

[GitHub] aaronmarkham commented on issue #10535: render fix

2018-04-12 Thread GitBox
aaronmarkham commented on issue #10535: render fix URL: https://github.com/apache/incubator-mxnet/pull/10535#issuecomment-380968048 @eric-haibin-lin - please review... should get this in for RC0... This is an automated

[GitHub] anirudh2290 commented on issue #10431: Elementwise multiplication of two ndarrays returns wrong results

2018-04-12 Thread GitBox
anirudh2290 commented on issue #10431: Elementwise multiplication of two ndarrays returns wrong results URL: https://github.com/apache/incubator-mxnet/issues/10431#issuecomment-380967924 You have to add fix in the PR for it to automatically close.

[GitHub] aaronmarkham opened a new pull request #10535: render fix

2018-04-12 Thread GitBox
aaronmarkham opened a new pull request #10535: render fix URL: https://github.com/apache/incubator-mxnet/pull/10535 ## Description ## Display patch fix for a render issue. For some reason the markdown converter is messing up on a comment tag (ridiculous): ```

[GitHub] harusametime commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors

2018-04-12 Thread GitBox
harusametime commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors URL: https://github.com/apache/incubator-mxnet/pull/10528#issuecomment-380967400 @ThomasDelteil Thank you for your testing. I created a ticket and added the label [MXNET-316] to the title of my

[GitHub] anirudh2290 closed issue #10431: Elementwise multiplication of two ndarrays returns wrong results

2018-04-12 Thread GitBox
anirudh2290 closed issue #10431: Elementwise multiplication of two ndarrays returns wrong results URL: https://github.com/apache/incubator-mxnet/issues/10431 This is an automated message from the Apache Git Service. To

[GitHub] harusametime commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors

2018-04-12 Thread GitBox
harusametime commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors URL: https://github.com/apache/incubator-mxnet/pull/10528#issuecomment-380967400 @ThomasDelteil Thank you for your comment. I created a ticket and added the label [MXNET-316] to the title of my

[GitHub] rahul003 commented on a change in pull request #10533: [MXNET-314] [WIP] Support Integer Type parsing in CSVIter

2018-04-12 Thread GitBox
rahul003 commented on a change in pull request #10533: [MXNET-314] [WIP] Support Integer Type parsing in CSVIter URL: https://github.com/apache/incubator-mxnet/pull/10533#discussion_r181237709 ## File path: src/io/iter_csv.cc ## @@ -54,27 +57,90 @@ struct CSVIterParam :

[GitHub] roywei commented on issue #10429: [MXNET-210]give warning for variables with same name in graph visualization

2018-04-12 Thread GitBox
roywei commented on issue #10429: [MXNET-210]give warning for variables with same name in graph visualization URL: https://github.com/apache/incubator-mxnet/pull/10429#issuecomment-380963420 @marcoabreu I am adding a unit test which require graphviz, may I know where shall I configure

[GitHub] rahul003 commented on a change in pull request #10533: [MXNET-314] [WIP] Support Integer Type parsing in CSVIter

2018-04-12 Thread GitBox
rahul003 commented on a change in pull request #10533: [MXNET-314] [WIP] Support Integer Type parsing in CSVIter URL: https://github.com/apache/incubator-mxnet/pull/10533#discussion_r181237908 ## File path: src/io/iter_csv.cc ## @@ -88,6 +154,34 @@ class CSVIter: public

[GitHub] rahul003 commented on a change in pull request #10533: [MXNET-314] [WIP] Support Integer Type parsing in CSVIter

2018-04-12 Thread GitBox
rahul003 commented on a change in pull request #10533: [MXNET-314] [WIP] Support Integer Type parsing in CSVIter URL: https://github.com/apache/incubator-mxnet/pull/10533#discussion_r181238273 ## File path: src/io/iter_csv.cc ## @@ -128,23 +229,45 @@ class CSVIter: public

[GitHub] rahul003 commented on a change in pull request #10533: [MXNET-314] [WIP] Support Integer Type parsing in CSVIter

2018-04-12 Thread GitBox
rahul003 commented on a change in pull request #10533: [MXNET-314] [WIP] Support Integer Type parsing in CSVIter URL: https://github.com/apache/incubator-mxnet/pull/10533#discussion_r181237709 ## File path: src/io/iter_csv.cc ## @@ -54,27 +57,90 @@ struct CSVIterParam :

[GitHub] rahul003 commented on issue #10431: Elementwise multiplication of two ndarrays returns wrong results

2018-04-12 Thread GitBox
rahul003 commented on issue #10431: Elementwise multiplication of two ndarrays returns wrong results URL: https://github.com/apache/incubator-mxnet/issues/10431#issuecomment-380957781 @anirudh2290 Could you close this? I thought that would be done automatically by linking PR to an issue?

[GitHub] rahul003 commented on issue #10431: Elementwise multiplication of two ndarrays returns wrong results

2018-04-12 Thread GitBox
rahul003 commented on issue #10431: Elementwise multiplication of two ndarrays returns wrong results URL: https://github.com/apache/incubator-mxnet/issues/10431#issuecomment-380957781 @anirudh2290 Could you close this? This

[GitHub] rahul003 commented on issue #10531: Float16 Support for dot

2018-04-12 Thread GitBox
rahul003 commented on issue #10531: Float16 Support for dot URL: https://github.com/apache/incubator-mxnet/issues/10531#issuecomment-380956997 @haojin2 Looks like we missed this. I went through dot-inl.h. Looks like that's disabled for no reason the GPU through the check. Could you take a

[GitHub] kpmurali opened a new pull request #10534: [MXNET-315] Fix the version select in the navbar to be independent of order

2018-04-12 Thread GitBox
kpmurali opened a new pull request #10534: [MXNET-315] Fix the version select in the navbar to be independent of order URL: https://github.com/apache/incubator-mxnet/pull/10534 ## Description ## Fix the version select in the navbar to be independent of the order versions listed.

[GitHub] dabraude commented on a change in pull request #10524: [MXNET-312] Added Matthew's Correlation Coefficient to metrics

2018-04-12 Thread GitBox
dabraude commented on a change in pull request #10524: [MXNET-312] Added Matthew's Correlation Coefficient to metrics URL: https://github.com/apache/incubator-mxnet/pull/10524#discussion_r181226180 ## File path: python/mxnet/metric.py ## @@ -661,6 +682,107 @@ def

[GitHub] dabraude commented on a change in pull request #10524: [MXNET-312] Added Matthew's Correlation Coefficient to metrics

2018-04-12 Thread GitBox
dabraude commented on a change in pull request #10524: [MXNET-312] Added Matthew's Correlation Coefficient to metrics URL: https://github.com/apache/incubator-mxnet/pull/10524#discussion_r181226099 ## File path: python/mxnet/metric.py ## @@ -661,6 +682,107 @@ def

[GitHub] KaiserSozo opened a new issue #10532: NDArray failed to allocate CPU memory

2018-04-12 Thread GitBox
KaiserSozo opened a new issue #10532: NDArray failed to allocate CPU memory URL: https://github.com/apache/incubator-mxnet/issues/10532 Traceback (most recent call last): File "SOM.py", line 109, in test_som_with_color_data() File "SOM.py", line 97, in

[GitHub] marcoabreu commented on issue #10525: Fix NNPACK header file position error

2018-04-12 Thread GitBox
marcoabreu commented on issue #10525: Fix NNPACK header file position error URL: https://github.com/apache/incubator-mxnet/pull/10525#issuecomment-380936468 Would you mind taking care of that? This is an automated message

[GitHub] ThomasDelteil commented on a change in pull request #10524: [MXNET-312] Added Matthew's Correlation Coefficient to metrics

2018-04-12 Thread GitBox
ThomasDelteil commented on a change in pull request #10524: [MXNET-312] Added Matthew's Correlation Coefficient to metrics URL: https://github.com/apache/incubator-mxnet/pull/10524#discussion_r181213305 ## File path: python/mxnet/metric.py ## @@ -661,6 +682,107 @@ def

[GitHub] piiswrong closed pull request #10410: Fix output names of nn operators.

2018-04-12 Thread GitBox
piiswrong closed pull request #10410: Fix output names of nn operators. URL: https://github.com/apache/incubator-mxnet/pull/10410 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] piiswrong closed pull request #10515: Prevent partially update of ParameterDict

2018-04-12 Thread GitBox
piiswrong closed pull request #10515: Prevent partially update of ParameterDict URL: https://github.com/apache/incubator-mxnet/pull/10515 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[incubator-mxnet] branch master updated: Prevent partially update of ParameterDict (#10515)

2018-04-12 Thread jxie
This is an automated email from the ASF dual-hosted git repository. jxie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 4852a99 Prevent partially update of

[incubator-mxnet] branch master updated: Fix output names of nn operators. (#10410)

2018-04-12 Thread jxie
This is an automated email from the ASF dual-hosted git repository. jxie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new b96affb Fix output names of nn

[GitHub] piiswrong commented on issue #10425: [MXNET-175] NdArrayiterator dict fix

2018-04-12 Thread GitBox
piiswrong commented on issue #10425: [MXNET-175] NdArrayiterator dict fix URL: https://github.com/apache/incubator-mxnet/pull/10425#issuecomment-380925451 That's incorrect usage. We shouldn't address it by special casing ndarrayiter in module. One thing we can do is to check

[GitHub] piiswrong closed pull request #10424: [MXNET-185] Improved error message

2018-04-12 Thread GitBox
piiswrong closed pull request #10424: [MXNET-185] Improved error message URL: https://github.com/apache/incubator-mxnet/pull/10424 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-mxnet] branch master updated: [MXNET-185] Improved error message (#10424)

2018-04-12 Thread jxie
This is an automated email from the ASF dual-hosted git repository. jxie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 4623c6d [MXNET-185] Improved error

[GitHub] piiswrong commented on a change in pull request #10424: [MXNET-185] Improved error message

2018-04-12 Thread GitBox
piiswrong commented on a change in pull request #10424: [MXNET-185] Improved error message URL: https://github.com/apache/incubator-mxnet/pull/10424#discussion_r181202015 ## File path: python/mxnet/gluon/block.py ## @@ -520,11 +520,11 @@ def _infer_attrs(self, infer_fn,

[GitHub] sbodenstein opened a new issue #10531: Float16 Support for dot

2018-04-12 Thread GitBox
sbodenstein opened a new issue #10531: Float16 Support for dot URL: https://github.com/apache/incubator-mxnet/issues/10531 Is there any work underway to add Float16 support for the dot operator? I know there is a ticket for the general job of adding Float16 support

[GitHub] piiswrong commented on issue #10525: Fix NNPACK header file position error

2018-04-12 Thread GitBox
piiswrong commented on issue #10525: Fix NNPACK header file position error URL: https://github.com/apache/incubator-mxnet/pull/10525#issuecomment-380922761 It's likely not working properly. I think there was an issue on updating nnpack support to include latest changes from nnpack

[GitHub] yzhliu commented on a change in pull request #10462: [MXNET-62] add test against spark integration

2018-04-12 Thread GitBox
yzhliu commented on a change in pull request #10462: [MXNET-62] add test against spark integration URL: https://github.com/apache/incubator-mxnet/pull/10462#discussion_r181194921 ## File path: scala-package/spark/src/test/scala/org/apache/mxnet/spark/MXNetGeneralSuite.scala

[GitHub] yzhliu commented on a change in pull request #10462: [MXNET-62] add test against spark integration

2018-04-12 Thread GitBox
yzhliu commented on a change in pull request #10462: [MXNET-62] add test against spark integration URL: https://github.com/apache/incubator-mxnet/pull/10462#discussion_r181193145 ## File path: scala-package/spark/bin/run-mnist-example.sh ## @@ -72,8 +71,8 @@ fi

[GitHub] spidyDev commented on issue #10425: [MXNET-175] NdArrayiterator dict fix

2018-04-12 Thread GitBox
spidyDev commented on issue #10425: [MXNET-175] NdArrayiterator dict fix URL: https://github.com/apache/incubator-mxnet/pull/10425#issuecomment-380904371 @piiswrong I agree. But user can create a NDIterator with multiple key-value but bind only few of them. For example, ```

[GitHub] haojin2 commented on issue #10376: Flaky test_gluon.test_lambda

2018-04-12 Thread GitBox
haojin2 commented on issue #10376: Flaky test_gluon.test_lambda URL: https://github.com/apache/incubator-mxnet/issues/10376#issuecomment-380903253 @reminisce Sure np! This is an automated message from the Apache Git Service.

[GitHub] marcoabreu commented on issue #10525: Fix NNPACK header file position error

2018-04-12 Thread GitBox
marcoabreu commented on issue #10525: Fix NNPACK header file position error URL: https://github.com/apache/incubator-mxnet/pull/10525#issuecomment-380902775 Should we enable it? This is an automated message from the Apache

[GitHub] reminisce commented on issue #10376: Flaky test_gluon.test_lambda

2018-04-12 Thread GitBox
reminisce commented on issue #10376: Flaky test_gluon.test_lambda URL: https://github.com/apache/incubator-mxnet/issues/10376#issuecomment-380902567 That's the problem of using too small `atol` for comparing two values close to zero. @haojin2 Can you change `atol` to `1e-3` along with

[GitHub] piiswrong commented on a change in pull request #10524: [MXNET-312] Added Matthew's Correlation Coefficient to metrics

2018-04-12 Thread GitBox
piiswrong commented on a change in pull request #10524: [MXNET-312] Added Matthew's Correlation Coefficient to metrics URL: https://github.com/apache/incubator-mxnet/pull/10524#discussion_r181179544 ## File path: python/mxnet/metric.py ## @@ -661,6 +682,107 @@ def

[GitHub] piiswrong commented on issue #10525: Fix NNPACK header file position error

2018-04-12 Thread GitBox
piiswrong commented on issue #10525: Fix NNPACK header file position error URL: https://github.com/apache/incubator-mxnet/pull/10525#issuecomment-380901021 I think nnpack should be moved into nn instead. @marcoabreu nnpack is not tested in the CI. It was added a long time ago and I

[GitHub] piiswrong commented on issue #10525: Fix NNPACK header file position error

2018-04-12 Thread GitBox
piiswrong commented on issue #10525: Fix NNPACK header file position error URL: https://github.com/apache/incubator-mxnet/pull/10525#issuecomment-380901021 I think nnpack should be moved into nn instead. @marcoabreu nnpack is not tested in the CI. I was added a long time ago and I

[GitHub] piiswrong commented on issue #10525: Fix NNPACK header file position error

2018-04-12 Thread GitBox
piiswrong commented on issue #10525: Fix NNPACK header file position error URL: https://github.com/apache/incubator-mxnet/pull/10525#issuecomment-380901021 I think nnpack should be moved into nn instead. @marcoabreu nnpack is not tested in the CI

[GitHub] piiswrong commented on issue #10425: [MXNET-175] NdArrayiterator dict fix

2018-04-12 Thread GitBox
piiswrong commented on issue #10425: [MXNET-175] NdArrayiterator dict fix URL: https://github.com/apache/incubator-mxnet/pull/10425#issuecomment-380900106 I don't think this is the right fix for this issue. The names on ndarrayiter doesn't automatically get's passed to module. The correct

[GitHub] piiswrong commented on issue #10425: [MXNET-175] NdArrayiterator dict fix

2018-04-12 Thread GitBox
piiswrong commented on issue #10425: [MXNET-175] NdArrayiterator dict fix URL: https://github.com/apache/incubator-mxnet/pull/10425#issuecomment-380900106 I don't think this is the right fix for this issue. The names in ndarrayiter doesn't automatically get's passed to module. The correct

[GitHub] haojin2 commented on issue #10376: Flaky test_gluon.test_lambda

2018-04-12 Thread GitBox
haojin2 commented on issue #10376: Flaky test_gluon.test_lambda URL: https://github.com/apache/incubator-mxnet/issues/10376#issuecomment-380900183 I met the same failure in: http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/incubator-mxnet/detail/PR-10371/6/pipeline. I

[GitHub] haojin2 commented on a change in pull request #10371: [MXNET-263] Support for dot(dns, csr) = dns and dot(dns, csr.T) = dns on GPU

2018-04-12 Thread GitBox
haojin2 commented on a change in pull request #10371: [MXNET-263] Support for dot(dns, csr) = dns and dot(dns, csr.T) = dns on GPU URL: https://github.com/apache/incubator-mxnet/pull/10371#discussion_r181177330 ## File path: src/operator/tensor/dot-inl.cuh ## @@ -895,6

[GitHub] marcoabreu commented on issue #9940: [MXNET-46]remove set CMAKE_GENERATOR_TOOLSET

2018-04-12 Thread GitBox
marcoabreu commented on issue #9940: [MXNET-46]remove set CMAKE_GENERATOR_TOOLSET URL: https://github.com/apache/incubator-mxnet/pull/9940#issuecomment-380898099 @lebeg This is an automated message from the Apache Git

[GitHub] aaronmarkham commented on issue #10485: [MXNET-304][RFC] Jenkins docs build

2018-04-12 Thread GitBox
aaronmarkham commented on issue #10485: [MXNET-304][RFC] Jenkins docs build URL: https://github.com/apache/incubator-mxnet/pull/10485#issuecomment-380897741 Ya, @ThomasDelteil ! Nightlies! This is an automated message

[GitHub] aaronmarkham commented on a change in pull request #10485: [MXNET-304][RFC] Jenkins docs build

2018-04-12 Thread GitBox
aaronmarkham commented on a change in pull request #10485: [MXNET-304][RFC] Jenkins docs build URL: https://github.com/apache/incubator-mxnet/pull/10485#discussion_r181175309 ## File path: ci/docker/install/ubuntu_scala.sh ## @@ -22,10 +22,17 @@ set -ex # install

[incubator-mxnet] branch master updated: Minor spelling corrections in profile (#10526)

2018-04-12 Thread jxie
This is an automated email from the ASF dual-hosted git repository. jxie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 923eb90 Minor spelling corrections in

[GitHub] piiswrong closed pull request #10526: Minor spelling corrections in profile

2018-04-12 Thread GitBox
piiswrong closed pull request #10526: Minor spelling corrections in profile URL: https://github.com/apache/incubator-mxnet/pull/10526 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] aaronmarkham commented on a change in pull request #10511: add naming tutorial

2018-04-12 Thread GitBox
aaronmarkham commented on a change in pull request #10511: add naming tutorial URL: https://github.com/apache/incubator-mxnet/pull/10511#discussion_r181166466 ## File path: docs/tutorials/gluon/naming.md ## @@ -0,0 +1,236 @@ + +# Naming of Gluon Parameter and Blocks + +In

[GitHub] lebeg opened a new pull request #10530: Jetson build with cmake and CUDA

2018-04-12 Thread GitBox
lebeg opened a new pull request #10530: Jetson build with cmake and CUDA URL: https://github.com/apache/incubator-mxnet/pull/10530 ## Description ## Changed jetson build to cmake. ## Checklist ## ### Essentials ### - [x] The PR title does not start with [MXNET-$JIRA_ID],

[GitHub] Roshrini commented on issue #10480: Could you help build windows pypi package with cuda9.0

2018-04-12 Thread GitBox
Roshrini commented on issue #10480: Could you help build windows pypi package with cuda9.0 URL: https://github.com/apache/incubator-mxnet/issues/10480#issuecomment-380892774 @PaulaQin Were you able to build the package?

[GitHub] aaronmarkham commented on a change in pull request #10511: add naming tutorial

2018-04-12 Thread GitBox
aaronmarkham commented on a change in pull request #10511: add naming tutorial URL: https://github.com/apache/incubator-mxnet/pull/10511#discussion_r181165570 ## File path: docs/tutorials/gluon/naming.md ## @@ -0,0 +1,236 @@ + +# Naming of Gluon Parameter and Blocks + +In

[GitHub] aaronmarkham commented on a change in pull request #10511: add naming tutorial

2018-04-12 Thread GitBox
aaronmarkham commented on a change in pull request #10511: add naming tutorial URL: https://github.com/apache/incubator-mxnet/pull/10511#discussion_r181162009 ## File path: docs/tutorials/gluon/naming.md ## @@ -0,0 +1,236 @@ + +# Naming of Gluon Parameter and Blocks + +In

  1   2   >