[GitHub] piyushghai edited a comment on issue #11626: [MXNET-651] MXNet Model Backwards Compatibility Checker

2018-07-10 Thread GitBox
piyushghai edited a comment on issue #11626: [MXNET-651] MXNet Model Backwards Compatibility Checker URL: https://github.com/apache/incubator-mxnet/pull/11626#issuecomment-404054059 We cannot unittest it as we are not testing the various model save/load APIs on the same version. We are

[GitHub] piyushghai commented on issue #11626: [MXNET-651] MXNet Model Backwards Compatibility Checker

2018-07-10 Thread GitBox
piyushghai commented on issue #11626: [MXNET-651] MXNet Model Backwards Compatibility Checker URL: https://github.com/apache/incubator-mxnet/pull/11626#issuecomment-404054059 We cannot unittest it as we are not testing the various model save/load APIs on the same version. We are trying to

[GitHub] szha commented on issue #11626: [MXNET-651] MXNet Model Backwards Compatibility Checker

2018-07-10 Thread GitBox
szha commented on issue #11626: [MXNET-651] MXNet Model Backwards Compatibility Checker URL: https://github.com/apache/incubator-mxnet/pull/11626#issuecomment-404053762 How do you test load_parameters and save_parameters? What additional case would the new test case for gluon's

[GitHub] zheng-da opened a new pull request #11641: [WIP] make CachedOp a normal operator

2018-07-10 Thread GitBox
zheng-da opened a new pull request #11641: [WIP] make CachedOp a normal operator URL: https://github.com/apache/incubator-mxnet/pull/11641 ## Description ## Currently, CachedOp is used for Gluon hybridization. It's registered as an operator, but it doesn't have a full set of operator

[GitHub] szha commented on issue #11626: [MXNET-651] MXNet Model Backwards Compatibility Checker

2018-07-10 Thread GitBox
szha commented on issue #11626: [MXNET-651] MXNet Model Backwards Compatibility Checker URL: https://github.com/apache/incubator-mxnet/pull/11626#issuecomment-404053508 2 is deprecated so there's no need to test. This is an

[GitHub] szha commented on issue #11626: [MXNET-651] MXNet Model Backwards Compatibility Checker

2018-07-10 Thread GitBox
szha commented on issue #11626: [MXNET-651] MXNet Model Backwards Compatibility Checker URL: https://github.com/apache/incubator-mxnet/pull/11626#issuecomment-404053471 Any reason not to do it in unittest, using a smaller model?

[GitHub] piyushghai edited a comment on issue #11626: [MXNET-651] MXNet Model Backwards Compatibility Checker

2018-07-10 Thread GitBox
piyushghai edited a comment on issue #11626: [MXNET-651] MXNet Model Backwards Compatibility Checker URL: https://github.com/apache/incubator-mxnet/pull/11626#issuecomment-404053135 I am checking the following scenarios to save/load models : 1. Hybridized models import/export API from

[GitHub] piyushghai commented on issue #11626: [MXNET-651] MXNet Model Backwards Compatibility Checker

2018-07-10 Thread GitBox
piyushghai commented on issue #11626: [MXNET-651] MXNet Model Backwards Compatibility Checker URL: https://github.com/apache/incubator-mxnet/pull/11626#issuecomment-404053135 I am checking the following scenarios to save/load models : 1. Hybridized models import/export API from [Gluon

[GitHub] szha commented on issue #11626: [MXNET-651] MXNet Model Backwards Compatibility Checker

2018-07-10 Thread GitBox
szha commented on issue #11626: [MXNET-651] MXNet Model Backwards Compatibility Checker URL: https://github.com/apache/incubator-mxnet/pull/11626#issuecomment-404052621 What kind of "loading" are you testing? The statement, as is, is underspecified.

[GitHub] szha closed pull request #11637: [MXNET-652] Allow for multi-context input to load gluon models from onnx

2018-07-10 Thread GitBox
szha closed pull request #11637: [MXNET-652] Allow for multi-context input to load gluon models from onnx URL: https://github.com/apache/incubator-mxnet/pull/11637 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[incubator-mxnet] branch master updated: [MXNET-652] Allow for multi-context input to load gluon models from onnx (#11637)

2018-07-10 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new f665c13 [MXNET-652] Allow for

[GitHub] szha commented on a change in pull request #11637: [MXNET-652] Allow for multi-context input to load gluon models from onnx

2018-07-10 Thread GitBox
szha commented on a change in pull request #11637: [MXNET-652] Allow for multi-context input to load gluon models from onnx URL: https://github.com/apache/incubator-mxnet/pull/11637#discussion_r201570460 ## File path: python/mxnet/contrib/onnx/onnx2mx/import_onnx.py ## @@

[GitHub] piyushghai commented on issue #11626: [MXNET-651] MXNet Model Backwards Compatibility Checker

2018-07-10 Thread GitBox
piyushghai commented on issue #11626: [MXNET-651] MXNet Model Backwards Compatibility Checker URL: https://github.com/apache/incubator-mxnet/pull/11626#issuecomment-404051396 @szha Here's what this PR does : "Backward compatibility aims to check whether models trained on earlier

[incubator-mxnet] branch master updated: Added query for cuDNN BN min. epsilon. Enabled choice of BN impl. for ONNX import (#11380)

2018-07-10 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new d814733 Added query for cuDNN BN

[GitHub] szha closed pull request #11380: Add ability to query cuDNN BatchNorm min. epsilon. Allow ONNX importer to use cuDNN BN if chosen eps >= cuDNN min. eps.

2018-07-10 Thread GitBox
szha closed pull request #11380: Add ability to query cuDNN BatchNorm min. epsilon. Allow ONNX importer to use cuDNN BN if chosen eps >= cuDNN min. eps. URL: https://github.com/apache/incubator-mxnet/pull/11380 This is a PR merged from a forked repository. As GitHub hides the original

[incubator-mxnet] branch master updated: Add stable nrm2 Reducer (#11573)

2018-07-10 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 43ad56c Add stable nrm2 Reducer

[GitHub] szha commented on issue #11509: Hanging flaky test test_operator.test_norm @ Python 3: GPU Win

2018-07-10 Thread GitBox
szha commented on issue #11509: Hanging flaky test test_operator.test_norm @ Python 3: GPU Win URL: https://github.com/apache/incubator-mxnet/issues/11509#issuecomment-404049914 FYI @anirudhacharya the test has been partially re-enabled in #11573.

[GitHub] szha closed pull request #11573: Add stable nrm2 Reducer

2018-07-10 Thread GitBox
szha closed pull request #11573: Add stable nrm2 Reducer URL: https://github.com/apache/incubator-mxnet/pull/11573 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] leezu commented on a change in pull request #11573: Add stable nrm2 Reducer

2018-07-10 Thread GitBox
leezu commented on a change in pull request #11573: Add stable nrm2 Reducer URL: https://github.com/apache/incubator-mxnet/pull/11573#discussion_r201567681 ## File path: src/operator/mshadow_op.h ## @@ -815,6 +868,76 @@ struct nanprod { } }; +/*! \brief compute l2

[GitHub] leezu commented on a change in pull request #11573: Add stable nrm2 Reducer

2018-07-10 Thread GitBox
leezu commented on a change in pull request #11573: Add stable nrm2 Reducer URL: https://github.com/apache/incubator-mxnet/pull/11573#discussion_r201567681 ## File path: src/operator/mshadow_op.h ## @@ -815,6 +868,76 @@ struct nanprod { } }; +/*! \brief compute l2

[GitHub] leezu commented on a change in pull request #11573: Add stable nrm2 Reducer

2018-07-10 Thread GitBox
leezu commented on a change in pull request #11573: Add stable nrm2 Reducer URL: https://github.com/apache/incubator-mxnet/pull/11573#discussion_r201564912 ## File path: tests/python/unittest/test_operator.py ## @@ -3051,30 +3061,31 @@ def l2norm(input_data, axis=0,

[GitHub] Ericargus opened a new issue #11640: write a new operator by myself

2018-07-10 Thread GitBox
Ericargus opened a new issue #11640: write a new operator by myself URL: https://github.com/apache/incubator-mxnet/issues/11640 Note: Providing complete information in the most concise form is the best way to get help. This issue template serves as the checklist for essential information

[GitHub] szha commented on issue #11639: some big numbers can not be assigned correctly with ndarray, it is a big bug???

2018-07-10 Thread GitBox
szha commented on issue #11639: some big numbers can not be assigned correctly with ndarray, it is a big bug??? URL: https://github.com/apache/incubator-mxnet/issues/11639#issuecomment-404038324 reproducible on master This

[GitHub] reminisce commented on issue #11325: Added TensorRT runtime integration

2018-07-10 Thread GitBox
reminisce commented on issue #11325: Added TensorRT runtime integration URL: https://github.com/apache/incubator-mxnet/pull/11325#issuecomment-404037962 @mkolod If I have understood the puzzle correctly, you want to access the TRT graph in the executor from frontend only for the testing

[GitHub] starimpact commented on issue #11639: ndarray can not store some big number, it is a bug???

2018-07-10 Thread GitBox
starimpact commented on issue #11639: ndarray can not store some big number, it is a bug??? URL: https://github.com/apache/incubator-mxnet/issues/11639#issuecomment-404037532 @tqchen @piiswrong This is an automated message

[GitHub] starimpact opened a new issue #11639: ndarray can not store some big number, it is a bug???

2018-07-10 Thread GitBox
starimpact opened a new issue #11639: ndarray can not store some big number, it is a bug??? URL: https://github.com/apache/incubator-mxnet/issues/11639 code: ```python 1 import sys 2 sys.path.insert(0, '/home/mingzhang/work/dmlc/mxnet_v0.8.0.python') 3 4 import mxnet

[GitHub] eric-haibin-lin commented on issue #11633: Fix dist kvstore for trainer

2018-07-10 Thread GitBox
eric-haibin-lin commented on issue #11633: Fix dist kvstore for trainer URL: https://github.com/apache/incubator-mxnet/pull/11633#issuecomment-404034465 @marcoabreu I've fixed and enabled the test. This is an automated

[GitHub] szha commented on a change in pull request #11636: [WIP] set MXNET_DATA_DIR as base for downloaded models through base.data_dir()

2018-07-10 Thread GitBox
szha commented on a change in pull request #11636: [WIP] set MXNET_DATA_DIR as base for downloaded models through base.data_dir() URL: https://github.com/apache/incubator-mxnet/pull/11636#discussion_r201554781 ## File path: docs/faq/env_var.md ## @@ -126,6 +126,11 @@ When

[GitHub] junrushao1994 commented on issue #11566: [MXNET-626] Add while_loop

2018-07-10 Thread GitBox
junrushao1994 commented on issue #11566: [MXNET-626] Add while_loop URL: https://github.com/apache/incubator-mxnet/pull/11566#issuecomment-404031350 @eric-haibin-lin @zheng-da I think while loop could support sparse NDArrays as well, so I remove the checks

[GitHub] al-rigazzi opened a new issue #11620: LBSGD does not have momentum

2018-07-10 Thread GitBox
al-rigazzi opened a new issue #11620: LBSGD does not have momentum URL: https://github.com/apache/incubator-mxnet/issues/11620 https://github.com/apache/incubator-mxnet/blob/8fde4b7526acbbe242fd5a5f41fac9e477f927f3/example/image-classification/common/fit.py#L219 Hi, I was wondering

[GitHub] reminisce commented on a change in pull request #11325: Added TensorRT runtime integration

2018-07-10 Thread GitBox
reminisce commented on a change in pull request #11325: Added TensorRT runtime integration URL: https://github.com/apache/incubator-mxnet/pull/11325#discussion_r201547888 ## File path: src/operator/contrib/tensorrt.cc ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache

[GitHub] reminisce commented on a change in pull request #11325: Added TensorRT runtime integration

2018-07-10 Thread GitBox
reminisce commented on a change in pull request #11325: Added TensorRT runtime integration URL: https://github.com/apache/incubator-mxnet/pull/11325#discussion_r201547571 ## File path: src/executor/tensorrt_pass.cc ## @@ -0,0 +1,583 @@ +/* + * Licensed to the Apache

[GitHub] ifeherva edited a comment on issue #9253: Numpy Diag in MXNet

2018-07-10 Thread GitBox
ifeherva edited a comment on issue #9253: Numpy Diag in MXNet URL: https://github.com/apache/incubator-mxnet/issues/9253#issuecomment-403290348 I am working on replicating np.diag(). Once done will do the full diagonal operator. This is my first operator so I am learning a lot at the

[GitHub] wkcn commented on issue #8569: The conflict between MXNet and OpenCV

2018-07-10 Thread GitBox
wkcn commented on issue #8569: The conflict between MXNet and OpenCV URL: https://github.com/apache/incubator-mxnet/issues/8569#issuecomment-404021480 @tequilaguru Thank you! I will try it next time. This is an automated

[GitHub] anirudh2290 commented on a change in pull request #11573: Add stable nrm2 Reducer

2018-07-10 Thread GitBox
anirudh2290 commented on a change in pull request #11573: Add stable nrm2 Reducer URL: https://github.com/apache/incubator-mxnet/pull/11573#discussion_r201541083 ## File path: tests/python/unittest/test_operator.py ## @@ -3051,30 +3061,31 @@ def l2norm(input_data, axis=0,

[GitHub] anirudh2290 commented on a change in pull request #11573: Add stable nrm2 Reducer

2018-07-10 Thread GitBox
anirudh2290 commented on a change in pull request #11573: Add stable nrm2 Reducer URL: https://github.com/apache/incubator-mxnet/pull/11573#discussion_r201542704 ## File path: src/operator/mshadow_op.h ## @@ -815,6 +868,76 @@ struct nanprod { } }; +/*! \brief

[GitHub] eric-haibin-lin opened a new issue #11638: distributed kvstore doesn't respect shape of ndarrays

2018-07-10 Thread GitBox
eric-haibin-lin opened a new issue #11638: distributed kvstore doesn't respect shape of ndarrays URL: https://github.com/apache/incubator-mxnet/issues/11638 Steps to reproduce: `test.py` ``` import mxnet as mx shape = (4, 2) def init_kv(): """init kv """

[GitHub] aaronmarkham edited a comment on issue #11562: [MXNET-244] Update RaspberryPI instructions

2018-07-10 Thread GitBox
aaronmarkham edited a comment on issue #11562: [MXNET-244] Update RaspberryPI instructions URL: https://github.com/apache/incubator-mxnet/pull/11562#issuecomment-404011682 I'm not sure what's up with that preview. It does that to me sometimes too. Try this link:

[GitHub] aaronmarkham commented on issue #11562: [MXNET-244] Update RaspberryPI instructions

2018-07-10 Thread GitBox
aaronmarkham commented on issue #11562: [MXNET-244] Update RaspberryPI instructions URL: https://github.com/apache/incubator-mxnet/pull/11562#issuecomment-404011682 I'm not sure what's up with that preview. It does that to me sometimes too.

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2018-07-10 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 66920dd Bump the publish

[GitHub] haojin2 commented on issue #11599: Autograd fails when using `take` operator repeatedly

2018-07-10 Thread GitBox
haojin2 commented on issue #11599: Autograd fails when using `take` operator repeatedly URL: https://github.com/apache/incubator-mxnet/issues/11599#issuecomment-404009281 So the problem is that the req type of the indices is not null, maybe this is due to the usage, I'll take a deeper

[GitHub] haojin2 commented on issue #11326: [MXNET-381] Enhancement of take operator

2018-07-10 Thread GitBox
haojin2 commented on issue #11326: [MXNET-381] Enhancement of take operator URL: https://github.com/apache/incubator-mxnet/pull/11326#issuecomment-404007175 @piiswrong Please give a review once you have a minute. This is an

[GitHub] anirudh2290 closed issue #11487: test_sample_multinomial test is flaky

2018-07-10 Thread GitBox
anirudh2290 closed issue #11487: test_sample_multinomial test is flaky URL: https://github.com/apache/incubator-mxnet/issues/11487 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] anirudh2290 commented on issue #11487: test_sample_multinomial test is flaky

2018-07-10 Thread GitBox
anirudh2290 commented on issue #11487: test_sample_multinomial test is flaky URL: https://github.com/apache/incubator-mxnet/issues/11487#issuecomment-404000192 Enabled it back here: https://github.com/apache/incubator-mxnet/pull/11366/files. Closing.

[GitHub] anirudh2290 closed pull request #11366: Fix flaky test:test_sample_multinomial

2018-07-10 Thread GitBox
anirudh2290 closed pull request #11366: Fix flaky test:test_sample_multinomial URL: https://github.com/apache/incubator-mxnet/pull/11366 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] ctcyang removed a comment on issue #11633: Fix dist kvstore for trainer

2018-07-10 Thread GitBox
ctcyang removed a comment on issue #11633: Fix dist kvstore for trainer URL: https://github.com/apache/incubator-mxnet/pull/11633#issuecomment-403999117 The three nightly tests now pass. LGTM This is an automated message from

[GitHub] anirudh2290 closed issue #10838: Flaky test_random.test_sample_multinomial

2018-07-10 Thread GitBox
anirudh2290 closed issue #10838: Flaky test_random.test_sample_multinomial URL: https://github.com/apache/incubator-mxnet/issues/10838 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-mxnet] branch master updated: Fix flaky test:test_sample_multinomial (#11366)

2018-07-10 Thread anirudh2290
This is an automated email from the ASF dual-hosted git repository. anirudh2290 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new c792638 Fix flaky

[GitHub] ctcyang commented on issue #11633: Fix dist kvstore for trainer

2018-07-10 Thread GitBox
ctcyang commented on issue #11633: Fix dist kvstore for trainer URL: https://github.com/apache/incubator-mxnet/pull/11633#issuecomment-403999117 The three nightly tests now pass. LGTM This is an automated message from the

[GitHub] anirudh2290 commented on issue #11252: [MXNET-323] Improve performance of broadcast ops backward pass

2018-07-10 Thread GitBox
anirudh2290 commented on issue #11252: [MXNET-323] Improve performance of broadcast ops backward pass URL: https://github.com/apache/incubator-mxnet/pull/11252#issuecomment-403999019 @eric-haibin-lin I have addressed your comments.

[GitHub] mkolod commented on a change in pull request #11325: Added TensorRT runtime integration

2018-07-10 Thread GitBox
mkolod commented on a change in pull request #11325: Added TensorRT runtime integration URL: https://github.com/apache/incubator-mxnet/pull/11325#discussion_r201527141 ## File path: src/operator/contrib/tensorrt.cc ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache

[GitHub] lanking520 commented on issue #11571: RNN Example not supported for MXNet Scala

2018-07-10 Thread GitBox
lanking520 commented on issue #11571: RNN Example not supported for MXNet Scala URL: https://github.com/apache/incubator-mxnet/issues/11571#issuecomment-403997392 The root cause of this issue is [this

[GitHub] thomelane commented on issue #11620: LBSGD does not have momentum

2018-07-10 Thread GitBox
thomelane commented on issue #11620: LBSGD does not have momentum URL: https://github.com/apache/incubator-mxnet/issues/11620#issuecomment-403996393 @sandeep-krishnamurthy @apeforest can we reopen and tag, looks like this should actually be updated. Signum and LBSGD both have momentum but

[GitHub] haojin2 commented on a change in pull request #11587: [MXNET-378] Adding depth_to_space and space_to_depth operator(Updated)

2018-07-10 Thread GitBox
haojin2 commented on a change in pull request #11587: [MXNET-378] Adding depth_to_space and space_to_depth operator(Updated) URL: https://github.com/apache/incubator-mxnet/pull/11587#discussion_r201525428 ## File path: src/operator/tensor/matrix_op-inl.h ## @@ -2158,6

[GitHub] haojin2 commented on a change in pull request #11587: [MXNET-378] Adding depth_to_space and space_to_depth operator(Updated)

2018-07-10 Thread GitBox
haojin2 commented on a change in pull request #11587: [MXNET-378] Adding depth_to_space and space_to_depth operator(Updated) URL: https://github.com/apache/incubator-mxnet/pull/11587#discussion_r201525428 ## File path: src/operator/tensor/matrix_op-inl.h ## @@ -2158,6

[GitHub] haojin2 commented on a change in pull request #11587: [MXNET-378] Adding depth_to_space and space_to_depth operator(Updated)

2018-07-10 Thread GitBox
haojin2 commented on a change in pull request #11587: [MXNET-378] Adding depth_to_space and space_to_depth operator(Updated) URL: https://github.com/apache/incubator-mxnet/pull/11587#discussion_r201525201 ## File path: tests/python/unittest/test_operator.py ## @@ -6966,6

[GitHub] lanking520 edited a comment on issue #11571: RNN Example not supported for MXNet Scala

2018-07-10 Thread GitBox
lanking520 edited a comment on issue #11571: RNN Example not supported for MXNet Scala URL: https://github.com/apache/incubator-mxnet/issues/11571#issuecomment-403921397 @yzhliu tested on `v1.1.0` backend and v1.0.0 frontend and didn't reproduce the issue. So I think it should be Scala

[GitHub] haojin2 commented on a change in pull request #11587: [MXNET-378] Adding depth_to_space and space_to_depth operator(Updated)

2018-07-10 Thread GitBox
haojin2 commented on a change in pull request #11587: [MXNET-378] Adding depth_to_space and space_to_depth operator(Updated) URL: https://github.com/apache/incubator-mxnet/pull/11587#discussion_r201524586 ## File path: src/operator/tensor/matrix_op.cc ## @@ -908,5 +909,96

[GitHub] haojin2 commented on a change in pull request #11587: [MXNET-378] Adding depth_to_space and space_to_depth operator(Updated)

2018-07-10 Thread GitBox
haojin2 commented on a change in pull request #11587: [MXNET-378] Adding depth_to_space and space_to_depth operator(Updated) URL: https://github.com/apache/incubator-mxnet/pull/11587#discussion_r201524568 ## File path: src/operator/tensor/matrix_op.cc ## @@ -908,5 +909,96

[GitHub] anirudhacharya commented on a change in pull request #11590: [MXNET-627] Fix Installation instructions for R bindings on Linux systems.

2018-07-10 Thread GitBox
anirudhacharya commented on a change in pull request #11590: [MXNET-627] Fix Installation instructions for R bindings on Linux systems. URL: https://github.com/apache/incubator-mxnet/pull/11590#discussion_r201516454 ## File path: docs/install/index.md ## @@ -939,133

[GitHub] haojin2 commented on a change in pull request #11587: [MXNET-378] Adding depth_to_space and space_to_depth operator(Updated)

2018-07-10 Thread GitBox
haojin2 commented on a change in pull request #11587: [MXNET-378] Adding depth_to_space and space_to_depth operator(Updated) URL: https://github.com/apache/incubator-mxnet/pull/11587#discussion_r201524217 ## File path: src/operator/tensor/matrix_op.cc ## @@ -908,5 +909,96

[GitHub] haojin2 commented on a change in pull request #11587: [MXNET-378] Adding depth_to_space and space_to_depth operator(Updated)

2018-07-10 Thread GitBox
haojin2 commented on a change in pull request #11587: [MXNET-378] Adding depth_to_space and space_to_depth operator(Updated) URL: https://github.com/apache/incubator-mxnet/pull/11587#discussion_r201524165 ## File path: src/operator/tensor/matrix_op.cc ## @@ -908,5 +909,96

[GitHub] larroy commented on issue #11562: [MXNET-244] Update RaspberryPI instructions

2018-07-10 Thread GitBox
larroy commented on issue #11562: [MXNET-244] Update RaspberryPI instructions URL: https://github.com/apache/incubator-mxnet/pull/11562#issuecomment-403994813 @aaronmarkham I don't have access to that url This is an

[GitHub] aaronmarkham edited a comment on issue #11590: [MXNET-627] Fix Installation instructions for R bindings on Linux systems.

2018-07-10 Thread GitBox
aaronmarkham edited a comment on issue #11590: [MXNET-627] Fix Installation instructions for R bindings on Linux systems. URL: https://github.com/apache/incubator-mxnet/pull/11590#issuecomment-403939181 I went ahead and resolved an issue with using the CI scripts as part of the

[GitHub] apeforest commented on issue #11466: [MXNET-560] Add temperature parameter in Softmax operator

2018-07-10 Thread GitBox
apeforest commented on issue #11466: [MXNET-560] Add temperature parameter in Softmax operator URL: https://github.com/apache/incubator-mxnet/pull/11466#issuecomment-403993815 If we add an if statement up front instead of inside every operation, the performance impact should be minimal.

[GitHub] haojin2 commented on issue #11498: Fix InferStorage for sparse fallback in FullyConnected

2018-07-10 Thread GitBox
haojin2 commented on issue #11498: Fix InferStorage for sparse fallback in FullyConnected URL: https://github.com/apache/incubator-mxnet/pull/11498#issuecomment-403993379 @zheng-da unit test added. This is an automated

[GitHub] haojin2 commented on a change in pull request #11625: [MXNET-647] Add Diff Collator

2018-07-10 Thread GitBox
haojin2 commented on a change in pull request #11625: [MXNET-647] Add Diff Collator URL: https://github.com/apache/incubator-mxnet/pull/11625#discussion_r201521047 ## File path: tools/diff_collator.py ## @@ -0,0 +1,165 @@ +# Licensed to the Apache Software Foundation

[GitHub] larroy commented on a change in pull request #11636: [WIP] set MXNET_DATA_DIR as base for downloaded models through base.data_dir()

2018-07-10 Thread GitBox
larroy commented on a change in pull request #11636: [WIP] set MXNET_DATA_DIR as base for downloaded models through base.data_dir() URL: https://github.com/apache/incubator-mxnet/pull/11636#discussion_r201522284 ## File path: docs/faq/env_var.md ## @@ -126,6 +126,11 @@

[GitHub] aaronmarkham edited a comment on issue #11590: [MXNET-627] Fix Installation instructions for R bindings on Linux systems.

2018-07-10 Thread GitBox
aaronmarkham edited a comment on issue #11590: [MXNET-627] Fix Installation instructions for R bindings on Linux systems. URL: https://github.com/apache/incubator-mxnet/pull/11590#issuecomment-403939181 I went ahead and resolved an issue with using the CI scripts as part of the

[GitHub] Caenorst commented on a change in pull request #11325: Added TensorRT runtime integration

2018-07-10 Thread GitBox
Caenorst commented on a change in pull request #11325: Added TensorRT runtime integration URL: https://github.com/apache/incubator-mxnet/pull/11325#discussion_r201521176 ## File path: src/executor/tensorrt_pass.cc ## @@ -0,0 +1,583 @@ +/* + * Licensed to the Apache

[GitHub] reminisce commented on a change in pull request #11325: Added TensorRT runtime integration

2018-07-10 Thread GitBox
reminisce commented on a change in pull request #11325: Added TensorRT runtime integration URL: https://github.com/apache/incubator-mxnet/pull/11325#discussion_r201520406 ## File path: src/operator/contrib/tensorrt.cc ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache

[GitHub] ctcyang commented on a change in pull request #11591: [MXNET-331] Single machine All Reduce Topology-aware Communication (Updated)

2018-07-10 Thread GitBox
ctcyang commented on a change in pull request #11591: [MXNET-331] Single machine All Reduce Topology-aware Communication (Updated) URL: https://github.com/apache/incubator-mxnet/pull/11591#discussion_r201520187 ## File path: src/kvstore/comm_tree.h ## @@ -0,0 +1,500 @@

[GitHub] aaronmarkham commented on issue #11590: [MXNET-627] Fix Installation instructions for R bindings on Linux systems.

2018-07-10 Thread GitBox
aaronmarkham commented on issue #11590: [MXNET-627] Fix Installation instructions for R bindings on Linux systems. URL: https://github.com/apache/incubator-mxnet/pull/11590#issuecomment-403990955 @hetong007 I updated the install page for OSX and Windows to point to the detailed

[GitHub] OneRaynyDay opened a new pull request #11637: [MXNET-652] Allow for multi-context input to load gluon models from onnx

2018-07-10 Thread GitBox
OneRaynyDay opened a new pull request #11637: [MXNET-652] Allow for multi-context input to load gluon models from onnx URL: https://github.com/apache/incubator-mxnet/pull/11637 ## Description ## Currently, Airbnb is developing applications that use mxnet(particularly `gluon`). We use

[GitHub] szha commented on a change in pull request #11636: [WIP] set MXNET_DATA_DIR as base for downloaded models through base.data_dir()

2018-07-10 Thread GitBox
szha commented on a change in pull request #11636: [WIP] set MXNET_DATA_DIR as base for downloaded models through base.data_dir() URL: https://github.com/apache/incubator-mxnet/pull/11636#discussion_r201517750 ## File path: python/mxnet/base.py ## @@ -47,6 +48,32 @@

[GitHub] szha commented on a change in pull request #11636: [WIP] set MXNET_DATA_DIR as base for downloaded models through base.data_dir()

2018-07-10 Thread GitBox
szha commented on a change in pull request #11636: [WIP] set MXNET_DATA_DIR as base for downloaded models through base.data_dir() URL: https://github.com/apache/incubator-mxnet/pull/11636#discussion_r201517657 ## File path: python/mxnet/base.py ## @@ -47,6 +48,32 @@

[GitHub] larroy commented on issue #11602: Fix for flaky keyservers #11601

2018-07-10 Thread GitBox
larroy commented on issue #11602: Fix for flaky keyservers #11601 URL: https://github.com/apache/incubator-mxnet/pull/11602#issuecomment-403988433 @szha This is an automated message from the Apache Git Service. To respond to

[GitHub] larroy commented on a change in pull request #11636: [WIP] set MXNET_DATA_DIR as base for downloaded models through base.data_dir()

2018-07-10 Thread GitBox
larroy commented on a change in pull request #11636: [WIP] set MXNET_DATA_DIR as base for downloaded models through base.data_dir() URL: https://github.com/apache/incubator-mxnet/pull/11636#discussion_r201517324 ## File path: python/mxnet/base.py ## @@ -47,6 +48,32 @@

[GitHub] szha commented on issue #11616: Flaky test test_gluon.test_export

2018-07-10 Thread GitBox
szha commented on issue #11616: Flaky test test_gluon.test_export URL: https://github.com/apache/incubator-mxnet/issues/11616#issuecomment-403988257 Having this complexity in the code base just to do what containers should have done doesn't seem the right approach to me.

[GitHub] larroy commented on a change in pull request #11636: [WIP] set MXNET_DATA_DIR as base for downloaded models through base.data_dir()

2018-07-10 Thread GitBox
larroy commented on a change in pull request #11636: [WIP] set MXNET_DATA_DIR as base for downloaded models through base.data_dir() URL: https://github.com/apache/incubator-mxnet/pull/11636#discussion_r201517185 ## File path: python/mxnet/base.py ## @@ -47,6 +48,32 @@

[GitHub] szha commented on issue #11616: Flaky test test_gluon.test_export

2018-07-10 Thread GitBox
szha commented on issue #11616: Flaky test test_gluon.test_export URL: https://github.com/apache/incubator-mxnet/issues/11616#issuecomment-403988023 Many design decisions are based on having a single instance of mxnet in a system. For example, the mxnet processes don't attempt to find and

[GitHub] szha commented on a change in pull request #11636: [WIP] set MXNET_DATA_DIR as base for downloaded models through base.data_dir()

2018-07-10 Thread GitBox
szha commented on a change in pull request #11636: [WIP] set MXNET_DATA_DIR as base for downloaded models through base.data_dir() URL: https://github.com/apache/incubator-mxnet/pull/11636#discussion_r201515424 ## File path: python/mxnet/base.py ## @@ -47,6 +48,32 @@

[GitHub] szha commented on a change in pull request #11636: [WIP] set MXNET_DATA_DIR as base for downloaded models through base.data_dir()

2018-07-10 Thread GitBox
szha commented on a change in pull request #11636: [WIP] set MXNET_DATA_DIR as base for downloaded models through base.data_dir() URL: https://github.com/apache/incubator-mxnet/pull/11636#discussion_r201515121 ## File path: python/mxnet/base.py ## @@ -47,6 +48,32 @@

[GitHub] szha commented on a change in pull request #11636: [WIP] set MXNET_DATA_DIR as base for downloaded models through base.data_dir()

2018-07-10 Thread GitBox
szha commented on a change in pull request #11636: [WIP] set MXNET_DATA_DIR as base for downloaded models through base.data_dir() URL: https://github.com/apache/incubator-mxnet/pull/11636#discussion_r201514882 ## File path: docs/faq/env_var.md ## @@ -126,6 +126,11 @@ When

[GitHub] ifeherva edited a comment on issue #9253: Numpy Diag in MXNet

2018-07-10 Thread GitBox
ifeherva edited a comment on issue #9253: Numpy Diag in MXNet URL: https://github.com/apache/incubator-mxnet/issues/9253#issuecomment-403290348 I am working on replicating np.diag(). Once done will do the full diagonal operator. This is my first operator so I am learning a lot at the

[GitHub] mkolod commented on issue #11380: Add ability to query cuDNN BatchNorm min. epsilon. Allow ONNX importer to use cuDNN BN if chosen eps >= cuDNN min. eps.

2018-07-10 Thread GitBox
mkolod commented on issue #11380: Add ability to query cuDNN BatchNorm min. epsilon. Allow ONNX importer to use cuDNN BN if chosen eps >= cuDNN min. eps. URL: https://github.com/apache/incubator-mxnet/pull/11380#issuecomment-403980212 @larroy It looks like the CI is happy now.

[GitHub] larroy opened a new pull request #11636: [WIP] set MXNET_DATA_DIR as base for downloaded models through base.data_dir()

2018-07-10 Thread GitBox
larroy opened a new pull request #11636: [WIP] set MXNET_DATA_DIR as base for downloaded models through base.data_dir() URL: https://github.com/apache/incubator-mxnet/pull/11636 ## Description ## (Brief description on what this PR is about) ## Checklist ## ### Essentials ###

[GitHub] slitsey commented on issue #11466: [MXNET-560] Add temperature parameter in Softmax operator

2018-07-10 Thread GitBox
slitsey commented on issue #11466: [MXNET-560] Add temperature parameter in Softmax operator URL: https://github.com/apache/incubator-mxnet/pull/11466#issuecomment-403976807 That sounds like a reasonable approach. How would that affect performance?

[GitHub] larroy commented on issue #11616: Flaky test test_gluon.test_export

2018-07-10 Thread GitBox
larroy commented on issue #11616: Flaky test test_gluon.test_export URL: https://github.com/apache/incubator-mxnet/issues/11616#issuecomment-403971858 The import export tests are failing on my machine with latest master: ``` [INFO] Setting test np/mx/python random seeds, use

[GitHub] zhanghang1989 commented on issue #11502: [MXNET-614] Adding Synchronized Batch Normalization

2018-07-10 Thread GitBox
zhanghang1989 commented on issue #11502: [MXNET-614] Adding Synchronized Batch Normalization URL: https://github.com/apache/incubator-mxnet/pull/11502#issuecomment-403967766 Thanks @RogerChern ! The comments in deconstruction function is really helpful.

[GitHub] ctcyang edited a comment on issue #11633: Fix dist kvstore for trainer

2018-07-10 Thread GitBox
ctcyang edited a comment on issue #11633: Fix dist kvstore for trainer URL: https://github.com/apache/incubator-mxnet/pull/11633#issuecomment-403966139 I see an error for `gluon_step`, but the other two nightly tests pass. I ran `../../tools/launch.py -n 7 --launcher local python

[GitHub] ctcyang commented on issue #11633: Fix dist kvstore for trainer

2018-07-10 Thread GitBox
ctcyang commented on issue #11633: Fix dist kvstore for trainer URL: https://github.com/apache/incubator-mxnet/pull/11633#issuecomment-403966139 I see an error for `gluon_step`, but the other two pass. I ran `../../tools/launch.py -n 7 --launcher local python dist_sync_kvstore.py

[GitHub] aaronmarkham opened a new issue #11634: website install page query string needed for devices

2018-07-10 Thread GitBox
aaronmarkham opened a new issue #11634: website install page query string needed for devices URL: https://github.com/apache/incubator-mxnet/issues/11634 Feature request: With the other install options you get all of the buttons as options for a deep link. Devices doesn't have this.

[GitHub] aaronmarkham commented on issue #11562: [MXNET-244] Update RaspberryPI instructions

2018-07-10 Thread GitBox
aaronmarkham commented on issue #11562: [MXNET-244] Update RaspberryPI instructions URL: https://github.com/apache/incubator-mxnet/pull/11562#issuecomment-403961277 If you check Jetson, those instructions are gone.

[GitHub] nswamy closed pull request #11574: [MXNET-624] Clojure Package Api Docs for the Website

2018-07-10 Thread GitBox
nswamy closed pull request #11574: [MXNET-624] Clojure Package Api Docs for the Website URL: https://github.com/apache/incubator-mxnet/pull/11574 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[incubator-mxnet] branch master updated: [MXNET-624] Clojure Package Api Docs for the Website (#11574)

2018-07-10 Thread nswamy
This is an automated email from the ASF dual-hosted git repository. nswamy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 7a6e8de [MXNET-624] Clojure Package

[GitHub] aaronmarkham commented on issue #11632: Adding models to example list and ONNX API page

2018-07-10 Thread GitBox
aaronmarkham commented on issue #11632: Adding models to example list and ONNX API page URL: https://github.com/apache/incubator-mxnet/pull/11632#issuecomment-403958985 LGTM! This is an automated message from the Apache

[GitHub] larroy commented on issue #11616: Flaky test test_gluon.test_export

2018-07-10 Thread GitBox
larroy commented on issue #11616: Flaky test test_gluon.test_export URL: https://github.com/apache/incubator-mxnet/issues/11616#issuecomment-403958824 @marcoabreu clear, I'm working on a fix. This is an automated message

[GitHub] aaronmarkham commented on issue #11528: New ecosystem website page

2018-07-10 Thread GitBox
aaronmarkham commented on issue #11528: New ecosystem website page URL: https://github.com/apache/incubator-mxnet/pull/11528#issuecomment-403958098 @szha or @thomelane - any more comments? Can we get this merged? This is an

[GitHub] rahul003 commented on a change in pull request #11533: Fix image classification scripts and Improve Fp16 tutorial

2018-07-10 Thread GitBox
rahul003 commented on a change in pull request #11533: Fix image classification scripts and Improve Fp16 tutorial URL: https://github.com/apache/incubator-mxnet/pull/11533#discussion_r201483749 ## File path: docs/faq/float16.md ## @@ -102,9 +102,17 @@ python fine-tune.py

  1   2   >