[GitHub] eric-haibin-lin commented on a change in pull request #11229: [MXNET-379] L1 Normalization

2018-06-29 Thread GitBox
eric-haibin-lin commented on a change in pull request #11229: [MXNET-379] L1 Normalization URL: https://github.com/apache/incubator-mxnet/pull/11229#discussion_r199217354 ## File path: tests/python/unittest/test_operator.py ## @@ -3009,6 +3009,50 @@ def

[GitHub] eric-haibin-lin commented on a change in pull request #11229: [MXNET-379] L1 Normalization

2018-06-28 Thread GitBox
eric-haibin-lin commented on a change in pull request #11229: [MXNET-379] L1 Normalization URL: https://github.com/apache/incubator-mxnet/pull/11229#discussion_r199026685 ## File path: src/operator/tensor/broadcast_reduce_op.h ## @@ -880,27 +880,24 @@ inline bool

[GitHub] eric-haibin-lin commented on a change in pull request #11229: [MXNET-379] L1 Normalization

2018-06-13 Thread GitBox
eric-haibin-lin commented on a change in pull request #11229: [MXNET-379] L1 Normalization URL: https://github.com/apache/incubator-mxnet/pull/11229#discussion_r195276646 ## File path: tests/python/unittest/test_operator.py ## @@ -2879,6 +2879,32 @@ def

[GitHub] eric-haibin-lin commented on a change in pull request #11229: [MXNET-379] L1 Normalization

2018-06-13 Thread GitBox
eric-haibin-lin commented on a change in pull request #11229: [MXNET-379] L1 Normalization URL: https://github.com/apache/incubator-mxnet/pull/11229#discussion_r195276671 ## File path: tests/python/unittest/test_operator.py ## @@ -2879,6 +2879,32 @@ def