[GitHub] [incubator-mxnet] zhanghang1989 commented on a change in pull request #16053: Fixes #15543

2019-09-05 Thread GitBox
zhanghang1989 commented on a change in pull request #16053: Fixes #15543 URL: https://github.com/apache/incubator-mxnet/pull/16053#discussion_r320903141 ## File path: tests/python/unittest/test_optimizer.py ## @@ -399,11 +395,7 @@ def update(self, index, weight, grad,

[GitHub] [incubator-mxnet] zhanghang1989 commented on a change in pull request #16053: Fixes #15543

2019-09-05 Thread GitBox
zhanghang1989 commented on a change in pull request #16053: Fixes #15543 URL: https://github.com/apache/incubator-mxnet/pull/16053#discussion_r321386949 ## File path: tests/python/unittest/test_optimizer.py ## @@ -396,6 +397,7 @@ def update(self, index, weight, grad,

[GitHub] [incubator-mxnet] zhanghang1989 commented on a change in pull request #16053: Fixes #15543

2019-09-04 Thread GitBox
zhanghang1989 commented on a change in pull request #16053: Fixes #15543 URL: https://github.com/apache/incubator-mxnet/pull/16053#discussion_r320996900 ## File path: tests/python/unittest/test_optimizer.py ## @@ -396,6 +397,7 @@ def update(self, index, weight, grad,

[GitHub] [incubator-mxnet] zhanghang1989 commented on a change in pull request #16053: Fixes #15543

2019-09-04 Thread GitBox
zhanghang1989 commented on a change in pull request #16053: Fixes #15543 URL: https://github.com/apache/incubator-mxnet/pull/16053#discussion_r320989758 ## File path: tests/python/unittest/test_optimizer.py ## @@ -396,6 +397,7 @@ def update(self, index, weight, grad,

[GitHub] [incubator-mxnet] zhanghang1989 commented on a change in pull request #16053: Fixes #15543

2019-09-04 Thread GitBox
zhanghang1989 commented on a change in pull request #16053: Fixes #15543 URL: https://github.com/apache/incubator-mxnet/pull/16053#discussion_r320903141 ## File path: tests/python/unittest/test_optimizer.py ## @@ -399,11 +395,7 @@ def update(self, index, weight, grad,

[GitHub] [incubator-mxnet] zhanghang1989 commented on a change in pull request #16053: Fixes #15543

2019-09-04 Thread GitBox
zhanghang1989 commented on a change in pull request #16053: Fixes #15543 URL: https://github.com/apache/incubator-mxnet/pull/16053#discussion_r320900451 ## File path: src/operator/optimizer_op-inl.h ## @@ -1119,22 +1112,16 @@ struct MP_NAGMomKernel { const OpReqType

[GitHub] [incubator-mxnet] zhanghang1989 commented on a change in pull request #16053: Fixes #15543

2019-09-04 Thread GitBox
zhanghang1989 commented on a change in pull request #16053: Fixes #15543 URL: https://github.com/apache/incubator-mxnet/pull/16053#discussion_r320900353 ## File path: src/operator/optimizer_op-inl.h ## @@ -1119,22 +1112,16 @@ struct MP_NAGMomKernel { const OpReqType

[GitHub] [incubator-mxnet] zhanghang1989 commented on a change in pull request #16053: Fixes #15543

2019-09-04 Thread GitBox
zhanghang1989 commented on a change in pull request #16053: Fixes #15543 URL: https://github.com/apache/incubator-mxnet/pull/16053#discussion_r320899830 ## File path: tests/python/unittest/test_optimizer.py ## @@ -385,10 +385,10 @@ def update(self, index, weight, grad,

[GitHub] [incubator-mxnet] zhanghang1989 commented on a change in pull request #16053: Fixes #15543

2019-09-04 Thread GitBox
zhanghang1989 commented on a change in pull request #16053: Fixes #15543 URL: https://github.com/apache/incubator-mxnet/pull/16053#discussion_r320899764 ## File path: tests/python/unittest/test_optimizer.py ## @@ -400,10 +400,10 @@ def update(self, index, weight, grad,