[GitHub] eric-haibin-lin commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training

2018-04-09 Thread GitBox
eric-haibin-lin commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training URL: https://github.com/apache/incubator-mxnet/pull/10183#discussion_r180296527 ## File path: amalgamation/Makefile ## @@ -23,6 +23,11 @@ ifndef

[GitHub] eric-haibin-lin commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training

2018-04-02 Thread GitBox
eric-haibin-lin commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training URL: https://github.com/apache/incubator-mxnet/pull/10183#discussion_r178665723 ## File path: src/kvstore/kvstore_dist_server.h ## @@ -170,43 +216,90 @@

[GitHub] eric-haibin-lin commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training

2018-04-02 Thread GitBox
eric-haibin-lin commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training URL: https://github.com/apache/incubator-mxnet/pull/10183#discussion_r178665130 ## File path: src/kvstore/kvstore_dist_server.h ## @@ -170,43 +216,90 @@

[GitHub] eric-haibin-lin commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training

2018-04-02 Thread GitBox
eric-haibin-lin commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training URL: https://github.com/apache/incubator-mxnet/pull/10183#discussion_r178665347 ## File path: src/kvstore/kvstore_dist_server.h ## @@ -170,43 +216,90 @@

[GitHub] eric-haibin-lin commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training

2018-04-02 Thread GitBox
eric-haibin-lin commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training URL: https://github.com/apache/incubator-mxnet/pull/10183#discussion_r178666240 ## File path: src/kvstore/kvstore_dist_server.h ## @@ -220,175 +313,229 @@

[GitHub] eric-haibin-lin commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training

2018-04-02 Thread GitBox
eric-haibin-lin commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training URL: https://github.com/apache/incubator-mxnet/pull/10183#discussion_r178646489 ## File path: python/mxnet/kvstore.py ## @@ -474,6 +474,8 @@ def

[GitHub] eric-haibin-lin commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training

2018-03-23 Thread GitBox
eric-haibin-lin commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training URL: https://github.com/apache/incubator-mxnet/pull/10183#discussion_r176900420 ## File path: src/kvstore/kvstore_dist.h ## @@ -506,41 +514,46 @@ class

[GitHub] eric-haibin-lin commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training

2018-03-23 Thread GitBox
eric-haibin-lin commented on a change in pull request #10183: [MXNET-120] Float16 support for distributed training URL: https://github.com/apache/incubator-mxnet/pull/10183#discussion_r176900404 ## File path: src/kvstore/kvstore_dist.h ## @@ -228,17 +228,18 @@ class