[GitHub] jeremiedb commented on issue #7476: R-package RNN refactor

2017-09-20 Thread git
jeremiedb commented on issue #7476: R-package RNN refactor URL: https://github.com/apache/incubator-mxnet/pull/7476#issuecomment-330895488 @thirdwing CI has issue with some Python test, not related to this pull. This is an

[GitHub] jeremiedb commented on issue #7476: R-package RNN refactor

2017-08-31 Thread git
jeremiedb commented on issue #7476: R-package RNN refactor URL: https://github.com/apache/incubator-mxnet/pull/7476#issuecomment-326354740 @thirdwing I'm out for 10 days, I'll try to put my hands a computer by then but it may take a few days.

[GitHub] jeremiedb commented on issue #7476: R-package RNN refactor

2017-08-27 Thread git
jeremiedb commented on issue #7476: R-package RNN refactor URL: https://github.com/apache/incubator-mxnet/pull/7476#issuecomment-325228128 Improve the harmonization with model.FeedForward: same fixed.params, arg.params and aux.params input arguments. Remove redundancies between

[GitHub] jeremiedb commented on issue #7476: R-package RNN refactor

2017-08-22 Thread git
jeremiedb commented on issue #7476: R-package RNN refactor URL: https://github.com/apache/incubator-mxnet/pull/7476#issuecomment-323931760 rnn.model.R is compatible with regular iterator and non RNN models. However, the need to bind at each batch results in a slower training time of

[GitHub] jeremiedb commented on issue #7476: R-package RNN refactor

2017-08-15 Thread git
jeremiedb commented on issue #7476: R-package RNN refactor URL: https://github.com/apache/incubator-mxnet/pull/7476#issuecomment-322632234 @thirdwing `source()` and `library()` calls removed. Functions `mx.model.train.rnn.buckets` and `mx.rnn.buckets` merged into `model.rnn.R` in

[GitHub] jeremiedb commented on issue #7476: R-package RNN refactor

2017-08-15 Thread git
jeremiedb commented on issue #7476: R-package RNN refactor URL: https://github.com/apache/incubator-mxnet/pull/7476#issuecomment-322632234 @thirdwing `source()` and `library()` calls removed. Functions `mx.model.train.rnn.buckets` and `mx.rnn.buckets` merged into `model.rnn.R` in