[GitHub] piiswrong commented on a change in pull request #7082: Sparse Tensor: request for reviews

2017-08-13 Thread git
piiswrong commented on a change in pull request #7082: Sparse Tensor: request for reviews URL: https://github.com/apache/incubator-mxnet/pull/7082#discussion_r132833058 ## File path: python/mxnet/ndarray/sparse_ndarray.py ## @@ -0,0 +1,906 @@ +# Licensed to the Apache

[GitHub] piiswrong commented on a change in pull request #7082: Sparse Tensor: request for reviews

2017-08-13 Thread git
piiswrong commented on a change in pull request #7082: Sparse Tensor: request for reviews URL: https://github.com/apache/incubator-mxnet/pull/7082#discussion_r132833058 ## File path: python/mxnet/ndarray/sparse_ndarray.py ## @@ -0,0 +1,906 @@ +# Licensed to the Apache

[GitHub] piiswrong commented on a change in pull request #7082: Sparse Tensor: request for reviews

2017-07-31 Thread git
piiswrong commented on a change in pull request #7082: Sparse Tensor: request for reviews URL: https://github.com/apache/incubator-mxnet/pull/7082#discussion_r130404224 ## File path: src/executor/attach_op_execs_pass.cc ## @@ -22,28 +23,39 @@ const OperatorProperty*

[GitHub] piiswrong commented on a change in pull request #7082: Sparse Tensor: request for reviews

2017-07-31 Thread git
piiswrong commented on a change in pull request #7082: Sparse Tensor: request for reviews URL: https://github.com/apache/incubator-mxnet/pull/7082#discussion_r130258387 ## File path: python/mxnet/kvstore.py ## @@ -214,11 +217,88 @@ def pull(self, key, out=None,

[GitHub] piiswrong commented on a change in pull request #7082: Sparse Tensor: request for reviews

2017-07-31 Thread git
piiswrong commented on a change in pull request #7082: Sparse Tensor: request for reviews URL: https://github.com/apache/incubator-mxnet/pull/7082#discussion_r130258392 ## File path: python/mxnet/kvstore.py ## @@ -214,11 +217,88 @@ def pull(self, key, out=None,

[GitHub] piiswrong commented on a change in pull request #7082: Sparse Tensor: request for reviews

2017-07-31 Thread git
piiswrong commented on a change in pull request #7082: Sparse Tensor: request for reviews URL: https://github.com/apache/incubator-mxnet/pull/7082#discussion_r130406399 ## File path: src/operator/elemwise_op_common.h ## @@ -90,6 +126,33 @@ inline bool ElemwiseType(const

[GitHub] piiswrong commented on a change in pull request #7082: Sparse Tensor: request for reviews

2017-07-31 Thread git
piiswrong commented on a change in pull request #7082: Sparse Tensor: request for reviews URL: https://github.com/apache/incubator-mxnet/pull/7082#discussion_r130272497 ## File path: python/mxnet/symbol.py ## @@ -17,8 +17,10 @@ from .base import NDArrayHandle,

[GitHub] piiswrong commented on a change in pull request #7082: Sparse Tensor: request for reviews

2017-07-31 Thread git
piiswrong commented on a change in pull request #7082: Sparse Tensor: request for reviews URL: https://github.com/apache/incubator-mxnet/pull/7082#discussion_r130403724 ## File path: src/c_api/c_api_ndarray.cc ## @@ -301,10 +384,25 @@ void PushOperator(const OpStatePtr&

[GitHub] piiswrong commented on a change in pull request #7082: Sparse Tensor: request for reviews

2017-07-31 Thread git
piiswrong commented on a change in pull request #7082: Sparse Tensor: request for reviews URL: https://github.com/apache/incubator-mxnet/pull/7082#discussion_r130258581 ## File path: python/mxnet/ndarray/ndarray_utils.py ## @@ -0,0 +1,127 @@ +# coding: utf-8 Review

[GitHub] piiswrong commented on a change in pull request #7082: Sparse Tensor: request for reviews

2017-07-31 Thread git
piiswrong commented on a change in pull request #7082: Sparse Tensor: request for reviews URL: https://github.com/apache/incubator-mxnet/pull/7082#discussion_r130272244 ## File path: python/mxnet/ndarray/sparse_ndarray.py ## @@ -0,0 +1,637 @@ +# coding: utf-8

[GitHub] piiswrong commented on a change in pull request #7082: Sparse Tensor: request for reviews

2017-07-31 Thread git
piiswrong commented on a change in pull request #7082: Sparse Tensor: request for reviews URL: https://github.com/apache/incubator-mxnet/pull/7082#discussion_r130403722 ## File path: src/c_api/c_api_ndarray.cc ## @@ -301,10 +384,25 @@ void PushOperator(const OpStatePtr&

[GitHub] piiswrong commented on a change in pull request #7082: Sparse Tensor: request for reviews

2017-07-31 Thread git
piiswrong commented on a change in pull request #7082: Sparse Tensor: request for reviews URL: https://github.com/apache/incubator-mxnet/pull/7082#discussion_r130257348 ## File path: include/mxnet/kvstore.h ## @@ -155,6 +156,29 @@ class KVStore {

[GitHub] piiswrong commented on a change in pull request #7082: Sparse Tensor: request for reviews

2017-07-31 Thread git
piiswrong commented on a change in pull request #7082: Sparse Tensor: request for reviews URL: https://github.com/apache/incubator-mxnet/pull/7082#discussion_r130272291 ## File path: python/mxnet/ndarray/sparse_ndarray.py ## @@ -0,0 +1,637 @@ +# coding: utf-8

[GitHub] piiswrong commented on a change in pull request #7082: Sparse Tensor: request for reviews

2017-07-31 Thread git
piiswrong commented on a change in pull request #7082: Sparse Tensor: request for reviews URL: https://github.com/apache/incubator-mxnet/pull/7082#discussion_r130272349 ## File path: python/mxnet/ndarray/sparse_ndarray.py ## @@ -0,0 +1,637 @@ +# coding: utf-8