[GitHub] tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM

tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#issuecomment-372068312 @jwfromm We do need to build MXNet from source for now before next release. This should work out of box if you build

[GitHub] tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM

tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#issuecomment-372068312 @jwfromm We do need to build MXNet from source for now before next release. This should work out of the box if you build

[GitHub] tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM

tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#issuecomment-369307004 for the first time, do ```git submodule update --recursive --init```

[GitHub] tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM

tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#issuecomment-369306281 @tornadomeet do ```git submodule update --recursive``` This

[GitHub] tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM

tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#issuecomment-369306281 do @tornadomeet ```git submodule update --recursive``` This

[GitHub] tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM

tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#issuecomment-368727403 This design is certainly unconventional and takes me a while to come up with it, in a sense that it tries to achieve something

[GitHub] tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM

tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#issuecomment-368694729 Thanks for the reviews! If there is no requests to change things today. I am going to merge this in tomorrow

[GitHub] tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM

tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#issuecomment-368693448 OK, will do an update in the python part as well This is an

[GitHub] tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM

tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#issuecomment-368686482 I added comment in the declaration point This is an automated

[GitHub] tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM

tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#issuecomment-368636020 @piiswrong Can you check and merge, or provide a list of action items that you think should change?

[GitHub] tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM

tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#issuecomment-368382610 @marcoabreu addressed the comments. The current test case already covers the API use-case of CPU and GPU of the async engine

[GitHub] tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM

tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#issuecomment-368382610 addressed the comments. The current test case already covers the API use-case of CPU and GPU of the async engine wrapping.

[GitHub] tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM

tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#issuecomment-368355290 Testcase and ci added This is an automated message from the

[GitHub] tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM

tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#issuecomment-368342384 I just mean the cost of building TVM's LLVM dependency. I don't want to directly introduce additional burden to the CI while

[GitHub] tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM

tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#issuecomment-368341749 This being said, I totally agree that having proper testing is important. That is why there is already test-cases that get

[GitHub] tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM

tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#issuecomment-368341278 Just to be clear, it is the way TVM bridge works that starts this special situation. This PR requires joint changes in both

[GitHub] tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM

tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#issuecomment-368338632 I have detailed my reasoning of but yet adding test-case to this PR. The TVM bridge depends on a header only component of TVM

[GitHub] tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM

tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#issuecomment-368327775 The test now pass, @piiswrong @szha can you review? This is

[GitHub] tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM

tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#issuecomment-368327775 The r test factor appears to be not related to this commit.

[GitHub] tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM

tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#issuecomment-368284709 TVM's side of PR https://github.com/dmlc/tvm/pull/930 This is