[GitHub] [mynewt-nimble] PROFESSOR-J-K commented on a diff in pull request #1492: Add the min. changes required to support the GF variant.

2023-05-08 Thread via GitHub
PROFESSOR-J-K commented on code in PR #1492: URL: https://github.com/apache/mynewt-nimble/pull/1492#discussion_r1187389930 ## nimble/drivers/dialog_cmac/src/ble_rf.c: ## @@ -114,6 +122,20 @@ set_reg16_mask(uint32_t addr, uint16_t mask, uint16_t val) *reg = (*reg & (~mask))

[GitHub] [mynewt-nimble] PROFESSOR-J-K commented on a diff in pull request #1492: Add the min. changes required to support the GF variant.

2023-05-08 Thread via GitHub
PROFESSOR-J-K commented on code in PR #1492: URL: https://github.com/apache/mynewt-nimble/pull/1492#discussion_r1187380816 ## nimble/drivers/dialog_cmac/src/ble_phy.c: ## @@ -1178,6 +1186,8 @@ ble_phy_init(void) g_ble_phy_data.phy_whitening = 1; #endif +

[GitHub] [mynewt-nimble] PROFESSOR-J-K commented on a diff in pull request #1492: Add the min. changes required to support the GF variant.

2023-05-05 Thread via GitHub
PROFESSOR-J-K commented on code in PR #1492: URL: https://github.com/apache/mynewt-nimble/pull/1492#discussion_r1185920447 ## nimble/drivers/dialog_cmac/src/ble_phy.c: ## @@ -1178,6 +1186,8 @@ ble_phy_init(void) g_ble_phy_data.phy_whitening = 1; #endif +

[GitHub] [mynewt-nimble] PROFESSOR-J-K commented on a diff in pull request #1492: Add the min. changes required to support the GF variant.

2023-05-05 Thread via GitHub
PROFESSOR-J-K commented on code in PR #1492: URL: https://github.com/apache/mynewt-nimble/pull/1492#discussion_r1185888556 ## nimble/drivers/dialog_cmac/src/ble_phy.c: ## @@ -1178,6 +1186,8 @@ ble_phy_init(void) g_ble_phy_data.phy_whitening = 1; #endif +