[GitHub] mwilliford commented on issue #47: Fixes issue with mpool in ble_ll_init, corrupted mpool linked list.

2018-04-16 Thread GitBox
mwilliford commented on issue #47: Fixes issue with mpool in ble_ll_init, corrupted mpool linked list. URL: https://github.com/apache/mynewt-nimble/pull/47#issuecomment-381672214 closing this PR, as the above solutions are more elegant.

[GitHub] mwilliford closed pull request #47: Fixes issue with mpool in ble_ll_init, corrupted mpool linked list.

2018-04-16 Thread GitBox
mwilliford closed pull request #47: Fixes issue with mpool in ble_ll_init, corrupted mpool linked list. URL: https://github.com/apache/mynewt-nimble/pull/47 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] mwilliford opened a new issue #160: Relative path for cmake src and headers

2018-04-16 Thread GitBox
mwilliford opened a new issue #160: Relative path for cmake src and headers URL: https://github.com/apache/mynewt-newt/issues/160 First, I love the target cmake ability, works with Clion, and changing targets is fast and easy now. However There is one small improvement which

[GitHub] mwilliford commented on issue #44: Extended Advertisement Issues

2018-04-16 Thread GitBox
mwilliford commented on issue #44: Extended Advertisement Issues URL: https://github.com/apache/mynewt-nimble/issues/44#issuecomment-381667220 @andrzej-kaczmarek Were you able to repro it no longer receiving ext_adv messages after 5min or so?

[GitHub] andrzej-kaczmarek commented on issue #44: Extended Advertisement Issues

2018-04-16 Thread GitBox
andrzej-kaczmarek commented on issue #44: Extended Advertisement Issues URL: https://github.com/apache/mynewt-nimble/issues/44#issuecomment-381681021 I did not try to check scanner yet, only the advertiser part which needs some fixing.

[mynewt-core] 01/01: Merge pull request #1014 from michal-narajowski/shell-cmd-help-fix

2018-04-16 Thread naraj
This is an automated email from the ASF dual-hosted git repository. naraj pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git commit 7c2da7b7857c28e60144e43dec11506683d695c0 Merge: e0d46d6 333cdf6 Author: Michał Narajowski

[GitHub] utzig commented on issue #1015: nrf52840 support for qspi flash

2018-04-16 Thread GitBox
utzig commented on issue #1015: nrf52840 support for qspi flash URL: https://github.com/apache/mynewt-core/pull/1015#issuecomment-381598907 LGTM This is an automated message from the Apache Git Service. To respond to the

[GitHub] sjanc commented on issue #47: Fixes issue with mpool in ble_ll_init, corrupted mpool linked list.

2018-04-16 Thread GitBox
sjanc commented on issue #47: Fixes issue with mpool in ble_ll_init, corrupted mpool linked list. URL: https://github.com/apache/mynewt-nimble/pull/47#issuecomment-381565439 I'd add os_mempool_clear() or maybe os_mempool_reinit() that would do that (_clear is better name imo)

[GitHub] michal-narajowski closed pull request #1014: sys/shell: Improve command help information

2018-04-16 Thread GitBox
michal-narajowski closed pull request #1014: sys/shell: Improve command help information URL: https://github.com/apache/mynewt-core/pull/1014 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[mynewt-core] branch master updated (e0d46d6 -> 7c2da7b)

2018-04-16 Thread naraj
This is an automated email from the ASF dual-hosted git repository. naraj pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git. from e0d46d6 lis2dw12: Support sleep change event for notifications (#1024) add 333cdf6 sys/shell: Improve

[GitHub] sjanc opened a new pull request #1030: mempool: Add os_mempool_clear function

2018-04-16 Thread GitBox
sjanc opened a new pull request #1030: mempool: Add os_mempool_clear function URL: https://github.com/apache/mynewt-core/pull/1030 This is used to clear mempool (ie all block taken are invalidated) without doing full initialisation of it. Unlike init this function can be called

[GitHub] vrahane commented on a change in pull request #1024: lis2dw12: Support sleep change event for notifications

2018-04-16 Thread GitBox
vrahane commented on a change in pull request #1024: lis2dw12: Support sleep change event for notifications URL: https://github.com/apache/mynewt-core/pull/1024#discussion_r181849825 ## File path: hw/drivers/sensors/lis2dw12/include/lis2dw12/lis2dw12.h ## @@ -131,85

[GitHub] davidzuhn opened a new pull request #1031: fix/typo

2018-04-16 Thread GitBox
davidzuhn opened a new pull request #1031: fix/typo URL: https://github.com/apache/mynewt-core/pull/1031 correct the sentence structure This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] matthewwarnes commented on a change in pull request #1024: lis2dw12: Support sleep change event for notifications

2018-04-16 Thread GitBox
matthewwarnes commented on a change in pull request #1024: lis2dw12: Support sleep change event for notifications URL: https://github.com/apache/mynewt-core/pull/1024#discussion_r181870451 ## File path: hw/drivers/sensors/lis2dw12/src/lis2dw12.c ## @@ -1946,89 +1943,106

[GitHub] rymanluk closed pull request #45: nimble/ll: Fix for setting address type for directed advertising

2018-04-16 Thread GitBox
rymanluk closed pull request #45: nimble/ll: Fix for setting address type for directed advertising URL: https://github.com/apache/mynewt-nimble/pull/45 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[mynewt-nimble] 01/01: Merge pull request #45 from rymanluk/fix_dir_addr_type

2018-04-16 Thread rymek
This is an automated email from the ASF dual-hosted git repository. rymek pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git commit 021773f070c74bbb152e2fdfc329b96bcbda8b69 Merge: 35bd3de 0967e8a Author: Łukasz Rymanowski

[mynewt-nimble] branch master updated (35bd3de -> 021773f)

2018-04-16 Thread rymek
This is an automated email from the ASF dual-hosted git repository. rymek pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git. from 35bd3de Merge pull request #43 from andrzej-kaczmarek/aux-assert-fix add 0967e8a nimble/ll: Fix for

[GitHub] vrahane commented on a change in pull request #1024: lis2dw12: Support sleep change event for notifications

2018-04-16 Thread GitBox
vrahane commented on a change in pull request #1024: lis2dw12: Support sleep change event for notifications URL: https://github.com/apache/mynewt-core/pull/1024#discussion_r181849591 ## File path: hw/drivers/sensors/lis2dw12/src/lis2dw12.c ## @@ -1946,89 +1943,106 @@

[GitHub] vrahane commented on a change in pull request #1024: lis2dw12: Support sleep change event for notifications

2018-04-16 Thread GitBox
vrahane commented on a change in pull request #1024: lis2dw12: Support sleep change event for notifications URL: https://github.com/apache/mynewt-core/pull/1024#discussion_r181854655 ## File path: hw/drivers/sensors/lis2dw12/src/lis2dw12.c ## @@ -2790,8 +2836,9 @@

[GitHub] rymanluk commented on a change in pull request #1030: mempool: Add os_mempool_clear function

2018-04-16 Thread GitBox
rymanluk commented on a change in pull request #1030: mempool: Add os_mempool_clear function URL: https://github.com/apache/mynewt-core/pull/1030#discussion_r181880468 ## File path: kernel/os/src/os_mempool.c ## @@ -135,6 +135,45 @@ os_mempool_ext_init(struct

[GitHub] ccollins476ad commented on issue #157: Make it easier to pin a version to a specific tag

2018-04-16 Thread GitBox
ccollins476ad commented on issue #157: Make it easier to pin a version to a specific tag URL: https://github.com/apache/mynewt-newt/issues/157#issuecomment-381838866 @davidzuhn - OK, I think I finally see what you mean. That does seem like an important use case, and one I hadn't

[GitHub] ccollins476ad commented on issue #157: Make it easier to pin a version to a specific tag

2018-04-16 Thread GitBox
ccollins476ad commented on issue #157: Make it easier to pin a version to a specific tag URL: https://github.com/apache/mynewt-newt/issues/157#issuecomment-381838866 @davidzuhn - OK, I think I finally see what you mean. That does seem like an important use case, and one I hadn't

[GitHub] ccollins476ad commented on issue #157: Make it easier to pin a version to a specific tag

2018-04-16 Thread GitBox
ccollins476ad commented on issue #157: Make it easier to pin a version to a specific tag URL: https://github.com/apache/mynewt-newt/issues/157#issuecomment-381838866 @davidzuhn - OK, I think I finally see what you mean. That does seem like an important use case, and one I hadn't

[GitHub] utzig opened a new pull request #1032: Stm32 common UART driver

2018-04-16 Thread GitBox
utzig opened a new pull request #1032: Stm32 common UART driver URL: https://github.com/apache/mynewt-core/pull/1032 Tested and working in all supported MCUs. This is an automated message from the Apache Git Service. To

[GitHub] vrahane opened a new pull request #1033: lis2dw12: Add support for set/clear int cfg bits

2018-04-16 Thread GitBox
vrahane opened a new pull request #1033: lis2dw12: Add support for set/clear int cfg bits URL: https://github.com/apache/mynewt-core/pull/1033 - Set/Clear individual interrupt cfg bits - Change config in sensor creator - Change int_active to int_active_low to be more explicit -

[GitHub] sjanc commented on issue #47: Fixes issue with mpool in ble_ll_init, corrupted mpool linked list.

2018-04-16 Thread GitBox
sjanc commented on issue #47: Fixes issue with mpool in ble_ll_init, corrupted mpool linked list. URL: https://github.com/apache/mynewt-nimble/pull/47#issuecomment-381565439 I'd add os_mempool_clear() or maybe os_mempool_reinit() that would do that

[GitHub] sjanc opened a new pull request #48: Support for duration and period in extended scan

2018-04-16 Thread GitBox
sjanc opened a new pull request #48: Support for duration and period in extended scan URL: https://github.com/apache/mynewt-nimble/pull/48 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] sjanc commented on issue #1030: mempool: Add os_mempool_clear function

2018-04-16 Thread GitBox
sjanc commented on issue #1030: mempool: Add os_mempool_clear function URL: https://github.com/apache/mynewt-core/pull/1030#issuecomment-381600645 Main motivation for this is https://github.com/apache/mynewt-nimble/issues/46 where we need to clear mempool on HCI reset.

[GitHub] sjanc opened a new pull request #49: nimble/ll: Fix scanner init on HCI Reset

2018-04-16 Thread GitBox
sjanc opened a new pull request #49: nimble/ll: Fix scanner init on HCI Reset URL: https://github.com/apache/mynewt-nimble/pull/49 mempool shouldn't be initialized on HCI Reset as it may affect other pools. Instead initialize it only on init and cleanup on HCI Reset.

[GitHub] andrzej-kaczmarek commented on issue #44: Extended Advertisement Issues

2018-04-16 Thread GitBox
andrzej-kaczmarek commented on issue #44: Extended Advertisement Issues URL: https://github.com/apache/mynewt-nimble/issues/44#issuecomment-381524839 The issue in controller triggered by this app is due to broken handling of `Duration` parameter in `LE Set Extended Advertising Enable`.

[GitHub] mwilliford commented on issue #44: Extended Advertisement Issues

2018-04-16 Thread GitBox
mwilliford commented on issue #44: Extended Advertisement Issues URL: https://github.com/apache/mynewt-nimble/issues/44#issuecomment-381538269 Thanks, should I use max_events instead for now as a workaround, would that be a more stable way to define the end of the broadcast? I

[GitHub] andrzej-kaczmarek commented on issue #44: Extended Advertisement Issues

2018-04-16 Thread GitBox
andrzej-kaczmarek commented on issue #44: Extended Advertisement Issues URL: https://github.com/apache/mynewt-nimble/issues/44#issuecomment-381542635 Yes, `max_events` should work fine. This is an automated message from the

[GitHub] rymanluk opened a new pull request #45: nimble/ll: Fix for setting address type for directed advertising

2018-04-16 Thread GitBox
rymanluk opened a new pull request #45: nimble/ll: Fix for setting address type for directed advertising URL: https://github.com/apache/mynewt-nimble/pull/45 This fix applies only to advertising extensions. This is an

[GitHub] ccollins476ad commented on a change in pull request #1030: mempool: Add os_mempool_clear function

2018-04-16 Thread GitBox
ccollins476ad commented on a change in pull request #1030: mempool: Add os_mempool_clear function URL: https://github.com/apache/mynewt-core/pull/1030#discussion_r181933594 ## File path: kernel/os/include/os/os_mempool.h ## @@ -188,6 +188,15 @@ os_error_t

[GitHub] ccollins476ad commented on a change in pull request #1033: lis2dw12: Add support for set/clear int cfg bits

2018-04-16 Thread GitBox
ccollins476ad commented on a change in pull request #1033: lis2dw12: Add support for set/clear int cfg bits URL: https://github.com/apache/mynewt-core/pull/1033#discussion_r181934958 ## File path: hw/drivers/sensors/lis2dw12/src/lis2dw12.c ## @@ -1949,92 +2034,93 @@

[GitHub] ccollins476ad commented on a change in pull request #1033: lis2dw12: Add support for set/clear int cfg bits

2018-04-16 Thread GitBox
ccollins476ad commented on a change in pull request #1033: lis2dw12: Add support for set/clear int cfg bits URL: https://github.com/apache/mynewt-core/pull/1033#discussion_r181935313 ## File path: hw/drivers/sensors/lis2dw12/include/lis2dw12/lis2dw12.h ## @@ -579,6

[GitHub] ccollins476ad commented on issue #1033: lis2dw12: Add support for set/clear int cfg bits

2018-04-16 Thread GitBox
ccollins476ad commented on issue #1033: lis2dw12: Add support for set/clear int cfg bits URL: https://github.com/apache/mynewt-core/pull/1033#issuecomment-381808098 I know I already mentioned this, but I get a little nervous about tracking the count of enabled interrupts without knowing

[GitHub] mwilliford opened a new issue #46: ble_ll_scan.c calls ble_ll_scan_init twice, which corrupts g_os_mempool_list

2018-04-16 Thread GitBox
mwilliford opened a new issue #46: ble_ll_scan.c calls ble_ll_scan_init twice, which corrupts g_os_mempool_list URL: https://github.com/apache/mynewt-nimble/issues/46 While troubleshooting why mpool cli command does not show anything beyond ble_ll_aux_scan_pool. repro: To

[GitHub] mwilliford opened a new pull request #47: Fixes issue with mpool in ble_ll_init, corrupted mpool linked list.

2018-04-16 Thread GitBox
mwilliford opened a new pull request #47: Fixes issue with mpool in ble_ll_init, corrupted mpool linked list. URL: https://github.com/apache/mynewt-nimble/pull/47 Fixes: https://github.com/apache/mynewt-nimble/issues/46 Solution: Skip creating mpool a second time through ble_ll_init

[GitHub] ncasaril commented on issue #1002: nffs: Assert at nffs_pkg_init with corrupt(?) flash

2018-04-16 Thread GitBox
ncasaril commented on issue #1002: nffs: Assert at nffs_pkg_init with corrupt(?) flash URL: https://github.com/apache/mynewt-core/issues/1002#issuecomment-381558628 Closing this issue as it was likely issues with the external flash causing them. /HOLD and /WP was left floating by mistake

[GitHub] ncasaril closed issue #1002: nffs: Assert at nffs_pkg_init with corrupt(?) flash

2018-04-16 Thread GitBox
ncasaril closed issue #1002: nffs: Assert at nffs_pkg_init with corrupt(?) flash URL: https://github.com/apache/mynewt-core/issues/1002 This is an automated message from the Apache Git Service. To respond to the message,