[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2258: Documentation SGM4056

2020-04-01 Thread GitBox
apache-mynewt-bot commented on issue #2258: Documentation SGM4056 URL: https://github.com/apache/mynewt-core/pull/2258#issuecomment-607345354 ## Style check summary No suggestions at this time!

[GitHub] [mynewt-newt] ccollins476ad commented on a change in pull request #392: Update documentation for mfg create

2020-04-01 Thread GitBox
ccollins476ad commented on a change in pull request #392: Update documentation for mfg create URL: https://github.com/apache/mynewt-newt/pull/392#discussion_r401717802 ## File path: docs/command_list/newt_mfg.rst ## @@ -87,16 +87,25 @@ The ``rb_blinky_rsa`` package needs

[mynewt-core] branch master updated: docs/os/bsp: Add board support section

2020-04-01 Thread mlaz
This is an automated email from the ASF dual-hosted git repository. mlaz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git The following commit(s) were added to refs/heads/master by this push: new 3c0dda3 docs/os/bsp: Add board support

[GitHub] [mynewt-core] mlaz merged pull request #2254: docs/os/bsp: Add board support section

2020-04-01 Thread GitBox
mlaz merged pull request #2254: docs/os/bsp: Add board support section URL: https://github.com/apache/mynewt-core/pull/2254 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [mynewt-core] caspermeijn opened a new pull request #2258: Documentation sgm4056

2020-04-01 Thread GitBox
caspermeijn opened a new pull request #2258: Documentation sgm4056 URL: https://github.com/apache/mynewt-core/pull/2258 This add documentation pages for charger-control and the SGM4056 driver. See also the tutorial in https://github.com/apache/mynewt-documentation/pull/94.

[mynewt-core] branch master updated (c418c0c -> 9dee495)

2020-04-01 Thread mlaz
This is an automated email from the ASF dual-hosted git repository. mlaz pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git. from c418c0c Merge pull request #2257 from JuulLabs/id-serial_mfg new 048fb40 hw/drivers/chg_ctrl/sgm4056: Add

[GitHub] [mynewt-core] mlaz merged pull request #2255: Add SGM4056 charger driver to pinetime BSP

2020-04-01 Thread GitBox
mlaz merged pull request #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [mynewt-core] mlaz commented on issue #2255: Add SGM4056 charger driver to pinetime BSP

2020-04-01 Thread GitBox
mlaz commented on issue #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255#issuecomment-607317147 Looks good, thanks for the changes, @caspermeijn This is an automated

[mynewt-core] branch master updated: sys/id: Add optional id/serial_mfg field for storing manufacturer serial numbers

2020-04-01 Thread benmccrea
This is an automated email from the ASF dual-hosted git repository. benmccrea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git The following commit(s) were added to refs/heads/master by this push: new 7e4c027 sys/id: Add optional

[GitHub] [mynewt-core] benmccrea merged pull request #2257: sys/id: Add optional id/serial_mfg field for storing manufacturer serial number

2020-04-01 Thread GitBox
benmccrea merged pull request #2257: sys/id: Add optional id/serial_mfg field for storing manufacturer serial number URL: https://github.com/apache/mynewt-core/pull/2257 This is an automated message from the Apache Git

[GitHub] [mynewt-newt] dwld edited a comment on issue #391: Fix for @repo targets in mfg create

2020-04-01 Thread GitBox
dwld edited a comment on issue #391: Fix for @repo targets in mfg create URL: https://github.com/apache/mynewt-newt/pull/391#issuecomment-607291079 @utzig, here is the output of the current master newt build as it is: ``` $ newt -ldebug mfg create p_nrf52_ble 0.0.0.5 ...

[GitHub] [mynewt-newt] dwld commented on issue #391: Fix for @repo targets in mfg create

2020-04-01 Thread GitBox
dwld commented on issue #391: Fix for @repo targets in mfg create URL: https://github.com/apache/mynewt-newt/pull/391#issuecomment-607291079 @utzig, here is the output of the current master newt build as it is: ``` 2020/04/01 16:30:41.371 [DEBUG] goroutine 1 [running]:

[GitHub] [mynewt-newt] dwld commented on issue #391: Fix for @repo targets

2020-04-01 Thread GitBox
dwld commented on issue #391: Fix for @repo targets URL: https://github.com/apache/mynewt-newt/pull/391#issuecomment-607261142 Hi @utzig, thanks for your feedback. I'll gather the debug output. Perhaps my .mfg file or my targets are not correct. I just published a documentation update

[GitHub] [mynewt-newt] dwld opened a new pull request #392: Update documentation for mfg create

2020-04-01 Thread GitBox
dwld opened a new pull request #392: Update documentation for mfg create URL: https://github.com/apache/mynewt-newt/pull/392 Documentation update for the mfg create command in order to match the current implementation. This

[GitHub] [mynewt-newt] utzig commented on issue #391: Fix for @repo targets

2020-04-01 Thread GitBox
utzig commented on issue #391: Fix for @repo targets URL: https://github.com/apache/mynewt-newt/pull/391#issuecomment-607243692 This use of `Name()` in those functions has been like this for basically ever. All my MCUBoot targets look something like the one you mentioned (`target.app:

[GitHub] [mynewt-newt] dwld opened a new pull request #391: Fix for @repo targets

2020-04-01 Thread GitBox
dwld opened a new pull request #391: Fix for @repo targets URL: https://github.com/apache/mynewt-newt/pull/391 Without the fix, building targets such as target.app: "@mcuboot/boot/mynewt" fails, since the path to the .manifest, .hex and .bin is wrong. This can be fixed by using

[GitHub] [mynewt-core] kasjer commented on issue #2255: Add SGM4056 charger driver to pinetime BSP

2020-04-01 Thread GitBox
kasjer commented on issue #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255#issuecomment-607136582 > I had some problems with the rebase and squash. But I fixed the history now ;-) Thanks, as soon as @mlaz is satisfied with his

[GitHub] [mynewt-core] caspermeijn commented on issue #2255: Add SGM4056 charger driver to pinetime BSP

2020-04-01 Thread GitBox
caspermeijn commented on issue #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255#issuecomment-607093858 I had some problems with the rebase and squash. But I fixed the history now ;-)

[GitHub] [mynewt-core] caspermeijn commented on a change in pull request #2255: Add SGM4056 charger driver to pinetime BSP

2020-04-01 Thread GitBox
caspermeijn commented on a change in pull request #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255#discussion_r401421249 ## File path: hw/drivers/chg_ctrl/sgm4056/src/sgm4056.c ## @@ -0,0 +1,192 @@ +/* + * Copyright

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2255: Add SGM4056 charger driver to pinetime BSP

2020-04-01 Thread GitBox
apache-mynewt-bot removed a comment on issue #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255#issuecomment-607083823 ## Style check summary No suggestions at this time!

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2255: Add SGM4056 charger driver to pinetime BSP

2020-04-01 Thread GitBox
apache-mynewt-bot commented on issue #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255#issuecomment-607092226 ## Style check summary No suggestions at this time!

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2255: Add SGM4056 charger driver to pinetime BSP

2020-04-01 Thread GitBox
apache-mynewt-bot commented on issue #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255#issuecomment-607083823 ## Style check summary No suggestions at this time!

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2255: Add SGM4056 charger driver to pinetime BSP

2020-04-01 Thread GitBox
apache-mynewt-bot removed a comment on issue #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255#issuecomment-606501796 ## Style check summary ### Our coding style is