[GitHub] [mynewt-nimble] PROFESSOR-J-K commented on a diff in pull request #1492: Add the min. changes required to support the GF variant.

2023-05-05 Thread via GitHub
PROFESSOR-J-K commented on code in PR #1492: URL: https://github.com/apache/mynewt-nimble/pull/1492#discussion_r1185888556 ## nimble/drivers/dialog_cmac/src/ble_phy.c: ## @@ -1178,6 +1186,8 @@ ble_phy_init(void) g_ble_phy_data.phy_whitening = 1; #endif +

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a diff in pull request #1492: Add the min. changes required to support the GF variant.

2023-05-05 Thread via GitHub
andrzej-kaczmarek commented on code in PR #1492: URL: https://github.com/apache/mynewt-nimble/pull/1492#discussion_r1185916273 ## nimble/drivers/dialog_cmac/src/ble_phy.c: ## @@ -1178,6 +1186,8 @@ ble_phy_init(void) g_ble_phy_data.phy_whitening = 1; #endif +

[GitHub] [mynewt-nimble] PROFESSOR-J-K commented on a diff in pull request #1492: Add the min. changes required to support the GF variant.

2023-05-05 Thread via GitHub
PROFESSOR-J-K commented on code in PR #1492: URL: https://github.com/apache/mynewt-nimble/pull/1492#discussion_r1185920447 ## nimble/drivers/dialog_cmac/src/ble_phy.c: ## @@ -1178,6 +1186,8 @@ ble_phy_init(void) g_ble_phy_data.phy_whitening = 1; #endif +

[GitHub] [mynewt-nimble] rahult-github opened a new pull request, #1493: nimble/host: Fix compilation issues observed by enabling -O2 optimization

2023-05-05 Thread via GitHub
rahult-github opened a new pull request, #1493: URL: https://github.com/apache/mynewt-nimble/pull/1493 When attempting to compile code with -O2 optimization enabled, observe compilation errors: In function 'ble_gattc_find_inc_svcs_cb', inlined from