[GitHub] [mynewt-mcumgr] de-nordic commented on issue #74: zephyr: TinyCBOR has been removed from interface libraries

[GitBox]

de-nordic commented on issue #74: zephyr: TinyCBOR has been removed from 
interface libraries
URL: https://github.com/apache/mynewt-mcumgr/pull/74#issuecomment-603649377
 
 
   Please merge.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-newtmgr] nixward opened a new issue #158: [macOS BLE] commands always failing

[GitBox]

nixward opened a new issue #158: [macOS BLE] commands always failing
URL: https://github.com/apache/mynewt-newtmgr/issues/158
 
 
   I installed 1.7.0 via brew.
   
   I've tried different connection profile parameters but no luck.
   
   $ newtmgr conn add profile01 type=ble 
connstring="peer_id=b6c9e1eece3cec00d78f48601e516659"
   
   $ newtmgr reset -c profile01
   2020/03/25 12:52:05 Unhandled event: 
xpc.Dict{"kCBMsgArgs":xpc.Dict{"kCBAdvDataDeviceAddress":[]uint8{0x65, 0x73, 
0x16, 0xf4, 0x9b, 0x8}}, "kCBMsgId":38}
   2020/03/25 12:52:05 Unhandled event: 
xpc.Dict{"kCBMsgArgs":xpc.Dict{"kCBAdvDataDeviceAddress":[]uint8{0x65, 0x73, 
0x16, 0xf4, 0x9b, 0x8}}, "kCBMsgId":38}
   Error: Failed to connect to peer after 10s


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-newt] ccollins476ad opened a new pull request #387: Use rc-tag-inference in inter-repo dependencies

[GitBox]

ccollins476ad opened a new pull request #387: Use rc-tag-inference in 
inter-repo dependencies
URL: https://github.com/apache/mynewt-newt/pull/387
 
 
   A repo can specify dependencies in its `repository.yml` file, e.g.,
   
   ```
   repo.deps:
   apache-mynewt-nimble:
   type: github
   user: apache
   repo: mynewt-nimble
   vers:
   mynewt_1_4_0_tag: 1.0.0
   ```
   
   The `mynewt_1_4_0_tag` tag of *this repo* depends on nimble 1.0.0.  If 
`mynewt_1_4_0_tag` does not exist, then `newt upgrade` would fail.
   
   This PR changes this process slightly so that rc-tag-inference is used.  If 
`mynewt_1_4_0_tag` does not exist, newt checks for the latest corresponding rc 
tag (e.g., `mynewt_1_4_0_rc1_tag`).  If one is found, it gets used.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #777: nimble/host: Clear master and slave states on host reset

[GitBox]

apache-mynewt-bot removed a comment on issue #777: nimble/host: Clear master 
and slave states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#issuecomment-603327058
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #777: nimble/host: Clear master and slave states on host reset

[GitBox]

apache-mynewt-bot commented on issue #777: nimble/host: Clear master and slave 
states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#issuecomment-603425856
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #777: nimble/host: Clear master and slave states on host reset

[GitBox]

apache-mynewt-bot removed a comment on issue #777: nimble/host: Clear master 
and slave states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#issuecomment-602703331
 
 
   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    nimble/host/src/ble_gap.c
   
   
   ```diff
   @@ -244,42 +244,42 @@

STATS_SECT_DECL(ble_gap_stats) ble_gap_stats;
STATS_NAME_START(ble_gap_stats)
   -STATS_NAME(ble_gap_stats, wl_set)
   -STATS_NAME(ble_gap_stats, wl_set_fail)
   -STATS_NAME(ble_gap_stats, adv_stop)
   -STATS_NAME(ble_gap_stats, adv_stop_fail)
   -STATS_NAME(ble_gap_stats, adv_start)
   -STATS_NAME(ble_gap_stats, adv_start_fail)
   -STATS_NAME(ble_gap_stats, adv_set_data)
   -STATS_NAME(ble_gap_stats, adv_set_data_fail)
   -STATS_NAME(ble_gap_stats, adv_rsp_set_data)
   -STATS_NAME(ble_gap_stats, adv_rsp_set_data_fail)
   -STATS_NAME(ble_gap_stats, discover)
   -STATS_NAME(ble_gap_stats, discover_fail)
   -STATS_NAME(ble_gap_stats, initiate)
   -STATS_NAME(ble_gap_stats, initiate_fail)
   -STATS_NAME(ble_gap_stats, terminate)
   -STATS_NAME(ble_gap_stats, terminate_fail)
   -STATS_NAME(ble_gap_stats, cancel)
   -STATS_NAME(ble_gap_stats, cancel_fail)
   -STATS_NAME(ble_gap_stats, update)
   -STATS_NAME(ble_gap_stats, update_fail)
   -STATS_NAME(ble_gap_stats, connect_mst)
   -STATS_NAME(ble_gap_stats, connect_slv)
   -STATS_NAME(ble_gap_stats, disconnect)
   -STATS_NAME(ble_gap_stats, rx_disconnect)
   -STATS_NAME(ble_gap_stats, rx_update_complete)
   -STATS_NAME(ble_gap_stats, rx_adv_report)
   -STATS_NAME(ble_gap_stats, rx_conn_complete)
   -STATS_NAME(ble_gap_stats, discover_cancel)
   -STATS_NAME(ble_gap_stats, discover_cancel_fail)
   -STATS_NAME(ble_gap_stats, security_initiate)
   -STATS_NAME(ble_gap_stats, security_initiate_fail)
   +STATS_NAME(ble_gap_stats, wl_set)
   +STATS_NAME(ble_gap_stats, wl_set_fail)
   +STATS_NAME(ble_gap_stats, adv_stop)
   +STATS_NAME(ble_gap_stats, adv_stop_fail)
   +STATS_NAME(ble_gap_stats, adv_start)
   +STATS_NAME(ble_gap_stats, adv_start_fail)
   +STATS_NAME(ble_gap_stats, adv_set_data)
   +STATS_NAME(ble_gap_stats, adv_set_data_fail)
   +STATS_NAME(ble_gap_stats, adv_rsp_set_data)
   +STATS_NAME(ble_gap_stats, adv_rsp_set_data_fail)
   +STATS_NAME(ble_gap_stats, discover)
   +STATS_NAME(ble_gap_stats, discover_fail)
   +STATS_NAME(ble_gap_stats, initiate)
   +STATS_NAME(ble_gap_stats, initiate_fail)
   +STATS_NAME(ble_gap_stats, terminate)
   +STATS_NAME(ble_gap_stats, terminate_fail)
   +STATS_NAME(ble_gap_stats, cancel)
   +STATS_NAME(ble_gap_stats, cancel_fail)
   +STATS_NAME(ble_gap_stats, update)
   +STATS_NAME(ble_gap_stats, update_fail)
   +STATS_NAME(ble_gap_stats, connect_mst)
   +STATS_NAME(ble_gap_stats, connect_slv)
   +STATS_NAME(ble_gap_stats, disconnect)
   +STATS_NAME(ble_gap_stats, rx_disconnect)
   +STATS_NAME(ble_gap_stats, rx_update_complete)
   +STATS_NAME(ble_gap_stats, rx_adv_report)
   +STATS_NAME(ble_gap_stats, rx_conn_complete)
   +STATS_NAME(ble_gap_stats, discover_cancel)
   +STATS_NAME(ble_gap_stats, discover_cancel_fail)
   +STATS_NAME(ble_gap_stats, security_initiate)
   +STATS_NAME(ble_gap_stats, security_initiate_fail)
STATS_NAME_END(ble_gap_stats)


/*
   - * $debug   
 *
   - 
*/
   +* $debug
*
   
+*/

#if MYNEWT_VAL(BLE_HS_DEBUG)
int
   ```
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #777: nimble/host: Clear master and slave states on host reset

[GitBox]

apache-mynewt-bot commented on issue #777: nimble/host: Clear master and slave 
states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#issuecomment-603327058
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] prasad-alatkar commented on a change in pull request #777: nimble/host: Clear master and slave states on host reset

[GitBox]

prasad-alatkar commented on a change in pull request #777: nimble/host: Clear 
master and slave states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#discussion_r397265344
 
 

 ##
 File path: nimble/host/src/ble_gap.c
 ##
 @@ -737,6 +748,39 @@ ble_gap_slave_reset_state(uint8_t instance)
 #endif
 }
 
+/**
+ * Clears advertisement and discovery state.  This function is necessary
+ * when the controller loses its active state (e.g. on stack reset).
+ */
+void
+ble_gap_reset_state(uint16_t conn_handle, int reason)
+{
+#if NIMBLE_BLE_ADVERTISE
+#if MYNEWT_VAL(BLE_EXT_ADV)
+uint8_t i;
+
+for (i = 0; i < BLE_ADV_INSTANCES; i++) {
+ble_gap_slave_reset_state(i);
+/* Indicate to application that advertising has stopped. */
+ble_gap_adv_finished(i, reason, conn_handle, 0);
 
 Review comment:
   True.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] prasad-alatkar commented on a change in pull request #777: nimble/host: Clear master and slave states on host reset

[GitBox]

prasad-alatkar commented on a change in pull request #777: nimble/host: Clear 
master and slave states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#discussion_r397265064
 
 

 ##
 File path: nimble/host/src/ble_hs.c
 ##
 @@ -388,6 +388,13 @@ ble_hs_reset(void)
 /* Clear configured addresses. */
 ble_hs_id_reset();
 
+/* Clear adverising and scanning states. */
+if (conn_handle == BLE_HS_CONN_HANDLE_NONE) {
 
 Review comment:
   Makes sense :+1: 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] prasad-alatkar commented on a change in pull request #777: nimble/host: Clear master and slave states on host reset

[GitBox]

prasad-alatkar commented on a change in pull request #777: nimble/host: Clear 
master and slave states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#discussion_r397265292
 
 

 ##
 File path: nimble/host/src/ble_gap.c
 ##
 @@ -737,6 +748,39 @@ ble_gap_slave_reset_state(uint8_t instance)
 #endif
 }
 
+/**
+ * Clears advertisement and discovery state.  This function is necessary
+ * when the controller loses its active state (e.g. on stack reset).
+ */
+void
+ble_gap_reset_state(uint16_t conn_handle, int reason)
+{
+#if NIMBLE_BLE_ADVERTISE
+#if MYNEWT_VAL(BLE_EXT_ADV)
+uint8_t i;
+
+for (i = 0; i < BLE_ADV_INSTANCES; i++) {
+ble_gap_slave_reset_state(i);
+/* Indicate to application that advertising has stopped. */
+ble_gap_adv_finished(i, reason, conn_handle, 0);
+}
+#else
+ble_gap_slave_reset_state(0);
+/* Indicate to application that advertising has stopped. */
+ble_gap_adv_finished(0, reason, conn_handle, 0);
 
 Review comment:
   Done !!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] prasad-alatkar commented on a change in pull request #777: nimble/host: Clear master and slave states on host reset

[GitBox]

prasad-alatkar commented on a change in pull request #777: nimble/host: Clear 
master and slave states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#discussion_r397263894
 
 

 ##
 File path: nimble/host/src/ble_gap.c
 ##
 @@ -737,6 +737,30 @@ ble_gap_slave_reset_state(uint8_t instance)
 #endif
 }
 
+/**
+ * Clears advertisement and discovery state.  This function is necessary
+ * when the controller loses its active state (e.g. on stack reset).
+ */
+void
+ble_gap_master_slave_reset_state(void)
+{
+#if NIMBLE_BLE_ADVERTISE
+#if MYNEWT_VAL(BLE_EXT_ADV)
+uint8_t i;
+
+for (i = 0; i < BLE_ADV_INSTANCES; i++) {
+ble_gap_slave_reset_state(i);
+}
+#else
+ble_gap_slave_reset_state(0);
+#endif
+#endif
+
+#if NIMBLE_BLE_SCAN
+ble_gap_master_reset_state();
 
 Review comment:
   Thank you for the explanation :+1: 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] prasad-alatkar commented on a change in pull request #777: nimble/host: Clear master and slave states on host reset

[GitBox]

prasad-alatkar commented on a change in pull request #777: nimble/host: Clear 
master and slave states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#discussion_r397263377
 
 

 ##
 File path: nimble/host/src/ble_gap.c
 ##
 @@ -737,6 +737,30 @@ ble_gap_slave_reset_state(uint8_t instance)
 #endif
 }
 
+/**
+ * Clears advertisement and discovery state.  This function is necessary
+ * when the controller loses its active state (e.g. on stack reset).
+ */
+void
+ble_gap_master_slave_reset_state(void)
+{
+#if NIMBLE_BLE_ADVERTISE
+#if MYNEWT_VAL(BLE_EXT_ADV)
+uint8_t i;
+
+for (i = 0; i < BLE_ADV_INSTANCES; i++) {
+ble_gap_slave_reset_state(i);
 
 Review comment:
   Yes, but I thought as we are anyway resetting the host stack, so resetting 
slave_state should be all right. However I understand, as far as 
`ble_gap_adv_finished` is concerned, we should only call it when actually 
active adv instance was there.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] brianwyld commented on issue #2245: STM32 Allow reboot to bootloader

[GitBox]

brianwyld commented on issue #2245: STM32 Allow reboot to bootloader
URL: https://github.com/apache/mynewt-core/pull/2245#issuecomment-603294533
 
 
   Ok, thanks!
   
   On Tue, 24 Mar 2020 at 16:03, kasjer  wrote:
   
   > Hi, Does this mean it may have an impact on using HSE with STM32? thanks
   > Brian
   >
   > Hi @brianwyld , this is adds new function
   > that can be used to start ST bootloader.
   > If you don't use this function in your code, there is no impact.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > ,
   > or unsubscribe
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] kasjer commented on issue #2245: STM32 Allow reboot to bootloader

[GitBox]

kasjer commented on issue #2245: STM32 Allow reboot to bootloader
URL: https://github.com/apache/mynewt-core/pull/2245#issuecomment-603291372
 
 
   > Hi, Does this mean it may have an impact on using HSE with STM32? thanks 
Brian
   
   Hi @brianwyld, this is adds new function that can be used to start ST 
bootloader.
   If you don't use this function in your code, there is no impact.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] brianwyld commented on issue #2245: STM32 Allow reboot to bootloader

[GitBox]

brianwyld commented on issue #2245: STM32 Allow reboot to bootloader
URL: https://github.com/apache/mynewt-core/pull/2245#issuecomment-603286496
 
 
   Hi,
   Does this mean it may have an impact on using HSE with STM32?
   thanks
   
   Brian
   
   On Tue, 24 Mar 2020 at 14:57, Fabio Utzig  wrote:
   
   > *@utzig* approved this pull request.
   >
   > LGTM. I only tested this on Nucleo-F439ZI so far, it works well. A caveat
   > is that I had to enable HSI (syscfg) otherwise the bootloader does not
   > start. I will do a bit testing on other families, but proceed with merge.
   >
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or unsubscribe
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] zacwbond commented on issue #781: Make connection update process timeout variable

[GitBox]

zacwbond commented on issue #781: Make connection update process timeout 
variable
URL: https://github.com/apache/mynewt-nimble/pull/781#issuecomment-603273789
 
 
   @rymanluk Your a) makes sense to me.  If I get a timeout, I'd tend to assume 
that the event that timed out is never going to happen, so it would be odd to 
send a timeout event if the procedure is eventually going to succeed.
   
   Another problem I've noticed is that I frequently see a call to my reset_cb 
with error code 19 when the gap connection parameter update procedure is 
initiated.  I think it must be associated with the function 
`ble_hs_hci_wait_for_ack()`.  That makes it sound like an HCI problem and not a 
Nimble problem, but it only ever happens with the parameter update procedure, 
and only intermittently.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] sjanc commented on issue #2237: [WIP DNM] Added bsp and mcu packages for dialog_da14695-dk-usb

[GitBox]

sjanc commented on issue #2237: [WIP DNM] Added bsp and mcu packages for 
dialog_da14695-dk-usb
URL: https://github.com/apache/mynewt-core/pull/2237#issuecomment-603218161
 
 
   yes, we have way too many copies (with subtle changes) of nrf startup code 
around ...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2248: BME388 license fix

[GitBox]

apache-mynewt-bot removed a comment on issue #2248: BME388 license fix
URL: https://github.com/apache/mynewt-core/pull/2248#issuecomment-603204076
 
 
   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    hw/drivers/sensors/bmp388/include/bmp388/bmp388.h
   
   
   ```diff
   @@ -41,7 +41,7 @@
 *
 * File   bmp388.h
 * Date   10 May 2019
   - * Version  1.0.2
   + * Version  1.0.2
 *
 */

   ```
   
   
   
    hw/drivers/sensors/bmp388/src/bmp388_priv.h
   
   
   ```diff
   @@ -41,7 +41,7 @@
 *
 * File   bmp388_priv.h
 * Date   10 May 2019
   - * Version  1.0.2
   + * Version  1.0.2
 *
 */

   ```
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2248: BME388 license fix

[GitBox]

apache-mynewt-bot commented on issue #2248: BME388 license fix
URL: https://github.com/apache/mynewt-core/pull/2248#issuecomment-603206054
 
 
   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2248: BME388 license fix

[GitBox]

apache-mynewt-bot commented on issue #2248: BME388 license fix
URL: https://github.com/apache/mynewt-core/pull/2248#issuecomment-603204076
 
 
   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    hw/drivers/sensors/bmp388/include/bmp388/bmp388.h
   
   
   ```diff
   @@ -41,7 +41,7 @@
 *
 * File   bmp388.h
 * Date   10 May 2019
   - * Version  1.0.2
   + * Version  1.0.2
 *
 */

   ```
   
   
   
    hw/drivers/sensors/bmp388/src/bmp388_priv.h
   
   
   ```diff
   @@ -41,7 +41,7 @@
 *
 * File   bmp388_priv.h
 * Date   10 May 2019
   - * Version  1.0.2
   + * Version  1.0.2
 *
 */

   ```
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2248: BME388 license fix

[GitBox]

apache-mynewt-bot removed a comment on issue #2248: BME388 license fix
URL: https://github.com/apache/mynewt-core/pull/2248#issuecomment-603187257
 
 
   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    hw/drivers/sensors/bmp388/include/bmp388/bmp388.h
   
   
   ```diff
   @@ -1,49 +1,49 @@
/**\mainpage
   -* Copyright (C) 2017 - 2019 Bosch Sensortec GmbH
   -*
   -* Redistribution and use in source and binary forms, with or without
   -* modification, are permitted provided that the following conditions are 
met:
   -*
   -* Redistributions of source code must retain the above copyright
   -* notice, this list of conditions and the following disclaimer.
   -*
   -* Redistributions in binary form must reproduce the above copyright
   -* notice, this list of conditions and the following disclaimer in the
   -* documentation and/or other materials provided with the distribution.
   -*
   -* Neither the name of the copyright holder nor the names of the
   -* contributors may be used to endorse or promote products derived from
   -* this software without specific prior written permission.
   -*
   -* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
   -* CONTRIBUTORS "AS IS" AND ANY EXPRESS OR
   -* IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
   -* WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
   -* DISCLAIMED. IN NO EVENT SHALL COPYRIGHT HOLDER
   -* OR CONTRIBUTORS BE LIABLE FOR ANY
   -* DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY,
   -* OR CONSEQUENTIAL DAMAGES(INCLUDING, BUT NOT LIMITED TO,
   -* PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
   -* LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
   -* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
   -* WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
   -* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
   -* ANY WAY OUT OF THE USE OF THIS
   -* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE
   -*
   -* The information provided is believed to be accurate and reliable.
   -* The copyright holder assumes no responsibility
   -* for the consequences of use
   -* of such information nor for any infringement of patents or
   -* other rights of third parties which may result from its use.
   -* No license is granted by implication or otherwise under any patent or
   -* patent rights of the copyright holder.
   -*
   -* File   bmp388.h
   -* Date   10 May 2019
   -* Version   1.0.2
   -*
   -*/
   + * Copyright (C) 2017 - 2019 Bosch Sensortec GmbH
   + *
   + * Redistribution and use in source and binary forms, with or without
   + * modification, are permitted provided that the following conditions are 
met:
   + *
   + * Redistributions of source code must retain the above copyright
   + * notice, this list of conditions and the following disclaimer.
   + *
   + * Redistributions in binary form must reproduce the above copyright
   + * notice, this list of conditions and the following disclaimer in the
   + * documentation and/or other materials provided with the distribution.
   + *
   + * Neither the name of the copyright holder nor the names of the
   + * contributors may be used to endorse or promote products derived from
   + * this software without specific prior written permission.
   + *
   + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
   + * CONTRIBUTORS "AS IS" AND ANY EXPRESS OR
   + * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
   + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
   + * DISCLAIMED. IN NO EVENT SHALL COPYRIGHT HOLDER
   + * OR CONTRIBUTORS BE LIABLE FOR ANY
   + * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY,
   + * OR CONSEQUENTIAL DAMAGES(INCLUDING, BUT NOT LIMITED TO,
   + * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
   + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
   + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
   + * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
   + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
   + * ANY WAY OUT OF THE USE OF THIS
   + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE
   + *
   + * The information provided is believed to be accurate and reliable.
   + * The copyright holder assumes no responsibility
   + * for the consequences of use
   + * of such information nor for any infringement of patents or
   + * other rights of third parties which may result from its use.
   + * No license is granted by implication or otherwise under any patent or
   + * patent rights of the copyright holder.
   + *
   + * File   bmp388.h
   + * Date   10 May 2019
   + * Version  1.0.2
   + *
   + */

#ifndef __BMP388_H__
#define __BMP388_H__
   ```
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log 

[GitHub] [mynewt-core] sjanc commented on issue #2248: BME388 license fix

[GitBox]

sjanc commented on issue #2248: BME388 license fix
URL: https://github.com/apache/mynewt-core/pull/2248#issuecomment-603187242
 
 
   @bstbud FYI
   
   Also please note that this change is against 1.8 release branch, after 
release I'll merge it back to master


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2248: BME388 license fix

[GitBox]

apache-mynewt-bot commented on issue #2248: BME388 license fix
URL: https://github.com/apache/mynewt-core/pull/2248#issuecomment-603187257
 
 
   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    hw/drivers/sensors/bmp388/include/bmp388/bmp388.h
   
   
   ```diff
   @@ -1,49 +1,49 @@
/**\mainpage
   -* Copyright (C) 2017 - 2019 Bosch Sensortec GmbH
   -*
   -* Redistribution and use in source and binary forms, with or without
   -* modification, are permitted provided that the following conditions are 
met:
   -*
   -* Redistributions of source code must retain the above copyright
   -* notice, this list of conditions and the following disclaimer.
   -*
   -* Redistributions in binary form must reproduce the above copyright
   -* notice, this list of conditions and the following disclaimer in the
   -* documentation and/or other materials provided with the distribution.
   -*
   -* Neither the name of the copyright holder nor the names of the
   -* contributors may be used to endorse or promote products derived from
   -* this software without specific prior written permission.
   -*
   -* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
   -* CONTRIBUTORS "AS IS" AND ANY EXPRESS OR
   -* IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
   -* WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
   -* DISCLAIMED. IN NO EVENT SHALL COPYRIGHT HOLDER
   -* OR CONTRIBUTORS BE LIABLE FOR ANY
   -* DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY,
   -* OR CONSEQUENTIAL DAMAGES(INCLUDING, BUT NOT LIMITED TO,
   -* PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
   -* LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
   -* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
   -* WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
   -* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
   -* ANY WAY OUT OF THE USE OF THIS
   -* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE
   -*
   -* The information provided is believed to be accurate and reliable.
   -* The copyright holder assumes no responsibility
   -* for the consequences of use
   -* of such information nor for any infringement of patents or
   -* other rights of third parties which may result from its use.
   -* No license is granted by implication or otherwise under any patent or
   -* patent rights of the copyright holder.
   -*
   -* File   bmp388.h
   -* Date   10 May 2019
   -* Version   1.0.2
   -*
   -*/
   + * Copyright (C) 2017 - 2019 Bosch Sensortec GmbH
   + *
   + * Redistribution and use in source and binary forms, with or without
   + * modification, are permitted provided that the following conditions are 
met:
   + *
   + * Redistributions of source code must retain the above copyright
   + * notice, this list of conditions and the following disclaimer.
   + *
   + * Redistributions in binary form must reproduce the above copyright
   + * notice, this list of conditions and the following disclaimer in the
   + * documentation and/or other materials provided with the distribution.
   + *
   + * Neither the name of the copyright holder nor the names of the
   + * contributors may be used to endorse or promote products derived from
   + * this software without specific prior written permission.
   + *
   + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
   + * CONTRIBUTORS "AS IS" AND ANY EXPRESS OR
   + * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
   + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
   + * DISCLAIMED. IN NO EVENT SHALL COPYRIGHT HOLDER
   + * OR CONTRIBUTORS BE LIABLE FOR ANY
   + * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY,
   + * OR CONSEQUENTIAL DAMAGES(INCLUDING, BUT NOT LIMITED TO,
   + * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
   + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
   + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
   + * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
   + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
   + * ANY WAY OUT OF THE USE OF THIS
   + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE
   + *
   + * The information provided is believed to be accurate and reliable.
   + * The copyright holder assumes no responsibility
   + * for the consequences of use
   + * of such information nor for any infringement of patents or
   + * other rights of third parties which may result from its use.
   + * No license is granted by implication or otherwise under any patent or
   + * patent rights of the copyright holder.
   + *
   + * File   bmp388.h
   + * Date   10 May 2019
   + * Version  1.0.2
   + *
   + */

#ifndef __BMP388_H__
#define __BMP388_H__
   ```
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to 

[GitHub] [mynewt-core] sjanc opened a new pull request #2248: BME388 license fix

[GitBox]

sjanc opened a new pull request #2248: BME388 license fix
URL: https://github.com/apache/mynewt-core/pull/2248
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] de-nordic closed pull request #2165: FIx: advance_internal should return error instead of using assert

[GitBox]

de-nordic closed pull request #2165: FIx: advance_internal should return error 
instead of using assert
URL: https://github.com/apache/mynewt-core/pull/2165
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] de-nordic commented on issue #2165: FIx: advance_internal should return error instead of using assert

[GitBox]

de-nordic commented on issue #2165: FIx: advance_internal should return error 
instead of using assert
URL: https://github.com/apache/mynewt-core/pull/2165#issuecomment-603168639
 
 
   Abandoned.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-mcumgr] de-nordic commented on issue #65: fs_mgmt: Fix file download for Zephyr

[GitBox]

de-nordic commented on issue #65: fs_mgmt: Fix file download for Zephyr
URL: https://github.com/apache/mynewt-mcumgr/pull/65#issuecomment-603161595
 
 
   > 
   > 
   > should this be closed now?
   
   Yes, this has been abandoned in favour of the less invasive approach 
https://github.com/apache/mynewt-mcumgr/pull/72


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-mcumgr] de-nordic closed pull request #65: fs_mgmt: Fix file download for Zephyr

[GitBox]

de-nordic closed pull request #65: fs_mgmt: Fix file download for Zephyr
URL: https://github.com/apache/mynewt-mcumgr/pull/65
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-mcumgr] sjanc commented on issue #65: fs_mgmt: Fix file download for Zephyr

[GitBox]

sjanc commented on issue #65: fs_mgmt: Fix file download for Zephyr
URL: https://github.com/apache/mynewt-mcumgr/pull/65#issuecomment-603147285
 
 
   should this be closed now?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[mynewt-blinky] branch 1_8_0_dev updated: Update dates in NOTICE

[janc]

This is an automated email from the ASF dual-hosted git repository.

janc pushed a commit to branch 1_8_0_dev
in repository https://gitbox.apache.org/repos/asf/mynewt-blinky.git


The following commit(s) were added to refs/heads/1_8_0_dev by this push:
 new 34e9aae  Update dates in NOTICE
34e9aae is described below

commit 34e9aae78f3ab4a4307bf99b4e25be11060aa526
Author: Szymon Janc 
AuthorDate: Mon Mar 23 12:59:01 2020 +0100

Update dates in NOTICE
---
 NOTICE | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/NOTICE b/NOTICE
index 4ba7354..20a92e2 100644
--- a/NOTICE
+++ b/NOTICE
@@ -1,5 +1,5 @@
 Apache Mynewt
-Copyright 2015-2017 The Apache Software Foundation
+Copyright 2015-2020 The Apache Software Foundation
 
 This product includes software developed at
 The Apache Software Foundation (http://www.apache.org/).

[GitHub] [mynewt-blinky] sjanc merged pull request #14: Update dates in NOTICE

[GitBox]

sjanc merged pull request #14: Update dates in NOTICE
URL: https://github.com/apache/mynewt-blinky/pull/14
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[mynewt-newtmgr] branch 1_8_0_dev updated: Fixes for 1.8 release

[janc]

This is an automated email from the ASF dual-hosted git repository.

janc pushed a commit to branch 1_8_0_dev
in repository https://gitbox.apache.org/repos/asf/mynewt-newtmgr.git


The following commit(s) were added to refs/heads/1_8_0_dev by this push:
 new 15c6a24  Fixes for 1.8 release
15c6a24 is described below

commit 15c6a24d57d6dbdcf33646df365b2c64a12de251
Author: Szymon Janc 
AuthorDate: Mon Mar 23 13:13:38 2020 +0100

Fixes for 1.8 release

Updates dates and removes no longer bundled vendor/ libraries from
LICENSE file.
---
 LICENSE  | 135 ---
 NOTICE   |   2 +-
 RELEASE_NOTES.md |   2 +-
 3 files changed, 2 insertions(+), 137 deletions(-)

diff --git a/LICENSE b/LICENSE
index 4c5a9f5..8dada3e 100644
--- a/LICENSE
+++ b/LICENSE
@@ -199,138 +199,3 @@
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-
-This product bundles pretty, which is available under the MIT license. For
-details, see:
-* vendor/github.com/kr/pretty/License
-
-This product bundles kr/text, which is available under the MIT license. For
-details, see:
-* vendor/github.com/kr/text/License
-
-This product bundles mapstructure, which is available under the MIT license.
-For details, see:
-* vendor/github.com/mitchellh/mapstructure/LICENSE
-
-This product bundles logrus, which is available under the MIT license. For
-details, see:
-* vendor/github.com/Sirupsen/logrus/LICENSE
-
-This product bundles Cast, which is available under the MIT license. For
-details, see:
-* vendor/github.com/spf13/cast/LICENSE
-
-This product bundles jWalterWeatherman, which is available under the MIT
-license. For details, see:
-* vendor/github.com/spf13/jwalterweatherman/LICENSE
-
-This product bundles pflag, which is available under the "3-clause BSD"
-license. For details, see:
-* vendor/github.com/spf13/pflag/LICENSE
-
-This product bundles the unix Go package, which is available under the
-"3-clause BSD" license. For details, see:
-* vendor/golang.org/x/sys/LICENSE
-
-This product bundles the Go supplementary cryptography libraries package,
-which is available under the "3-clause BSD" license. For details, see:
-* vendor/golang.org/x/crypto/LICENSE
-
-This product bundles the Go supplementary networking libraries package, which
-is available under the "3-clause BSD" license. For details, see:
-* vendor/golang.org/x/net/LICENSE
-
-This product bundles fsnotify.v1, which is available under the "3-clause BSD"
-license. For details, see:
-* vendor/gopkg.in/fsnotify.v1/LICENSE
-
-This product bundles yaml.v2's Go port of libyaml, which is available under the
-MIT license. For details, see:
-* vendor/mynewt.apache.org/newt/yaml/apic.go
-* vendor/mynewt.apache.org/newt/yaml/emitterc.go
-* vendor/mynewt.apache.org/newt/yaml/parserc.go
-* vendor/mynewt.apache.org/newt/yaml/readerc.go
-* vendor/mynewt.apache.org/newt/yaml/scannerc.go
-* vendor/mynewt.apache.org/newt/yaml/writerc.go
-* vendor/mynewt.apache.org/newt/yaml/yamlh.go
-* vendor/mynewt.apache.org/newt/yaml/yamlprivateh.go
-
-This product bundles viper, which is available under the MIT license. For
-details, see:
-* vendor/mynewt.apache.org/newt/viper/LICENSE
-
-This product bundles pb, which is available under the "3-clause BSD" license.
-For details, see:
-* vendor/github.com/cheggaaa/pb/LICENSE
-
-This product bundles ble, which is available under the "3-clause BSD" license.
-For details, see:
-* vendor/github.com/currantlabs/ble/LICENSE
-
-This product bundles structs, which is available under the MIT license. For
-details, see:
-* vendor/github.com/fatih/structs/LICENSE
-
-This product bundles structs, which is available under the Apache License 2.0.
-For details, see:
-* vendor/github.com/inconshreveable/mousetrap/LICENSE
-
-This product bundles go-crc16, which is available under the MIT license. For
-details, see:
-* vendor/github.com/joaojeronimo/go-crc16/README.md
-
-This product bundles ansi, which is available under the MIT license. For
-details, see:
-* vendor/github.com/mgutz/ansi/LICENSE
-
-This product bundles logxi, which is available under the MIT license. For
-details, see:
-* vendor/github.com/mgutz/logxi/LICENSE
-
-This product bundles go-homedir, which is available under the MIT license. For
-details, see:
-* vendor/github.com/mitchellh/go-homedir/LICENSE
-
-This product bundles go-codec, which is available under the MIT license. For
-details, see:
-* vendor/github.com/ugorji/go/LICENSE
-
-This product bundles goble, which is available under the MIT license. For
-details, see:
-* vendor/github.com/raff/goble/LICENSE
-
-This product bundles go-coap, which is available under the MIT license. For
-details, see:
-* 

[GitHub] [mynewt-newtmgr] sjanc merged pull request #157: Fixes for 1.8 release

[GitBox]

sjanc merged pull request #157: Fixes for 1.8 release
URL: https://github.com/apache/mynewt-newtmgr/pull/157
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[mynewt-nimble] branch 1_3_0_dev updated: Fixes for 1.3.0 release

[janc]

This is an automated email from the ASF dual-hosted git repository.

janc pushed a commit to branch 1_3_0_dev
in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git


The following commit(s) were added to refs/heads/1_3_0_dev by this push:
 new 97ce3ea  Fixes for 1.3.0 release
97ce3ea is described below

commit 97ce3eacaaa79e8ed6cf71717149ced4f5328ee7
Author: Szymon Janc 
AuthorDate: Wed Mar 18 16:02:00 2020 +0100

Fixes for 1.3.0 release
---
 .rat-excludes | 2 ++
 NOTICE| 2 +-
 README.md | 2 +-
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/.rat-excludes b/.rat-excludes
index 2c0be75..672c0e7 100644
--- a/.rat-excludes
+++ b/.rat-excludes
@@ -14,6 +14,8 @@ pts-l2cap.txt
 pts-sm.txt
 94654-20170317-085122560.tpg
 94654-20170317-085441153.pts
+uncrustify.cfg
+.style_ignored_dirs
 
 # tinycrypt - BSD License.
 tinycrypt
diff --git a/NOTICE b/NOTICE
index fc24c6a..84ecb14 100644
--- a/NOTICE
+++ b/NOTICE
@@ -1,5 +1,5 @@
 Apache Mynewt NimBLE
-Copyright 2015-2018 The Apache Software Foundation
+Copyright 2015-2020 The Apache Software Foundation
 
 This product includes software developed at
 The Apache Software Foundation (http://www.apache.org/).
diff --git a/README.md b/README.md
index a6f4d04..37103be 100644
--- a/README.md
+++ b/README.md
@@ -23,7 +23,7 @@
 
 ## Overview
 
-Apache NimBLE is an open-source Bluetooth 5.0 stack (both Host & Controller)
+Apache NimBLE is an open-source Bluetooth 5.1 stack (both Host & Controller)
 that completely replaces the proprietary SoftDevice on Nordic chipsets. It is
 part of [Apache Mynewt project](https://github.com/apache/mynewt-core).
 

[GitHub] [mynewt-nimble] sjanc merged pull request #779: Fixes for 1.3 release

[GitBox]

sjanc merged pull request #779: Fixes for 1.3 release
URL: https://github.com/apache/mynewt-nimble/pull/779
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-newt] sjanc merged pull request #386: Fixes for 1.8 release

[GitBox]

sjanc merged pull request #386: Fixes for 1.8 release
URL: https://github.com/apache/mynewt-newt/pull/386
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[mynewt-newt] branch 1_8_0_dev updated: Fixes for 1.8 release

[janc]

This is an automated email from the ASF dual-hosted git repository.

janc pushed a commit to branch 1_8_0_dev
in repository https://gitbox.apache.org/repos/asf/mynewt-newt.git


The following commit(s) were added to refs/heads/1_8_0_dev by this push:
 new 725740e  Fixes for 1.8 release
725740e is described below

commit 725740e08825a4a15d6270cccd7ff45fdd928312
Author: Szymon Janc 
AuthorDate: Mon Mar 23 13:24:30 2020 +0100

Fixes for 1.8 release

Updates dates and removes no longer bundled vendor/ libraries from
LICENSE file.
---
 LICENSE  | 99 
 NOTICE   |  2 +-
 RELEASE_NOTES.md |  2 +-
 3 files changed, 2 insertions(+), 101 deletions(-)

diff --git a/LICENSE b/LICENSE
index c4c0480..25968b1 100644
--- a/LICENSE
+++ b/LICENSE
@@ -200,69 +200,8 @@
See the License for the specific language governing permissions and
limitations under the License.
 
-This product bundles pretty, which is available under the MIT license.  For
-details, see:
- * newt/vendor/github.com/kr/pretty/License
- * newtmgr/vendor/github.com/kr/pretty/License
-
-This product bundles kr/text, which is available under the MIT license.  For
-details, see:
- * newt/vendor/github.com/kr/text/License
- * newtmgr/vendor/github.com/kr/text/License
-
-This product bundles mapstructure, which is available under the MIT license.
-For details, see:
-* newt/vendor/github.com/mitchellh/mapstructure/LICENSE
-* newtmgr/vendor/github.com/mitchellh/mapstructure/LICENSE
-
-This product bundles logrus, which is available under the MIT license.  For
-details, see:
-* newt/vendor/github.com/sirupsen/logrus/LICENSE
-* newtmgr/vendor/github.com/sirupsen/logrus/LICENSE
-
-This product bundles Cast, which is available under the MIT license.  For
-details, see:
-* newt/vendor/github.com/spf13/cast/LICENSE
-* newtmgr/vendor/github.com/spf13/cast/LICENSE
-
-This product bundles jWalterWeatherman, which is available under the MIT
-license.  For details, see:
-* newt/vendor/github.com/spf13/jwalterweatherman/LICENSE
-* newtmgr/vendor/github.com/spf13/jwalterweatherman/LICENSE
-
-This product bundles pflag, which is available under the "3-clause BSD"
-license.  For details, see:
-* newt/vendor/github.com/spf13/pflag/LICENSE
-* newtmgr/vendor/github.com/spf13/pflag/LICENSE
-
-This product bundles the unix Go package, which is available under the
-"3-clause BSD" license.  For details, see:
-* newt/vendor/golang.org/x/sys/LICENSE
-* newtmgr/vendor/golang.org/x/sys/LICENSE
-
-This product bundles fsnotify.v1, which is available under the "3-clause BSD"
-license.  For details, see:
-* newt/vendor/gopkg.in/fsnotify.v1/LICENSE
-* newtmgr/vendor/gopkg.in/fsnotify.v1/LICENSE
-
 This product bundles yaml.v2's Go port of libyaml, which is available under the
 MIT license.  For details, see:
-* newt/vendor/mynewt.apache.org/newt/yaml/apic.go
-* newt/vendor/mynewt.apache.org/newt/yaml/emitterc.go
-* newt/vendor/mynewt.apache.org/newt/yaml/parserc.go
-* newt/vendor/mynewt.apache.org/newt/yaml/readerc.go
-* newt/vendor/mynewt.apache.org/newt/yaml/scannerc.go
-* newt/vendor/mynewt.apache.org/newt/yaml/writerc.go
-* newt/vendor/mynewt.apache.org/newt/yaml/yamlh.go
-* newt/vendor/mynewt.apache.org/newt/yaml/yamlprivateh.go
-* newtmgr/vendor/mynewt.apache.org/newt/yaml/apic.go
-* newtmgr/vendor/mynewt.apache.org/newt/yaml/emitterc.go
-* newtmgr/vendor/mynewt.apache.org/newt/yaml/parserc.go
-* newtmgr/vendor/mynewt.apache.org/newt/yaml/readerc.go
-* newtmgr/vendor/mynewt.apache.org/newt/yaml/scannerc.go
-* newtmgr/vendor/mynewt.apache.org/newt/yaml/writerc.go
-* newtmgr/vendor/mynewt.apache.org/newt/yaml/yamlh.go
-* newtmgr/vendor/mynewt.apache.org/newt/yaml/yamlprivateh.go
 * yaml/apic.go
 * yaml/emitterc.go
 * yaml/parserc.go
@@ -271,41 +210,3 @@ MIT license.  For details, see:
 * yaml/writerc.go
 * yaml/yamlh.go
 * yaml/yamlprivateh.go
-
-This product bundles viper, which is available under the MIT license.  For
-details, see:
-* newt/vendor/mynewt.apache.org/newt/viper/LICENSE
-* newtmgr/vendor/mynewt.apache.org/newt/viper/LICENSE
-* viper/LICENSE
-
-This product bundles go-crc16, which is available under the MIT license.  For
-details, see:
-* newtmgr/vendor/github.com/joaojeronimo/go-crc16/README.md
-
-This product bundles GATT, which is available under the "3-clause BSD" license.
-For details, see:
-* newtmgr/vendor/github.com/runtimeinc/gatt
-
-This product bundles xpc, which is available under the MIT license.  For
-details, see:
-* newtmgr/vendor/github.com/runtimeinc/gatt/xpc/LICENSE
-
-This product bundles gioctl, which is available under the MIT license.  For
-details, see:
-* newtmgr/vendor/github.com/runtimeinc/gatt/linux/gioctl/LICENSE.md
-
-This product bundles tarm/serial, which is 

[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #777: nimble/host: Clear master and slave states on host reset

[GitBox]

rymanluk commented on a change in pull request #777: nimble/host: Clear master 
and slave states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#discussion_r397004577
 
 

 ##
 File path: nimble/host/src/ble_hs.c
 ##
 @@ -388,6 +388,13 @@ ble_hs_reset(void)
 /* Clear configured addresses. */
 ble_hs_id_reset();
 
+/* Clear adverising and scanning states. */
+if (conn_handle == BLE_HS_CONN_HANDLE_NONE) {
 
 Review comment:
   we should just call `ble_gap_reset_state` with a `ble_hs_reset_reason`.  
Imho `conn_handle` at this point is always `BLE_HS_CONN_HANDLE_NONE`.
   
   BTW later I think that we can move following block
   ```
while (1) {
   
   conn_handle = ble_hs_atomic_first_conn_handle();
   if (conn_handle == BLE_HS_CONN_HANDLE_NONE) {
   break;
   }
   
   ble_gap_conn_broken(conn_handle, ble_hs_reset_reason);
   }
   ```
   to the new `ble_gap_reset_state()`
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #777: nimble/host: Clear master and slave states on host reset

[GitBox]

rymanluk commented on a change in pull request #777: nimble/host: Clear master 
and slave states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#discussion_r396993791
 
 

 ##
 File path: nimble/host/src/ble_gap.c
 ##
 @@ -737,6 +748,39 @@ ble_gap_slave_reset_state(uint8_t instance)
 #endif
 }
 
+/**
+ * Clears advertisement and discovery state.  This function is necessary
+ * when the controller loses its active state (e.g. on stack reset).
+ */
+void
+ble_gap_reset_state(uint16_t conn_handle, int reason)
+{
+#if NIMBLE_BLE_ADVERTISE
+#if MYNEWT_VAL(BLE_EXT_ADV)
+uint8_t i;
+
+for (i = 0; i < BLE_ADV_INSTANCES; i++) {
+ble_gap_slave_reset_state(i);
+/* Indicate to application that advertising has stopped. */
+ble_gap_adv_finished(i, reason, conn_handle, 0);
+}
+#else
+ble_gap_slave_reset_state(0);
+/* Indicate to application that advertising has stopped. */
+ble_gap_adv_finished(0, reason, conn_handle, 0);
 
 Review comment:
   same here, we need to do in only when active.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #777: nimble/host: Clear master and slave states on host reset

[GitBox]

rymanluk commented on a change in pull request #777: nimble/host: Clear master 
and slave states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#discussion_r396993578
 
 

 ##
 File path: nimble/host/src/ble_gap.c
 ##
 @@ -737,6 +737,30 @@ ble_gap_slave_reset_state(uint8_t instance)
 #endif
 }
 
+/**
+ * Clears advertisement and discovery state.  This function is necessary
+ * when the controller loses its active state (e.g. on stack reset).
+ */
+void
+ble_gap_master_slave_reset_state(void)
+{
+#if NIMBLE_BLE_ADVERTISE
+#if MYNEWT_VAL(BLE_EXT_ADV)
+uint8_t i;
+
+for (i = 0; i < BLE_ADV_INSTANCES; i++) {
+ble_gap_slave_reset_state(i);
 
 Review comment:
   but, don't  we need to call it only for the active instances?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #777: nimble/host: Clear master and slave states on host reset

[GitBox]

rymanluk commented on a change in pull request #777: nimble/host: Clear master 
and slave states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#discussion_r397000378
 
 

 ##
 File path: nimble/host/src/ble_gap.c
 ##
 @@ -737,6 +748,39 @@ ble_gap_slave_reset_state(uint8_t instance)
 #endif
 }
 
+/**
+ * Clears advertisement and discovery state.  This function is necessary
+ * when the controller loses its active state (e.g. on stack reset).
+ */
+void
+ble_gap_reset_state(uint16_t conn_handle, int reason)
 
 Review comment:
   I would remove `conn_handle` at all because it is not needed. I explained 
below why.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #777: nimble/host: Clear master and slave states on host reset

[GitBox]

rymanluk commented on a change in pull request #777: nimble/host: Clear master 
and slave states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#discussion_r397000116
 
 

 ##
 File path: nimble/host/src/ble_gap.c
 ##
 @@ -737,6 +748,39 @@ ble_gap_slave_reset_state(uint8_t instance)
 #endif
 }
 
+/**
+ * Clears advertisement and discovery state.  This function is necessary
+ * when the controller loses its active state (e.g. on stack reset).
+ */
+void
+ble_gap_reset_state(uint16_t conn_handle, int reason)
+{
+#if NIMBLE_BLE_ADVERTISE
+#if MYNEWT_VAL(BLE_EXT_ADV)
+uint8_t i;
+
+for (i = 0; i < BLE_ADV_INSTANCES; i++) {
+ble_gap_slave_reset_state(i);
+/* Indicate to application that advertising has stopped. */
+ble_gap_adv_finished(i, reason, conn_handle, 0);
 
 Review comment:
   I don't think we need `conn_handle` here. It is used when advertising is 
completed because connection has been established and it is not a case here for 
sure


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #777: nimble/host: Clear master and slave states on host reset

[GitBox]

rymanluk commented on a change in pull request #777: nimble/host: Clear master 
and slave states on host reset
URL: https://github.com/apache/mynewt-nimble/pull/777#discussion_r397010560
 
 

 ##
 File path: nimble/host/src/ble_gap.c
 ##
 @@ -737,6 +737,30 @@ ble_gap_slave_reset_state(uint8_t instance)
 #endif
 }
 
+/**
+ * Clears advertisement and discovery state.  This function is necessary
+ * when the controller loses its active state (e.g. on stack reset).
+ */
+void
+ble_gap_master_slave_reset_state(void)
+{
+#if NIMBLE_BLE_ADVERTISE
+#if MYNEWT_VAL(BLE_EXT_ADV)
+uint8_t i;
+
+for (i = 0; i < BLE_ADV_INSTANCES; i++) {
+ble_gap_slave_reset_state(i);
+}
+#else
+ble_gap_slave_reset_state(0);
+#endif
+#endif
+
+#if NIMBLE_BLE_SCAN
+ble_gap_master_reset_state();
 
 Review comment:
   ad 2. Because application started connection procedure and is waiting for a 
result of it. 
   As the example, if device is not around and application sent Connect, host 
has internal timeout for Connection procedure. When it timeouts, then host do 
connect cancel and when connection complete arrives host is calling 
`ble_gap_master_connect_cancelled`. In our case we don't want to send connect 
cancel but we want to notify application that connection is failed. 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services