[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #778: apps: scanner added

2020-03-30 Thread GitBox
apache-mynewt-bot removed a comment on issue #778: apps: scanner added URL: https://github.com/apache/mynewt-nimble/pull/778#issuecomment-601669692 ## Style check summary No suggestions at this time! ---

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #778: apps: scanner added

2020-03-30 Thread GitBox
apache-mynewt-bot removed a comment on issue #778: apps: scanner added URL: https://github.com/apache/mynewt-nimble/pull/778#issuecomment-605878250 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #778: apps: scanner added

2020-03-30 Thread GitBox
apache-mynewt-bot commented on issue #778: apps: scanner added URL: https://github.com/apache/mynewt-nimble/pull/778#issuecomment-605887409 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #778: apps: scanner added

2020-03-30 Thread GitBox
apache-mynewt-bot commented on issue #778: apps: scanner added URL: https://github.com/apache/mynewt-nimble/pull/778#issuecomment-605901848 ## Style check summary No suggestions at this time! This i

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #778: apps: scanner added

2020-03-30 Thread GitBox
apache-mynewt-bot removed a comment on issue #778: apps: scanner added URL: https://github.com/apache/mynewt-nimble/pull/778#issuecomment-605887409 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md

[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #784: nimble/ll: Fix build with extended advertising and without privacy

2020-03-30 Thread GitBox
andrzej-kaczmarek merged pull request #784: nimble/ll: Fix build with extended advertising and without privacy URL: https://github.com/apache/mynewt-nimble/pull/784 This is an automated message from the Apache Git Service. T

[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request #787: nimble/ll: Drop ext adv event if aux is not sent

2020-03-30 Thread GitBox
andrzej-kaczmarek opened a new pull request #787: nimble/ll: Drop ext adv event if aux is not sent URL: https://github.com/apache/mynewt-nimble/pull/787 If one of auxiliary packets is not sent, we should drop remaining advertising event since any subsequent packet sent in event cannot be

[GitHub] [mynewt-nimble] prasad-alatkar closed issue #776: NimBLE Host: Advertisement and Scanning state should be reset when `ble_hs_reset` is called

2020-03-30 Thread GitBox
prasad-alatkar closed issue #776: NimBLE Host: Advertisement and Scanning state should be reset when `ble_hs_reset` is called URL: https://github.com/apache/mynewt-nimble/issues/776 This is an automated message from the Apac

[GitHub] [mynewt-nimble] prasad-alatkar opened a new issue #788: nimble/store: `ble_gap_unpair_oldest_peer` in `ble_store_util_status_rr`(store callback) can cause infinite loop for CCCDs

2020-03-30 Thread GitBox
prasad-alatkar opened a new issue #788: nimble/store: `ble_gap_unpair_oldest_peer` in `ble_store_util_status_rr`(store callback) can cause infinite loop for CCCDs URL: https://github.com/apache/mynewt-nimble/issues/788 In cases where CCCDs are exceeding `MYNEWT_VAL(BLE_STORE_MAX_CCCDS)` (

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #787: nimble/ll: Drop ext adv event if aux is not sent

2020-03-30 Thread GitBox
apache-mynewt-bot commented on issue #787: nimble/ll: Drop ext adv event if aux is not sent URL: https://github.com/apache/mynewt-nimble/pull/787#issuecomment-606265099 ## Style check summary No suggestions at this time! -

[GitHub] [mynewt-core] caspermeijn opened a new pull request #2255: Add SGM4056 charger driver to pinetime BSP

2020-03-31 Thread GitBox
caspermeijn opened a new pull request #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255 This adds a driver for the SGM4056 driver. The first commit adds the base driver, second commit adds charge control integration to the base driver. T

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2255: Add SGM4056 charger driver to pinetime BSP

2020-03-31 Thread GitBox
apache-mynewt-bot commented on issue #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255#issuecomment-606501796 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/COD

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2224: add functionality to allow low power operation for STM32L1xx

2020-03-31 Thread GitBox
apache-mynewt-bot removed a comment on issue #2224: add functionality to allow low power operation for STM32L1xx URL: https://github.com/apache/mynewt-core/pull/2224#issuecomment-595362454 ## Style check summary ### Our coding style is [here!](https://github.com/apache/m

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2224: add functionality to allow low power operation for STM32L1xx

2020-03-31 Thread GitBox
apache-mynewt-bot commented on issue #2224: add functionality to allow low power operation for STM32L1xx URL: https://github.com/apache/mynewt-core/pull/2224#issuecomment-606555366 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-co

[GitHub] [mynewt-core] kasjer commented on a change in pull request #2255: Add SGM4056 charger driver to pinetime BSP

2020-03-31 Thread GitBox
kasjer commented on a change in pull request #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255#discussion_r400836974 ## File path: hw/drivers/chg_ctrl/sgm4056/src/sgm4056.c ## @@ -0,0 +1,192 @@ +/* + * Copyright 2020 Cas

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2252: [RFC] I2S API and driver for STM32 MCUs

2020-03-31 Thread GitBox
apache-mynewt-bot commented on issue #2252: [RFC] I2S API and driver for STM32 MCUs URL: https://github.com/apache/mynewt-core/pull/2252#issuecomment-606714969 ## Style check summary No suggestions at this time! --

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2252: [RFC] I2S API and driver for STM32 MCUs

2020-03-31 Thread GitBox
apache-mynewt-bot removed a comment on issue #2252: [RFC] I2S API and driver for STM32 MCUs URL: https://github.com/apache/mynewt-core/pull/2252#issuecomment-605108684 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/maste

[GitHub] [mynewt-nimble] joonazan opened a new issue #789: How to use ble_gap_connect?

2020-03-31 Thread GitBox
joonazan opened a new issue #789: How to use ble_gap_connect? URL: https://github.com/apache/mynewt-nimble/issues/789 I am using NimBLE with esp-idf. I would like to set the connection interval but I can't figure out how. ble_gap_connect lets you set the interval but it seems that b

[GitHub] [mynewt-nimble] h2zero commented on issue #788: nimble/store: `ble_gap_unpair_oldest_peer` in `ble_store_util_status_rr`(store callback) can cause infinite loop for CCCDs

2020-03-31 Thread GitBox
h2zero commented on issue #788: nimble/store: `ble_gap_unpair_oldest_peer` in `ble_store_util_status_rr`(store callback) can cause infinite loop for CCCDs URL: https://github.com/apache/mynewt-nimble/issues/788#issuecomment-606723283 I found this as well, currently testing a fix in my own f

[GitHub] [mynewt-core] mlaz commented on a change in pull request #2255: Add SGM4056 charger driver to pinetime BSP

2020-03-31 Thread GitBox
mlaz commented on a change in pull request #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255#discussion_r401104932 ## File path: hw/drivers/chg_ctrl/sgm4056/src/sgm4056.c ## @@ -0,0 +1,192 @@ +/* + * Copyright 2020 Caspe

[GitHub] [mynewt-core] mlaz commented on a change in pull request #2255: Add SGM4056 charger driver to pinetime BSP

2020-03-31 Thread GitBox
mlaz commented on a change in pull request #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255#discussion_r401104381 ## File path: hw/drivers/chg_ctrl/sgm4056/src/sgm4056.c ## @@ -0,0 +1,192 @@ +/* + * Copyright 2020 Caspe

[GitHub] [mynewt-core] mlaz commented on a change in pull request #2255: Add SGM4056 charger driver to pinetime BSP

2020-03-31 Thread GitBox
mlaz commented on a change in pull request #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255#discussion_r401102369 ## File path: hw/drivers/chg_ctrl/sgm4056/src/sgm4056.c ## @@ -0,0 +1,192 @@ +/* + * Copyright 2020 Caspe

[GitHub] [mynewt-core] mlaz commented on a change in pull request #2255: Add SGM4056 charger driver to pinetime BSP

2020-03-31 Thread GitBox
mlaz commented on a change in pull request #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255#discussion_r401104807 ## File path: hw/drivers/chg_ctrl/sgm4056/src/sgm4056.c ## @@ -0,0 +1,192 @@ +/* + * Copyright 2020 Caspe

[GitHub] [mynewt-core] mlaz commented on a change in pull request #2255: Add SGM4056 charger driver to pinetime BSP

2020-03-31 Thread GitBox
mlaz commented on a change in pull request #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255#discussion_r401102875 ## File path: hw/drivers/chg_ctrl/sgm4056/src/sgm4056.c ## @@ -0,0 +1,192 @@ +/* + * Copyright 2020 Caspe

[GitHub] [mynewt-core] mlaz commented on issue #2254: [RFC] docs/os/bsp: Add board support section

2020-03-31 Thread GitBox
mlaz commented on issue #2254: [RFC] docs/os/bsp: Add board support section URL: https://github.com/apache/mynewt-core/pull/2254#issuecomment-606784118 Ok, I changed the title of this PR to [RFC] since this is a structural change to doc. Anyway I agree with it and I think we should encourag

[GitHub] [mynewt-nimble] prasad-alatkar opened a new pull request #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-03-31 Thread GitBox
prasad-alatkar opened a new pull request #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit URL: https://github.com/apache/mynewt-nimble/pull/790 Issue reference: #788 Description: In cases where CCCDs are exceeding MYNEWT_VAL(BLE_STORE_MAX_CCCDS)

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-03-31 Thread GitBox
apache-mynewt-bot commented on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit URL: https://github.com/apache/mynewt-nimble/pull/790#issuecomment-606821185 ## Style check summary ### Our coding style is [here!](https://github.co

[GitHub] [mynewt-nimble] h2zero commented on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-03-31 Thread GitBox
h2zero commented on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit URL: https://github.com/apache/mynewt-nimble/pull/790#issuecomment-606926563 Glad you built a proper fix and hope it gets merged. I still question why we store cccd data fo

[GitHub] [mynewt-core] benmccrea opened a new pull request #2256: sys/id: Add optional id/serial_mfg field for storing manufacturer serial numbers

2020-03-31 Thread GitBox
benmccrea opened a new pull request #2256: sys/id: Add optional id/serial_mfg field for storing manufacturer serial numbers URL: https://github.com/apache/mynewt-core/pull/2256 This PR adds a new optional field, `id/serial_mfg` to be used for alternate serial numbers on devices during the

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2256: sys/id: Add optional id/serial_mfg field for storing manufacturer serial numbers

2020-03-31 Thread GitBox
apache-mynewt-bot commented on issue #2256: sys/id: Add optional id/serial_mfg field for storing manufacturer serial numbers URL: https://github.com/apache/mynewt-core/pull/2256#issuecomment-606987859 ## RAT Report (2020-04-01 02:20:28) ## New files with unknown licenses

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2256: sys/id: Add optional id/serial_mfg field for storing manufacturer serial numbers

2020-03-31 Thread GitBox
apache-mynewt-bot commented on issue #2256: sys/id: Add optional id/serial_mfg field for storing manufacturer serial numbers URL: https://github.com/apache/mynewt-core/pull/2256#issuecomment-606987980 ## Style check summary ### Our coding style is [here!](https://github.

[GitHub] [mynewt-core] benmccrea closed pull request #2256: sys/id: Add optional id/serial_mfg field for storing manufacturer serial numbers

2020-03-31 Thread GitBox
benmccrea closed pull request #2256: sys/id: Add optional id/serial_mfg field for storing manufacturer serial numbers URL: https://github.com/apache/mynewt-core/pull/2256 This is an automated message from the Apache Git Serv

[GitHub] [mynewt-core] benmccrea opened a new pull request #2257: sys/id: Add optional id/serial_mfg field for storing manufacturer serial number

2020-03-31 Thread GitBox
benmccrea opened a new pull request #2257: sys/id: Add optional id/serial_mfg field for storing manufacturer serial number URL: https://github.com/apache/mynewt-core/pull/2257 This PR adds a new optional field, id/serial_mfg to be used for alternate serial numbers on devices during the man

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2257: sys/id: Add optional id/serial_mfg field for storing manufacturer serial number

2020-03-31 Thread GitBox
apache-mynewt-bot commented on issue #2257: sys/id: Add optional id/serial_mfg field for storing manufacturer serial number URL: https://github.com/apache/mynewt-core/pull/2257#issuecomment-606996564 ## Style check summary ### Our coding style is [here!](https://github.c

[GitHub] [mynewt-core] benmccrea commented on issue #2256: sys/id: Add optional id/serial_mfg field for storing manufacturer serial numbers

2020-03-31 Thread GitBox
benmccrea commented on issue #2256: sys/id: Add optional id/serial_mfg field for storing manufacturer serial numbers URL: https://github.com/apache/mynewt-core/pull/2256#issuecomment-606997984 Closing in favor of 2257 This is

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2257: sys/id: Add optional id/serial_mfg field for storing manufacturer serial number

2020-03-31 Thread GitBox
apache-mynewt-bot removed a comment on issue #2257: sys/id: Add optional id/serial_mfg field for storing manufacturer serial number URL: https://github.com/apache/mynewt-core/pull/2257#issuecomment-606996564 ## Style check summary ### Our coding style is [here!](https://

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2257: sys/id: Add optional id/serial_mfg field for storing manufacturer serial number

2020-03-31 Thread GitBox
apache-mynewt-bot commented on issue #2257: sys/id: Add optional id/serial_mfg field for storing manufacturer serial number URL: https://github.com/apache/mynewt-core/pull/2257#issuecomment-606999280 ## Style check summary No suggestions at this time! --

[GitHub] [mynewt-nimble] prasad-alatkar commented on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-03-31 Thread GitBox
prasad-alatkar commented on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit URL: https://github.com/apache/mynewt-nimble/pull/790#issuecomment-607031816 @h2zero That is a valid point, will update if I find anything. Maybe @rymanluk can explain it

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2255: Add SGM4056 charger driver to pinetime BSP

2020-04-01 Thread GitBox
apache-mynewt-bot removed a comment on issue #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255#issuecomment-606501796 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/ma

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2255: Add SGM4056 charger driver to pinetime BSP

2020-04-01 Thread GitBox
apache-mynewt-bot commented on issue #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255#issuecomment-607083823 ## Style check summary No suggestions at this time! ---

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2255: Add SGM4056 charger driver to pinetime BSP

2020-04-01 Thread GitBox
apache-mynewt-bot commented on issue #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255#issuecomment-607092226 ## Style check summary No suggestions at this time! ---

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2255: Add SGM4056 charger driver to pinetime BSP

2020-04-01 Thread GitBox
apache-mynewt-bot removed a comment on issue #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255#issuecomment-607083823 ## Style check summary No suggestions at this time! ---

[GitHub] [mynewt-core] caspermeijn commented on a change in pull request #2255: Add SGM4056 charger driver to pinetime BSP

2020-04-01 Thread GitBox
caspermeijn commented on a change in pull request #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255#discussion_r401421249 ## File path: hw/drivers/chg_ctrl/sgm4056/src/sgm4056.c ## @@ -0,0 +1,192 @@ +/* + * Copyright 202

[GitHub] [mynewt-core] caspermeijn commented on issue #2255: Add SGM4056 charger driver to pinetime BSP

2020-04-01 Thread GitBox
caspermeijn commented on issue #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255#issuecomment-607093858 I had some problems with the rebase and squash. But I fixed the history now ;-) -

[GitHub] [mynewt-core] kasjer commented on issue #2255: Add SGM4056 charger driver to pinetime BSP

2020-04-01 Thread GitBox
kasjer commented on issue #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255#issuecomment-607136582 > I had some problems with the rebase and squash. But I fixed the history now ;-) Thanks, as soon as @mlaz is satisfied with his cha

[GitHub] [mynewt-newt] dwld opened a new pull request #391: Fix for @repo targets

2020-04-01 Thread GitBox
dwld opened a new pull request #391: Fix for @repo targets URL: https://github.com/apache/mynewt-newt/pull/391 Without the fix, building targets such as target.app: "@mcuboot/boot/mynewt" fails, since the path to the .manifest, .hex and .bin is wrong. This can be fixed by using

[GitHub] [mynewt-newt] utzig commented on issue #391: Fix for @repo targets

2020-04-01 Thread GitBox
utzig commented on issue #391: Fix for @repo targets URL: https://github.com/apache/mynewt-newt/pull/391#issuecomment-607243692 This use of `Name()` in those functions has been like this for basically ever. All my MCUBoot targets look something like the one you mentioned (`target.app: "@mc

[GitHub] [mynewt-newt] dwld opened a new pull request #392: Update documentation for mfg create

2020-04-01 Thread GitBox
dwld opened a new pull request #392: Update documentation for mfg create URL: https://github.com/apache/mynewt-newt/pull/392 Documentation update for the mfg create command in order to match the current implementation. This i

[GitHub] [mynewt-newt] dwld commented on issue #391: Fix for @repo targets

2020-04-01 Thread GitBox
dwld commented on issue #391: Fix for @repo targets URL: https://github.com/apache/mynewt-newt/pull/391#issuecomment-607261142 Hi @utzig, thanks for your feedback. I'll gather the debug output. Perhaps my .mfg file or my targets are not correct. I just published a documentation update idea

[GitHub] [mynewt-newt] dwld commented on issue #391: Fix for @repo targets in mfg create

2020-04-01 Thread GitBox
dwld commented on issue #391: Fix for @repo targets in mfg create URL: https://github.com/apache/mynewt-newt/pull/391#issuecomment-607291079 @utzig, here is the output of the current master newt build as it is: ``` 2020/04/01 16:30:41.371 [DEBUG] goroutine 1 [running]: mynewt.apache

[GitHub] [mynewt-newt] dwld edited a comment on issue #391: Fix for @repo targets in mfg create

2020-04-01 Thread GitBox
dwld edited a comment on issue #391: Fix for @repo targets in mfg create URL: https://github.com/apache/mynewt-newt/pull/391#issuecomment-607291079 @utzig, here is the output of the current master newt build as it is: ``` $ newt -ldebug mfg create p_nrf52_ble 0.0.0.5 ... 2020/04/

[GitHub] [mynewt-core] benmccrea merged pull request #2257: sys/id: Add optional id/serial_mfg field for storing manufacturer serial number

2020-04-01 Thread GitBox
benmccrea merged pull request #2257: sys/id: Add optional id/serial_mfg field for storing manufacturer serial number URL: https://github.com/apache/mynewt-core/pull/2257 This is an automated message from the Apache Git Servi

[GitHub] [mynewt-core] mlaz commented on issue #2255: Add SGM4056 charger driver to pinetime BSP

2020-04-01 Thread GitBox
mlaz commented on issue #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255#issuecomment-607317147 Looks good, thanks for the changes, @caspermeijn This is an automated messa

[GitHub] [mynewt-core] mlaz merged pull request #2255: Add SGM4056 charger driver to pinetime BSP

2020-04-01 Thread GitBox
mlaz merged pull request #2255: Add SGM4056 charger driver to pinetime BSP URL: https://github.com/apache/mynewt-core/pull/2255 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [mynewt-core] caspermeijn opened a new pull request #2258: Documentation sgm4056

2020-04-01 Thread GitBox
caspermeijn opened a new pull request #2258: Documentation sgm4056 URL: https://github.com/apache/mynewt-core/pull/2258 This add documentation pages for charger-control and the SGM4056 driver. See also the tutorial in https://github.com/apache/mynewt-documentation/pull/94.

[GitHub] [mynewt-core] mlaz merged pull request #2254: docs/os/bsp: Add board support section

2020-04-01 Thread GitBox
mlaz merged pull request #2254: docs/os/bsp: Add board support section URL: https://github.com/apache/mynewt-core/pull/2254 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [mynewt-newt] ccollins476ad commented on a change in pull request #392: Update documentation for mfg create

2020-04-01 Thread GitBox
ccollins476ad commented on a change in pull request #392: Update documentation for mfg create URL: https://github.com/apache/mynewt-newt/pull/392#discussion_r401717802 ## File path: docs/command_list/newt_mfg.rst ## @@ -87,16 +87,25 @@ The ``rb_blinky_rsa`` package needs a

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2258: Documentation SGM4056

2020-04-01 Thread GitBox
apache-mynewt-bot commented on issue #2258: Documentation SGM4056 URL: https://github.com/apache/mynewt-core/pull/2258#issuecomment-607345354 ## Style check summary No suggestions at this time! This

[GitHub] [mynewt-newt] dwld commented on a change in pull request #392: Update documentation for mfg create

2020-04-02 Thread GitBox
dwld commented on a change in pull request #392: Update documentation for mfg create URL: https://github.com/apache/mynewt-newt/pull/392#discussion_r402104325 ## File path: docs/command_list/newt_mfg.rst ## @@ -87,16 +87,25 @@ The ``rb_blinky_rsa`` package needs a pkg.yml

[GitHub] [mynewt-newt] ccollins476ad commented on a change in pull request #392: Update documentation for mfg create

2020-04-02 Thread GitBox
ccollins476ad commented on a change in pull request #392: Update documentation for mfg create URL: https://github.com/apache/mynewt-newt/pull/392#discussion_r402433931 ## File path: docs/command_list/newt_mfg.rst ## @@ -87,16 +87,25 @@ The ``rb_blinky_rsa`` package needs a

[GitHub] [mynewt-newt] ccollins476ad commented on a change in pull request #392: Update documentation for mfg create

2020-04-02 Thread GitBox
ccollins476ad commented on a change in pull request #392: Update documentation for mfg create URL: https://github.com/apache/mynewt-newt/pull/392#discussion_r402433931 ## File path: docs/command_list/newt_mfg.rst ## @@ -87,16 +87,25 @@ The ``rb_blinky_rsa`` package needs a

[GitHub] [mynewt-newt] dwld commented on a change in pull request #392: Update documentation for mfg create

2020-04-02 Thread GitBox
dwld commented on a change in pull request #392: Update documentation for mfg create URL: https://github.com/apache/mynewt-newt/pull/392#discussion_r402446438 ## File path: docs/command_list/newt_mfg.rst ## @@ -87,16 +87,25 @@ The ``rb_blinky_rsa`` package needs a pkg.yml

[GitHub] [mynewt-newt] ccollins476ad merged pull request #392: Update documentation for mfg create

2020-04-02 Thread GitBox
ccollins476ad merged pull request #392: Update documentation for mfg create URL: https://github.com/apache/mynewt-newt/pull/392 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [mynewt-core] caspermeijn opened a new pull request #2259: ARM semihosting console on pinetime

2020-04-02 Thread GitBox
caspermeijn opened a new pull request #2259: ARM semihosting console on pinetime URL: https://github.com/apache/mynewt-core/pull/2259 This adds ARM semihosting console support to mynewt. It is only the tx side. And it is enabled by default for PineTime BSP. This first commits adds th

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2259: ARM semihosting console on pinetime

2020-04-02 Thread GitBox
apache-mynewt-bot commented on issue #2259: ARM semihosting console on pinetime URL: https://github.com/apache/mynewt-core/pull/2259#issuecomment-608018497 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STAN

[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-04-03 Thread GitBox
rymanluk commented on a change in pull request #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit URL: https://github.com/apache/mynewt-nimble/pull/790#discussion_r402775932 ## File path: nimble/host/src/ble_gap.c ## @@ -5594,7 +5594,7 @@

[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-04-03 Thread GitBox
rymanluk commented on a change in pull request #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit URL: https://github.com/apache/mynewt-nimble/pull/790#discussion_r402780122 ## File path: nimble/host/src/ble_store_util.c ## @@ -230,13 +299

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2259: ARM semihosting console on pinetime

2020-04-03 Thread GitBox
apache-mynewt-bot removed a comment on issue #2259: ARM semihosting console on pinetime URL: https://github.com/apache/mynewt-core/pull/2259#issuecomment-608018497 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CO

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2259: ARM semihosting console on pinetime

2020-04-03 Thread GitBox
apache-mynewt-bot commented on issue #2259: ARM semihosting console on pinetime URL: https://github.com/apache/mynewt-core/pull/2259#issuecomment-608275979 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STAN

[GitHub] [mynewt-nimble] prasad-alatkar commented on a change in pull request #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-04-03 Thread GitBox
prasad-alatkar commented on a change in pull request #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit URL: https://github.com/apache/mynewt-nimble/pull/790#discussion_r403009539 ## File path: nimble/host/src/ble_gap.c ## @@ -5594,7 +5594

[GitHub] [mynewt-nimble] prasad-alatkar commented on a change in pull request #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-04-03 Thread GitBox
prasad-alatkar commented on a change in pull request #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit URL: https://github.com/apache/mynewt-nimble/pull/790#discussion_r403012231 ## File path: nimble/host/src/ble_store_util.c ## @@ -230,1

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-04-03 Thread GitBox
apache-mynewt-bot removed a comment on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit URL: https://github.com/apache/mynewt-nimble/pull/790#issuecomment-606821185 ## Style check summary ### Our coding style is [here!](https://g

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-04-03 Thread GitBox
apache-mynewt-bot commented on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit URL: https://github.com/apache/mynewt-nimble/pull/790#issuecomment-608441257 ## Style check summary ### Our coding style is [here!](https://github.co

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-04-03 Thread GitBox
apache-mynewt-bot removed a comment on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit URL: https://github.com/apache/mynewt-nimble/pull/790#issuecomment-608441257 ## Style check summary ### Our coding style is [here!](https://g

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-04-03 Thread GitBox
apache-mynewt-bot commented on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit URL: https://github.com/apache/mynewt-nimble/pull/790#issuecomment-608445002 ## Style check summary ### Our coding style is [here!](https://github.co

[GitHub] [mynewt-core] 5frank opened a new pull request #2260: const correctness log name

2020-04-03 Thread GitBox
5frank opened a new pull request #2260: const correctness log name URL: https://github.com/apache/mynewt-core/pull/2260 `const` recently added to `struct os_dev:od_name` (which is great) but using that name with the log module currently gives a compile error. --

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2260: const correctness log name

2020-04-03 Thread GitBox
apache-mynewt-bot commented on issue #2260: const correctness log name URL: https://github.com/apache/mynewt-core/pull/2260#issuecomment-608456651 ## Style check summary No suggestions at this time!

[GitHub] [mynewt-core] ccollins476ad merged pull request #2260: const correctness log name

2020-04-03 Thread GitBox
ccollins476ad merged pull request #2260: const correctness log name URL: https://github.com/apache/mynewt-core/pull/2260 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-04-03 Thread GitBox
apache-mynewt-bot commented on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit URL: https://github.com/apache/mynewt-nimble/pull/790#issuecomment-608526892 ## Style check summary ### Our coding style is [here!](https://github.co

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-04-03 Thread GitBox
apache-mynewt-bot removed a comment on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit URL: https://github.com/apache/mynewt-nimble/pull/790#issuecomment-608445002 ## Style check summary ### Our coding style is [here!](https://g

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-04-03 Thread GitBox
apache-mynewt-bot commented on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit URL: https://github.com/apache/mynewt-nimble/pull/790#issuecomment-608547695 ## Style check summary No suggestions at this time! ---

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-04-03 Thread GitBox
apache-mynewt-bot removed a comment on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit URL: https://github.com/apache/mynewt-nimble/pull/790#issuecomment-608526892 ## Style check summary ### Our coding style is [here!](https://g

[GitHub] [mynewt-core] tinocyngn opened a new pull request #2261: Adding a version into newt compatilibilty map, for version: 0.0.1

2020-04-03 Thread GitBox
tinocyngn opened a new pull request #2261: Adding a version into newt compatilibilty map, for version: 0.0.1 URL: https://github.com/apache/mynewt-core/pull/2261 This removes 'newt' warning when building JDP, since newt upgrade picks 0.0.1 for commit from master and keeps warning that 0.0.

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2261: Adding a version into newt compatilibilty map, for version: 0.0.1

2020-04-03 Thread GitBox
apache-mynewt-bot commented on issue #2261: Adding a version into newt compatilibilty map, for version: 0.0.1 URL: https://github.com/apache/mynewt-core/pull/2261#issuecomment-608771335 ## Style check summary No suggestions at this time!

[GitHub] [mynewt-core] ccollins476ad merged pull request #2261: Adding a version into newt compatilibilty map, for version: 0.0.1

2020-04-03 Thread GitBox
ccollins476ad merged pull request #2261: Adding a version into newt compatilibilty map, for version: 0.0.1 URL: https://github.com/apache/mynewt-core/pull/2261 This is an automated message from the Apache Git Service. To res

[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-04-04 Thread GitBox
rymanluk commented on a change in pull request #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit URL: https://github.com/apache/mynewt-nimble/pull/790#discussion_r403511125 ## File path: nimble/host/src/ble_store_util.c ## @@ -230,16 +315

[GitHub] [mynewt-nimble] prasad-alatkar commented on a change in pull request #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-04-05 Thread GitBox
prasad-alatkar commented on a change in pull request #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit URL: https://github.com/apache/mynewt-nimble/pull/790#discussion_r403840472 ## File path: nimble/host/src/ble_store_util.c ## @@ -230,1

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-04-05 Thread GitBox
apache-mynewt-bot commented on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit URL: https://github.com/apache/mynewt-nimble/pull/790#issuecomment-609581758 ## Style check summary No suggestions at this time! ---

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-04-05 Thread GitBox
apache-mynewt-bot removed a comment on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit URL: https://github.com/apache/mynewt-nimble/pull/790#issuecomment-608547695 ## Style check summary No suggestions at this time! ---

[GitHub] [mynewt-nimble] prasad-alatkar commented on issue #788: nimble/store: `ble_gap_unpair_oldest_peer` in `ble_store_util_status_rr`(store callback) can cause infinite loop for CCCDs

2020-04-06 Thread GitBox
prasad-alatkar commented on issue #788: nimble/store: `ble_gap_unpair_oldest_peer` in `ble_store_util_status_rr`(store callback) can cause infinite loop for CCCDs URL: https://github.com/apache/mynewt-nimble/issues/788#issuecomment-609676002 @h2zero your proposed solution may avoid this is

[GitHub] [mynewt-nimble] rymanluk opened a new pull request #791: btshell: Add command to unpair the oldest device

2020-04-06 Thread GitBox
rymanluk opened a new pull request #791: btshell: Add command to unpair the oldest device URL: https://github.com/apache/mynewt-nimble/pull/791 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [mynewt-nimble] h2zero commented on issue #788: nimble/store: `ble_gap_unpair_oldest_peer` in `ble_store_util_status_rr`(store callback) can cause infinite loop for CCCDs

2020-04-06 Thread GitBox
h2zero commented on issue #788: nimble/store: `ble_gap_unpair_oldest_peer` in `ble_store_util_status_rr`(store callback) can cause infinite loop for CCCDs URL: https://github.com/apache/mynewt-nimble/issues/788#issuecomment-609818788 Yes, you are correct. It was just a quick patch to get by

[GitHub] [mynewt-nimble] h2zero edited a comment on issue #788: nimble/store: `ble_gap_unpair_oldest_peer` in `ble_store_util_status_rr`(store callback) can cause infinite loop for CCCDs

2020-04-06 Thread GitBox
h2zero edited a comment on issue #788: nimble/store: `ble_gap_unpair_oldest_peer` in `ble_store_util_status_rr`(store callback) can cause infinite loop for CCCDs URL: https://github.com/apache/mynewt-nimble/issues/788#issuecomment-609818788 @prasad-alatkar Yes, you are correct. It was just

[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-04-06 Thread GitBox
rymanluk commented on a change in pull request #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit URL: https://github.com/apache/mynewt-nimble/pull/790#discussion_r404129458 ## File path: nimble/host/src/ble_store_util.c ## @@ -230,16 +315

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #791: btshell: Add command to unpair the oldest device

2020-04-06 Thread GitBox
apache-mynewt-bot commented on issue #791: btshell: Add command to unpair the oldest device URL: https://github.com/apache/mynewt-nimble/pull/791#issuecomment-609831897 ## Style check summary No suggestions at this time! -

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2252: [RFC] I2S API and driver for STM32 MCUs

2020-04-06 Thread GitBox
apache-mynewt-bot commented on issue #2252: [RFC] I2S API and driver for STM32 MCUs URL: https://github.com/apache/mynewt-core/pull/2252#issuecomment-609856939 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2252: [RFC] I2S API and driver for STM32 MCUs

2020-04-06 Thread GitBox
apache-mynewt-bot removed a comment on issue #2252: [RFC] I2S API and driver for STM32 MCUs URL: https://github.com/apache/mynewt-core/pull/2252#issuecomment-606714969 ## Style check summary No suggestions at this time! --

[GitHub] [mynewt-nimble] rymanluk merged pull request #791: btshell: Add command to unpair the oldest device

2020-04-06 Thread GitBox
rymanluk merged pull request #791: btshell: Add command to unpair the oldest device URL: https://github.com/apache/mynewt-nimble/pull/791 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [mynewt-nimble] rymanluk opened a new pull request #792: nimble/host: Improve find conn by ble_addr_t

2020-04-06 Thread GitBox
rymanluk opened a new pull request #792: nimble/host: Improve find conn by ble_addr_t URL: https://github.com/apache/mynewt-nimble/pull/792 This function compares ble_addr_t and the problems starts when type 0x02 or 0x03 is used in conn Usually it is user who should take care abou

[GitHub] [mynewt-core] nkaje opened a new pull request #2262: do not merge: da1469x otp and serial script enhancements

2020-04-06 Thread GitBox
nkaje opened a new pull request #2262: do not merge: da1469x otp and serial script enhancements URL: https://github.com/apache/mynewt-core/pull/2262 This PR provides script enhancements to 1. da146x_serial.py: Makes the reset script optional. Use manual reset method or script to en

<    3   4   5   6   7   8   9   10   11   12   >