[jira] [Commented] (NETBEANS-2082) Scroll to the caret position when code fold feature is run

2020-05-18 Thread Alexandar Popov (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110868#comment-17110868
 ] 

Alexandar Popov commented on NETBEANS-2082:
---

Thank you! It seems that the fix works fine. You've made my day!

> Scroll to the caret position when code fold feature is run
> --
>
> Key: NETBEANS-2082
> URL: https://issues.apache.org/jira/browse/NETBEANS-2082
> Project: NetBeans
>  Issue Type: Bug
>  Components: editor - Code folding
>Affects Versions: 10.0, 11.0, 11.1, 11.2
> Environment: Netbeans 11 with OpenJDK 12. 
> Darwin MacBook-Pro-2.local 18.5.0 Darwin Kernel Version 18.5.0: Mon Mar 11 
> 20:40:32 PDT 2019; root:xnu-4903.251.3~3/RELEASE_X86_64 x86_64
> Netbeans 10 with OpenJDK 11.
> Darwin MacBook-Pro-2.local 18.2.0 Darwin Kernel Version 18.2.0: Thu Dec 20 
> 20:46:53 PST 2018; root:xnu-4903.241.1~1/RELEASE_X86_64 x86_64
>Reporter: Pier Luigi
>Assignee: Svatopluk Dedic
>Priority: Critical
> Fix For: 12.0
>
> Attachments: DemoPHPCodeFoldingProblem_NB11.php, NETBEANS-2082.zip, 
> netbeans-2082.gif
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Collapsing a block often results in a jump of the editor to an incorrect 
> editing position (and scrolling the page cause a rejump to that position 
> after a second of scroll inactivity).
> The same sources works perfectly with Netbeans 8.2.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-4348) No errors for required arguments

2020-05-18 Thread Los Vitaly (Jira)
Los Vitaly created NETBEANS-4348:


 Summary: No errors for required arguments
 Key: NETBEANS-4348
 URL: https://issues.apache.org/jira/browse/NETBEANS-4348
 Project: NetBeans
  Issue Type: Bug
  Components: php - Code
Affects Versions: 11.3
Reporter: Los Vitaly
 Attachments: Screenshot from 2020-05-18 23-05-08.png

When I try to create object from class Test, I receive fatal error, 

 Fatal error: Uncaught ArgumentCountError: Too few arguments to function 
Test::__construct(), 0 passed in  

ArgumentCountError: Too few arguments to function Test::__construct(), 0 passed 
in 

but I get no warning from Netbeans



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans] branch cnd created (now c9dfd42)

2020-05-18 Thread jlahoda
This is an automated email from the ASF dual-hosted git repository.

jlahoda pushed a change to branch cnd
in repository https://gitbox.apache.org/repos/asf/netbeans.git.


  at c9dfd42  Merge pull request #2134 from jlahoda/NETBEANS-4259

No new revisions were added by this update.


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-2464) Netbeans 8.2's C/C++ Plugin Install Error Timeout for Loading Module

2020-05-18 Thread Greg Lewis (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110567#comment-17110567
 ] 

Greg Lewis commented on NETBEANS-2464:
--

Just tried with NB 11.3:

Product Version: Apache NetBeans IDE 11.3
Updates: Updates available to version NetBeans 8.2 Patch 2
Java: 14; OpenJDK 64-Bit Server VM 14+36-1461
Runtime: OpenJDK Runtime Environment 14+36-1461
System: Linux version 5.6.12-300.fc32.x86_64 running on amd64; UTF-8; en_US (nb)
User directory: /home/greg/.netbeans/11.3
Cache directory: /home/greg/.cache/netbeans/11.

 

This looks like a timeout accessing a rest service on org.netbeans site, not a 
net-beans version problem per-se.

> Netbeans 8.2's C/C++ Plugin Install Error Timeout for Loading Module
> 
>
> Key: NETBEANS-2464
> URL: https://issues.apache.org/jira/browse/NETBEANS-2464
> Project: NetBeans
>  Issue Type: Bug
>  Components: utilities - Code
>Affects Versions: 11.0
> Environment: openSUSE Linux 15.0, KDE 5, OpenJDK 10 running on Intel 
> Core i5 750 at 2.67 GHz + 8 GB of RAM + AMD Radeon RX 580.
>Reporter: giu.gr
>Priority: Major
> Fix For: 10.0
>
>
> Installing C/C++ plugin does get interrupted throwing an exception.
>  
> {code:java}
> INFO [org.netbeans.modules.autoupdate.services.InstallSupportImpl]: Timeout 
> waiting for loading module org.netbeans.modules.cnd.api.remote@1.29.5.1
> INFO [org.netbeans.modules.autoupdate.ui.wizards.InstallStep]: timeout of 
> loading C/C++ Remote Development 
> API[org.netbeans.modules.cnd.api.remote/1.29.5.1]
> org.netbeans.api.autoupdate.OperationException[INSTALL]: timeout of loading 
> C/C++ Remote Development API[org.netbeans.modules.cnd.api.remote/1.29.5.1]
>     at 
> org.netbeans.modules.autoupdate.services.InstallSupportImpl$3.call(InstallSupportImpl.java:429)
>     at 
> org.netbeans.modules.autoupdate.services.InstallSupportImpl$3.call(InstallSupportImpl.java:289)
>     at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
>     at 
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1135)
>     at 
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
> {code}
>  
> Netbeans 8.2's C/C++ plugin used to work in Netbeans 10.0.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-3898) ModuleList.doScanNetBeansOrgSources descends into .git/.hg

2020-05-18 Thread Svatopluk Dedic (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110405#comment-17110405
 ] 

Svatopluk Dedic commented on NETBEANS-3898:
---

I'd say leave out all leading dots.

> ModuleList.doScanNetBeansOrgSources descends into .git/.hg
> --
>
> Key: NETBEANS-3898
> URL: https://issues.apache.org/jira/browse/NETBEANS-3898
> Project: NetBeans
>  Issue Type: Bug
>  Components: apisupport - Project
>Reporter: Ernie Rael
>Priority: Minor
>  Labels: performance
>
>  
> org.netbeans.modules.apisupport.project.universe.ModuleList.doScanNetBeansOrgSources
>  produces LOG entries like: 
> {quote}INFO...: exhaustive scan of F:\repos\netbeans\.hg\cache
>  INFO...: exhaustive scan of F:\repos\netbeans\.hg\git
>  ...
> {quote}
> Which come because of stuff after the following code, ("kids" is directories 
> in /netebeans)
> {code:java}
> for (File kid : kids) {
> if (!kid.isDirectory()) {
> continue;
> }
> String name = kid.getName();
> if (EXCLUDED_DIR_NAMES.contains(name)) {
> // #61579: known to not be project dirs, so skip to save time.
> continue;
> }
> {code}
> Can save even more time by staying out of the repo data. Two possible 
> solutions
>  * Add ".git" and ".hg" to EXCLUDED_DIR_NAMES
>  * Skip anything that starts with "."
> Comments? I'm inclined towards the second, skip anything that's hidden.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Resolved] (NETBEANS-3733) Cannot test single method with Maven and Junit 5

2020-05-18 Thread Svatopluk Dedic (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Svatopluk Dedic resolved NETBEANS-3733.
---
Fix Version/s: 12.0
   Resolution: Fixed

> Cannot test single method with Maven and Junit 5
> 
>
> Key: NETBEANS-3733
> URL: https://issues.apache.org/jira/browse/NETBEANS-3733
> Project: NetBeans
>  Issue Type: Bug
>  Components: java - JUnit, projects - Maven
>Affects Versions: 11.1, 11.2, 11.3
>Reporter: Bernard
>Assignee: Svatopluk Dedic
>Priority: Critical
> Fix For: 12.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> All defaults, hello world application as simple as possible.
> How to reproduce:
> Menu|File|New Project|Java with Maven|Java Application|Finish
> Projects|New|java Class|NewClass|Finish
> Add two methods:
> public void hello1() {
>  System.out.println("Hello 1");
>  }
>  
>  public void hello2() {
>  System.out.println("Hello 2");
>  }
> [Ctrl+Shift+U] Create / Update Tests|JUnit|OK
> generates test as expected, adds dependencies to POM as expected:
> 
>  
>  org.junit.jupiter
>  junit-jupiter-api
>  5.3.1
>  test
>  
>  
>  org.junit.jupiter
>  junit-jupiter-params
>  5.3.1
>  test
>  
>  
>  org.junit.jupiter
>  junit-jupiter-engine
>  5.3.1
>  test
>  
>  
> In generated class NewClassTest now I want to test the single method 
> "testHello2()"
> So I put cursor on it and right click, "Run Focused Test Method".
> I get a dialog:
> "Feature requires update of POM"
> "Executing single test method requires Surefire 2.8+ and JUnit in version 4.8 
> and bigger.
> Update your pom.xml?"
> I click "Yes"
> In pom.xml, another dependecy is added:
> 
>  junit
>  junit
>  4.11
>  
> Si I try again. Put cursor on the method and right click, "Run Focused Test 
> Method".
> I get a message
> "No tests executed for mavenproject1"
> This means that I cannot use the default way of NetBeans to quickly create a 
> class and test it.
> This reproduces with all only defaults selected such as Java Maven project, 
> as simple as it can get. This has worked for about 10 years until it was 
> broken with JUnit 5.
> How can we select JUnit 4 until this is mature?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Resolved] (NETBEANS-2082) Scroll to the caret position when code fold feature is run

2020-05-18 Thread Svatopluk Dedic (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Svatopluk Dedic resolved NETBEANS-2082.
---
Fix Version/s: 12.0
   Resolution: Fixed

> Scroll to the caret position when code fold feature is run
> --
>
> Key: NETBEANS-2082
> URL: https://issues.apache.org/jira/browse/NETBEANS-2082
> Project: NetBeans
>  Issue Type: Bug
>  Components: editor - Code folding
>Affects Versions: 10.0, 11.0, 11.1, 11.2
> Environment: Netbeans 11 with OpenJDK 12. 
> Darwin MacBook-Pro-2.local 18.5.0 Darwin Kernel Version 18.5.0: Mon Mar 11 
> 20:40:32 PDT 2019; root:xnu-4903.251.3~3/RELEASE_X86_64 x86_64
> Netbeans 10 with OpenJDK 11.
> Darwin MacBook-Pro-2.local 18.2.0 Darwin Kernel Version 18.2.0: Thu Dec 20 
> 20:46:53 PST 2018; root:xnu-4903.241.1~1/RELEASE_X86_64 x86_64
>Reporter: Pier Luigi
>Assignee: Svatopluk Dedic
>Priority: Critical
> Fix For: 12.0
>
> Attachments: DemoPHPCodeFoldingProblem_NB11.php, NETBEANS-2082.zip, 
> netbeans-2082.gif
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Collapsing a block often results in a jump of the editor to an incorrect 
> editing position (and scrolling the page cause a rejump to that position 
> after a second of scroll inactivity).
> The same sources works perfectly with Netbeans 8.2.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans] branch master updated: NETBEANS-2082: do not scroll to caret after fold collapse, if caret is off-screen.

2020-05-18 Thread skygo
This is an automated email from the ASF dual-hosted git repository.

skygo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git


The following commit(s) were added to refs/heads/master by this push:
 new 150a06b  NETBEANS-2082: do not scroll to caret after fold collapse, if 
caret is off-screen.
 new 563a638  Merge pull request #2139 from sdedic/bugfix/NETBEANS-2082
150a06b is described below

commit 150a06b191e5f84666080b0168517c30c6b85a61
Author: Svata Dedic 
AuthorDate: Fri May 15 16:23:12 2020 +0200

NETBEANS-2082: do not scroll to caret after fold collapse, if caret is 
off-screen.
---
 .../modules/editor/fold/ui/FoldViewFactory.java| 35 --
 .../org/netbeans/api/editor/caret/EditorCaret.java | 12 
 2 files changed, 32 insertions(+), 15 deletions(-)

diff --git 
a/ide/editor.fold.nbui/src/org/netbeans/modules/editor/fold/ui/FoldViewFactory.java
 
b/ide/editor.fold.nbui/src/org/netbeans/modules/editor/fold/ui/FoldViewFactory.java
index 1c91044..c729e3e 100644
--- 
a/ide/editor.fold.nbui/src/org/netbeans/modules/editor/fold/ui/FoldViewFactory.java
+++ 
b/ide/editor.fold.nbui/src/org/netbeans/modules/editor/fold/ui/FoldViewFactory.java
@@ -260,24 +260,25 @@ public final class FoldViewFactory extends 
EditorViewFactory implements FoldHier
 
 @Override
 public void foldHierarchyChanged(FoldHierarchyEvent evt) {
-if (!collapsedFoldEncountered) {
-// Check if any collapsed fold was added or a collapsed/expanded 
state changed
-for (int i = evt.getAddedFoldCount() - 1; i >= 0; i--) {
-if (evt.getAddedFold(i).isCollapsed()) {
-collapsedFoldEncountered = true;
-break;
-}
+boolean collapsedAdded = false;
+boolean changedToCollapsed = false;
+// Check if any collapsed fold was added or a collapsed/expanded state 
changed
+for (int i = evt.getAddedFoldCount() - 1; i >= 0; i--) {
+if (evt.getAddedFold(i).isCollapsed()) {
+collapsedAdded = true;
+break;
 }
-if (!collapsedFoldEncountered) {
-for (int i = evt.getFoldStateChangeCount() - 1; i >= 0; i--) {
-FoldStateChange foldStateChange = 
evt.getFoldStateChange(i);
-if (foldStateChange.isCollapsedChanged() && 
foldStateChange.getFold().isCollapsed()) {
-collapsedFoldEncountered = true;
-break;
-}
+}
+if (!collapsedAdded) {
+for (int i = evt.getFoldStateChangeCount() - 1; i >= 0; i--) {
+FoldStateChange foldStateChange = evt.getFoldStateChange(i);
+if (foldStateChange.isCollapsedChanged() && 
foldStateChange.getFold().isCollapsed()) {
+changedToCollapsed = true;
+break;
 }
 }
 }
+collapsedFoldEncountered |= collapsedAdded || changedToCollapsed;
 JTextComponent comp = textComponent();
 if (collapsedFoldEncountered && comp != null) {
 // [TODO] there could be more detailed inspection done among folds
@@ -289,7 +290,11 @@ public final class FoldViewFactory extends 
EditorViewFactory implements FoldHier
 ViewUtils.log(CHANGE_LOG, "CHANGE in FoldViewFactory: <" + // 
NOI18N
 startOffset + "," + endOffset + ">\n"); // NOI18N
 }
-comp.putClientProperty("editorcaret.updateRetainsVisibleOnce", 
Boolean.TRUE);
+if (collapsedAdded) {
+// this hint covers a specific case when a fold is created as 
*initially* collapsed
+// to maintain caret position on screen, if the caret was 
visible. 
+comp.putClientProperty("editorcaret.updateRetainsVisibleOnce", 
Boolean.TRUE);
+}
 fireEvent(EditorViewFactoryChange.createList(startOffset, 
endOffset,
 EditorViewFactoryChange.Type.PARAGRAPH_CHANGE));
 }
diff --git a/ide/editor.lib2/src/org/netbeans/api/editor/caret/EditorCaret.java 
b/ide/editor.lib2/src/org/netbeans/api/editor/caret/EditorCaret.java
index 76a9cd9d..926c5e3 100644
--- a/ide/editor.lib2/src/org/netbeans/api/editor/caret/EditorCaret.java
+++ b/ide/editor.lib2/src/org/netbeans/api/editor/caret/EditorCaret.java
@@ -1999,6 +1999,9 @@ public final class EditorCaret implements Caret {
 if (cbounds != null) {
 // save relative position of the main caret
 maybeSaveCaretOffset(cbounds);
+if (log) {
+LOG.fine("EditorCaret.update: forced:true, 
savedBounds=" + cbounds + ", relativeOffset=" + lastCaretVisualOffset + "\n"); 
// NOI18N
+}
 }
 }
 if (!calledFromPaint && 

[netbeans] branch master updated: [NETBEANS-4259] Preventing crash in code completion for a lambda expression stub.

2020-05-18 Thread skygo
This is an automated email from the ASF dual-hosted git repository.

skygo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git


The following commit(s) were added to refs/heads/master by this push:
 new fcc6083  [NETBEANS-4259] Preventing crash in code completion for a 
lambda expression stub.
 new c9dfd42  Merge pull request #2134 from jlahoda/NETBEANS-4259
fcc6083 is described below

commit fcc608362fa5148ce7e6a9fb1fac4156e5beda89
Author: Jan Lahoda 
AuthorDate: Mon May 11 22:33:30 2020 +0200

[NETBEANS-4259] Preventing crash in code completion for a lambda expression 
stub.
---
 .../src/org/netbeans/modules/java/completion/BaseTask.java| 3 +++
 .../modules/java/completion/JavaCompletionTask18FeaturesTest.java | 4 
 2 files changed, 7 insertions(+)

diff --git 
a/java/java.completion/src/org/netbeans/modules/java/completion/BaseTask.java 
b/java/java.completion/src/org/netbeans/modules/java/completion/BaseTask.java
index 7be3a9f..74994da 100644
--- 
a/java/java.completion/src/org/netbeans/modules/java/completion/BaseTask.java
+++ 
b/java/java.completion/src/org/netbeans/modules/java/completion/BaseTask.java
@@ -386,6 +386,9 @@ abstract class BaseTask extends UserTask {
 }
 sourcePositions = new SourcePositionsImpl(block, 
sourcePositions, sp[0], blockPos, -1);
 path = 
tu.getPathElementOfKind(Tree.Kind.LAMBDA_EXPRESSION, tu.pathFor(new 
TreePath(blockPath.getParentPath(), block), offset, sourcePositions));
+if (path == null) {
+return null;
+}
 lambdaBody = ((LambdaExpressionTree) 
path.getLeaf()).getBody();
 bodyPos = (int) sourcePositions.getStartPosition(root, 
lambdaBody);
 if (bodyPos >= offset) {
diff --git 
a/java/java.completion/test/unit/src/org/netbeans/modules/java/completion/JavaCompletionTask18FeaturesTest.java
 
b/java/java.completion/test/unit/src/org/netbeans/modules/java/completion/JavaCompletionTask18FeaturesTest.java
index 98f5b18..b8cda0c 100644
--- 
a/java/java.completion/test/unit/src/org/netbeans/modules/java/completion/JavaCompletionTask18FeaturesTest.java
+++ 
b/java/java.completion/test/unit/src/org/netbeans/modules/java/completion/JavaCompletionTask18FeaturesTest.java
@@ -338,6 +338,10 @@ public class JavaCompletionTask18FeaturesTest extends 
CompletionTestBase {
 performTest("LambdaExpressionOutsideMethodBody", 959, null, 
"lambdaOutsideMethodBodyContent.pass", "1.8");
 }
 
+public void testNETBEANS_4259() throws Exception {
+performTest("LambdaExpression", 986, "return (String s", 
"stringVarName.pass", "1.8");
+}
+
 static {
 JavacParser.DISABLE_SOURCE_LEVEL_DOWNGRADE = true;
 }


-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-4347) HSL is not working on CSS file

2020-05-18 Thread Victor Pineda (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Victor Pineda updated NETBEANS-4347:

Description: 
When I tried to work with HSL values for color in CSS editor, this is not 
recognized and shows an error on editor 

  !css_error_hsl.jpg!

  was:
When I tried to work with HSL values for color in CSS editor, this is not 
recognized and shows an error on editor !css_error_hsl.png!

 


> HSL is not working on CSS file
> --
>
> Key: NETBEANS-4347
> URL: https://issues.apache.org/jira/browse/NETBEANS-4347
> Project: NetBeans
>  Issue Type: Bug
>  Components: web - CSS Editor
>Affects Versions: 11.3
>Reporter: Victor Pineda
>Priority: Minor
>  Labels: color, css, hsl
> Attachments: css_error_hsl.jpg
>
>
> When I tried to work with HSL values for color in CSS editor, this is not 
> recognized and shows an error on editor 
>   !css_error_hsl.jpg!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Updated] (NETBEANS-4347) HSL is not working on CSS file

2020-05-18 Thread Victor Pineda (Jira)


 [ 
https://issues.apache.org/jira/browse/NETBEANS-4347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Victor Pineda updated NETBEANS-4347:

Attachment: css_error_hsl.jpg

> HSL is not working on CSS file
> --
>
> Key: NETBEANS-4347
> URL: https://issues.apache.org/jira/browse/NETBEANS-4347
> Project: NetBeans
>  Issue Type: Bug
>  Components: web - CSS Editor
>Affects Versions: 11.3
>Reporter: Victor Pineda
>Priority: Minor
>  Labels: color, css, hsl
> Attachments: css_error_hsl.jpg
>
>
> When I tried to work with HSL values for color in CSS editor, this is not 
> recognized and shows an error on editor !css_error_hsl.png!
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Created] (NETBEANS-4347) HSL is not working on CSS file

2020-05-18 Thread Victor Pineda (Jira)
Victor Pineda created NETBEANS-4347:
---

 Summary: HSL is not working on CSS file
 Key: NETBEANS-4347
 URL: https://issues.apache.org/jira/browse/NETBEANS-4347
 Project: NetBeans
  Issue Type: Bug
  Components: web - CSS Editor
Affects Versions: 11.3
Reporter: Victor Pineda


When I tried to work with HSL values for color in CSS editor, this is not 
recognized and shows an error on editor !css_error_hsl.png!

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-2470) Better support for build-helper-maven-plugin plugin - sources added via "add-test-source" cannot be refactored AND add-test-resource is not supported

2020-05-18 Thread Pavel_K (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110209#comment-17110209
 ] 

Pavel_K commented on NETBEANS-2470:
---

[~fers3485] If you have no time, maybe it is necessary to assign this issue to 
someone else?

>  Better support for build-helper-maven-plugin plugin - sources added via 
> "add-test-source" cannot be refactored AND add-test-resource is not supported
> --
>
> Key: NETBEANS-2470
> URL: https://issues.apache.org/jira/browse/NETBEANS-2470
> Project: NetBeans
>  Issue Type: Improvement
>  Components: apisupport - Maven
>Affects Versions: 8.2, 9.0, 10.0, 11.0
> Environment: Product Version: Apache NetBeans IDE 11.0 (Build 
> incubator-netbeans-release-404-on-20190319)
> Java: 1.8.0_201; Java HotSpot(TM) 64-Bit Server VM 25.201-b09
> Runtime: Java(TM) SE Runtime Environment 1.8.0_201-b09
> System: Windows 10 version 10.0 running on amd64; Cp1252; en_US (nb)
>Reporter: Arnaud Bourrée
>Assignee: ANTONIO FERRER GONZALEZ
>Priority: Major
>
> Old issue https://netbeans.org/bugzilla/show_bug.cgi?id=231240
> When we separate integration tests from unit tests in different folders as 
> suggested 
> [here|https://cwiki.apache.org/confluence/display/MAVENOLD/best+practices+-+testing+strategies]
>  
> We need build-helper-maven-plugin with the following configuration:
> {{
> add-test-source
> 
> add-test-source
> 
> 
> 
> src/it/java
> src/it/resources
> 
> 
> 
> }}
> Many IDEs support second test folder, NetBeans show it as Generated folder: 
> "Generated Test Sources (java)"/ "Generated Test Sourced (resources)" nodes 
> in the project tree.
> And yes you cannot do any refactoring (Move/Copy/Refactoring hints) in 
> classes below those nodes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Comment Edited] (NETBEANS-2470) Better support for build-helper-maven-plugin plugin - sources added via "add-test-source" cannot be refactored AND add-test-resource is not supported

2020-05-18 Thread Pavel_K (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110205#comment-17110205
 ] 

Pavel_K edited comment on NETBEANS-2470 at 5/18/20, 12:10 PM:
--

I totally agree with the reporter. I use NB 11.3 and can say that it is not 
possible to work in `/src/it/java` - it even doesn't automatically fix imports. 
Another problem, when you try to create file (for example class) somewhere in 
`/src/it/java` it is created somewhere in `/src/main/java`.


was (Author: pavel_k):
I totally agree with the reporter. I use NB 11.3 and can say that it is not 
possible to work in `/src/it/java` - it event doesn't automatically fix 
imports. Another problem, when you try to create file (for example class) 
somewhere in `/src/it/java` it is created somewhere in `/src/main/java`.

>  Better support for build-helper-maven-plugin plugin - sources added via 
> "add-test-source" cannot be refactored AND add-test-resource is not supported
> --
>
> Key: NETBEANS-2470
> URL: https://issues.apache.org/jira/browse/NETBEANS-2470
> Project: NetBeans
>  Issue Type: Improvement
>  Components: apisupport - Maven
>Affects Versions: 8.2, 9.0, 10.0, 11.0
> Environment: Product Version: Apache NetBeans IDE 11.0 (Build 
> incubator-netbeans-release-404-on-20190319)
> Java: 1.8.0_201; Java HotSpot(TM) 64-Bit Server VM 25.201-b09
> Runtime: Java(TM) SE Runtime Environment 1.8.0_201-b09
> System: Windows 10 version 10.0 running on amd64; Cp1252; en_US (nb)
>Reporter: Arnaud Bourrée
>Assignee: ANTONIO FERRER GONZALEZ
>Priority: Major
>
> Old issue https://netbeans.org/bugzilla/show_bug.cgi?id=231240
> When we separate integration tests from unit tests in different folders as 
> suggested 
> [here|https://cwiki.apache.org/confluence/display/MAVENOLD/best+practices+-+testing+strategies]
>  
> We need build-helper-maven-plugin with the following configuration:
> {{
> add-test-source
> 
> add-test-source
> 
> 
> 
> src/it/java
> src/it/resources
> 
> 
> 
> }}
> Many IDEs support second test folder, NetBeans show it as Generated folder: 
> "Generated Test Sources (java)"/ "Generated Test Sourced (resources)" nodes 
> in the project tree.
> And yes you cannot do any refactoring (Move/Copy/Refactoring hints) in 
> classes below those nodes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[jira] [Commented] (NETBEANS-2470) Better support for build-helper-maven-plugin plugin - sources added via "add-test-source" cannot be refactored AND add-test-resource is not supported

2020-05-18 Thread Pavel_K (Jira)


[ 
https://issues.apache.org/jira/browse/NETBEANS-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110205#comment-17110205
 ] 

Pavel_K commented on NETBEANS-2470:
---

I totally agree with the reporter. I use NB 11.3 and can say that it is not 
possible to work in `/src/it/java` - it event doesn't automatically fix 
imports. Another problem, when you try to create file (for example class) 
somewhere in `/src/it/java` it is created somewhere in `/src/main/java`.

>  Better support for build-helper-maven-plugin plugin - sources added via 
> "add-test-source" cannot be refactored AND add-test-resource is not supported
> --
>
> Key: NETBEANS-2470
> URL: https://issues.apache.org/jira/browse/NETBEANS-2470
> Project: NetBeans
>  Issue Type: Improvement
>  Components: apisupport - Maven
>Affects Versions: 8.2, 9.0, 10.0, 11.0
> Environment: Product Version: Apache NetBeans IDE 11.0 (Build 
> incubator-netbeans-release-404-on-20190319)
> Java: 1.8.0_201; Java HotSpot(TM) 64-Bit Server VM 25.201-b09
> Runtime: Java(TM) SE Runtime Environment 1.8.0_201-b09
> System: Windows 10 version 10.0 running on amd64; Cp1252; en_US (nb)
>Reporter: Arnaud Bourrée
>Assignee: ANTONIO FERRER GONZALEZ
>Priority: Major
>
> Old issue https://netbeans.org/bugzilla/show_bug.cgi?id=231240
> When we separate integration tests from unit tests in different folders as 
> suggested 
> [here|https://cwiki.apache.org/confluence/display/MAVENOLD/best+practices+-+testing+strategies]
>  
> We need build-helper-maven-plugin with the following configuration:
> {{
> add-test-source
> 
> add-test-source
> 
> 
> 
> src/it/java
> src/it/resources
> 
> 
> 
> }}
> Many IDEs support second test folder, NetBeans show it as Generated folder: 
> "Generated Test Sources (java)"/ "Generated Test Sourced (resources)" nodes 
> in the project tree.
> And yes you cannot do any refactoring (Move/Copy/Refactoring hints) in 
> classes below those nodes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[netbeans] branch master updated: [NETBEANS-3733] Suggest surefire 2.22 for JUnit5 tests.

2020-05-18 Thread sdedic
This is an automated email from the ASF dual-hosted git repository.

sdedic pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git


The following commit(s) were added to refs/heads/master by this push:
 new 78778ee  [NETBEANS-3733] Suggest surefire 2.22 for JUnit5 tests.
 new cd600b0  Merge pull request #2144 from 
sdedic/bugfix/NETBEANS-3733_surefire-junit5
78778ee is described below

commit 78778ee66febfb65da6e9e1f1f3c19b48581bb6f
Author: Svata Dedic 
AuthorDate: Sun May 17 10:17:48 2020 +0200

[NETBEANS-3733] Suggest surefire 2.22 for JUnit5 tests.
---
 .../netbeans/modules/maven/ActionProviderImpl.java | 29 +++---
 1 file changed, 25 insertions(+), 4 deletions(-)

diff --git a/java/maven/src/org/netbeans/modules/maven/ActionProviderImpl.java 
b/java/maven/src/org/netbeans/modules/maven/ActionProviderImpl.java
index a3aac55..a9dd035 100644
--- a/java/maven/src/org/netbeans/modules/maven/ActionProviderImpl.java
+++ b/java/maven/src/org/netbeans/modules/maven/ActionProviderImpl.java
@@ -211,6 +211,8 @@ public class ActionProviderImpl implements ActionProvider {
 
 //TODO these effectively need updating once in a while
 private static final String SUREFIRE_VERSION_SAFE = "2.15"; //2.16 is 
broken
+// surefire 2.22 is needed for JUnit 5
+private static final String SUREFIRE_VERSION_SAFE_5 = "2.22.0";
 private static final String JUNIT_VERSION_SAFE = "4.11";
 
 @Override public void invokeAction(final String action, final Lookup 
lookup) {
@@ -288,14 +290,17 @@ public class ActionProviderImpl implements ActionProvider 
{
 
 @Messages({
 "run_single_method_disabled=Surefire 2.8+ with JUnit 4.8+ or TestNG 
needed to run a single test method.",
+"run_single_method_disabled5=Surefire 2.22.0 is required to run a 
single test method with JUnit5.",
 "TIT_RequiresUpdateOfPOM=Feature requires update of POM",
-"TXT_Run_Single_method=Executing single test method requires 
Surefire 2.8+ and JUnit in version 4.8 and bigger. Update your 
pom.xml?"
+"TXT_Run_Single_method=Executing single test method requires 
Surefire 2.8+ and JUnit in version 4.8 and bigger. Update your 
pom.xml?",
+"TXT_Run_Single_method5=Executing single test method with JUnit 
5 requires Surefire 2.22.0. Update your pom.xml?"
 })
 private boolean checkSurefire(final String action) {
 if (action.equals(SingleMethod.COMMAND_RUN_SINGLE_METHOD) || 
action.equals(SingleMethod.COMMAND_DEBUG_SINGLE_METHOD)) {
 if (!runSingleMethodEnabled()) {
+boolean ju5 = usingJUnit5();
 if 
(NbPreferences.forModule(ActionProviderImpl.class).getBoolean(SHOW_SUREFIRE_WARNING,
 true)) {
-WarnPanel pnl = new WarnPanel(TXT_Run_Single_method());
+WarnPanel pnl = new WarnPanel(ju5 ? 
TXT_Run_Single_method5() : TXT_Run_Single_method());
 Object o = DialogDisplayer.getDefault().notify(new 
NotifyDescriptor.Confirmation(pnl, TIT_RequiresUpdateOfPOM(), 
NotifyDescriptor.YES_NO_OPTION));
 if (pnl.disabledWarning()) {
 
NbPreferences.forModule(ActionProviderImpl.class).putBoolean(SHOW_SUREFIRE_WARNING,
 false);
@@ -304,9 +309,24 @@ public class ActionProviderImpl implements ActionProvider {
 RequestProcessor.getDefault().post(new Runnable() {
 @Override
 public void run() {
+String surefireVersion = null;
+String junitVersion = null;
+
+if (ju5 && !usingSurefire2_22()) {
+surefireVersion = SUREFIRE_VERSION_SAFE_5;
+} else if (!usingSurefire28()) {
+surefireVersion = SUREFIRE_VERSION_SAFE;
+}
+if (!ju5) {
+junitVersion = usingJUnit4() || 
usingTestNG() ? null : JUNIT_VERSION_SAFE;
+}
+
 Utilities.performPOMModelOperations(
 
proj.getProjectDirectory().getFileObject("pom.xml"),
-Collections.singletonList(new 
UpdateSurefireOperation(usingSurefire28() ? null : SUREFIRE_VERSION_SAFE, 
usingJUnit4() || usingTestNG() ? null : JUNIT_VERSION_SAFE)));
+Collections.singletonList(new 
UpdateSurefireOperation(
+surefireVersion, junitVersion
+))
+);
 //this appears to run too fast, before the 
resolved model is updated.

[jira] [Created] (NETBEANS-4346) Rename C++ class: Renames definition, header and source file automagically

2020-05-18 Thread Birger Skogeng Pedersen (Jira)
Birger Skogeng Pedersen created NETBEANS-4346:
-

 Summary: Rename C++ class: Renames definition, header and source 
file automagically
 Key: NETBEANS-4346
 URL: https://issues.apache.org/jira/browse/NETBEANS-4346
 Project: NetBeans
  Issue Type: New Feature
  Components: cnd - Editor, cnd - Project
Reporter: Birger Skogeng Pedersen


It would be really neat if renaming a C++ class also renames:
 * the header file,
 * header guards (if any) and
 * source file



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists