[jira] [Commented] (NETBEANS-4696) NetBeans 12.1-beta1 sometimes hangs on open
[ https://issues.apache.org/jira/browse/NETBEANS-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202614#comment-17202614 ] Glenn Holmer commented on NETBEANS-4696: Since I didn't have a repeatable repro case and it didn't happen often, I can't definitely say it's resolved. All I can say is that I haven't seen it happen since I've been using dailies with Ernie's fix. Thanks, Ernie! > NetBeans 12.1-beta1 sometimes hangs on open > --- > > Key: NETBEANS-4696 > URL: https://issues.apache.org/jira/browse/NETBEANS-4696 > Project: NetBeans > Issue Type: Bug > Components: ide - Performance >Affects Versions: 12.1 > Environment: Linux (Debian "Buster") > OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10) >Reporter: Glenn Holmer >Priority: Blocker > Labels: deadlock, pull-requests-available > Fix For: 12.1 > > Attachments: 12.1-vc1-thread-dump-orac.txt, > nb12.1-beta1-thread-dump.png, nb12.1-beta1-thread-dump.txt, > netbeans-12.1-thread-dump.txt > > Time Spent: 1h 10m > Remaining Estimate: 0h > > > NetBeans sometimes hangs on startup; the symptom is a stalled "Opening > Projects" progress bar. I haven't been able to find a repro case, but I'm > attaching a thread dump (from VisualVM) and screen shot. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4696) NetBeans 12.1-beta1 sometimes hangs on open
[ https://issues.apache.org/jira/browse/NETBEANS-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17196267#comment-17196267 ] Jeremy commented on NETBEANS-4696: -- [~errael] I downloaded the latest build - #53 [eba3ee243620628c58e7c69710d8b1b9642fc02c]. I have been testing all morning and the issue appears to be resolved for me. Thanks for all your hard work on this bug and the same to everyone else! > NetBeans 12.1-beta1 sometimes hangs on open > --- > > Key: NETBEANS-4696 > URL: https://issues.apache.org/jira/browse/NETBEANS-4696 > Project: NetBeans > Issue Type: Bug > Components: ide - Performance >Affects Versions: 12.1 > Environment: Linux (Debian "Buster") > OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10) >Reporter: Glenn Holmer >Priority: Blocker > Labels: deadlock, pull-requests-available > Attachments: 12.1-vc1-thread-dump-orac.txt, > nb12.1-beta1-thread-dump.png, nb12.1-beta1-thread-dump.txt, > netbeans-12.1-thread-dump.txt > > Time Spent: 1h 10m > Remaining Estimate: 0h > > > NetBeans sometimes hangs on startup; the symptom is a stalled "Opening > Projects" progress bar. I haven't been able to find a repro case, but I'm > attaching a thread dump (from VisualVM) and screen shot. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4696) NetBeans 12.1-beta1 sometimes hangs on open
[ https://issues.apache.org/jira/browse/NETBEANS-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17195566#comment-17195566 ] Glenn Holmer commented on NETBEANS-4696: I'll start using that build on a daily basis and report here if there's a problem. > NetBeans 12.1-beta1 sometimes hangs on open > --- > > Key: NETBEANS-4696 > URL: https://issues.apache.org/jira/browse/NETBEANS-4696 > Project: NetBeans > Issue Type: Bug > Components: ide - Performance >Affects Versions: 12.1 > Environment: Linux (Debian "Buster") > OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10) >Reporter: Glenn Holmer >Priority: Blocker > Labels: deadlock, pull-requests-available > Attachments: 12.1-vc1-thread-dump-orac.txt, > nb12.1-beta1-thread-dump.png, nb12.1-beta1-thread-dump.txt, > netbeans-12.1-thread-dump.txt > > Time Spent: 1h 10m > Remaining Estimate: 0h > > > NetBeans sometimes hangs on startup; the symptom is a stalled "Opening > Projects" progress bar. I haven't been able to find a repro case, but I'm > attaching a thread dump (from VisualVM) and screen shot. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4696) NetBeans 12.1-beta1 sometimes hangs on open
[ https://issues.apache.org/jira/browse/NETBEANS-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17195481#comment-17195481 ] Ernie Rael commented on NETBEANS-4696: -- The PRs to fix this were merged into master on Sep 9. So the daily builds should have these fixes. It's possible there are observable differences. If there are issues, the sooner the better... The as yet undocumented location of the build artifacts is [https://ci-builds.apache.org/job/Netbeans/job/netbeans-linux] With that starting point # Click "Last Successful Artifacts" or something in the "Build History" list on the left # Then traverse "nbbuild > NetBeans-dev-Netbeans # download netbeans-linux-...-release.zip This should run on windows as well as linux, AFAICT. > NetBeans 12.1-beta1 sometimes hangs on open > --- > > Key: NETBEANS-4696 > URL: https://issues.apache.org/jira/browse/NETBEANS-4696 > Project: NetBeans > Issue Type: Bug > Components: ide - Performance >Affects Versions: 12.1 > Environment: Linux (Debian "Buster") > OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10) >Reporter: Glenn Holmer >Priority: Blocker > Labels: deadlock, pull-requests-available > Attachments: 12.1-vc1-thread-dump-orac.txt, > nb12.1-beta1-thread-dump.png, nb12.1-beta1-thread-dump.txt, > netbeans-12.1-thread-dump.txt > > Time Spent: 1h 10m > Remaining Estimate: 0h > > > NetBeans sometimes hangs on startup; the symptom is a stalled "Opening > Projects" progress bar. I haven't been able to find a repro case, but I'm > attaching a thread dump (from VisualVM) and screen shot. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4696) NetBeans 12.1-beta1 sometimes hangs on open
[
https://issues.apache.org/jira/browse/NETBEANS-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190415#comment-17190415
]
Ernie Rael commented on NETBEANS-4696:
--
I went back and looked at removing the dependency from javascript2.knockout to
projectuiapi.base. I had left in
{code:java}
if (!OpenProjects.getDefault().openProjects().isDone()) {
return null;
}
{code}
I took that out (it was before QuerySupport stuff) and it made no difference.
The code is now
{code:java}
KnockoutIndex index = INDEXES.get(project);
if (index == null) {
Collection sourceRoots = QuerySupport.findRoots(project,
null /* all source roots */,
Collections.emptyList(),
Collections.emptyList());
QuerySupport querrySupport = QuerySupport.forRoots(
KnockoutIndexer.Factory.NAME,
KnockoutIndexer.Factory.VERSION,
sourceRoots.toArray(new FileObject[]{}));
index = new KnockoutIndex(querrySupport);
if (sourceRoots.size() > 0) {
INDEXES.put(project, index);
}
}
return index;
{code}
With the early return left out, until the project is open, sourceRoots.size()
is 0 until the open completes. Updating the PR to remove the dependency.
> NetBeans 12.1-beta1 sometimes hangs on open
> ---
>
> Key: NETBEANS-4696
> URL: https://issues.apache.org/jira/browse/NETBEANS-4696
> Project: NetBeans
> Issue Type: Bug
> Components: ide - Performance
>Affects Versions: 12.1
> Environment: Linux (Debian "Buster")
> OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10)
>Reporter: Glenn Holmer
>Priority: Blocker
> Labels: deadlock, pull-requests-available
> Attachments: 12.1-vc1-thread-dump-orac.txt,
> nb12.1-beta1-thread-dump.png, nb12.1-beta1-thread-dump.txt,
> netbeans-12.1-thread-dump.txt
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
>
> NetBeans sometimes hangs on startup; the symptom is a stalled "Opening
> Projects" progress bar. I haven't been able to find a repro case, but I'm
> attaching a thread dump (from VisualVM) and screen shot.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4696) NetBeans 12.1-beta1 sometimes hangs on open
[ https://issues.apache.org/jira/browse/NETBEANS-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190368#comment-17190368 ] Ernie Rael commented on NETBEANS-4696: -- There are two pull requests available. # One seems very safe, don't block to get module name. # The other has the html parser's indexer returning null if project opening is not complete. Simple preliminary tests don't show a problem. But the 2nd PR should be carefully considered by someone who has some sense of the html parsing code. Note that either change avoids the deadlock (at least that's the idea). > NetBeans 12.1-beta1 sometimes hangs on open > --- > > Key: NETBEANS-4696 > URL: https://issues.apache.org/jira/browse/NETBEANS-4696 > Project: NetBeans > Issue Type: Bug > Components: ide - Performance >Affects Versions: 12.1 > Environment: Linux (Debian "Buster") > OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10) >Reporter: Glenn Holmer >Priority: Blocker > Labels: deadlock, pull-requests-available > Attachments: 12.1-vc1-thread-dump-orac.txt, > nb12.1-beta1-thread-dump.png, nb12.1-beta1-thread-dump.txt, > netbeans-12.1-thread-dump.txt > > Time Spent: 20m > Remaining Estimate: 0h > > > NetBeans sometimes hangs on startup; the symptom is a stalled "Opening > Projects" progress bar. I haven't been able to find a repro case, but I'm > attaching a thread dump (from VisualVM) and screen shot. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4696) NetBeans 12.1-beta1 sometimes hangs on open
[ https://issues.apache.org/jira/browse/NETBEANS-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190267#comment-17190267 ] Ernie Rael commented on NETBEANS-4696: -- [~geertjan] From what I can tell from various comments, the code that is in the knockout area has become integral to Netbeans' html infrastructure. (isn't evolution wonderful?). > NetBeans 12.1-beta1 sometimes hangs on open > --- > > Key: NETBEANS-4696 > URL: https://issues.apache.org/jira/browse/NETBEANS-4696 > Project: NetBeans > Issue Type: Bug > Components: ide - Performance >Affects Versions: 12.1 > Environment: Linux (Debian "Buster") > OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10) >Reporter: Glenn Holmer >Priority: Blocker > Labels: deadlock > Attachments: 12.1-vc1-thread-dump-orac.txt, > nb12.1-beta1-thread-dump.png, nb12.1-beta1-thread-dump.txt, > netbeans-12.1-thread-dump.txt > > > > NetBeans sometimes hangs on startup; the symptom is a stalled "Opening > Projects" progress bar. I haven't been able to find a repro case, but I'm > attaching a thread dump (from VisualVM) and screen shot. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4696) NetBeans 12.1-beta1 sometimes hangs on open
[ https://issues.apache.org/jira/browse/NETBEANS-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190241#comment-17190241 ] Ernie Rael commented on NETBEANS-4696: -- Actually, I don't need to reproduce the deadlock. Given the changes I'm proposing, there won't be a deadlock (famous last words, but in defense the changes remove *both* contributors to the deadlock). I'm just trying to insure that I haven't broken anything (or at least not too much :-) ). I need to do some things in a project that exercise these indexes. I'm guessing that they are used for navigation, like goto definition, findusages, ... as they would be in a normal java project. But I have no experience in the dynamic html area, so I don't know what behavior is expected. > NetBeans 12.1-beta1 sometimes hangs on open > --- > > Key: NETBEANS-4696 > URL: https://issues.apache.org/jira/browse/NETBEANS-4696 > Project: NetBeans > Issue Type: Bug > Components: ide - Performance >Affects Versions: 12.1 > Environment: Linux (Debian "Buster") > OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10) >Reporter: Glenn Holmer >Priority: Blocker > Labels: deadlock > Attachments: 12.1-vc1-thread-dump-orac.txt, > nb12.1-beta1-thread-dump.png, nb12.1-beta1-thread-dump.txt, > netbeans-12.1-thread-dump.txt > > > > NetBeans sometimes hangs on startup; the symptom is a stalled "Opening > Projects" progress bar. I haven't been able to find a repro case, but I'm > attaching a thread dump (from VisualVM) and screen shot. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4696) NetBeans 12.1-beta1 sometimes hangs on open
[ https://issues.apache.org/jira/browse/NETBEANS-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190228#comment-17190228 ] Glenn Holmer commented on NETBEANS-4696: The projects I was re-opening when I saw this were not Knockout JS projects, but JSF with PrimeFaces. It hasn't occurred often, but whenever I've seen it, one of these two projects were being re-opened: [https://gitlab.com/Cenbe/geofont-web] [https://gitlab.com/Cenbe/jakartaee8] > NetBeans 12.1-beta1 sometimes hangs on open > --- > > Key: NETBEANS-4696 > URL: https://issues.apache.org/jira/browse/NETBEANS-4696 > Project: NetBeans > Issue Type: Bug > Components: ide - Performance >Affects Versions: 12.1 > Environment: Linux (Debian "Buster") > OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10) >Reporter: Glenn Holmer >Priority: Blocker > Labels: deadlock > Attachments: 12.1-vc1-thread-dump-orac.txt, > nb12.1-beta1-thread-dump.png, nb12.1-beta1-thread-dump.txt, > netbeans-12.1-thread-dump.txt > > > > NetBeans sometimes hangs on startup; the symptom is a stalled "Opening > Projects" progress bar. I haven't been able to find a repro case, but I'm > attaching a thread dump (from VisualVM) and screen shot. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4696) NetBeans 12.1-beta1 sometimes hangs on open
[ https://issues.apache.org/jira/browse/NETBEANS-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190221#comment-17190221 ] Geertjan Wielenga commented on NETBEANS-4696: - The problem is the Knockout integration is old, has never been updated and probably no one is using it. But there is a Knockout sample in the New Project dialog that you should be able to use to reproduce this or use to try things out. > NetBeans 12.1-beta1 sometimes hangs on open > --- > > Key: NETBEANS-4696 > URL: https://issues.apache.org/jira/browse/NETBEANS-4696 > Project: NetBeans > Issue Type: Bug > Components: ide - Performance >Affects Versions: 12.1 > Environment: Linux (Debian "Buster") > OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10) >Reporter: Glenn Holmer >Priority: Blocker > Labels: deadlock > Attachments: 12.1-vc1-thread-dump-orac.txt, > nb12.1-beta1-thread-dump.png, nb12.1-beta1-thread-dump.txt, > netbeans-12.1-thread-dump.txt > > > > NetBeans sometimes hangs on startup; the symptom is a stalled "Opening > Projects" progress bar. I haven't been able to find a repro case, but I'm > attaching a thread dump (from VisualVM) and screen shot. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4696) NetBeans 12.1-beta1 sometimes hangs on open
[ https://issues.apache.org/jira/browse/NETBEANS-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190212#comment-17190212 ] Ernie Rael commented on NETBEANS-4696: -- I need a project xhtml/javascript (I don't know what) that makes use of the "knockout indexes". Does this type of project have the regular navigation stuff like goto definition? Do anyone have, or can someone tell me how to build, a project I can use to verify the fixes for deadlock? > NetBeans 12.1-beta1 sometimes hangs on open > --- > > Key: NETBEANS-4696 > URL: https://issues.apache.org/jira/browse/NETBEANS-4696 > Project: NetBeans > Issue Type: Bug > Components: ide - Performance >Affects Versions: 12.1 > Environment: Linux (Debian "Buster") > OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10) >Reporter: Glenn Holmer >Priority: Blocker > Labels: deadlock > Attachments: 12.1-vc1-thread-dump-orac.txt, > nb12.1-beta1-thread-dump.png, nb12.1-beta1-thread-dump.txt, > netbeans-12.1-thread-dump.txt > > > > NetBeans sometimes hangs on startup; the symptom is a stalled "Opening > Projects" progress bar. I haven't been able to find a repro case, but I'm > attaching a thread dump (from VisualVM) and screen shot. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4696) NetBeans 12.1-beta1 sometimes hangs on open
[ https://issues.apache.org/jira/browse/NETBEANS-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189793#comment-17189793 ] Ernie Rael commented on NETBEANS-4696: -- Added a bunch of project that need to be opened and got a breakpoint at "return null", so the above seems to detect open not complete. But I never got any other breakpoint in this method. I suspect/hope that my nearly empty boilerplate xhtml file doesn't have enough stuff in it; so this method never got called again. I don't know what the indexes are used with/for. Can someone suggest a way to test that things are working OK with this change. > NetBeans 12.1-beta1 sometimes hangs on open > --- > > Key: NETBEANS-4696 > URL: https://issues.apache.org/jira/browse/NETBEANS-4696 > Project: NetBeans > Issue Type: Bug > Components: ide - Performance >Affects Versions: 12.1 > Environment: Linux (Debian "Buster") > OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10) >Reporter: Glenn Holmer >Priority: Blocker > Labels: deadlock > Attachments: 12.1-vc1-thread-dump-orac.txt, > nb12.1-beta1-thread-dump.png, nb12.1-beta1-thread-dump.txt, > netbeans-12.1-thread-dump.txt > > > > NetBeans sometimes hangs on startup; the symptom is a stalled "Opening > Projects" progress bar. I haven't been able to find a repro case, but I'm > attaching a thread dump (from VisualVM) and screen shot. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4696) NetBeans 12.1-beta1 sometimes hangs on open
[
https://issues.apache.org/jira/browse/NETBEANS-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189716#comment-17189716
]
Ernie Rael commented on NETBEANS-4696:
--
For the knockout side I've got
{code}
$ hg diff
diff --git
a/webcommon/javascript2.knockout/src/org/netbeans/modules/javascript2/knockout/index/KnockoutIndex.java
b/webcommon/javascript2.knockout/src/org/netbeans/modules/javascript2/knockout/index/KnockoutIndex.java
---
a/webcommon/javascript2.knockout/src/org/netbeans/modules/javascript2/knockout/index/KnockoutIndex.java
+++
b/webcommon/javascript2.knockout/src/org/netbeans/modules/javascript2/knockout/index/KnockoutIndex.java
@@ -45,7 +45,6 @@
private static final Map INDEXES = new
WeakHashMap<>();
private final QuerySupport querySupport;
-private static boolean areProjectsOpen = false;
public static KnockoutIndex get(Project project) throws IOException {
if (project == null) {
@@ -54,16 +53,8 @@
synchronized (INDEXES) {
KnockoutIndex index = INDEXES.get(project);
if (index == null) {
-if (!areProjectsOpen) {
-try {
-// just be sure that the projects are open
-OpenProjects.getDefault().openProjects().get();
-} catch (InterruptedException | ExecutionException ex) {
-Exceptions.printStackTrace(ex);
-} finally {
-areProjectsOpen = true;
-}
-}
+if(!OpenProjects.getDefault().openProjects().isDone())
+return null;
Collection sourceRoots =
QuerySupport.findRoots(project,
null /* all source roots */,
Collections.emptyList(),
{code}
FindUsage shows that all callers of "...get(project)" check for a null return.
Looking at the call sites, it doesn't seem like anything is cached; it seems
like it should come back next time it wants info. But I couldn't get a
breakpoint at the "return null", so who knows.
Comments? Just try it?
> NetBeans 12.1-beta1 sometimes hangs on open
> ---
>
> Key: NETBEANS-4696
> URL: https://issues.apache.org/jira/browse/NETBEANS-4696
> Project: NetBeans
> Issue Type: Bug
> Components: ide - Performance
>Affects Versions: 12.1
> Environment: Linux (Debian "Buster")
> OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10)
>Reporter: Glenn Holmer
>Priority: Blocker
> Labels: deadlock
> Attachments: 12.1-vc1-thread-dump-orac.txt,
> nb12.1-beta1-thread-dump.png, nb12.1-beta1-thread-dump.txt,
> netbeans-12.1-thread-dump.txt
>
>
>
> NetBeans sometimes hangs on startup; the symptom is a stalled "Opening
> Projects" progress bar. I haven't been able to find a repro case, but I'm
> attaching a thread dump (from VisualVM) and screen shot.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4696) NetBeans 12.1-beta1 sometimes hangs on open
[
https://issues.apache.org/jira/browse/NETBEANS-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189673#comment-17189673
]
Ernie Rael commented on NETBEANS-4696:
--
For the problematic
{code:java}
private static String getModuleName(@NonNull final FileObject moduleInfo)
{code}
in UnitTestsCompilerOptionsQueryImpl.java, replaced the rather expensive method
with the single line
{code:java}
return SourceUtils.parseModuleName(moduleInfo);
{code}
and the debugger shows the same result (in the case I tried)
I couldn't get
{code:java}
SourceUtils.getModuleName(moduleInfo.getParent().toURL())
{code}
to work. Then I noticed that the javadoc asks for a binary root; not sure what
that means.
Unless there's an objection, I'll file a pull request with this change tomorrow.
I'll take a look at KOHtmlExtension and try to come up with something.
[~gholmer], [~hink084] I couldn't get a failure, to verify the fix. I added an
xhtml file and a maven test to get a breakpoint in the troubling method. But no
hang. If this gets pulled into master, maybe you can check a daily build...
> NetBeans 12.1-beta1 sometimes hangs on open
> ---
>
> Key: NETBEANS-4696
> URL: https://issues.apache.org/jira/browse/NETBEANS-4696
> Project: NetBeans
> Issue Type: Bug
> Components: ide - Performance
>Affects Versions: 12.1
> Environment: Linux (Debian "Buster")
> OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10)
>Reporter: Glenn Holmer
>Priority: Blocker
> Labels: deadlock
> Attachments: 12.1-vc1-thread-dump-orac.txt,
> nb12.1-beta1-thread-dump.png, nb12.1-beta1-thread-dump.txt,
> netbeans-12.1-thread-dump.txt
>
>
>
> NetBeans sometimes hangs on startup; the symptom is a stalled "Opening
> Projects" progress bar. I haven't been able to find a repro case, but I'm
> attaching a thread dump (from VisualVM) and screen shot.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4696) NetBeans 12.1-beta1 sometimes hangs on open
[ https://issues.apache.org/jira/browse/NETBEANS-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189570#comment-17189570 ] Ernie Rael commented on NETBEANS-4696: -- Just a note. I've recently ran into some issues requiring module-info manipulation. I've filed NETBEANS-4765 which ask for a common public api for working with module-info and mentions some areas where a common api for module-info stuff could be used. > NetBeans 12.1-beta1 sometimes hangs on open > --- > > Key: NETBEANS-4696 > URL: https://issues.apache.org/jira/browse/NETBEANS-4696 > Project: NetBeans > Issue Type: Bug > Components: ide - Performance >Affects Versions: 12.1 > Environment: Linux (Debian "Buster") > OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10) >Reporter: Glenn Holmer >Priority: Blocker > Labels: deadlock > Attachments: 12.1-vc1-thread-dump-orac.txt, > nb12.1-beta1-thread-dump.png, nb12.1-beta1-thread-dump.txt, > netbeans-12.1-thread-dump.txt > > > > NetBeans sometimes hangs on startup; the symptom is a stalled "Opening > Projects" progress bar. I haven't been able to find a repro case, but I'm > attaching a thread dump (from VisualVM) and screen shot. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4696) NetBeans 12.1-beta1 sometimes hangs on open
[ https://issues.apache.org/jira/browse/NETBEANS-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189326#comment-17189326 ] Tomas Zezula commented on NETBEANS-4696: I think the [UnitTestsCompilerOptionsQueryImpl|https://github.com/apache/netbeans/blob/master/java/maven/src/org/netbeans/modules/maven/queries/UnitTestsCompilerOptionsQueryImpl.java#L284] should use [ModuleNames |https://github.com/apache/netbeans/blob/master/java/java.source.base/src/org/netbeans/modules/java/source/ModuleNames.java] cache. It can be done using the [SourceUtils.getModuleName|https://github.com/apache/netbeans/blob/master/java/java.source.base/src/org/netbeans/api/java/source/SourceUtils.java#L1316] API. Ideally also the KOHtmlExtension should not wait for the index as described in my previous comment. But using the module names cache should be easier. > NetBeans 12.1-beta1 sometimes hangs on open > --- > > Key: NETBEANS-4696 > URL: https://issues.apache.org/jira/browse/NETBEANS-4696 > Project: NetBeans > Issue Type: Bug > Components: ide - Performance >Affects Versions: 12.1 > Environment: Linux (Debian "Buster") > OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10) >Reporter: Glenn Holmer >Priority: Blocker > Labels: deadlock > Attachments: 12.1-vc1-thread-dump-orac.txt, > nb12.1-beta1-thread-dump.png, nb12.1-beta1-thread-dump.txt, > netbeans-12.1-thread-dump.txt > > > > NetBeans sometimes hangs on startup; the symptom is a stalled "Opening > Projects" progress bar. I haven't been able to find a repro case, but I'm > attaching a thread dump (from VisualVM) and screen shot. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4696) NetBeans 12.1-beta1 sometimes hangs on open
[
https://issues.apache.org/jira/browse/NETBEANS-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189141#comment-17189141
]
Jaroslav Tulach commented on NETBEANS-4696:
---
-1 to removing {{org.netbeans.module.html.knockout}} module. HTML/Java supports
depends on it.
> NetBeans 12.1-beta1 sometimes hangs on open
> ---
>
> Key: NETBEANS-4696
> URL: https://issues.apache.org/jira/browse/NETBEANS-4696
> Project: NetBeans
> Issue Type: Bug
> Components: ide - Performance
>Affects Versions: 12.1
> Environment: Linux (Debian "Buster")
> OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10)
>Reporter: Glenn Holmer
>Priority: Major
> Attachments: 12.1-vc1-thread-dump-orac.txt,
> nb12.1-beta1-thread-dump.png, nb12.1-beta1-thread-dump.txt,
> netbeans-12.1-thread-dump.txt
>
>
>
> NetBeans sometimes hangs on startup; the symptom is a stalled "Opening
> Projects" progress bar. I haven't been able to find a repro case, but I'm
> attaching a thread dump (from VisualVM) and screen shot.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4696) NetBeans 12.1-beta1 sometimes hangs on open
[ https://issues.apache.org/jira/browse/NETBEANS-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189118#comment-17189118 ] Geertjan Wielenga commented on NETBEANS-4696: - We could simply remove the whole org.netbeans.modules.html.knockout module, it is old and outdated anyway. > NetBeans 12.1-beta1 sometimes hangs on open > --- > > Key: NETBEANS-4696 > URL: https://issues.apache.org/jira/browse/NETBEANS-4696 > Project: NetBeans > Issue Type: Bug > Components: ide - Performance >Affects Versions: 12.1 > Environment: Linux (Debian "Buster") > OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10) >Reporter: Glenn Holmer >Priority: Major > Attachments: 12.1-vc1-thread-dump-orac.txt, > nb12.1-beta1-thread-dump.png, nb12.1-beta1-thread-dump.txt, > netbeans-12.1-thread-dump.txt > > > > NetBeans sometimes hangs on startup; the symptom is a stalled "Opening > Projects" progress bar. I haven't been able to find a repro case, but I'm > attaching a thread dump (from VisualVM) and screen shot. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4696) NetBeans 12.1-beta1 sometimes hangs on open
[
https://issues.apache.org/jira/browse/NETBEANS-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189113#comment-17189113
]
Ernie Rael commented on NETBEANS-4696:
--
[~tzezula] I came across
{code:java}
org.netbeans.api.java.source.SourceUtils{.parseModuleName,.getModuleName*}
{code}
I guess these are the module name parsing utilities to which you are referring?
> NetBeans 12.1-beta1 sometimes hangs on open
> ---
>
> Key: NETBEANS-4696
> URL: https://issues.apache.org/jira/browse/NETBEANS-4696
> Project: NetBeans
> Issue Type: Bug
> Components: ide - Performance
>Affects Versions: 12.1
> Environment: Linux (Debian "Buster")
> OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10)
>Reporter: Glenn Holmer
>Priority: Major
> Attachments: 12.1-vc1-thread-dump-orac.txt,
> nb12.1-beta1-thread-dump.png, nb12.1-beta1-thread-dump.txt,
> netbeans-12.1-thread-dump.txt
>
>
>
> NetBeans sometimes hangs on startup; the symptom is a stalled "Opening
> Projects" progress bar. I haven't been able to find a repro case, but I'm
> attaching a thread dump (from VisualVM) and screen shot.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4696) NetBeans 12.1-beta1 sometimes hangs on open
[
https://issues.apache.org/jira/browse/NETBEANS-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189022#comment-17189022
]
Tomas Zezula commented on NETBEANS-4696:
[~jtulach]
>Parsing API doesn't really hold a "lock", but it only runs in a single
>dedicated thread (which is a shared, spare resource too).
There are two kinds of actions. The first are the event based tasks scheduled
by schedulers. These run in the dedicated thread as you described. But there
are also user action task which are executed in the caller thread. They are
mutually exclusive to other user action tasks and scheduler tasks. The deadlock
is caused by a user action task which holds a global lock to exclude other
tasks.
Also Java indexing creates a separate compiler \{JavaCustomIndexer} which does
not take this lock and run concurrently to the above tasks. For tasks the lock
cannot be removed as the parsers are not thread safe (parsers and parser
results are shared).
Looking at the stack trace the deadlock is not caused by indexing but by brace
matching ("EditorBracesMatching" #15 daemon prio=1) which waits until the
projects are loaded.
{code:java}
- waiting to re-lock in wait() <0x8718a120> (a
org.openide.util.RequestProcessor$Task)
at
org.openide.util.RequestProcessor$Task.waitFinished(RequestProcessor.java:1672)
at
org.netbeans.modules.project.ui.OpenProjectList$LoadOpenProjects.get(OpenProjectList.java:576)
at
org.netbeans.modules.project.ui.OpenProjectList$LoadOpenProjects.get(OpenProjectList.java:320)
at
org.netbeans.modules.javascript2.knockout.index.KnockoutIndex.get(KnockoutIndex.java:60)
- locked <0x8e4c2988> (a java.util.WeakHashMap)
at
org.netbeans.modules.html.knockout.KOHtmlExtension.isTagCustomKnockoutElement(KOHtmlExtension.java:395)
at
org.netbeans.modules.html.knockout.KOHtmlExtension.isCustomTag(KOHtmlExtension.java:302){code}
There are two possible fixes.
Probably both should be done.
1st) There should be \{KnockoutIndex.getIfExists} and the KOHtmlExtension
should not wait for the index. It should just return no tags. It's much better
than holding the global lock for a long time. The project loading is long
running task.
2nd) The second thread in the deadlock is parsing module name. As far as I
remember I did some utilities doing module name parsing which were lock free.
Maybe we need to more to update the the \{UnitTestsCompilerOptionsQueryImpl} to
use them or add a needed version.
> NetBeans 12.1-beta1 sometimes hangs on open
> ---
>
> Key: NETBEANS-4696
> URL: https://issues.apache.org/jira/browse/NETBEANS-4696
> Project: NetBeans
> Issue Type: Bug
> Components: ide - Performance
>Affects Versions: 12.1
> Environment: Linux (Debian "Buster")
> OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10)
>Reporter: Glenn Holmer
>Priority: Major
> Attachments: 12.1-vc1-thread-dump-orac.txt,
> nb12.1-beta1-thread-dump.png, nb12.1-beta1-thread-dump.txt,
> netbeans-12.1-thread-dump.txt
>
>
>
> NetBeans sometimes hangs on startup; the symptom is a stalled "Opening
> Projects" progress bar. I haven't been able to find a repro case, but I'm
> attaching a thread dump (from VisualVM) and screen shot.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4696) NetBeans 12.1-beta1 sometimes hangs on open
[
https://issues.apache.org/jira/browse/NETBEANS-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189010#comment-17189010
]
Jaroslav Tulach commented on NETBEANS-4696:
---
The general rule to fight with deadlocks in an API is [never hold a lock when
calling foreign code|http://wiki.apidesign.org/wiki/Deadlock]. However in this
case it is not that easy to find out who's an API and who's the client. What
can help is to topologically sort and layer the modules according to their
runtime dependencies - the ones below are an API, the ones above are clients.
Then a callback from below to above which holds a lock would be problematic.
Such a callback is happening in the deadlock:
{code:java}
org.netbeans.modules.html.knockout.KOHtmlExtension.isCustomTag(KOHtmlExtension.java:302)
is being called by "lower" module:
org.netbeans.modules.html.editor.gsf.HtmlGSFParser$1.isCustomTag(HtmlGSFParser.java:109)
is being called by "lower" module:
org.netbeans.modules.html.editor.lib.api.SyntaxAnalyzerResult.doParseHtml(SyntaxAnalyzerResult.java:259)
is being called by "lower" module:
org.netbeans.modules.csl.navigation.ElementScanningTask$1.run(ElementScanningTask.java:149)
is being called by "lower" module:
org.netbeans.modules.parsing.impl.TaskProcessor.callUserTask {code}
Parsing API doesn't really hold a "lock", but it only runs in a single
dedicated thread (which is a shared, spare resource too). Can we avoid that?
Too hard, right [~tomas_zezula] & [~zezulato...@gmail.com] & [~tzezula]? This
is a core of the indexing infrastructure. We don't want to touch it. Who else
to blame?
Let's make a rule: Whoever registers an indexer, isn't allowed to make a call
to modules "above" Parsing API.
With such rule, it is clear that {{KOHtmlExtension}} breaks it by calling into
Project UI API . Take a look at [four deadlock
conditions|http://wiki.apidesign.org/wiki/Deadlock_conditions] and select one
to break the deadlock the simplest way. This would do it:
{code:java}
---
a/webcommon/javascript2.knockout/src/org/netbeans/modules/javascript2/knockout/index/KnockoutIndex.java
+++
b/webcommon/javascript2.knockout/src/org/netbeans/modules/javascript2/knockout/index/KnockoutIndex.java
@@ -27,6 +27,8 @@
import java.util.Map;
import java.util.WeakHashMap;
import java.util.concurrent.ExecutionException;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
import java.util.logging.Logger;
import org.netbeans.api.project.Project;
import org.netbeans.api.project.ui.OpenProjects;
@@ -57,8 +59,8 @@
if (!areProjectsOpen) {
try {
// just be sure that the projects are open
-OpenProjects.getDefault().openProjects().get();
-} catch (InterruptedException | ExecutionException ex) {
+OpenProjects.getDefault().openProjects().get(10,
TimeUnit.SECONDS);
+} catch (InterruptedException | ExecutionException |
TimeoutException ex) {
Exceptions.printStackTrace(ex);
} finally {
areProjectsOpen = true; {code}
e.g. don't wait indefinitely. However given [Roman Svitanič's
comment|https://github.com/emilianbold/netbeans-releases/commit/30092308c4fef#diff-b6844ad6d2c225bbb1c8d6c0287d6a6cR80]
"just be sure that the projects are open" - I'd suggest to delete the whole
{{areProjectsOpen}} check. This shouldn't be here at all. If the dependency of
{{javascript2.knockout}} module on Project UI API can be removed, then even
better!
> NetBeans 12.1-beta1 sometimes hangs on open
> ---
>
> Key: NETBEANS-4696
> URL: https://issues.apache.org/jira/browse/NETBEANS-4696
> Project: NetBeans
> Issue Type: Bug
> Components: ide - Performance
>Affects Versions: 12.1
> Environment: Linux (Debian "Buster")
> OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10)
>Reporter: Glenn Holmer
>Priority: Major
> Attachments: 12.1-vc1-thread-dump-orac.txt,
> nb12.1-beta1-thread-dump.png, nb12.1-beta1-thread-dump.txt,
> netbeans-12.1-thread-dump.txt
>
>
>
> NetBeans sometimes hangs on startup; the symptom is a stalled "Opening
> Projects" progress bar. I haven't been able to find a repro case, but I'm
> attaching a thread dump (from VisualVM) and screen shot.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4696) NetBeans 12.1-beta1 sometimes hangs on open
[
https://issues.apache.org/jira/browse/NETBEANS-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17188841#comment-17188841
]
Ernie Rael commented on NETBEANS-4696:
--
Here's the deadlock, note that parsing.api.ParserManager.parse is one at a time
A task that's parsing is waiting for projects to finish opening.
Project opener is waiting to parse.
The maven stuff from ProjectOpener looks pretty suspicious, but IDK?
If it only happens with the html stuff, then maybe the rule is that
a parser isn't supposed to wait for the ProjectOpener.
=== a parsing task
{code}
Some Random Task does parsing, invokes
at org.netbeans.modules.parsing.api.ParserManager.parse
(ParserManager.java:81)
and then does
at org.netbeans.modules.html.editor.api.gsf.HtmlParserResult.root
(HtmlParserResult.java:119)
which ends up doing
at org.netbeans.modules.project.ui.OpenProjectList$LoadOpenProjects.get
(OpenProjectList.java:576)
and this OpenProjectList$LoadOpenProjects.get() wait for opening to complete
{code}
=== "Load Open Projects"
{code}
at org.netbeans.spi.java.project.support.CompilerOptionsQueryMerger
$CompilerOptionsQueryImpl$ResultImpl.lambda$checkProviders$4
(CompilerOptionsQueryMerger.java:184)
goes into some maven specific code
at org.netbeans.modules.maven.queries.UnitTestsCompilerOptionsQueryImpl
$ResultImpl.getArguments
(UnitTestsCompilerOptionsQueryImpl.java:155)
which ends up at
at org.netbeans.modules.maven.queries.UnitTestsCompilerOptionsQueryImpl
$ResultImpl.getModuleName
(UnitTestsCompilerOptionsQueryImpl.java:289)
and then
at org.netbeans.modules.parsing.api.ParserManager.parse
(ParserManager.java:81)
{code}
> NetBeans 12.1-beta1 sometimes hangs on open
> ---
>
> Key: NETBEANS-4696
> URL: https://issues.apache.org/jira/browse/NETBEANS-4696
> Project: NetBeans
> Issue Type: Bug
> Components: ide - Performance
>Affects Versions: 12.1
> Environment: Linux (Debian "Buster")
> OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10)
>Reporter: Glenn Holmer
>Priority: Major
> Attachments: 12.1-vc1-thread-dump-orac.txt,
> nb12.1-beta1-thread-dump.png, nb12.1-beta1-thread-dump.txt,
> netbeans-12.1-thread-dump.txt
>
>
>
> NetBeans sometimes hangs on startup; the symptom is a stalled "Opening
> Projects" progress bar. I haven't been able to find a repro case, but I'm
> attaching a thread dump (from VisualVM) and screen shot.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4696) NetBeans 12.1-beta1 sometimes hangs on open
[ https://issues.apache.org/jira/browse/NETBEANS-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17188008#comment-17188008 ] Glenn Holmer commented on NETBEANS-4696: Every time it's happened to me, an XHTML JSF file was also one of the files being re-opened. > NetBeans 12.1-beta1 sometimes hangs on open > --- > > Key: NETBEANS-4696 > URL: https://issues.apache.org/jira/browse/NETBEANS-4696 > Project: NetBeans > Issue Type: Bug > Components: ide - Performance >Affects Versions: 12.1 > Environment: Linux (Debian "Buster") > OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10) >Reporter: Glenn Holmer >Priority: Major > Attachments: 12.1-vc1-thread-dump-orac.txt, > nb12.1-beta1-thread-dump.png, nb12.1-beta1-thread-dump.txt, > netbeans-12.1-thread-dump.txt > > > NetBeans sometimes hangs on startup; the symptom is a stalled "Opening > Projects" progress bar. I haven't been able to find a repro case, but I'm > attaching a thread dump (from VisualVM) and screen shot. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4696) NetBeans 12.1-beta1 sometimes hangs on open
[ https://issues.apache.org/jira/browse/NETBEANS-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187423#comment-17187423 ] Jeremy commented on NETBEANS-4696: -- So an update from me...I have realized that I can get NetBeans to load properly while having XHTML files/tabs open but an XHTML file cannot be the active tab when NetBeans is launched. When an XHTML file is first to load, the IDE fails to finish "opening projects", it cannot load the Navigator, and the text color of all tabs is black and do not reflect the current VCS state. > NetBeans 12.1-beta1 sometimes hangs on open > --- > > Key: NETBEANS-4696 > URL: https://issues.apache.org/jira/browse/NETBEANS-4696 > Project: NetBeans > Issue Type: Bug > Components: ide - Performance >Affects Versions: 12.1 > Environment: Linux (Debian "Buster") > OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10) >Reporter: Glenn Holmer >Priority: Major > Attachments: 12.1-vc1-thread-dump-orac.txt, > nb12.1-beta1-thread-dump.png, nb12.1-beta1-thread-dump.txt, > netbeans-12.1-thread-dump.txt > > > NetBeans sometimes hangs on startup; the symptom is a stalled "Opening > Projects" progress bar. I haven't been able to find a repro case, but I'm > attaching a thread dump (from VisualVM) and screen shot. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4696) NetBeans 12.1-beta1 sometimes hangs on open
[ https://issues.apache.org/jira/browse/NETBEANS-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187411#comment-17187411 ] Ernie Rael commented on NETBEANS-4696: -- My guess is wrong. The syncronizer is part of get(). > NetBeans 12.1-beta1 sometimes hangs on open > --- > > Key: NETBEANS-4696 > URL: https://issues.apache.org/jira/browse/NETBEANS-4696 > Project: NetBeans > Issue Type: Bug > Components: ide - Performance >Affects Versions: 12.1 > Environment: Linux (Debian "Buster") > OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10) >Reporter: Glenn Holmer >Priority: Major > Attachments: 12.1-vc1-thread-dump-orac.txt, > nb12.1-beta1-thread-dump.png, nb12.1-beta1-thread-dump.txt, > netbeans-12.1-thread-dump.txt > > > NetBeans sometimes hangs on startup; the symptom is a stalled "Opening > Projects" progress bar. I haven't been able to find a repro case, but I'm > attaching a thread dump (from VisualVM) and screen shot. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4696) NetBeans 12.1-beta1 sometimes hangs on open
[ https://issues.apache.org/jira/browse/NETBEANS-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187406#comment-17187406 ] Ernie Rael commented on NETBEANS-4696: -- BTW, this matches Jeremy's finding that html files are needed to bring about the failure condition. > NetBeans 12.1-beta1 sometimes hangs on open > --- > > Key: NETBEANS-4696 > URL: https://issues.apache.org/jira/browse/NETBEANS-4696 > Project: NetBeans > Issue Type: Bug > Components: ide - Performance >Affects Versions: 12.1 > Environment: Linux (Debian "Buster") > OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10) >Reporter: Glenn Holmer >Priority: Major > Attachments: 12.1-vc1-thread-dump-orac.txt, > nb12.1-beta1-thread-dump.png, nb12.1-beta1-thread-dump.txt, > netbeans-12.1-thread-dump.txt > > > NetBeans sometimes hangs on startup; the symptom is a stalled "Opening > Projects" progress bar. I haven't been able to find a repro case, but I'm > attaching a thread dump (from VisualVM) and screen shot. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4696) NetBeans 12.1-beta1 sometimes hangs on open
[
https://issues.apache.org/jira/browse/NETBEANS-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187404#comment-17187404
]
Ernie Rael commented on NETBEANS-4696:
--
All three thread dumps have this signature.
"Load Open Projects" is parking waiting for "XXX". And some other task is
trying to get html results and in trying to get these results does
"OpenProjectList$LoadOpenProjects.get()".
Some possibilities are that
* your not suppose to get the open projects while there being opened, your
supposed to wait
* your not supposed to hold the synchronizer when you call into
openProjects.get()
My guess is the second
{code}
"Load Open Projects" #59 daemon prio=1 os_prio=0 cpu=684.74ms elapsed=136.09s
tid=0x7f833c932000 nid=0x5831 waiting on condition [0x7f82c1bf4000]
java.lang.Thread.State: WAITING (parking)
at jdk.internal.misc.Unsafe.park(java.base@11.0.8/Native Method)
- parking to wait for <0x00070ab1db30> (a
java.util.concurrent.locks.ReentrantLock$FairSync)
{code}
And some other task (the specific task varies) is getting parsing results of an
html file. The stack of this task always ends with
{code}
"Editor Parsing Loop (12.1-cade25887c5450e4595fa59e616daee4d2520ee0)" #16
daemon prio=1 os_prio=0 cpu=504.56ms elapsed=145.75s tid=0x7f83d87a8000
nid=0x57f3 in Object.wait() [0x7f838991d000]
java.lang.Thread.State: WAITING (on object monitor)
at java.lang.Object.wait(java.base@11.0.8/Native Method)
- waiting on
at java.lang.Object.wait(java.base@11.0.8/Object.java:328)
at org.openide.util.Task.waitFinished(Task.java:110)
- waiting to re-lock in wait() <0x0007072bf790> (a
org.openide.util.RequestProcessor$Task)
at
org.openide.util.RequestProcessor$Task.waitFinished(RequestProcessor.java:1672)
at
org.netbeans.modules.project.ui.OpenProjectList$LoadOpenProjects.get(OpenProjectList.java:576)
at
org.netbeans.modules.project.ui.OpenProjectList$LoadOpenProjects.get(OpenProjectList.java:320)
at
org.netbeans.modules.javascript2.knockout.index.KnockoutIndex.get(KnockoutIndex.java:60)
- locked <0x000714b0> (a java.util.WeakHashMap)
at
org.netbeans.modules.html.knockout.KOHtmlExtension.isTagCustomKnockoutElement(KOHtmlExtension.java:395)
at
org.netbeans.modules.html.knockout.KOHtmlExtension.isCustomTag(KOHtmlExtension.java:302)
at
org.netbeans.modules.html.editor.gsf.HtmlGSFParser$1.isCustomTag(HtmlGSFParser.java:109)
at
org.netbeans.modules.html.editor.gsf.HtmlGSFParser$AggregatedUndeclaredContentResolver.isCustomTag(HtmlGSFParser.java:153)
at
org.netbeans.modules.html.editor.lib.api.SyntaxAnalyzerResult$ElementContentFilter.shouldBeFiltered(SyntaxAnalyzerResult.java:752)
at
org.netbeans.modules.html.editor.lib.api.SyntaxAnalyzerResult$ElementContentFilter.getMasks(SyntaxAnalyzerResult.java:720)
at
org.netbeans.modules.html.editor.lib.api.SyntaxAnalyzerResult.getMaskedAreas(SyntaxAnalyzerResult.java:492)
- locked <0x000714b00350> (a
org.netbeans.modules.html.editor.lib.api.SyntaxAnalyzerResult)
at
org.netbeans.modules.html.editor.lib.api.SyntaxAnalyzerResult.doParseHtml(SyntaxAnalyzerResult.java:259)
at
org.netbeans.modules.html.editor.lib.api.SyntaxAnalyzerResult.parseHtml(SyntaxAnalyzerResult.java:185)
- locked <0x000714b00350> (a
org.netbeans.modules.html.editor.lib.api.SyntaxAnalyzerResult)
at
org.netbeans.modules.html.editor.api.gsf.HtmlParserResult.root(HtmlParserResult.java:119)
{code}
and this task always has
{code}
Locked ownable synchronizers:
- <0x00070ab1db30> (a
java.util.concurrent.locks.ReentrantLock$FairSync)
{code}
where this "Locked ownable" thing is the same as what the "Load Open Projects"
task is waiting for.
> NetBeans 12.1-beta1 sometimes hangs on open
> ---
>
> Key: NETBEANS-4696
> URL: https://issues.apache.org/jira/browse/NETBEANS-4696
> Project: NetBeans
> Issue Type: Bug
> Components: ide - Performance
>Affects Versions: 12.1
> Environment: Linux (Debian "Buster")
> OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10)
>Reporter: Glenn Holmer
>Priority: Major
> Attachments: 12.1-vc1-thread-dump-orac.txt,
> nb12.1-beta1-thread-dump.png, nb12.1-beta1-thread-dump.txt,
> netbeans-12.1-thread-dump.txt
>
>
> NetBeans sometimes hangs on startup; the symptom is a stalled "Opening
> Projects" progress bar. I haven't been able to find a repro case, but I'm
> attaching a thread dump (from VisualVM) and screen shot.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-
[jira] [Commented] (NETBEANS-4696) NetBeans 12.1-beta1 sometimes hangs on open
[ https://issues.apache.org/jira/browse/NETBEANS-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187354#comment-17187354 ] Glenn Holmer commented on NETBEANS-4696: Just saw it again, this time when upgrading one of my laptops to 12.1-vc1. It was on first start. I had renamed my existing user and cache dirs from 12.1-beta4 to 12.1, although I wouldn't think that would matter. I was able close NetBeans normally, but the symptoms were as above: "opening projects" stuck at 20% on five projects; one out of five projects showed its versioning label. Added another thread dump from VisualVM. > NetBeans 12.1-beta1 sometimes hangs on open > --- > > Key: NETBEANS-4696 > URL: https://issues.apache.org/jira/browse/NETBEANS-4696 > Project: NetBeans > Issue Type: Bug > Components: ide - Performance >Affects Versions: 12.1 > Environment: Linux (Debian "Buster") > OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10) >Reporter: Glenn Holmer >Priority: Major > Attachments: nb12.1-beta1-thread-dump.png, > nb12.1-beta1-thread-dump.txt, netbeans-12.1-thread-dump.txt > > > NetBeans sometimes hangs on startup; the symptom is a stalled "Opening > Projects" progress bar. I haven't been able to find a repro case, but I'm > attaching a thread dump (from VisualVM) and screen shot. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4696) NetBeans 12.1-beta1 sometimes hangs on open
[ https://issues.apache.org/jira/browse/NETBEANS-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187238#comment-17187238 ] Glenn Holmer commented on NETBEANS-4696: I just saw this again on 12.1 vc1. The symptoms are: Progress bar stalls at "opening projects" with 50% showing. I've set to show versioning labels, but only two of the four projects I had open show them. If I hit F6 to run a project, I get a beep. The editor does appear to be working. I attached another thread dump from VisualVM. > NetBeans 12.1-beta1 sometimes hangs on open > --- > > Key: NETBEANS-4696 > URL: https://issues.apache.org/jira/browse/NETBEANS-4696 > Project: NetBeans > Issue Type: Bug > Components: ide - Performance >Affects Versions: 12.1 > Environment: Linux (Debian "Buster") > OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10) >Reporter: Glenn Holmer >Priority: Major > Attachments: nb12.1-beta1-thread-dump.png, > nb12.1-beta1-thread-dump.txt, netbeans-12.1-thread-dump.txt > > > NetBeans sometimes hangs on startup; the symptom is a stalled "Opening > Projects" progress bar. I haven't been able to find a repro case, but I'm > attaching a thread dump (from VisualVM) and screen shot. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-4696) NetBeans 12.1-beta1 sometimes hangs on open
[ https://issues.apache.org/jira/browse/NETBEANS-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17178378#comment-17178378 ] Jeremy commented on NETBEANS-4696: -- This is an issue for me as well. *Product Version:* Apache NetBeans IDE 12.0 *Java:* 14; OpenJDK 64-Bit Server VM 14+36-1461 *Runtime:* OpenJDK Runtime Environment 14+36-1461 *System:* Windows 10 version 10.0 running on amd64; Cp1252; en_US (nb) NetBeans 11.3 was the last version where I did not encounter this problem. For me, I have discovered that if I close all my open tabs and then restart the IDE then it will not stall during the "Opening Projects" initialization. I was able to narrow this down a bit further to only having to close the XHTML files. I'd be curious to know if you experience the same results, and/or maybe it will help someone resolve this issue. > NetBeans 12.1-beta1 sometimes hangs on open > --- > > Key: NETBEANS-4696 > URL: https://issues.apache.org/jira/browse/NETBEANS-4696 > Project: NetBeans > Issue Type: Bug > Components: ide - Performance >Affects Versions: 12.1 > Environment: Linux (Debian "Buster") > OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10) >Reporter: Glenn Holmer >Priority: Major > Attachments: nb12.1-beta1-thread-dump.png, > nb12.1-beta1-thread-dump.txt > > > NetBeans sometimes hangs on startup; the symptom is a stalled "Opening > Projects" progress bar. I haven't been able to find a repro case, but I'm > attaching a thread dump (from VisualVM) and screen shot. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
