[jira] [Commented] (NETBEANS-6347) Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6.
[ https://issues.apache.org/jira/browse/NETBEANS-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17485547#comment-17485547 ] Thomas Schapitz commented on NETBEANS-6347: --- It actually hadn't. This explains it. So I'll close the issue as fixed. > Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6. > --- > > Key: NETBEANS-6347 > URL: https://issues.apache.org/jira/browse/NETBEANS-6347 > Project: NetBeans > Issue Type: Bug > Components: apisupport - Maven >Affects Versions: 12.5, 12.6 >Reporter: Thomas Schapitz >Assignee: Svatopluk Dedic >Priority: Critical > Labels: pull-request-available > Fix For: NB13 > > Attachments: dialog-hint.jpg, image-2021-12-31-10-27-08-275.png, > image-2021-12-31-10-30-58-143.png, image-2022-01-13-19-09-32-623.png, > image-2022-01-13-19-27-19-230.png > > Time Spent: 3.5h > Remaining Estimate: 0h > > The following hardcopy illustrates the problem. > It *is* possible, to add a new definition, but afterwards, it is no longer > possible to maintain values for the goals & profiles, as has been the case up > to version 12.3 > And it isn't possible to activate the definition, it get's created in > disabled state. (Prior to 12.4, it wasn't possible to disable a definition) > Furthermore, at least on Windows 10 / JDK 17, one may observe, that the > alignment of the buttons with the list is botched, as the last one, "Disable" > gets clipped, because the listbox default hight dictates the length. > !image-2021-12-31-10-30-58-143.png! > > This is how it looked like up to 12.3: > !image-2021-12-31-10-27-08-275.png! > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-6347) Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6.
[ https://issues.apache.org/jira/browse/NETBEANS-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17484753#comment-17484753 ] Neil C Smith commented on NETBEANS-6347: [~taps] does the imported action have any goals? Actions without goals should appear disabled. > Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6. > --- > > Key: NETBEANS-6347 > URL: https://issues.apache.org/jira/browse/NETBEANS-6347 > Project: NetBeans > Issue Type: Bug > Components: apisupport - Maven >Affects Versions: 12.5, 12.6 >Reporter: Thomas Schapitz >Assignee: Svatopluk Dedic >Priority: Critical > Labels: pull-request-available > Fix For: NB13 > > Attachments: dialog-hint.jpg, image-2021-12-31-10-27-08-275.png, > image-2021-12-31-10-30-58-143.png, image-2022-01-13-19-09-32-623.png, > image-2022-01-13-19-27-19-230.png > > Time Spent: 3.5h > Remaining Estimate: 0h > > The following hardcopy illustrates the problem. > It *is* possible, to add a new definition, but afterwards, it is no longer > possible to maintain values for the goals & profiles, as has been the case up > to version 12.3 > And it isn't possible to activate the definition, it get's created in > disabled state. (Prior to 12.4, it wasn't possible to disable a definition) > Furthermore, at least on Windows 10 / JDK 17, one may observe, that the > alignment of the buttons with the list is botched, as the last one, "Disable" > gets clipped, because the listbox default hight dictates the length. > !image-2021-12-31-10-30-58-143.png! > > This is how it looked like up to 12.3: > !image-2021-12-31-10-27-08-275.png! > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-6347) Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6.
[ https://issues.apache.org/jira/browse/NETBEANS-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17484159#comment-17484159 ] Thomas Schapitz commented on NETBEANS-6347: --- [~sdedic] Hi. just wanted to let you know, that this at least partially fixed it as of Version 13-rc2. The controls are editable again. Let it just be noted, that an Item, that has been marked as 'disabled' by 12.6, still appears as 'disabled' (grey) in the list, after it has been imported into 13-rc2, until you actually do some back and forth editing in the controls, probably because only then the flag controlling this. gets reset. It wouldn't bother me, but might cause some puzzlement and new Jira Issues down the road if left that way. I will leave it up to you, whether you would like to fix this for the release. In any case, this issue could be closed. Pending your decision, we might open a low priority bug, describing the remaining glitch and the workaround for it - just so that it is documented, and may be found/referred to. > Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6. > --- > > Key: NETBEANS-6347 > URL: https://issues.apache.org/jira/browse/NETBEANS-6347 > Project: NetBeans > Issue Type: Bug > Components: apisupport - Maven >Affects Versions: 12.5, 12.6 >Reporter: Thomas Schapitz >Assignee: Svatopluk Dedic >Priority: Critical > Labels: pull-request-available > Fix For: NB13 > > Attachments: dialog-hint.jpg, image-2021-12-31-10-27-08-275.png, > image-2021-12-31-10-30-58-143.png, image-2022-01-13-19-09-32-623.png, > image-2022-01-13-19-27-19-230.png > > Time Spent: 3.5h > Remaining Estimate: 0h > > The following hardcopy illustrates the problem. > It *is* possible, to add a new definition, but afterwards, it is no longer > possible to maintain values for the goals & profiles, as has been the case up > to version 12.3 > And it isn't possible to activate the definition, it get's created in > disabled state. (Prior to 12.4, it wasn't possible to disable a definition) > Furthermore, at least on Windows 10 / JDK 17, one may observe, that the > alignment of the buttons with the list is botched, as the last one, "Disable" > gets clipped, because the listbox default hight dictates the length. > !image-2021-12-31-10-30-58-143.png! > > This is how it looked like up to 12.3: > !image-2021-12-31-10-27-08-275.png! > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-6347) Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6.
[ https://issues.apache.org/jira/browse/NETBEANS-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17476092#comment-17476092 ] Svatopluk Dedic commented on NETBEANS-6347: --- Re. the vacant place - this is reserved for inline help / description of the focused text entry - see the picture: !dialog-hint.jpg! So I would not prefer to remove the area entirely. I made it smaller + gave it less resize weight so when you expand the dialog, other controls will gain more space than this one. > Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6. > --- > > Key: NETBEANS-6347 > URL: https://issues.apache.org/jira/browse/NETBEANS-6347 > Project: NetBeans > Issue Type: Bug > Components: apisupport - Maven >Affects Versions: 12.5, 12.6 >Reporter: Thomas Schapitz >Assignee: Svatopluk Dedic >Priority: Critical > Labels: pull-request-available > Fix For: NB13 > > Attachments: dialog-hint.jpg, image-2021-12-31-10-27-08-275.png, > image-2021-12-31-10-30-58-143.png, image-2022-01-13-19-09-32-623.png, > image-2022-01-13-19-27-19-230.png > > Time Spent: 1h > Remaining Estimate: 0h > > The following hardcopy illustrates the problem. > It *is* possible, to add a new definition, but afterwards, it is no longer > possible to maintain values for the goals & profiles, as has been the case up > to version 12.3 > And it isn't possible to activate the definition, it get's created in > disabled state. (Prior to 12.4, it wasn't possible to disable a definition) > Furthermore, at least on Windows 10 / JDK 17, one may observe, that the > alignment of the buttons with the list is botched, as the last one, "Disable" > gets clipped, because the listbox default hight dictates the length. > !image-2021-12-31-10-30-58-143.png! > > This is how it looked like up to 12.3: > !image-2021-12-31-10-27-08-275.png! > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-6347) Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6.
[ https://issues.apache.org/jira/browse/NETBEANS-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17475678#comment-17475678 ] Svatopluk Dedic commented on NETBEANS-6347: --- I just wanted to have reproduction steps and/or the buggy state so I can verify the supposed fix before PR gets merged. Thanks for that and for pointing out the layout issues - I'll look at it. Re. the behaviour - in the first round, it is fixable by enabling 'disable' button just for builtin actions; this was added more or less just override contributed defaults (some plugins may disable some actions which user may not like). I filed the other issue to provide better experience / consistency overall - but that requires to slightly change the APIs and serialization, which I don't want to do just before the branching - so filed an issue to remind me. > Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6. > --- > > Key: NETBEANS-6347 > URL: https://issues.apache.org/jira/browse/NETBEANS-6347 > Project: NetBeans > Issue Type: Bug > Components: apisupport - Maven >Affects Versions: 12.5, 12.6 >Reporter: Thomas Schapitz >Assignee: Svatopluk Dedic >Priority: Critical > Labels: pull-request-available > Fix For: NB13 > > Attachments: image-2021-12-31-10-27-08-275.png, > image-2021-12-31-10-30-58-143.png, image-2022-01-13-19-09-32-623.png, > image-2022-01-13-19-27-19-230.png > > Time Spent: 50m > Remaining Estimate: 0h > > The following hardcopy illustrates the problem. > It *is* possible, to add a new definition, but afterwards, it is no longer > possible to maintain values for the goals & profiles, as has been the case up > to version 12.3 > And it isn't possible to activate the definition, it get's created in > disabled state. (Prior to 12.4, it wasn't possible to disable a definition) > Furthermore, at least on Windows 10 / JDK 17, one may observe, that the > alignment of the buttons with the list is botched, as the last one, "Disable" > gets clipped, because the listbox default hight dictates the length. > !image-2021-12-31-10-30-58-143.png! > > This is how it looked like up to 12.3: > !image-2021-12-31-10-27-08-275.png! > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-6347) Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6.
[
https://issues.apache.org/jira/browse/NETBEANS-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17475665#comment-17475665
]
Thomas Schapitz commented on NETBEANS-6347:
---
Not exactly understanding what you are saying, but: It doesn't matter, whether
I start with an empty userdir/config/Projects, or content automigrated from a
previous installation:
!image-2022-01-13-19-09-32-623.png!
Adding a name hier and clicking OK, will take me to the result initially shown,
and producing this as (sans Copyright-Header:
CUSTOM-aas
aas
Starting with something meaningful, like this:
CUSTOM-Version Updates
Version Updates
versions:display-plugin-updates
versions:display-parent-updates
versions:display-property-updates
versions:display-dependency-updates
will allow you to edit goals and parameters for this one, if you click it in
the window, but adding another one, still gets you nowhere:
!image-2022-01-13-19-27-19-230.png!
And scaling is mentioned: scaling is broken too: I could do without the blank
space between the controls and OK/Cancel/Help, which makes up nearly half of
the panel. But here, the Disabled "Disabled' button (which shouldn't be
disabled at all, and likely be labeled 'Enable', if the goal is 'Disabled',
vanishes, because its enclosing box is to small, while the Properties Multiline
Textbox shows just half of a line.
Afterwards, the definitions look like this:
CUSTOM-Version Updates
Version Updates
versions:display-plugin-updates
versions:display-parent-updates
versions:display-property-updates
versions:display-dependency-updates
CUSTOM-anothergoal
anothergoal
true
I would think that:
* firstly, the new definition shouldn't be created in disabled state in the
first place,
* secondly, it shouldn't make a difference to the three textboxes for goals,
profiles & packagings, whether the definition is disabled or not, it should be
possible to edit them in the disable state, as is the case for the multiline
properties box and the Add-Button to its left.
* 3rd. whether those five controls are active should hinge solely on whether
one of the definitions in the list above has been {*}selected{*}.
* If there is none selected, these controls should be disabled and empty
Maybe it is a solution, to put the five controls for a single definition into a
group, and en/disable the whole group?
Come to think of all this: It would also be better, if we drop the pop up
dialogue asking for the action name, and replace that with another editable
text control, so we may be able to edit the name later too. Alas, this would
make disabling rules a bit more complicated Possible path: on pressing Add
(Goal), insert a dummy line into the list of definitions,
whose text gets fixed as it is typed into the control below.
> Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6.
> ---
>
> Key: NETBEANS-6347
> URL: https://issues.apache.org/jira/browse/NETBEANS-6347
> Project: NetBeans
> Issue Type: Bug
> Components: apisupport - Maven
>Affects Versions: 12.5, 12.6
>Reporter: Thomas Schapitz
>Assignee: Svatopluk Dedic
>Priority: Critical
> Labels: pull-request-available
> Fix For: NB13
>
> Attachments: image-2021-12-31-10-27-08-275.png,
> image-2021-12-31-10-30-58-143.png, image-2022-01-13-19-09-32-623.png,
> image-2022-01-13-19-27-19-230.png
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The following hardcopy illustrates the problem.
> It *is* possible, to add a new definition, but afterwards, it is no longer
> possible to maintain values for the goals & profiles, as has been the case up
> to version 12.3
> And it isn't possible to activate the definition, it get's created in
> disabled state. (Prior to 12.4, it wasn't possible to disable a definition)
> Furthermore, at least on Windows 10 / JDK 17, one may observe, that the
> alignment of the buttons with the list is botched, as the last one, "Disable"
> gets clipped, because the listbox default hight dictates the length.
> !image-2021-12-31-10-30-58-143.png!
>
> This is how it looked like up to 12.3:
> !image-2021-12-31-10-27-08-275.png!
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional
[jira] [Commented] (NETBEANS-6347) Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6.
[
https://issues.apache.org/jira/browse/NETBEANS-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17475330#comment-17475330
]
Svatopluk Dedic commented on NETBEANS-6347:
---
Could you please supply a sample of your global action defs ? They are located
in {*}userdir{*}/config/Projects/org-netbeans-modules-maven/nbactions.xml.
The reason for the bug is that *disabled* condition for an action is
represented as *absence* of any goal, which is the default state of any new
action. A proper fix is more complicated - filed NETBEANS-6387 to track the
progress.
The fast fix before NB13 branch point is simply to assume user-defined actions
as always enabled + necessary adjustments in UI.
> Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6.
> ---
>
> Key: NETBEANS-6347
> URL: https://issues.apache.org/jira/browse/NETBEANS-6347
> Project: NetBeans
> Issue Type: Bug
> Components: apisupport - Maven
>Affects Versions: 12.5, 12.6
>Reporter: Thomas Schapitz
>Assignee: Neil C Smith
>Priority: Critical
> Labels: pull-request-available
> Fix For: NB13
>
> Attachments: image-2021-12-31-10-27-08-275.png,
> image-2021-12-31-10-30-58-143.png
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The following hardcopy illustrates the problem.
> It *is* possible, to add a new definition, but afterwards, it is no longer
> possible to maintain values for the goals & profiles, as has been the case up
> to version 12.3
> And it isn't possible to activate the definition, it get's created in
> disabled state. (Prior to 12.4, it wasn't possible to disable a definition)
> Furthermore, at least on Windows 10 / JDK 17, one may observe, that the
> alignment of the buttons with the list is botched, as the last one, "Disable"
> gets clipped, because the listbox default hight dictates the length.
> !image-2021-12-31-10-30-58-143.png!
>
> This is how it looked like up to 12.3:
> !image-2021-12-31-10-27-08-275.png!
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org
For additional commands, e-mail: commits-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-6347) Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6.
[ https://issues.apache.org/jira/browse/NETBEANS-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474728#comment-17474728 ] Neil C Smith commented on NETBEANS-6347: Have opened a pull request to revert the change that causes this. Also breaks the project level actions configuration as well as at global level. > Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6. > --- > > Key: NETBEANS-6347 > URL: https://issues.apache.org/jira/browse/NETBEANS-6347 > Project: NetBeans > Issue Type: Bug > Components: apisupport - Maven >Affects Versions: 12.5, 12.6 >Reporter: Thomas Schapitz >Assignee: Neil C Smith >Priority: Major > Labels: pull-request-available > Attachments: image-2021-12-31-10-27-08-275.png, > image-2021-12-31-10-30-58-143.png > > Time Spent: 10m > Remaining Estimate: 0h > > The following hardcopy illustrates the problem. > It *is* possible, to add a new definition, but afterwards, it is no longer > possible to maintain values for the goals & profiles, as has been the case up > to version 12.3 > And it isn't possible to activate the definition, it get's created in > disabled state. (Prior to 12.4, it wasn't possible to disable a definition) > Furthermore, at least on Windows 10 / JDK 17, one may observe, that the > alignment of the buttons with the list is botched, as the last one, "Disable" > gets clipped, because the listbox default hight dictates the length. > !image-2021-12-31-10-30-58-143.png! > > This is how it looked like up to 12.3: > !image-2021-12-31-10-27-08-275.png! > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-6347) Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6.
[ https://issues.apache.org/jira/browse/NETBEANS-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467161#comment-17467161 ] Thomas Schapitz commented on NETBEANS-6347: --- The following hardcopy illustrates the problem. It *is* possible, to add a new definition, but afterwards, it is no longer possible to maintain values for the goals & profiles, as has been the case up to version 12.3 And it isn't possible to activate the definition, it get's created in disabled state. (Prior to 12.4, it wasn't possible to disable a definition) Furthermore, at least on Windows 10 / JDK 17, one may observe, that the alignment of the buttons with the list is botched, as the last one, "Disable" gets clipped, because the listbox default hight dictates the length. !image-2021-12-31-10-23-09-881.png! This is how it looked like up to 12.3: !image-2021-12-31-10-27-08-275.png! > Adding Global Goal Definitions for Maven is broken for 12.5 + 12.6. > --- > > Key: NETBEANS-6347 > URL: https://issues.apache.org/jira/browse/NETBEANS-6347 > Project: NetBeans > Issue Type: Bug >Reporter: Thomas Schapitz >Priority: Major > Attachments: image-2021-12-31-10-23-09-881.png, > image-2021-12-31-10-27-08-275.png > > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
