xiaoxiang781216 commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1032743975
##
arch/sim/src/sim/sim_netdriver.c:
##
@@ -72,6 +72,18 @@
#include "sim_internal.h"
+#if CONFIG_IOB_BUFSIZE >= (MAX_NETDEV_PKTSIZE + \
Review Comment:
xiaoxiang781216 commented on code in PR #7678:
URL: https://github.com/apache/nuttx/pull/7678#discussion_r1032734790
##
drivers/segger/rtt_stream.c:
##
@@ -0,0 +1,192 @@
+/
+ *
xiaoxiang781216 opened a new pull request, #7700:
URL: https://github.com/apache/nuttx/pull/7700
## Summary
- libc/stream: Rename lib_stream_[put|get]c to lib_stream_[put|get]
- libc/stdio: Don't set FL_[LONG|SHORT] repeatly in vsprintf_internal
- libc/stdio: Don't count the
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new bfb1ca7c Publishing web:
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
commit 9cdb865c9cbc6805ed97144b42e4be799f6701b6
Author: SuGliger
AuthorDate: Fri Nov 25 15:00:30 2022 -0300
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
commit 83a4b45dd4c7f9e510812062df708429c4ae8628
Author: SuGliger
AuthorDate: Fri Nov 25 15:04:17 2022 -0300
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from a0ded9d0d4 fs_epoll: [bug fix] epoll node use-after-free in epoll
extend list
new 9cdb865c9c
xiaoxiang781216 merged PR #7693:
URL: https://github.com/apache/nuttx/pull/7693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new a0ded9d0d4 fs_epoll: [bug fix] epoll node
xiaoxiang781216 merged PR #7699:
URL: https://github.com/apache/nuttx/pull/7699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git
The following commit(s) were added to refs/heads/master by this push:
new e978ad4c project.yml: Fix typo in
xiaoxiang781216 merged PR #81:
URL: https://github.com/apache/nuttx-website/pull/81
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git
The following commit(s) were added to refs/heads/master by this push:
new 5b09e214 Navigation: Use https for
xiaoxiang781216 merged PR #82:
URL: https://github.com/apache/nuttx-website/pull/82
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 47bc703c Publishing web:
anchao commented on PR #7678:
URL: https://github.com/apache/nuttx/pull/7678#issuecomment-1327884622
>> @xiaoxiang781216 I recall you were doing a documentation about using
Segger JLink System View with NuttX, do you have some news about it?
> @anchao could you take a time:)?
hartmannathan opened a new pull request, #82:
URL: https://github.com/apache/nuttx-website/pull/82
## Summary
In the navigation dropdown menu, change http to https for foundation-wide
links.
## Impact
None.
## Testing
Verified links work with https.
--
This is an automated email from the ASF dual-hosted git repository.
hartmannathan pushed a commit to branch https-nav
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git
commit cf38b4d0880dbf986db5ad9473999ff4fde3d3db
Author: Nathan Hartman
This is an automated email from the ASF dual-hosted git repository.
hartmannathan pushed a change to branch https-nav
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git
at cf38b4d0 Navigation: Use https for user-facing apache.org links
This branch includes the following
hartmannathan opened a new pull request, #81:
URL: https://github.com/apache/nuttx-website/pull/81
## Summary
Although `unix_name` is not currently utilized (except in a commented
section), fixing this typo to prevent it being used by mistake in the future.
## Impact
This is an automated email from the ASF dual-hosted git repository.
hartmannathan pushed a change to branch typo-unix-name
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git
at 39f599df project.yml: Fix typo in value of unix_name
This branch includes the following new
This is an automated email from the ASF dual-hosted git repository.
hartmannathan pushed a commit to branch typo-unix-name
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git
commit 39f599dff255b79f68d1072e0b8f5211d50e3b15
Author: Nathan Hartman
hartmannathan commented on PR #7669:
URL: https://github.com/apache/nuttx/pull/7669#issuecomment-1327797275
> @hartmannathan I will need to do some more work to get this done. We can
either leave the container alone in this PR for now (just reference the images)
which will let this pass,
btashton commented on PR #7669:
URL: https://github.com/apache/nuttx/pull/7669#issuecomment-1327780852
@hartmannathan I will need to do some more work to get this done. We can
either leave the container alone in this PR for now (just reference the images)
which will let this pass, or we
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1032636239
##
net/utils/net_ipchksum.c:
##
@@ -160,7 +168,15 @@ uint16_t ipv6_upperlayer_chksum(FAR struct net_driver_s
*dev,
/* Sum IP payload data. */
- sum = chksum(sum,
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1032635835
##
net/utils/utils.h:
##
@@ -377,6 +430,20 @@ uint16_t udp_ipv6_chksum(FAR struct net_driver_s *dev);
uint16_t icmp_chksum(FAR struct net_driver_s *dev, int len);
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1032635300
##
net/utils/utils.h:
##
@@ -211,6 +211,28 @@ void net_ipv6_pref2mask(uint8_t preflen, net_ipv6addr_t
mask);
uint16_t chksum(uint16_t sum, FAR const uint8_t *data,
anchao commented on code in PR #7616:
URL: https://github.com/apache/nuttx/pull/7616#discussion_r1032635044
##
arch/sim/src/sim/sim_netdriver.c:
##
@@ -72,6 +72,19 @@
#include "sim_internal.h"
+#if CONFIG_IOB_BUFSIZE > (MAX_NETDEV_PKTSIZE + \
Review Comment:
Done
--
SuGlider commented on PR #7693:
URL: https://github.com/apache/nuttx/pull/7693#issuecomment-1327759808
> @SuGlider please squash and rebase your branch
Done. Let me know if this is all fine.
--
This is an automated message from the Apache Git Service.
To respond to the message,
SuGlider closed pull request #7693: Adds ESP32-WroverKit LUA config and fixes
LEDs setup
URL: https://github.com/apache/nuttx/pull/7693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
CV-Bowen opened a new pull request, #7699:
URL: https://github.com/apache/nuttx/pull/7699
## Summary
should use list_for_every_entry_safe() instead list_for_every_entry() to
free the epoll_node in the extend list
## Impact
epoll
## Testing
local test on sim
--
Gary-Hobson commented on code in PR #7680:
URL: https://github.com/apache/nuttx/pull/7680#discussion_r1032595620
##
drivers/segger/rtt_initialize.c:
##
@@ -0,0 +1,53 @@
+/
+ *
SuGlider commented on code in PR #7693:
URL: https://github.com/apache/nuttx/pull/7693#discussion_r1032596444
##
boards/xtensa/esp32/esp32-wrover-kit/configs/lua/defconfig:
##
@@ -0,0 +1,80 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make
Gary-Hobson commented on code in PR #7680:
URL: https://github.com/apache/nuttx/pull/7680#discussion_r1032595620
##
drivers/segger/rtt_initialize.c:
##
@@ -0,0 +1,53 @@
+/
+ *
xiaoxiang781216 commented on code in PR #7674:
URL: https://github.com/apache/nuttx/pull/7674#discussion_r1032595554
##
drivers/syslog/syslog_stream.c:
##
@@ -0,0 +1,393 @@
+/
+ *
btashton merged PR #80:
URL: https://github.com/apache/nuttx-website/pull/80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
btashton commented on PR #7669:
URL: https://github.com/apache/nuttx/pull/7669#issuecomment-1327648137
Looks like we just need to sort the build image out. I'll do that this
morning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
xiaoxiang781216 commented on code in PR #7680:
URL: https://github.com/apache/nuttx/pull/7680#discussion_r1032560962
##
drivers/segger/rtt_initialize.c:
##
@@ -0,0 +1,53 @@
+/
+ *
btashton commented on PR #7669:
URL: https://github.com/apache/nuttx/pull/7669#issuecomment-1327637765
There are a couple details that we may need to fix. I'm not sure the
container reference will magically work without pushing a new one (possibly it
will). The checks are failing here
xiaoxiang781216 commented on code in PR #7678:
URL: https://github.com/apache/nuttx/pull/7678#discussion_r1032546737
##
drivers/segger/rtt_stream.c:
##
@@ -0,0 +1,126 @@
+/
+ *
PeterBee97 commented on code in PR #7687:
URL: https://github.com/apache/nuttx/pull/7687#discussion_r1032545903
##
drivers/video/video.c:
##
@@ -1161,6 +1162,15 @@ static int video_qbuf(FAR struct video_mng_s *vmng,
memcpy(>buf, buf, sizeof(struct v4l2_buffer));
PeterBee97 commented on code in PR #7687:
URL: https://github.com/apache/nuttx/pull/7687#discussion_r1032545173
##
video/Kconfig:
##
@@ -13,6 +13,10 @@ config VIDEO
if VIDEO
+config VIDEO_DEV_PATH
+ string "video device path"
Review Comment:
Done
--
This is
TimJTi opened a new pull request, #7698:
URL: https://github.com/apache/nuttx/pull/7698
## Summary
4th attempt :)
Fixes PIO definitions for ATSAMA5D2
## Impact
none
## Testing
Used GPIO testing example app to check GPIO operation, inputs, outputs and
SuGlider commented on code in PR #7693:
URL: https://github.com/apache/nuttx/pull/7693#discussion_r1032526811
##
boards/xtensa/esp32/esp32-wrover-kit/configs/lua/defconfig:
##
@@ -0,0 +1,80 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make
SuGlider commented on code in PR #7693:
URL: https://github.com/apache/nuttx/pull/7693#discussion_r1032526811
##
boards/xtensa/esp32/esp32-wrover-kit/configs/lua/defconfig:
##
@@ -0,0 +1,80 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make
xiaoxiang781216 commented on PR #7695:
URL: https://github.com/apache/nuttx/pull/7695#issuecomment-1327570610
@acassis @flyingfish89 has more better fix for this problem, let's wait the
update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
Gary-Hobson commented on PR #7680:
URL: https://github.com/apache/nuttx/pull/7680#issuecomment-1327564848
> @Gary-Hobson could you please include a Documentation/ about it?
Of course, I will submit a separate readme about the use of Segger J Link
RTT later
Or submit it I use
tmedicci commented on code in PR #7693:
URL: https://github.com/apache/nuttx/pull/7693#discussion_r1032502378
##
boards/xtensa/esp32/esp32-wrover-kit/include/board.h:
##
@@ -53,18 +53,40 @@
#define BOARD_LED10
#define BOARD_LED21
#define BOARD_LED32
hartmannathan commented on PR #7669:
URL: https://github.com/apache/nuttx/pull/7669#issuecomment-1327540807
@xiaoxiang781216 The checks appear to be broken and I am not sure what is
missing. Does this usually happen when modifying the workflow scripts?
--
This is an automated message
acassis commented on PR #7693:
URL: https://github.com/apache/nuttx/pull/7693#issuecomment-1327506920
@SuGlider please squash and rebase your branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
acassis closed issue #7670: GigaDevice 4 byte address status register bit -
incorrect?
URL: https://github.com/apache/nuttx/issues/7670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
xiaoxiang781216 commented on PR #7678:
URL: https://github.com/apache/nuttx/pull/7678#issuecomment-1327500179
> @xiaoxiang781216 I recall you were doing a documentation about using
Segger JLink System View with NuttX, do you have some news about it?
@anchao could you take a time:)?
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
commit 377bf976131a434c104e6fe2706d0dec33a319ec
Author: yinshengkai
AuthorDate: Fri Nov 25 17:19:45 2022 +0800
stream:
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
commit 511070c300a18768927c5398f8ac26359e54d1db
Author: yinshengkai
AuthorDate: Fri Nov 25 17:19:45 2022 +0800
include:
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 2f2176151e fs_epoll: [bug fix] EPOLL_CTL_ADD/MOD consider the teardown
list too
new 511070c300 include:
xiaoxiang781216 merged PR #7688:
URL: https://github.com/apache/nuttx/pull/7688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 2f2176151e fs_epoll: [bug fix]
xiaoxiang781216 merged PR #7696:
URL: https://github.com/apache/nuttx/pull/7696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
TimJTi commented on PR #7697:
URL: https://github.com/apache/nuttx/pull/7697#issuecomment-1327481890
It is sayingh io want to merge 23 commits - I don't. I am close to giving up
on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
TimJTi closed pull request #7697: SAMA5D2 PIO corrections
URL: https://github.com/apache/nuttx/pull/7697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
TimJTi opened a new pull request, #7697:
URL: https://github.com/apache/nuttx/pull/7697
## Summary
3rd time lucky? Corrects PIO VBASE definitions to allow all 4 PIO banks on
SAMA5D2 to work properly
## Impact
None
## Testing
GPIO test example app used to verify
hartmannathan commented on PR #7669:
URL: https://github.com/apache/nuttx/pull/7669#issuecomment-1327475131
@btashton The checks are failing even though the repositories have been
renamed. Do you know what else needs to be updated to make the checks pass
again?
--
This is an automated
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 4075509579 4 byte read mode bit position
acassis commented on code in PR #7691:
URL: https://github.com/apache/nuttx/pull/7691#discussion_r1032441603
##
drivers/mtd/gd25.c:
##
@@ -107,6 +107,7 @@
#define GD25_SR_WIP (1 << 0) /* Bit 0: Write in Progress */
#define GD25_SR_WEL (1 << 1)
acassis merged PR #7691:
URL: https://github.com/apache/nuttx/pull/7691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lucasssvaz commented on code in PR #7693:
URL: https://github.com/apache/nuttx/pull/7693#discussion_r1032441040
##
boards/xtensa/esp32/esp32-wrover-kit/configs/lua/defconfig:
##
@@ -0,0 +1,80 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make
hartmannathan commented on PR #7669:
URL: https://github.com/apache/nuttx/pull/7669#issuecomment-1327446688
> @hartmannathan I think now it can me merged
@acassis Yay! I will mark it ready for review.
Please check carefully: this patch affects the GitHub workflows!!
fjpanag commented on PR #7525:
URL: https://github.com/apache/nuttx/pull/7525#issuecomment-1327443806
Also added the maximum connections limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
xiaoxiang781216 commented on code in PR #7674:
URL: https://github.com/apache/nuttx/pull/7674#discussion_r1032421458
##
include/nuttx/syslog/syslog.h:
##
@@ -243,6 +244,55 @@ int syslog_initialize(void);
FAR struct syslog_channel_s *syslog_file_channel(FAR const char
lucasssvaz commented on code in PR #7693:
URL: https://github.com/apache/nuttx/pull/7693#discussion_r1032411662
##
boards/xtensa/esp32/esp32-wrover-kit/configs/lua/defconfig:
##
@@ -0,0 +1,80 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make
SuGlider commented on code in PR #7693:
URL: https://github.com/apache/nuttx/pull/7693#discussion_r1032404565
##
boards/xtensa/esp32/esp32-wrover-kit/configs/lua/defconfig:
##
@@ -0,0 +1,80 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make
fjpanag commented on PR #7525:
URL: https://github.com/apache/nuttx/pull/7525#issuecomment-1327402938
This is my second take on improving dynamically allocated connections.
Now a pool of preallocated connections is created during start.
These connections are preferred, reducing
TimJTi commented on PR #7614:
URL: https://github.com/apache/nuttx/pull/7614#issuecomment-1327402055
Closing as this is merged with other changes in a PR I have closed and same
applies here - my lack of github skills have rendered the PR a waste of time.
--
This is an automated message
TimJTi closed pull request #7614: SAMA5D2 pio errors
URL: https://github.com/apache/nuttx/pull/7614
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
TimJTi closed pull request #7595: SAMA5Dx ADC and TSD fixes
URL: https://github.com/apache/nuttx/pull/7595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
TimJTi commented on PR #7595:
URL: https://github.com/apache/nuttx/pull/7595#issuecomment-1327401283
Closing as my lack of github skills have made this PR a waste of time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
TimJTi commented on code in PR #7595:
URL: https://github.com/apache/nuttx/pull/7595#discussion_r1032396843
##
arch/arm/src/sama5/sam_tsd.c:
##
@@ -245,12 +257,7 @@ static const struct file_operations g_tsdops =
/* The driver state structure is pre-allocated. */
-static
acassis commented on PR #7678:
URL: https://github.com/apache/nuttx/pull/7678#issuecomment-1327391290
@xiaoxiang781216 I recall you were doing a documentation about using Segger
JLink System View with NuttX, do you have some news about it?
--
This is an automated message from the Apache
acassis commented on PR #7680:
URL: https://github.com/apache/nuttx/pull/7680#issuecomment-1327389319
@Gary-Hobson could you please include a Documentation/ about it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
TimJTi commented on code in PR #7691:
URL: https://github.com/apache/nuttx/pull/7691#discussion_r1032386682
##
drivers/mtd/gd25.c:
##
@@ -107,6 +107,7 @@
#define GD25_SR_WIP (1 << 0) /* Bit 0: Write in Progress */
#define GD25_SR_WEL (1 << 1)
acassis commented on PR #7669:
URL: https://github.com/apache/nuttx/pull/7669#issuecomment-1327386740
@hartmannathan I think now it can me merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from c2d083e3c1 Update boards/arm64/a64/pinephone/src/pinephone_boardinit.c
add b45f113943 boards/sparc add initial
acassis merged PR #7685:
URL: https://github.com/apache/nuttx/pull/7685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
acassis commented on code in PR #7691:
URL: https://github.com/apache/nuttx/pull/7691#discussion_r1032381233
##
drivers/mtd/gd25.c:
##
@@ -107,6 +107,7 @@
#define GD25_SR_WIP (1 << 0) /* Bit 0: Write in Progress */
#define GD25_SR_WEL (1 << 1)
acassis commented on code in PR #7691:
URL: https://github.com/apache/nuttx/pull/7691#discussion_r1032380362
##
drivers/mtd/gd25.c:
##
@@ -107,6 +107,7 @@
#define GD25_SR_WIP (1 << 0) /* Bit 0: Write in Progress */
#define GD25_SR_WEL (1 << 1)
lucasssvaz commented on code in PR #7693:
URL: https://github.com/apache/nuttx/pull/7693#discussion_r1032376791
##
boards/xtensa/esp32/esp32-wrover-kit/configs/lua/defconfig:
##
@@ -0,0 +1,80 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make
CV-Bowen opened a new pull request, #7696:
URL: https://github.com/apache/nuttx/pull/7696
## Summary
bug fix: should consider the teardown list in EPOLL_CTL_ADD and
EPOLL_CTL_MOD operation too.
## Impact
epoll
## Testing
local test in sim.
--
This is an
lucasssvaz commented on PR #7693:
URL: https://github.com/apache/nuttx/pull/7693#issuecomment-1327356061
Also, please fix the `esp32-wrover-kit/lua` defconfig.
You can use `./tools/refresh.sh esp32-wrover-kit:lua` to generate the
correct options in the file. You can probably use all the
lucasssvaz commented on code in PR #7693:
URL: https://github.com/apache/nuttx/pull/7693#discussion_r1032316041
##
boards/xtensa/esp32/esp32-wrover-kit/include/board.h:
##
@@ -53,18 +53,39 @@
#define BOARD_LED10
#define BOARD_LED21
#define BOARD_LED32
TimJTi commented on PR #7614:
URL: https://github.com/apache/nuttx/pull/7614#issuecomment-1327337644
Let me know if there's anything else (apart from he static initialization
discussed above) you'd like done. As I gain more GitHub experience (aka PAIN) I
could close this and resubmit as a
TimJTi commented on code in PR #7614:
URL: https://github.com/apache/nuttx/pull/7614#discussion_r1032315114
##
arch/arm/src/sama5/sama5d2x_pio.c:
##
@@ -262,6 +262,32 @@ static uint32_t sam_configcommon(pio_pinset_t cfgset)
break;
}
+ /* Select Input Event
TimJTi commented on code in PR #7614:
URL: https://github.com/apache/nuttx/pull/7614#discussion_r1032314697
##
arch/arm/src/sama5/sama5d2x_pio.c:
##
@@ -262,6 +262,32 @@ static uint32_t sam_configcommon(pio_pinset_t cfgset)
break;
}
+ /* Select Input Event
TimJTi commented on code in PR #7614:
URL: https://github.com/apache/nuttx/pull/7614#discussion_r1032314382
##
arch/arm/src/sama5/sam_tsd.c:
##
@@ -1655,7 +1735,10 @@ int sam_tsd_register(struct sam_adc_s *adc, int minor)
/* Initialize the touchscreen device driver
xiaoxiang781216 commented on code in PR #7616:
URL: https://github.com/apache/incubator-nuttx/pull/7616#discussion_r1032167540
##
net/utils/net_ipchksum.c:
##
@@ -160,7 +168,15 @@ uint16_t ipv6_upperlayer_chksum(FAR struct net_driver_s
*dev,
/* Sum IP payload data. */
-
Gary-Hobson commented on code in PR #7688:
URL: https://github.com/apache/incubator-nuttx/pull/7688#discussion_r1032178943
##
include/nuttx/streams.h:
##
@@ -40,6 +40,25 @@
* Pre-processor Definitions
xiaoxiang781216 commented on code in PR #7616:
URL: https://github.com/apache/incubator-nuttx/pull/7616#discussion_r1032034557
##
net/utils/utils.h:
##
@@ -211,6 +211,28 @@ void net_ipv6_pref2mask(uint8_t preflen, net_ipv6addr_t
mask);
uint16_t chksum(uint16_t sum, FAR
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
from 9bfc91e6f1 libc/stream: Remove \n special handle from syslogstream_putc
add b31054b1e3 arch/arm64:
xiaoxiang781216 merged PR #7692:
URL: https://github.com/apache/incubator-nuttx/pull/7692
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
xiaoxiang781216 commented on PR #7688:
URL: https://github.com/apache/incubator-nuttx/pull/7688#issuecomment-1327170323
please rebase to the last master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
xiaoxiang781216 commented on code in PR #7688:
URL: https://github.com/apache/incubator-nuttx/pull/7688#discussion_r1032131324
##
include/nuttx/streams.h:
##
@@ -40,6 +40,25 @@
* Pre-processor Definitions
1 - 100 of 104 matches
Mail list logo
