lipengfei28 commented on code in PR #16798:
URL: https://github.com/apache/nuttx/pull/16798#discussion_r2275301435
##
arch/arm64/src/imx9/imx9_scmi.h:
##
@@ -29,6 +29,7 @@
/
#include
+#include "har
lipengfei28 commented on code in PR #16798:
URL: https://github.com/apache/nuttx/pull/16798#discussion_r2275290038
##
arch/arm64/src/imx9/imx9_iomuxc.h:
##
@@ -54,13 +74,38 @@
.pad= (_pad), \
.mux= (_mux), \
}
-
+#endif
/**
lipengfei28 commented on code in PR #16798:
URL: https://github.com/apache/nuttx/pull/16798#discussion_r2275288669
##
arch/arm64/src/imx9/hardware/imx95/imx95_iomuxc.h:
##
@@ -0,0 +1,810 @@
+/
+ * arch/a
anchao commented on PR #16763:
URL: https://github.com/apache/nuttx/pull/16763#issuecomment-3186584098
> @comejv @anchao @xiaoxiang781216 I don't see Nix support as something bad,
of course, there are many Package managers out here, but people are free to add
it. After all this is an democr
nuttxs commented on PR #16845:
URL: https://github.com/apache/nuttx/pull/16845#issuecomment-3186528712
@acassis
I have verified the alignment and offset information locally and also
received feedback
(https://github.com/apache/nuttx/pull/14595#issuecomment-3186414042). I have
updated t
nuttxs commented on code in PR #16845:
URL: https://github.com/apache/nuttx/pull/16845#discussion_r2275125760
##
include/sys/socket.h:
##
@@ -323,7 +323,7 @@
* the fields of those structures without alignment problems.
*/
-struct sockaddr_storage
+struct aligned_data(SS_AL
xiaoxiang781216 commented on code in PR #16838:
URL: https://github.com/apache/nuttx/pull/16838#discussion_r2275074758
##
include/nuttx/sensors/tmp112.h:
##
@@ -0,0 +1,95 @@
+/
+ * include/nuttx/sensors/
wenquan2015 commented on PR #14595:
URL: https://github.com/apache/nuttx/pull/14595#issuecomment-3186414042
> > @nuttxs hi, this patch results the struct sockaddr_storage aligned by 2,
if a struct contains the struct sockaddr_storage as member peer and have a 2
bytes length memb
comejv commented on PR #16763:
URL: https://github.com/apache/nuttx/pull/16763#issuecomment-3186313859
Nix isn't a build system though, it just handles dependencies. But I see
your point
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new e1104b7b2 Publishing web: 51627ec
acassis commented on PR #16838:
URL: https://github.com/apache/nuttx/pull/16838#issuecomment-3186079649
@nmaggioni alternatively you can modify (or add a new tmp112_orb.c) to make
it compatible with orb test sensor app.
--
This is an automated message from the Apache Git Service.
To respo
acassis commented on PR #3154:
URL: https://github.com/apache/nuttx-apps/pull/3154#issuecomment-3186064780
> Does Nuttx actually support the `export` target in cmake as of today?
I think it is not supported yet, cmake is relatively new on NuttX and it is
not the official building syst
acassis commented on PR #16841:
URL: https://github.com/apache/nuttx/pull/16841#issuecomment-3186059247
> @acassis I will look into that, I am currently waiting for more hardware
to test this properly. Anyway, this code also works fine for a single board.
Great! Please include all the
acassis commented on PR #16845:
URL: https://github.com/apache/nuttx/pull/16845#issuecomment-3186053284
@nuttxs did you test in real hardware and qemu? Let me include needs more
test while it still in Draft
--
This is an automated message from the Apache Git Service.
To respond to the mes
acassis commented on PR #16763:
URL: https://github.com/apache/nuttx/pull/16763#issuecomment-3186039211
@comejv @anchao @xiaoxiang781216 I don't see Nix support as something bad,
of course, there are many Package managers out here, but people are free to add
it. At the end it is an democrat
jlaitine commented on code in PR #16673:
URL: https://github.com/apache/nuttx/pull/16673#discussion_r2274632825
##
sched/sched/sched_unlock.c:
##
@@ -69,28 +76,41 @@ void sched_unlock(void)
* then pre-emption has been re-enabled.
*/
- if (rtcb != NULL && -
jlaitine commented on code in PR #16673:
URL: https://github.com/apache/nuttx/pull/16673#discussion_r2274632825
##
sched/sched/sched_unlock.c:
##
@@ -69,28 +76,41 @@ void sched_unlock(void)
* then pre-emption has been re-enabled.
*/
- if (rtcb != NULL && -
jlaitine commented on PR #16673:
URL: https://github.com/apache/nuttx/pull/16673#issuecomment-3185858003
> We found a new issue on ESP32-S3 with SMP + SPI Flash enabled:
>
> The `spi_flash_op_block_task` doesn't run on the second core (it was
created within the critical section). It k
comejv commented on PR #16830:
URL: https://github.com/apache/nuttx/pull/16830#issuecomment-3185809670
I got it! I only updated the cmake pipeline, forgot about the makefiles.
Will push one last time.
--
This is an automated message from the Apache Git Service.
To respond to the message,
tmedicci commented on code in PR #16673:
URL: https://github.com/apache/nuttx/pull/16673#discussion_r2274539973
##
sched/sched/sched_unlock.c:
##
@@ -69,28 +76,41 @@ void sched_unlock(void)
* then pre-emption has been re-enabled.
*/
- if (rtcb != NULL && -
cederom commented on PR #3154:
URL: https://github.com/apache/nuttx-apps/pull/3154#issuecomment-3185546648
> @zdebanos: Does Nuttx actually support the `export` target in cmake as of
today?
I am Make user, sorry, maybe @raiden00pl will know? :-)
--
This is an automated message from
zdebanos commented on PR #3154:
URL: https://github.com/apache/nuttx-apps/pull/3154#issuecomment-3185439925
Does Nuttx actually support the `export` target as of today?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
zdebanos opened a new pull request, #16849:
URL: https://github.com/apache/nuttx/pull/16849
Use this command to extract archives.
Not all architectures are modified, only those commands I know or could be
logically deducted from the rest were added.
## Summary
A useful multiplat
jlaitine commented on issue #16430:
URL: https://github.com/apache/nuttx/issues/16430#issuecomment-3185005754
I hid the previous comment. The PR was wrong, I just got confused by the
several different signal delivery paths. (which also justifies this issue ...
signal delivery is too complic
jlaitine commented on PR #16847:
URL: https://github.com/apache/nuttx/pull/16847#issuecomment-3184998109
This was just wrong. I got confused, sorry for the noise. Closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
jlaitine closed pull request #16847: arm64/riscv schedulesigaction: Remove
redundant zeroing of tcb->sigdeliver
URL: https://github.com/apache/nuttx/pull/16847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jlaitine commented on PR #16847:
URL: https://github.com/apache/nuttx/pull/16847#issuecomment-3184717802
I'll have to check this one again, it is failing the CI ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
hartmannathan commented on code in PR #16846:
URL: https://github.com/apache/nuttx/pull/16846#discussion_r2273818643
##
arch/arm64/src/common/arm64_schedulesigaction.c:
##
Review Comment:
I don't have hardware to test right now. Commit log looks good.
--
This is an auto
cederom commented on PR #3154:
URL: https://github.com/apache/nuttx-apps/pull/3154#issuecomment-3184382224
Yup, the same for SED it is sed on Linux, while on BSD sed is "bsd sed" and
gsed (GNU sed compatible with Linux one), we should also add SEDX variable for
sed :D
--
This is an auto
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from fa9f771a0fd arch/arm/rp2040: Implement GPIO output override
functionality
add 7ea3f8e333f arch/arm/rp2040: Sup
xiaoxiang781216 merged PR #16842:
URL: https://github.com/apache/nuttx/pull/16842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 8a157d7514b arch/arm64_schedulesigaction.c: Fix signal delivery in EL1
when MMU is enabled
add fa9f771a0fd arc
xiaoxiang781216 merged PR #16840:
URL: https://github.com/apache/nuttx/pull/16840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
xiaoxiang781216 commented on code in PR #16845:
URL: https://github.com/apache/nuttx/pull/16845#discussion_r2273803493
##
include/sys/socket.h:
##
@@ -323,7 +323,7 @@
* the fields of those structures without alignment problems.
*/
-struct sockaddr_storage
+struct aligned_d
xiaoxiang781216 commented on code in PR #16848:
URL: https://github.com/apache/nuttx/pull/16848#discussion_r2273789408
##
boards/risc-v/rp23xx-rv/common/src/rp23xx_reset.c:
##
@@ -60,11 +61,20 @@ int board_reset(int status)
{
syslog(LOG_INFO, "reboot status=%d\n", status);
cederom commented on PR #3159:
URL: https://github.com/apache/nuttx-apps/pull/3159#issuecomment-3184338976
Thanks for the update @nmaggioni :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
xiaoxiang781216 merged PR #16846:
URL: https://github.com/apache/nuttx/pull/16846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 83dd57a488c crypto/hmac: Fix typo in function implementation names
add 8a157d7514b arch/arm64_schedulesigaction
xiaoxiang781216 merged PR #16839:
URL: https://github.com/apache/nuttx/pull/16839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 6f38806a5d5 arch/arm64/imx9: Fix first trace
add 83dd57a488c crypto/hmac: Fix typo in function implementation n
zdebanos commented on PR #3154:
URL: https://github.com/apache/nuttx-apps/pull/3154#issuecomment-3184292519
I also forgot to mention one problem I've come accross. I've found out that
the $(AR) variable in the nuttx build system is set to `ar rcs` on Unix.
Shouldn't it be rather `ar`, only?
comejv commented on PR #16763:
URL: https://github.com/apache/nuttx/pull/16763#issuecomment-3184290714
Should I revert and create another repo? Or maybe move it into tools?
@anchao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
xiaoxiang781216 merged PR #3159:
URL: https://github.com/apache/nuttx-apps/pull/3159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new d8dcc9926 crypto/libsodium: Update libsod
xiaoxiang781216 merged PR #3160:
URL: https://github.com/apache/nuttx-apps/pull/3160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new b0726955a fsutils/libtinycbor: Update Tin
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 056f04d17 tools/mksymtab: Replace depreca
xiaoxiang781216 merged PR #3161:
URL: https://github.com/apache/nuttx-apps/pull/3161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...
lipengfei28 commented on code in PR #16772:
URL: https://github.com/apache/nuttx/pull/16772#discussion_r2273594863
##
include/nuttx/pci/pcie_dw.h:
##
@@ -0,0 +1,569 @@
+/
+ * include/nuttx/pci/pcie_dw.h
lipengfei28 commented on code in PR #16772:
URL: https://github.com/apache/nuttx/pull/16772#discussion_r2273592324
##
include/nuttx/pci/pcie_dw.h:
##
@@ -0,0 +1,569 @@
+/
+ * include/nuttx/pci/pcie_dw.h
shtirlic commented on PR #16848:
URL: https://github.com/apache/nuttx/pull/16848#issuecomment-3184081323
@cederom try pls, `reboot bootloader` now should work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
shtirlic opened a new pull request, #16848:
URL: https://github.com/apache/nuttx/pull/16848
## Summary
Update board reset with BOOTROM functions calls
- normal reboot
- reboot to bootloader
normal reboot and reboot bootloader now possible from nsh
--
This is an au
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 1dfe1f16c6a arch/arm/rp2040: Fix Kconfig ADC options names
add 6f38806a5d5 arch/arm64/imx9: Fix first trace
No n
acassis merged PR #16844:
URL: https://github.com/apache/nuttx/pull/16844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac
nmaggioni commented on PR #3161:
URL: https://github.com/apache/nuttx-apps/pull/3161#issuecomment-3184030984
@cederom Thanks for checking on BSD - in my defense I explicitly stated
_tested on a Linux host_ ;)
I made these changes mostly to remove some noise at build time, I agree that
it
nmaggioni commented on PR #3159:
URL: https://github.com/apache/nuttx-apps/pull/3159#issuecomment-318401
@cederom Not as far as I know: the
[changelogs](https://github.com/jedisct1/libsodium/releases) report no breaking
changes and my HMAC usages in NuttX still work.
On the other
acassis commented on PR #16834:
URL: https://github.com/apache/nuttx/pull/16834#issuecomment-3183991228
Thank you @lurch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
cederom commented on PR #3159:
URL: https://github.com/apache/nuttx-apps/pull/3159#issuecomment-3183775479
Thanks @nmaggioni :-) Is 1.0.20 compatible with 1.0.18? No other application
will be broken after this update?
--
This is an automated message from the Apache Git Service.
To respond
jlaitine commented on issue #16430:
URL: https://github.com/apache/nuttx/issues/16430#issuecomment-3183728981
@maxikrie : I believe there is a race condition in signal delivery, which I
suspected earlier and then forgot about it... I now made a fix for arm64 and
risc-v platforms in https://
jlaitine opened a new pull request, #16847:
URL: https://github.com/apache/nuttx/pull/16847
## Summary
The tcb->sigdeliver is already set to NULL in the signal delivery, and it
must be done only there. Zeroing it again after the signal has been delivered
is a potential race condition
jlaitine opened a new pull request, #16846:
URL: https://github.com/apache/nuttx/pull/16846
## Summary
When delivering a signal to a kernel task, or any task in CONFIG_BUILD_FLAT
with MMU enabled, the REG_SCTLR_EL1 needs to be stored for exception return.
Otherwise 0 is res
nuttxs opened a new pull request, #16845:
URL: https://github.com/apache/nuttx/pull/16845
## Summary
Since `ss_family` is of type `uint16_t` (2-byte alignment), packing the
internal substructures will reduce the overall alignment of `sockaddr_storage`
to 2, which triggers an unaligned ac
jerpelea commented on PR #16840:
URL: https://github.com/apache/nuttx/pull/16840#issuecomment-3183389614
> @jerpelea Done. Feel free to stop the build to save some runner time
though, it'll break until #16837 is merged.
please re-base and force-push
--
This is an automated message
This is an automated email from the ASF dual-hosted git repository.
jerpelea pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 3c313a316b6 Documentation/platforms: RP2350 doesn't contain an RTC.
add be71e3d0194 arch/arm/rp2040: Fix typos i
jerpelea merged PR #16837:
URL: https://github.com/apache/nuttx/pull/16837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apa
nmaggioni commented on PR #16840:
URL: https://github.com/apache/nuttx/pull/16840#issuecomment-3183376987
@jerpelea Done. Feel free to stop the build to save some runner time though,
it'll break until #16837 is merged.
--
This is an automated message from the Apache Git Service.
To respon
xiaoxiang781216 commented on PR #16842:
URL: https://github.com/apache/nuttx/pull/16842#issuecomment-3183260845
> None of Uncrustify, nxstyle, checkpatch, or the pre-commit hooks are
catching these formatting issues. Am I missing something in my workflow?
these styles doesn't enforce
nmaggioni commented on PR #16841:
URL: https://github.com/apache/nuttx/pull/16841#issuecomment-3183221055
@acassis I will look into that, I am currently waiting for more hardware to
test this properly. Anyway, this code also works fine for a single board.
--
This is an automated message f
nmaggioni commented on PR #16842:
URL: https://github.com/apache/nuttx/pull/16842#issuecomment-3183207529
None of Uncrustify, nxstyle, checkpatch, or the pre-commit hooks are
catching these formatting issues. Am I missing something in my workflow?
--
This is an automated message from the
lurch commented on PR #16834:
URL: https://github.com/apache/nuttx/pull/16834#issuecomment-3183132863
> Cool, I posted about it on LinkedIn as well:
https://www.linkedin.com/feed/update/urn:li:activity:7360672364847579136/
>
> If you can share it there, maybe more people will discover
nuttxs commented on PR #14595:
URL: https://github.com/apache/nuttx/pull/14595#issuecomment-3183104239
> @nuttxs hi, this patch results the struct sockaddr_storage aligned by 2,
if a struct contains the struct sockaddr_storage as member peer and have a 2
bytes length member in front of the
lurch commented on PR #16834:
URL: https://github.com/apache/nuttx/pull/16834#issuecomment-3182939354
> @lurch if we implement Always-On power domain, what the better way to call
it ? `AON Timer` like in datasheet?
That's probably a question for @peterharperuk or @kilograham
--
Th
anchao commented on PR #16763:
URL: https://github.com/apache/nuttx/pull/16763#issuecomment-3182768999
@acassis @xiaoxiang781216 This is a bad start. Package manager configuration
should not be merged into the nuttx kernel. If there is a need for manager
integration, a wrapper should be mad
shtirlic commented on PR #16834:
URL: https://github.com/apache/nuttx/pull/16834#issuecomment-3182752804
@lurch if we implement Always-On power domain, what the better way to call
it ? `AON Timer` like in datasheet?
--
This is an automated message from the Apache Git Service.
To respond t
wenquan2015 commented on PR #14595:
URL: https://github.com/apache/nuttx/pull/14595#issuecomment-3182670934
@nuttxs hi, this patch results the struct sockaddr_storage aligned by 2, if
a struct contains the struct sockaddr_storage as member peer and have a 2 bytes
length member in front of
arikimari opened a new pull request, #16844:
URL: https://github.com/apache/nuttx/pull/16844
## Summary
Swap board init and uart init.
Reason is that trace might be used on board initialize function.
## Impact
Impacts only imx9 hw
No new feature
No impact on user
76 matches
Mail list logo