Re: [PR] nshlib/prompt: add empty prompt string fallbacks [nuttx-apps]

xiaoxiang781216 merged PR #2300: URL: https://github.com/apache/nuttx-apps/pull/2300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] nshlib/prompt: add empty prompt string fallbacks [nuttx-apps]

yf13 commented on code in PR #2300: URL: https://github.com/apache/nuttx-apps/pull/2300#discussion_r1501750927 ## nshlib/nsh_prompt.c: ## @@ -0,0 +1,104 @@ +/ + * apps/nshlib/nsh_prompt.c + * + *

Re: [PR] nshlib/prompt: add empty prompt string fallbacks [nuttx-apps]

xiaoxiang781216 commented on code in PR #2300: URL: https://github.com/apache/nuttx-apps/pull/2300#discussion_r1501745067 ## nshlib/nsh_prompt.c: ## @@ -0,0 +1,104 @@ +/ + * apps/nshlib/nsh_prompt.c + *

Re: [PR] nshlib/prompt: add empty prompt string fallbacks [nuttx-apps]

xiaoxiang781216 commented on code in PR #2300: URL: https://github.com/apache/nuttx-apps/pull/2300#discussion_r1501733238 ## nshlib/nsh_prompt.c: ## @@ -0,0 +1,104 @@ +/ + * apps/nshlib/nsh_prompt.c + *

Re: [PR] nshlib/prompt: add empty prompt string fallbacks [nuttx-apps]

xiaoxiang781216 commented on code in PR #2300: URL: https://github.com/apache/nuttx-apps/pull/2300#discussion_r1501731483 ## nshlib/nsh_prompt.c: ## @@ -0,0 +1,104 @@ +/ + * apps/nshlib/nsh_prompt.c + *

Re: [PR] nshlib/prompt: add empty prompt string fallbacks [nuttx-apps]

xiaoxiang781216 commented on code in PR #2300: URL: https://github.com/apache/nuttx-apps/pull/2300#discussion_r1501638151 ## nshlib/nsh_prompt.c: ## @@ -0,0 +1,107 @@ +/ + * apps/nshlib/nsh_prompt.c + *

Re: [PR] nshlib/prompt: add empty prompt string fallbacks [nuttx-apps]

xiaoxiang781216 commented on code in PR #2300: URL: https://github.com/apache/nuttx-apps/pull/2300#discussion_r1501472111 ## nshlib/nsh_prompt.c: ## @@ -0,0 +1,108 @@ +/ + * apps/nshlib/nsh_prompt.c + *

Re: [PR] nshlib/prompt: add empty prompt string fallbacks [nuttx-apps]

xiaoxiang781216 commented on code in PR #2300: URL: https://github.com/apache/nuttx-apps/pull/2300#discussion_r1501472111 ## nshlib/nsh_prompt.c: ## @@ -0,0 +1,108 @@ +/ + * apps/nshlib/nsh_prompt.c + *

Re: [PR] nshlib/prompt: add empty prompt string fallbacks [nuttx-apps]

xiaoxiang781216 commented on code in PR #2300: URL: https://github.com/apache/nuttx-apps/pull/2300#discussion_r1501470565 ## nshlib/nsh_prompt.c: ## @@ -0,0 +1,108 @@ +/ + * apps/nshlib/nsh_prompt.c + *

Re: [PR] nshlib/prompt: add empty prompt string fallbacks [nuttx-apps]

yf13 commented on code in PR #2300: URL: https://github.com/apache/nuttx-apps/pull/2300#discussion_r1501468144 ## nshlib/nsh_prompt.c: ## @@ -0,0 +1,106 @@ +/ + * apps/nshlib/nsh_prompt.c + * + *

Re: [PR] nshlib/prompt: add empty prompt string fallbacks [nuttx-apps]

xiaoxiang781216 commented on code in PR #2300: URL: https://github.com/apache/nuttx-apps/pull/2300#discussion_r1501455201 ## nshlib/nsh_init.c: ## @@ -110,10 +110,14 @@ void nsh_initialize(void) FAR struct console_stdio_s *pstate; #endif + /* populate NSH prompt string

Re: [PR] nshlib/prompt: add empty prompt string fallbacks [nuttx-apps]

yf13 commented on code in PR #2300: URL: https://github.com/apache/nuttx-apps/pull/2300#discussion_r1501438438 ## nshlib/nsh_init.c: ## @@ -110,10 +110,14 @@ void nsh_initialize(void) FAR struct console_stdio_s *pstate; #endif + /* populate NSH prompt string */ + +

Re: [PR] nshlib/prompt: add empty prompt string fallbacks [nuttx-apps]

xiaoxiang781216 commented on code in PR #2300: URL: https://github.com/apache/nuttx-apps/pull/2300#discussion_r1501411924 ## nshlib/Kconfig: ## @@ -66,7 +66,31 @@ config NSH_PROMPT_STRING string "Prompt String" default "nsh> " ---help--- -

Re: [PR] nshlib/prompt: add empty prompt string fallbacks [nuttx-apps]

yf13 commented on code in PR #2300: URL: https://github.com/apache/nuttx-apps/pull/2300#discussion_r1501348259 ## nshlib/nsh_prompt.c: ## @@ -0,0 +1,122 @@ +/ + * apps/nshlib/nsh_prompt.c + * + *

Re: [PR] nshlib/prompt: add empty prompt string fallbacks [nuttx-apps]

yf13 commented on code in PR #2300: URL: https://github.com/apache/nuttx-apps/pull/2300#discussion_r1501348259 ## nshlib/nsh_prompt.c: ## @@ -0,0 +1,122 @@ +/ + * apps/nshlib/nsh_prompt.c + * + *

Re: [PR] nshlib/prompt: add empty prompt string fallbacks [nuttx-apps]

yf13 commented on code in PR #2300: URL: https://github.com/apache/nuttx-apps/pull/2300#discussion_r1501355463 ## nshlib/nsh_prompt.c: ## @@ -0,0 +1,122 @@ +/ + * apps/nshlib/nsh_prompt.c + * + *

Re: [PR] nshlib/prompt: add empty prompt string fallbacks [nuttx-apps]

yf13 commented on code in PR #2300: URL: https://github.com/apache/nuttx-apps/pull/2300#discussion_r1501352284 ## nshlib/nsh_prompt.c: ## @@ -0,0 +1,122 @@ +/ + * apps/nshlib/nsh_prompt.c + * + *

Re: [PR] nshlib/prompt: add empty prompt string fallbacks [nuttx-apps]

yf13 commented on code in PR #2300: URL: https://github.com/apache/nuttx-apps/pull/2300#discussion_r1501348259 ## nshlib/nsh_prompt.c: ## @@ -0,0 +1,122 @@ +/ + * apps/nshlib/nsh_prompt.c + * + *

Re: [PR] nshlib/prompt: add empty prompt string fallbacks [nuttx-apps]

yf13 commented on code in PR #2300: URL: https://github.com/apache/nuttx-apps/pull/2300#discussion_r1501347095 ## nshlib/nsh.h: ## @@ -748,7 +750,7 @@ extern const char g_loginsuccess[]; extern const char g_badcredentials[]; extern const char g_loginfailure[]; #endif -extern

Re: [PR] nshlib/prompt: add empty prompt string fallbacks [nuttx-apps]

xiaoxiang781216 commented on code in PR #2300: URL: https://github.com/apache/nuttx-apps/pull/2300#discussion_r1501337145 ## nshlib/Kconfig: ## @@ -66,7 +66,21 @@ config NSH_PROMPT_STRING string "Prompt String" default "nsh> " ---help--- -