YuuichiNakamura opened a new pull request #1271:
URL: https://github.com/apache/incubator-nuttx/pull/1271
## Summary
This PR adds sched_note_syscall_enter/leave hooks for the system call
instrumentation.
In FLAT build, syscall wrapper library is created.
In PROTECTED/KERNEL bui
Ouss4 commented on issue #1235:
URL:
https://github.com/apache/incubator-nuttx/issues/1235#issuecomment-645901665
There already is a white list in nxstyle.c, we can just add `_Exit` to the
list.
```diff
diff --git a/tools/nxstyle.c b/tools/nxstyle.c
index 78351334bf..38b89f98df 10
Ouss4 edited a comment on issue #1235:
URL:
https://github.com/apache/incubator-nuttx/issues/1235#issuecomment-645901665
There already is a white list in nxstyle.c, we can just add `_Exit` to the
list.
```diff
diff --git a/tools/nxstyle.c b/tools/nxstyle.c
index 78351334bf..38b89f
Ouss4 edited a comment on issue #1235:
URL:
https://github.com/apache/incubator-nuttx/issues/1235#issuecomment-645901665
There already is a white list in nxstyle.c, we can just add `_Exit` to the
list.
```diff
diff --git a/tools/nxstyle.c b/tools/nxstyle.c
index 78351334bf..38b89f
davids5 commented on pull request #1268:
URL: https://github.com/apache/incubator-nuttx/pull/1268#issuecomment-645947128
@dakejahl the technical side please look into @raiden00pl query.
On the process side: Unfortunately this project has limited the committer's
ability to do the rig
davids5 commented on a change in pull request #1270:
URL: https://github.com/apache/incubator-nuttx/pull/1270#discussion_r442194428
##
File path: tools/Makefile.unix
##
@@ -25,9 +25,13 @@ include $(TOPDIR)/Make.defs
GIT_DIR = $(if $(wildcard $(TOPDIR)$(DELIM).git),y,)
+ife
acassis commented on pull request #1268:
URL: https://github.com/apache/incubator-nuttx/pull/1268#issuecomment-645995169
Congratulations Jacob! Now it is passing in the CI tests. I was going to
Merge it when I saw the raiden00pl question about why you created a new file to
RCC configuratio
patacongo commented on a change in pull request #1271:
URL: https://github.com/apache/incubator-nuttx/pull/1271#discussion_r442210048
##
File path: arch/arm/src/Makefile
##
@@ -69,6 +69,19 @@ else
NUTTX = "$(TOPDIR)$(DELIM)nuttx$(EXEEXT)"
endif
+# Additional rules for sys
patacongo commented on a change in pull request #1271:
URL: https://github.com/apache/incubator-nuttx/pull/1271#discussion_r442210048
##
File path: arch/arm/src/Makefile
##
@@ -69,6 +69,19 @@ else
NUTTX = "$(TOPDIR)$(DELIM)nuttx$(EXEEXT)"
endif
+# Additional rules for sys
patacongo merged pull request #1262:
URL: https://github.com/apache/incubator-nuttx/pull/1262
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 3ec12a8 Makefile.unix:versioning insure it is a .git dir
add 1ab98da nuttx-names.dat: add strstr.
patacongo commented on pull request #1271:
URL: https://github.com/apache/incubator-nuttx/pull/1271#issuecomment-646007116
The nxstyle failure can be be ignored. I would like to have some other
people look at this before it is merged since it has mostly impacts on the
build-related logic.
YuuichiNakamura commented on a change in pull request #1271:
URL: https://github.com/apache/incubator-nuttx/pull/1271#discussion_r442256681
##
File path: arch/arm/src/Makefile
##
@@ -69,6 +69,19 @@ else
NUTTX = "$(TOPDIR)$(DELIM)nuttx$(EXEEXT)"
endif
+# Additional rules f
v01d commented on pull request #1248:
URL: https://github.com/apache/incubator-nuttx/pull/1248#issuecomment-646051733
> We currently have ONESHOT_MAX_DELAY() macro, so the additional
ONESHOT_MIN_DELAY() macro seems like a good idea.
Adding that macro can be useful but not modifying t
raiden00pl commented on pull request #1268:
URL: https://github.com/apache/incubator-nuttx/pull/1268#issuecomment-646168801
Yes, stm32f4_rcc.c seems to be more appropriate.
From what I looked, the file stm32f40xxx_rcc.c doesn't look so bad when it
comes to #ifdefs so I don't really
raiden00pl commented on pull request #1248:
URL: https://github.com/apache/incubator-nuttx/pull/1248#issuecomment-646229938
I think it is the responsibility of the caller to provide a valid input data
for the called function. If the input is incorrect, we expect the called
function to retu
xiaoxiang781216 commented on a change in pull request #1271:
URL: https://github.com/apache/incubator-nuttx/pull/1271#discussion_r442412819
##
File path: syscall/syscall_name.c
##
@@ -0,0 +1,61 @@
+/
+
davids5 opened a new pull request #1272:
URL: https://github.com/apache/incubator-nuttx/pull/1272
## Summary
renamed call to clock_systimespec as clock_systime_timespec
## Impact
Was breaking build
## Testing
Compiles now
FYI @PetervdPerk-NXP
dakejahl commented on pull request #1268:
URL: https://github.com/apache/incubator-nuttx/pull/1268#issuecomment-646284297
Alright I'll squash and force push as a single commit. I made the extra
rcc.c file because I was trying to keep things straight in my head when doing
the bringup, and I
PetervdPerk-NXP commented on pull request #1272:
URL: https://github.com/apache/incubator-nuttx/pull/1272#issuecomment-646287829
Thanks for pointing out, I guess something went wrong with rebasing. Same
applies for
https://github.com/apache/incubator-nuttx/blob/master/arch/arm/src/kinetis/
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new b64060f s32k1xx:flexcan clock_sys
Ouss4 merged pull request #1272:
URL: https://github.com/apache/incubator-nuttx/pull/1272
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
xiaoxiang781216 commented on a change in pull request #1271:
URL: https://github.com/apache/incubator-nuttx/pull/1271#discussion_r442410205
##
File path: syscall/Makefile
##
@@ -76,27 +88,43 @@ $(BIN1): $(PROXY_OBJS)
$(BIN2): $(STUB_OBJS)
$(call ARCHIVE, $@, $(STUB_OBJ
xiaoxiang781216 commented on a change in pull request #1271:
URL: https://github.com/apache/incubator-nuttx/pull/1271#discussion_r442605091
##
File path: syscall/Makefile
##
@@ -76,27 +88,43 @@ $(BIN1): $(PROXY_OBJS)
$(BIN2): $(STUB_OBJS)
$(call ARCHIVE, $@, $(STUB_OBJ
YuuichiNakamura commented on a change in pull request #1271:
URL: https://github.com/apache/incubator-nuttx/pull/1271#discussion_r442631912
##
File path: syscall/syscall_name.c
##
@@ -0,0 +1,61 @@
+/
+
YuuichiNakamura commented on a change in pull request #1271:
URL: https://github.com/apache/incubator-nuttx/pull/1271#discussion_r442631758
##
File path: syscall/Makefile
##
@@ -76,27 +88,43 @@ $(BIN1): $(PROXY_OBJS)
$(BIN2): $(STUB_OBJS)
$(call ARCHIVE, $@, $(STUB_OBJ
YuuichiNakamura commented on a change in pull request #1271:
URL: https://github.com/apache/incubator-nuttx/pull/1271#discussion_r442631977
##
File path: tools/mksyscall.c
##
@@ -450,6 +452,27 @@ static void generate_stub(int nfixed, int nparms)
fprintf(stream, ")\n{\n");
xiaoxiang781216 commented on a change in pull request #1271:
URL: https://github.com/apache/incubator-nuttx/pull/1271#discussion_r442643767
##
File path: syscall/syscall_name.c
##
@@ -0,0 +1,61 @@
+/
+
xiaoxiang781216 commented on a change in pull request #1271:
URL: https://github.com/apache/incubator-nuttx/pull/1271#discussion_r442644376
##
File path: syscall/Makefile
##
@@ -76,27 +88,43 @@ $(BIN1): $(PROXY_OBJS)
$(BIN2): $(STUB_OBJS)
$(call ARCHIVE, $@, $(STUB_OBJ
xiaoxiang781216 commented on a change in pull request #1271:
URL: https://github.com/apache/incubator-nuttx/pull/1271#discussion_r442643767
##
File path: syscall/syscall_name.c
##
@@ -0,0 +1,61 @@
+/
+
xiaoxiang781216 commented on a change in pull request #1271:
URL: https://github.com/apache/incubator-nuttx/pull/1271#discussion_r442652974
##
File path: syscall/Makefile
##
@@ -76,27 +88,43 @@ $(BIN1): $(PROXY_OBJS)
$(BIN2): $(STUB_OBJS)
$(call ARCHIVE, $@, $(STUB_OBJ
xiaoxiang781216 commented on a change in pull request #1271:
URL: https://github.com/apache/incubator-nuttx/pull/1271#discussion_r442652974
##
File path: syscall/Makefile
##
@@ -76,27 +88,43 @@ $(BIN1): $(PROXY_OBJS)
$(BIN2): $(STUB_OBJS)
$(call ARCHIVE, $@, $(STUB_OBJ
xiaoxiang781216 commented on a change in pull request #1271:
URL: https://github.com/apache/incubator-nuttx/pull/1271#discussion_r442652974
##
File path: syscall/Makefile
##
@@ -76,27 +88,43 @@ $(BIN1): $(PROXY_OBJS)
$(BIN2): $(STUB_OBJS)
$(call ARCHIVE, $@, $(STUB_OBJ
33 matches
Mail list logo
