mrivi opened a new pull request #1623:
URL: https://github.com/apache/incubator-nuttx/pull/1623
## Summary
this PR extends the support for RTR also in cases where the extended id is
used.
## Impact
## Testing
Ouss4 commented on a change in pull request #1616:
URL: https://github.com/apache/incubator-nuttx/pull/1616#discussion_r474737098
##
File path: tools/configure.c
##
@@ -794,6 +835,8 @@ static void check_configdir(void)
static void check_configured(void)
{
+ char
davids5 commented on pull request #1577:
URL: https://github.com/apache/incubator-nuttx/pull/1577#issuecomment-678328420
@xiaoxiang781216 By doing a force push, I can not see what you changed from
what it was. So it forces me to re-review the whole thing. I will look at this
again over
patacongo commented on pull request #1577:
URL: https://github.com/apache/incubator-nuttx/pull/1577#issuecomment-678350047
> @acassis shall we ask Ken Pettit, to have a look?
Ken is a great guy and a good person to review anything. But this is an odd
request since Ken is not one of
xiaoxiang781216 commented on a change in pull request #1616:
URL: https://github.com/apache/incubator-nuttx/pull/1616#discussion_r474740592
##
File path: tools/configure.c
##
@@ -794,6 +835,8 @@ static void check_configdir(void)
static void check_configured(void)
{
+ char
acassis commented on pull request #1577:
URL: https://github.com/apache/incubator-nuttx/pull/1577#issuecomment-678343987
@davids5 I pinged Ken and he told me that will take a look.
This is an automated message from the
davids5 commented on issue #1568:
URL:
https://github.com/apache/incubator-nuttx/issues/1568#issuecomment-678362575
@fjpanag stm32_pwr_enableoverdrive sounds like a landmine, we should
probably delete it it if is not used.
davids5 commented on pull request #1623:
URL: https://github.com/apache/incubator-nuttx/pull/1623#issuecomment-678369922
@mrivi
Please run tools nxstyle on the changed file.
If the log lines MUST to be kept intact for readability you can extend the
lines of , (it is the
This is an automated email from the ASF dual-hosted git repository.
liuhaitao pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 3543950 arch: cxd56xx: Use spinlock API in cxd56_serial.c
add 8ce0ff5 arch/sim: Make
liuguo09 commented on pull request #1461:
URL: https://github.com/apache/incubator-nuttx/pull/1461#issuecomment-678173542
The mixed case letter nxstyle error could be ignored. So I'll help to merge
it.
This is an automated
liuguo09 merged pull request #1461:
URL: https://github.com/apache/incubator-nuttx/pull/1461
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
xiaoxiang781216 commented on pull request #1616:
URL: https://github.com/apache/incubator-nuttx/pull/1616#issuecomment-678324024
LGTM, but nxstyle warning need be fixed first.
This is an automated message from the Apache Git
davids5 commented on pull request #1577:
URL: https://github.com/apache/incubator-nuttx/pull/1577#issuecomment-678348205
> @davids5 I pinged Ken and he told me that will take a look.
@acassis, Ken - Thank you!
This
Ouss4 commented on a change in pull request #1616:
URL: https://github.com/apache/incubator-nuttx/pull/1616#discussion_r474735419
##
File path: tools/configure.c
##
@@ -808,12 +851,35 @@ static void check_configured(void)
}
else
{
-
Ouss4 commented on a change in pull request #1616:
URL: https://github.com/apache/incubator-nuttx/pull/1616#discussion_r474743103
##
File path: tools/configure.c
##
@@ -808,12 +851,35 @@ static void check_configured(void)
}
else
{
-
davids5 commented on pull request #1577:
URL: https://github.com/apache/incubator-nuttx/pull/1577#issuecomment-678172279
@xiaoxiang781216 - thank you for the additional information and link. More
context always helps!
What guarantees the buffer has the capacity for the expansion?
jerpelea merged pull request #1621:
URL: https://github.com/apache/incubator-nuttx/pull/1621
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
jerpelea pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 39539be xtensa/esp32: Improve SPI transmission
add 3543950 arch: cxd56xx: Use spinlock API in
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 8617cd9 Fix nxstyle warning
add 6670bc2 libc/time: Implement tm::tm_gmtoff field
No new revisions
acassis commented on pull request #1615:
URL: https://github.com/apache/incubator-nuttx/pull/1615#issuecomment-678226157
Thank you Xiang!
This is an automated message from the Apache Git Service.
To respond to the message,
acassis merged pull request #1615:
URL: https://github.com/apache/incubator-nuttx/pull/1615
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
xiaoxiang781216 commented on pull request #1577:
URL: https://github.com/apache/incubator-nuttx/pull/1577#issuecomment-678250774
@davids5 the new patch address your concern.
This is an automated message from the Apache Git
davids5 commented on pull request #1577:
URL: https://github.com/apache/incubator-nuttx/pull/1577#issuecomment-678203388
@xiaoxiang781216 Forgive all the question, I have not dug into this code
before. Does this support lazy allocation? I ask because of line 832. If it
does, does the the
xiaoxiang781216 commented on pull request #1577:
URL: https://github.com/apache/incubator-nuttx/pull/1577#issuecomment-678245898
> @xiaoxiang781216 Forgive all the question, I have not dug into this code
before. Does this support lazy allocation? I ask because of line 832. If it
does,
Ouss4 commented on pull request #1611:
URL: https://github.com/apache/incubator-nuttx/pull/1611#issuecomment-678134119
> It should work in theory.
It's already in place for branches, @btashton set it up, we use it for
releases.
An extra effort is needed to make it work with PRs,
xiaoxiang781216 commented on pull request #1577:
URL: https://github.com/apache/incubator-nuttx/pull/1577#issuecomment-678145968
> @xiaoxiang781216 would you please provide more information on how this
works and mechanism by which it saves memory?
>
I already describe the case
xiaoxiang781216 edited a comment on pull request #1611:
URL: https://github.com/apache/incubator-nuttx/pull/1611#issuecomment-678150846
> > > It should work in theory.
> >
> >
> > It's already in place for branches, @btashton set it up, we use it for
releases.
> > An extra
xiaoxiang781216 commented on pull request #1577:
URL: https://github.com/apache/incubator-nuttx/pull/1577#issuecomment-678176411
> @xiaoxiang781216 - thank you for the additional information and link. More
context always helps!
>
> What guarantees the buffer has the capacity for the
leomar95 edited a comment on pull request #1617:
URL: https://github.com/apache/incubator-nuttx/pull/1617#issuecomment-677906930
> > I tried these steps, but it didn't work for #1618
>
> It looks like your also did some 'git merge' . Merging and rebasing are
incompatible because
davids5 commented on pull request #1611:
URL: https://github.com/apache/incubator-nuttx/pull/1611#issuecomment-678137091
> > It should work in theory.
>
> It's already in place for branches, @btashton set it up, we use it for
releases.
> An extra effort is needed to make it work
acassis commented on pull request #1577:
URL: https://github.com/apache/incubator-nuttx/pull/1577#issuecomment-678247667
> @xiaoxiang781216 would you please provide more information on how this
works and mechanism by which it saves memory?
>
> @acassis shall we ask Ken Pettit, to
xiaoxiang781216 commented on a change in pull request #1616:
URL: https://github.com/apache/incubator-nuttx/pull/1616#discussion_r474697965
##
File path: tools/configure.c
##
@@ -808,12 +851,35 @@ static void check_configured(void)
}
else
{
-
RB-tel opened a new pull request #1622:
URL: https://github.com/apache/incubator-nuttx/pull/1622
## Summary
RIIC suport for RX65N
## Impact
## Testing
This is an automated message from the Apache Git
donghengqaz commented on pull request #1610:
URL: https://github.com/apache/incubator-nuttx/pull/1610#issuecomment-678147136
> LGTM, thanks @donghengqaz.
@Ouss4 Thanks for your deeply reviewing.
This is an
xiaoxiang781216 commented on pull request #1577:
URL: https://github.com/apache/incubator-nuttx/pull/1577#issuecomment-678180637
@davids5 done.
This is an automated message from the Apache Git Service.
To respond to the
btashton commented on pull request #1611:
URL: https://github.com/apache/incubator-nuttx/pull/1611#issuecomment-678236018
> > It should work in theory.
>
> It's already in place for branches, @btashton set it up, we use it for
releases.
> An extra effort is needed to make it work
xiaoxiang781216 commented on pull request #1611:
URL: https://github.com/apache/incubator-nuttx/pull/1611#issuecomment-678150846
> > > It should work in theory.
> >
> >
> > It's already in place for branches, @btashton set it up, we use it for
releases.
> > An extra effort is
Ouss4 commented on pull request #1616:
URL: https://github.com/apache/incubator-nuttx/pull/1616#issuecomment-678565445
> but nxstyle warning need be fixed first.
Done.
This is an automated message from the Apache Git
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 6670bc2 libc/time: Implement tm::tm_gmtoff field
add 1c295af tools/configure.sh: Don't distclean
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 6670bc2 libc/time: Implement tm::tm_gmtoff field
add 1c295af tools/configure.sh: Don't distclean
xiaoxiang781216 commented on pull request #1577:
URL: https://github.com/apache/incubator-nuttx/pull/1577#issuecomment-678581436
> @xiaoxiang781216 Forgive all the question, I have not dug into this code
before. Does this support lazy allocation? I ask because of line 832. If it
does,
xiaoxiang781216 merged pull request #1616:
URL: https://github.com/apache/incubator-nuttx/pull/1616
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
masayuki2009 commented on pull request #1620:
URL: https://github.com/apache/incubator-nuttx/pull/1620#issuecomment-678118898
@jerpelea
This is an automated message from the Apache Git Service.
To respond to the
jerpelea merged pull request #1620:
URL: https://github.com/apache/incubator-nuttx/pull/1620
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
jerpelea pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 8beb1ed Fix inverted errno in mq_open
add 0d971d4 arch: cxd56xx: Fix IRQ control in cxd56_dmac.c
xiaoxiang781216 commented on pull request #1577:
URL: https://github.com/apache/incubator-nuttx/pull/1577#issuecomment-678122303
@acassis could you merge this patch?
This is an automated message from the Apache Git Service.
This is an automated email from the ASF dual-hosted git repository.
liuhaitao pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 0d971d4 arch: cxd56xx: Fix IRQ control in cxd56_dmac.c
add 297c294 libc: Change ctype macro to
liuguo09 merged pull request #1496:
URL: https://github.com/apache/incubator-nuttx/pull/1496
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
masayuki2009 opened a new pull request #1621:
URL: https://github.com/apache/incubator-nuttx/pull/1621
## Summary
- This commit improves cxd56_serial performance in SMP mode.
## Impact
- This commit affects SMP mode only.
## Testing
- Tested with
Ouss4 merged pull request #1608:
URL: https://github.com/apache/incubator-nuttx/pull/1608
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
masayuki2009 commented on pull request #1621:
URL: https://github.com/apache/incubator-nuttx/pull/1621#issuecomment-678128070
@jerpelea
This is an automated message from the Apache Git Service.
To respond to the
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 297c294 libc: Change ctype macro to normal function
add b3e0116 sched/signal: Add sighandler_t
Ouss4 merged pull request #1610:
URL: https://github.com/apache/incubator-nuttx/pull/1610
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from b3e0116 sched/signal: Add sighandler_t typedef
add 39539be xtensa/esp32: Improve SPI
54 matches
Mail list logo
