xiaoxiang781216 commented on a change in pull request #1693:
URL: https://github.com/apache/incubator-nuttx/pull/1693#discussion_r484704496
##
File path: arch/sim/src/nuttx-names.in
##
@@ -34,190 +34,72 @@
NXSYMBOLS(__cxa_atexit)
NXSYMBOLS(__errno)
NXSYMBOLS(_exit)
-NXSYMBOL
xiaoxiang781216 opened a new pull request #1731:
URL: https://github.com/apache/incubator-nuttx/pull/1731
## Summary
to reflect this is just a normal note driver with ram buffer
## Impact
## Testing
T
no1wudi opened a new pull request #378:
URL: https://github.com/apache/incubator-nuttx-apps/pull/378
## Summary
Introduce wasm3 WebAssembly runtime support, with baisc test utility.
## Impact
None
## Testing
Tested on stm32
---
xiaoxiang781216 commented on a change in pull request #378:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/378#discussion_r484882626
##
File path: interpreters/wasm3/.gitignore
##
@@ -0,0 +1,2 @@
+wasm3*
+*.tar.gz
Review comment:
add a newline
---
xiaoxiang781216 commented on a change in pull request #1377:
URL: https://github.com/apache/incubator-nuttx/pull/1377#discussion_r484884535
##
File path: arch/arm/src/common/arm_initialize.c
##
@@ -163,6 +164,10 @@ void up_initialize(void)
note_register(); /* Non-standa
patacongo commented on pull request #378:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/378#issuecomment-688879055
wasm3 has an MIT license. The MIT license is compatible with Apache, but
don't you think we should at least let the user know that the resulting
binaries follow M
hartmannathan opened a new pull request #1732:
URL: https://github.com/apache/incubator-nuttx/pull/1732
## Summary
arch/arm/src/tiva/common/tiva_timerlow32.c:
* Fix nxstyle warnings. No functional changes.
## Impact
## Testing
Ran nxstyle
patacongo commented on pull request #1726:
URL: https://github.com/apache/incubator-nuttx/pull/1726#issuecomment-64714
> @patacongo ok, I see why this is now, there's a "hack" in place that keeps
the timer running.
> I don't really understand the explanation. I guess it refers to a p
hartmannathan commented on pull request #1721:
URL: https://github.com/apache/incubator-nuttx/pull/1721#issuecomment-64885
I opened [PR-1732](https://github.com/apache/incubator-nuttx/pull/1732) to
fix the nxstyle issues in this file. After that's merged please rebase this
change and l
v01d commented on pull request #1726:
URL: https://github.com/apache/incubator-nuttx/pull/1726#issuecomment-68715
> > @patacongo ok, I see why this is now, there's a "hack" in place that
keeps the timer running.
> > I don't really understand the explanation. I guess it refers to a
p
v01d opened a new issue #1733:
URL: https://github.com/apache/incubator-nuttx/issues/1733
When NuttX is configure in tickless mode, the scheduling timer will continue
to run even when there is a single task and no timeouts are pending. This means
that unless the processor goes to sleep (th
davids5 commented on pull request #1693:
URL: https://github.com/apache/incubator-nuttx/pull/1693#issuecomment-688895130
@GUIDINGLI - just curious can you use --wrap or weak to accomplish this?
This is an automated message f
patacongo commented on issue #1733:
URL:
https://github.com/apache/incubator-nuttx/issues/1733#issuecomment-688904848
This only applies to round robin scheduling, correct? Changing this could
be quite complex in the SMP case.
-
patacongo edited a comment on issue #1733:
URL:
https://github.com/apache/incubator-nuttx/issues/1733#issuecomment-688904848
This only applies to round robin scheduling, correct? Changing this could
be quite complex in the SMP case.
Is it a work around to (1) make sure that all tas
v01d commented on issue #1733:
URL:
https://github.com/apache/incubator-nuttx/issues/1733#issuecomment-688911864
I have really no idea, my understanding of this part of NuttX is very
limited.
This is an automated message fr
v01d commented on pull request #1726:
URL: https://github.com/apache/incubator-nuttx/pull/1726#issuecomment-688921942
regarding this PR: I asked for @raiden00pl for review but he may not be
available. Anyone else willing to review this?
patacongo commented on issue #1733:
URL:
https://github.com/apache/incubator-nuttx/issues/1733#issuecomment-688924086
> This only applies to round robin scheduling, correct? Changing this could
be quite complex in the SMP case.
>
> Is it a work around to (1) make sure that all t
patacongo edited a comment on issue #1733:
URL:
https://github.com/apache/incubator-nuttx/issues/1733#issuecomment-688924086
> This only applies to round robin scheduling, correct? Changing this could
be quite complex in the SMP case.
>
> Is it a work around to (1) make sure that al
patacongo commented on issue #1733:
URL:
https://github.com/apache/incubator-nuttx/issues/1733#issuecomment-688932789
>
>
> I have really no idea, my understanding of this part of NuttX is very
limited.
And my memory is very limited. People think that because I wrote most o
patacongo edited a comment on issue #1733:
URL:
https://github.com/apache/incubator-nuttx/issues/1733#issuecomment-688932789
>
>
> I have really no idea, my understanding of this part of NuttX is very
limited.
And my memory is very limited. People think that because I wrote
xiaoxiang781216 commented on pull request #1693:
URL: https://github.com/apache/incubator-nuttx/pull/1693#issuecomment-688959129
> @GUIDINGLI - just curious can you use --wrap or weak to accomplish this?
1. The problem just exist in sim arch, it isn't good to add weak for the
common
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 835d394 tiva: tiva_timerlow32.c: Fi
xiaoxiang781216 merged pull request #1732:
URL: https://github.com/apache/incubator-nuttx/pull/1732
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
btashton opened a new pull request #31:
URL: https://github.com/apache/incubator-nuttx-website/pull/31
## Summary
Add documentation to the README on triggering the deployment workflow.
This is an automated message from
btashton commented on pull request #31:
URL:
https://github.com/apache/incubator-nuttx-website/pull/31#issuecomment-688988398
@adamfeuer @v01d @Ouss4 since you all have been helping out with the
documentation I figured I should point you at this and add it to the README.
adamfeuer commented on pull request #31:
URL:
https://github.com/apache/incubator-nuttx-website/pull/31#issuecomment-689006862
Thanks @btashton – this is what we run to deploy the website, including
documentation, is that right?
---
btashton commented on pull request #31:
URL:
https://github.com/apache/incubator-nuttx-website/pull/31#issuecomment-689007749
yeah eventually this trigger will get called from the OS CI, but we need
secrets configured for that and INFRA was looking into it so it is a quick
manual step for
btashton edited a comment on pull request #31:
URL:
https://github.com/apache/incubator-nuttx-website/pull/31#issuecomment-689007749
yeah eventually this trigger will get called from the OS CI, but we need
secrets configured for that and INFRA was looking into it so it is a quick
manual s
adamfeuer commented on pull request #31:
URL:
https://github.com/apache/incubator-nuttx-website/pull/31#issuecomment-689008900
@btashton Cool, thank you. LGTM. 👍
This is an automated message from the Apache Git Service.
To
This is an automated email from the ASF dual-hosted git repository.
protobits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/master by this push:
new d943dbf CI: Add documentati
v01d merged pull request #31:
URL: https://github.com/apache/incubator-nuttx-website/pull/31
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new ab58e5f Publishing web
xiaoxiang781216 commented on pull request #378:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/378#issuecomment-689039586
How about we mark the license in Kconfig like this:
```
config INTERPRETERS_WASM3
tristate "WASM3 Webassembly Runtime(MIT)"
default n
btashton commented on pull request #378:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/378#issuecomment-689069427
> How about we mark the license in Kconfig like this:
>
> ```
> config INTERPRETERS_WASM3
>tristate "WASM3 Webassembly Runtime(MIT)"
>default
patacongo commented on pull request #378:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/378#issuecomment-689086308
> Another option in this vain would be to have an allowed licences Kconfig
where we would fail the build if a non-allowed license was enabled. We could
also make t
btashton commented on pull request #378:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/378#issuecomment-689090787
I'm just extrapolating from my experience with Yocto and Buildroot for
Linux. With those you can limit the acceptable licenses and also get the
License files for t
davids5 opened a new pull request #1734:
URL: https://github.com/apache/incubator-nuttx/pull/1734
## Summary
A driver passing a buffer that is aligned and sized on d-cache bounders
but does not used the full extent of the buffer will fail the dma_capable test
and in a debug build DEBU
davids5 commented on pull request #1734:
URL: https://github.com/apache/incubator-nuttx/pull/1734#issuecomment-689110385
Please ignore (or suggest a remedy) for the alignment of the braces. It
looks fine to me, but the ifdef must be screwing with the detection.
---
v01d commented on pull request #378:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/378#issuecomment-689123824
Maybe something useful would be to set a configuration value indicating the
"clean" licensing status of a build so that on a binary you can check if the
build includes
patacongo commented on pull request #378:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/378#issuecomment-689165225
>
>
> Maybe something useful would be to set a configuration value indicating
the "clean" licensing status of a build so that on a binary you can check if
ghn-certi commented on a change in pull request #1734:
URL: https://github.com/apache/incubator-nuttx/pull/1734#discussion_r485231824
##
File path: arch/arm/src/stm32h7/Kconfig
##
@@ -1684,6 +1684,16 @@ config STM32H7_DMACAPABLE
Drivers then may use this informa
YuuichiNakamura commented on a change in pull request #1377:
URL: https://github.com/apache/incubator-nuttx/pull/1377#discussion_r485280871
##
File path: arch/arm/src/common/arm_initialize.c
##
@@ -163,6 +164,10 @@ void up_initialize(void)
note_register(); /* Non-standa
YuuichiNakamura commented on a change in pull request #1731:
URL: https://github.com/apache/incubator-nuttx/pull/1731#discussion_r485282212
##
File path: drivers/note/noteram_driver.c
##
@@ -0,0 +1,477 @@
+/***
YuuichiNakamura commented on a change in pull request #1377:
URL: https://github.com/apache/incubator-nuttx/pull/1377#discussion_r485284736
##
File path: drivers/note/note_driver.c
##
@@ -384,6 +472,69 @@ static ssize_t note_read(FAR struct file *filep, FAR char
*buffer,
re
xiaoxiang781216 commented on a change in pull request #1731:
URL: https://github.com/apache/incubator-nuttx/pull/1731#discussion_r485308531
##
File path: drivers/note/noteram_driver.c
##
@@ -0,0 +1,477 @@
+/***
xiaoxiang781216 commented on pull request #1721:
URL: https://github.com/apache/incubator-nuttx/pull/1721#issuecomment-689271597
@hartmannathan PR need rebase not merge.
This is an automated message from the Apache Git Servic
no1wudi opened a new pull request #379:
URL: https://github.com/apache/incubator-nuttx-apps/pull/379
## Summary
Some project (like wasm-micro-runtime) use .s instead of .S as assembly file
suffix, this patch make the suffix configurable as CXXEXT
## Impact
None
## Testing
masayuki2009 opened a new pull request #1735:
URL: https://github.com/apache/incubator-nuttx/pull/1735
## Summary
- I noticed that ostest sometimes stops with DEBUGASSERT
- Finally I found a bug that cpu1 can not disable interrupt
- This commit initializes nvic to fix this bug
masayuki2009 commented on pull request #1735:
URL: https://github.com/apache/incubator-nuttx/pull/1735#issuecomment-689292424
@jerpelea
This is an automated message from the Apache Git Service.
To respond to the message,
patacongo commented on pull request #379:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/379#issuecomment-689302171
By convention, .s and .S files are normally different file types. .s is raw
assembly code; .S files need to be run through the C pre-processor before being
assemb
raiden00pl commented on a change in pull request #1726:
URL: https://github.com/apache/incubator-nuttx/pull/1726#discussion_r485351122
##
File path: arch/arm/src/nrf52/nrf52_tickless_rtc.c
##
@@ -0,0 +1,330 @@
+/**
Bhindhiya opened a new pull request #1736:
URL: https://github.com/apache/incubator-nuttx/pull/1736
Resolved RX65N pre-check warnings in rx65n_eth.c
This is an automated message from the Apache Git Service.
To respond to
jerpelea merged pull request #1735:
URL: https://github.com/apache/incubator-nuttx/pull/1735
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
jerpelea pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new ce93fe7 arm: cxd56xx: Fix nvic setti
jerpelea commented on pull request #1734:
URL: https://github.com/apache/incubator-nuttx/pull/1734#issuecomment-689338304
LGTM please fix CI error
This is an automated message from the Apache Git Service.
To respond to the me
55 matches
Mail list logo
