davids5 commented on pull request #1734:
URL: https://github.com/apache/incubator-nuttx/pull/1734#issuecomment-689471445
> LGTM please fix CI error
As I said above: please ignore (or suggest a remedy) for the alignment of
the braces. It looks fine to me, but the `ifdef` must be
jerpelea commented on pull request #1734:
URL: https://github.com/apache/incubator-nuttx/pull/1734#issuecomment-689510795
>
>
> > @davids5 we have 2 options
> > ```
> > * add 4 spaces instead of 2 before all brackets and we avoid future
errors
> >
> > * ignore the
hartmannathan commented on pull request #1721:
URL: https://github.com/apache/incubator-nuttx/pull/1721#issuecomment-689574740
> @hartmannathan PR need rebase not merge.
Agreed. But github is not allowing rebase due to conflicts.
@barbiani, please could you squash/rebase this
jerpelea edited a comment on pull request #1734:
URL: https://github.com/apache/incubator-nuttx/pull/1734#issuecomment-689477547
@davids5 we have 2 options
- add 4 spaces instead of 2 before all brackets and we avoid future errors
- ignore the error
davids5 commented on pull request #1734:
URL: https://github.com/apache/incubator-nuttx/pull/1734#issuecomment-689515126
@jerpelea @Ouss4 - Agreed! - Who would like to push the merge button?
This is an automated message from
jerpelea commented on pull request #1737:
URL: https://github.com/apache/incubator-nuttx/pull/1737#issuecomment-689485924
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log
Ouss4 commented on pull request #1734:
URL: https://github.com/apache/incubator-nuttx/pull/1734#issuecomment-689500681
> @davids5 we have 2 options
>
> * add 4 spaces instead of 2 before all brackets and we avoid future
errors
>
> * ignore the error
I'd suggest
davids5 commented on a change in pull request #1734:
URL: https://github.com/apache/incubator-nuttx/pull/1734#discussion_r485503187
##
File path: arch/arm/src/stm32h7/Kconfig
##
@@ -1684,6 +1684,16 @@ config STM32H7_DMACAPABLE
Drivers then may use this
GUIDINGLI opened a new pull request #1738:
URL: https://github.com/apache/incubator-nuttx/pull/1738
## Summary
add u_intXX_t ARCH_HAVE_SERIAL_TERMIOS SIGQUIT & SIGTERM support
## Impact
## Testing
jerpelea commented on pull request #1734:
URL: https://github.com/apache/incubator-nuttx/pull/1734#issuecomment-689477547
we have 2 options
- add 4 spaces instead of 2 before all brackets and we avoid future errors
- ignore the error
jerpelea merged pull request #1734:
URL: https://github.com/apache/incubator-nuttx/pull/1734
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
jerpelea pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 2cfb239 arch/sim/src/nuttx-names.in: only host code need replace if
-fvisibility=hidden
add
xiaoxiang781216 commented on pull request #1737:
URL: https://github.com/apache/incubator-nuttx/pull/1737#issuecomment-689523937
LGTM, this bug is found and fixed in our LTP testing:
https://github.com/linux-test-project/ltp
btashton merged pull request #1739:
URL: https://github.com/apache/incubator-nuttx/pull/1739
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
btashton pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 20c5c57 Update tiva_timerlow32.c
add 8f6b2f6 tiva: tiva_adclib.c: Fix nxstyle warnings
No new
btashton commented on pull request #60:
URL:
https://github.com/apache/incubator-nuttx-testing/pull/60#issuecomment-689648787
@ramya-n-s Much appreciated, I was hoping I would not have to dig into the
depths of textinfo. Looks like it is building now.
xiaoxiang781216 commented on pull request #1721:
URL: https://github.com/apache/incubator-nuttx/pull/1721#issuecomment-689611510
@hartmannathan I fixed the conflict, please review it.
This is an automated message from the
This is an automated email from the ASF dual-hosted git repository.
davids5 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new bf06776 fs/vfs: reuse file_dup2
v01d commented on a change in pull request #1726:
URL: https://github.com/apache/incubator-nuttx/pull/1726#discussion_r485771399
##
File path: arch/arm/src/nrf52/nrf52_tickless_rtc.h
##
@@ -0,0 +1,58 @@
v01d commented on a change in pull request #1726:
URL: https://github.com/apache/incubator-nuttx/pull/1726#discussion_r485771485
##
File path: arch/arm/src/nrf52/nrf52_tickless_rtc.c
##
@@ -0,0 +1,330 @@
v01d commented on a change in pull request #1726:
URL: https://github.com/apache/incubator-nuttx/pull/1726#discussion_r485772748
##
File path: arch/arm/src/nrf52/nrf52_tickless_rtc.h
##
@@ -0,0 +1,58 @@
davids5 merged pull request #1737:
URL: https://github.com/apache/incubator-nuttx/pull/1737
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
btashton merged pull request #1721:
URL: https://github.com/apache/incubator-nuttx/pull/1721
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
btashton pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 20c5c57 Update tiva_timerlow32.c
v01d commented on pull request #1726:
URL: https://github.com/apache/incubator-nuttx/pull/1726#issuecomment-689690936
@raiden00pl I fixed what the problems you found, I just added these to last
commit and force pushed.
This
Ouss4 opened a new pull request #1740:
URL: https://github.com/apache/incubator-nuttx/pull/1740
## Summary
Trivial typos, mostly "their is" to "there is"
## Impact
## Testing
This is an automated message
v01d commented on a change in pull request #1726:
URL: https://github.com/apache/incubator-nuttx/pull/1726#discussion_r485773799
##
File path: arch/arm/src/nrf52/nrf52_tickless_rtc.h
##
@@ -0,0 +1,58 @@
v01d commented on a change in pull request #1726:
URL: https://github.com/apache/incubator-nuttx/pull/1726#discussion_r485773401
##
File path: arch/arm/src/nrf52/nrf52_systick.c
##
@@ -123,26 +76,14 @@ static int nrf52_timerisr(int irq, uint32_t *regs, void
*arg)
void
davids5 opened a new pull request #1741:
URL: https://github.com/apache/incubator-nuttx/pull/1741
## Summary
The Multiblock write path was missing the
the SDIO_WAITENABLE with SDIOWAIT_WRCOMPLETE.
This could be seen with debugging turned on as
hartmannathan opened a new pull request #1739:
URL: https://github.com/apache/incubator-nuttx/pull/1739
## Summary
arch/arm/src/tiva/common/tiva_adclib.c:
* Fix nxstyle warnings. No functional changes.
## Impact
No functional changes.
## Testing
hartmannathan merged pull request #1740:
URL: https://github.com/apache/incubator-nuttx/pull/1740
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
hartmannathan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 06ca12e arch/: Trivial typos,
hartmannathan commented on pull request #1740:
URL: https://github.com/apache/incubator-nuttx/pull/1740#issuecomment-689729269
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-testing.git
The following commit(s) were added to refs/heads/master by this push:
new fc32509 Switch to Ubuntu
xiaoxiang781216 closed issue #58:
URL: https://github.com/apache/incubator-nuttx-testing/issues/58
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
xiaoxiang781216 merged pull request #60:
URL: https://github.com/apache/incubator-nuttx-testing/pull/60
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
v01d commented on pull request #1661:
URL: https://github.com/apache/incubator-nuttx/pull/1661#issuecomment-689963713
> If you use what is in master you should be good for everything but
advertising which you would use the ioctl for now. I'll be picking this up
later this week and most of
no1wudi edited a comment on pull request #379:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/379#issuecomment-689940987
> By convention, .s and .S files are normally different file types. .s is
raw assembly code; .S files need to be run through the C pre-processor before
being
btashton commented on pull request #1661:
URL: https://github.com/apache/incubator-nuttx/pull/1661#issuecomment-689963111
If you use what is in master you should be good for everything but
advertising which you would use the ioctl for now. I'll be picking this up
later this week and most
masayuki2009 opened a new pull request #1742:
URL: https://github.com/apache/incubator-nuttx/pull/1742
## Summary
- I noticed that ldrex/strex on cxd56xx have an issue
- The issue is still under investigation
- This commit introduces a custom testset to avoid the issue
no1wudi commented on pull request #379:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/379#issuecomment-69734
The build break is from sim/up_tapdev.c
This is an automated message from the Apache Git Service.
no1wudi commented on pull request #379:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/379#issuecomment-689940987
> By convention, .s and .S files are normally different file types. .s is
raw assembly code; .S files need to be run through the C pre-processor before
being
masayuki2009 commented on pull request #1684:
URL: https://github.com/apache/incubator-nuttx/pull/1684#issuecomment-689966092
> Yes, I think it is preferable.
@v01d
OK. I will rename the file name and push it later.
masayuki2009 commented on pull request #1684:
URL: https://github.com/apache/incubator-nuttx/pull/1684#issuecomment-689978201
I pushed the file with -f.
This is an automated message from the Apache Git Service.
To
v01d commented on pull request #1661:
URL: https://github.com/apache/incubator-nuttx/pull/1661#issuecomment-689962301
Hey Brennan. I would like to start working on adapting the ATT layer so that
it interfaces with L2CAP layer via sockets and not direct calls. I was thinking
on working on
masayuki2009 commented on pull request #1684:
URL: https://github.com/apache/incubator-nuttx/pull/1684#issuecomment-689962270
Hi @acassis,
Should I rename .nuttx-gdbinit to nuttx-gdbinit so that it can be merged?
masayuki2009 commented on pull request #1742:
URL: https://github.com/apache/incubator-nuttx/pull/1742#issuecomment-68756
@jerpelea
This is an automated message from the Apache Git Service.
To respond to the
v01d commented on pull request #1684:
URL: https://github.com/apache/incubator-nuttx/pull/1684#issuecomment-689962507
Yes, I think it is preferable.
This is an automated message from the Apache Git Service.
To respond to the
Bhindhiya opened a new pull request #1736:
URL: https://github.com/apache/incubator-nuttx/pull/1736
Resolved RX65N pre-check warnings in rx65n_eth.c
This is an automated message from the Apache Git Service.
To respond to
This is an automated email from the ASF dual-hosted git repository.
jerpelea pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new ce93fe7 arm: cxd56xx: Fix nvic
jerpelea merged pull request #1735:
URL: https://github.com/apache/incubator-nuttx/pull/1735
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jerpelea commented on pull request #1734:
URL: https://github.com/apache/incubator-nuttx/pull/1734#issuecomment-689338304
LGTM please fix CI error
This is an automated message from the Apache Git Service.
To respond to the
xiaoxiang781216 commented on pull request #1736:
URL: https://github.com/apache/incubator-nuttx/pull/1736#issuecomment-689367243
@Bhindhiya why rx65n_eth don't support ICMPv6?
This is an automated message from the Apache Git
liuguo09 opened a new pull request #1737:
URL: https://github.com/apache/incubator-nuttx/pull/1737
## Summary
Close the fd2 return by dup() would segment fault since filep->f_priv null
access, while file_dup2 handle this rightly.
## Impact
## Testing
Test and verify
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 42a1d45a8acdd1d77b58a121d56367ce1a3f2c80
Author: ligd
AuthorDate: Tue Sep 8 16:33:08 2020 +0800
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 2cfb239a87263ffa55f49334bf00c4dbf6519f83
Author: ligd
AuthorDate: Tue Sep 8 11:20:16 2020 +0800
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from ce93fe7 arm: cxd56xx: Fix nvic settings for SMP
new 42a1d45 arch/sim: replace printf fprintf to
xiaoxiang781216 merged pull request #1693:
URL: https://github.com/apache/incubator-nuttx/pull/1693
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 21cff9fc4fcec80b321c7a0d507d40ba34b4148e
Author: ligd
AuthorDate: Wed Sep 2 10:35:37 2020 +0800
59 matches
Mail list logo
