[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #456: CXD56: move isx012 driver to board specific drivers
patacongo commented on a change in pull request #456: CXD56: move isx012 driver to board specific drivers URL: https://github.com/apache/incubator-nuttx/pull/456#discussion_r389225045 ## File path: boards/arm/cxd56xx/drivers/camera/Make.defs ## @@ -0,0 +1,42 @@ + +# boards/arm/cxd56xx/drivers/sensors/Make.defs +# +# Copyright 2018 Sony Semiconductor Solutions Corporation +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions +# are met: +# +# 1. Redistributions of source code must retain the above copyright +#notice, this list of conditions and the following disclaimer. +# 2. Redistributions in binary form must reproduce the above copyright +#notice, this list of conditions and the following disclaimer in +#the documentation and/or other materials provided with the +#distribution. +# 3. Neither the name of Sony Semiconductor Solutions Corporation nor +#the names of its contributors may be used to endorse or promote +#products derived from this software without specific prior written +#permission. +# +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS +# FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE +# COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, +# INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, +# BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS +# OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED +# AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT +# LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN +# ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE +# POSSIBILITY OF SUCH DAMAGE. +# + Review comment: Fixed by PR #468 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated: cxd56xx: correct comment format in Make.defs to fix build break
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new c0e8afc cxd56xx: correct comment format in Make.defs to fix build break c0e8afc is described below commit c0e8afc5311dc1894a628ee411f5bc11d98765fa Author: liuhaitao AuthorDate: Sat Mar 7 10:08:32 2020 +0800 cxd56xx: correct comment format in Make.defs to fix build break Error log as below: platform/camera/Make.defs:1: *** missing separator. Stop. --- boards/arm/cxd56xx/drivers/camera/Make.defs | 38 ++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/boards/arm/cxd56xx/drivers/camera/Make.defs b/boards/arm/cxd56xx/drivers/camera/Make.defs index fd19bfb..8281784 100644 --- a/boards/arm/cxd56xx/drivers/camera/Make.defs +++ b/boards/arm/cxd56xx/drivers/camera/Make.defs @@ -1,22 +1,22 @@ -/ - * boards/arm/cxd56xx/drivers/video/Make.defs - * - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. The - * ASF licenses this file to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance with the - * License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT - * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the - * License for the specific language governing permissions and limitations - * under the License. - * - / + +# boards/arm/cxd56xx/drivers/video/Make.defs +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# + ifeq ($(VIDEO_ISX012),y) CSRCS += isx012.c
[incubator-nuttx] branch pr468 updated: cxd56xx: correct comment format in Make.defs to fix build break
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a commit to branch pr468 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/pr468 by this push: new 012c7ef cxd56xx: correct comment format in Make.defs to fix build break 012c7ef is described below commit 012c7ef77eb0a1019f4561e00e3db913bbc402c2 Author: liuhaitao AuthorDate: Sat Mar 7 10:08:32 2020 +0800 cxd56xx: correct comment format in Make.defs to fix build break Error log as below: platform/camera/Make.defs:1: *** missing separator. Stop. Signed-off-by: liuhaitao --- boards/arm/cxd56xx/drivers/camera/Make.defs | 38 ++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/boards/arm/cxd56xx/drivers/camera/Make.defs b/boards/arm/cxd56xx/drivers/camera/Make.defs index fd19bfb..8281784 100644 --- a/boards/arm/cxd56xx/drivers/camera/Make.defs +++ b/boards/arm/cxd56xx/drivers/camera/Make.defs @@ -1,22 +1,22 @@ -/ - * boards/arm/cxd56xx/drivers/video/Make.defs - * - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. The - * ASF licenses this file to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance with the - * License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT - * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the - * License for the specific language governing permissions and limitations - * under the License. - * - / + +# boards/arm/cxd56xx/drivers/video/Make.defs +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# + ifeq ($(VIDEO_ISX012),y) CSRCS += isx012.c
[incubator-nuttx] branch pr468 created (now 2478d12)
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch pr468 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. at 2478d12 arch/arm/src/sama5/hardware/_sama5d3x_memorymap.h: Restore lines (#464) No new revisions were added by this update.
[GitHub] [incubator-nuttx] patacongo merged pull request #468: cxd56xx: correct comment format in Make.defs to fix build break
patacongo merged pull request #468: cxd56xx: correct comment format in Make.defs to fix build break URL: https://github.com/apache/incubator-nuttx/pull/468 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on issue #467: arch/z80/src/ez80/ez80_spi.c: Correct oversight in previous commit
liuguo09 commented on issue #467: arch/z80/src/ez80/ez80_spi.c: Correct oversight in previous commit URL: https://github.com/apache/incubator-nuttx/pull/467#issuecomment-596034276 Glad to hear that : ) I found there is a build break in arm-01. I make a PR to fix it. https://github.com/apache/incubator-nuttx/pull/468 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 opened a new pull request #468: cxd56xx: correct comment format in Make.defs to fix build break
liuguo09 opened a new pull request #468: cxd56xx: correct comment format in Make.defs to fix build break URL: https://github.com/apache/incubator-nuttx/pull/468 Error log as below: platform/camera/Make.defs:1: *** missing separator. Stop. Signed-off-by: liuhaitao This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on issue #461: fs/littlefs: correct some code format in lfs.h by running checkpatch.sh
liuguo09 commented on issue #461: fs/littlefs: correct some code format in lfs.h by running checkpatch.sh URL: https://github.com/apache/incubator-nuttx/pull/461#issuecomment-596031932 ok, thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #456: CXD56: move isx012 driver to board specific drivers
patacongo commented on a change in pull request #456: CXD56: move isx012 driver to board specific drivers URL: https://github.com/apache/incubator-nuttx/pull/456#discussion_r389213012 ## File path: boards/arm/cxd56xx/drivers/camera/Make.defs ## @@ -0,0 +1,42 @@ + +# boards/arm/cxd56xx/drivers/sensors/Make.defs +# +# Copyright 2018 Sony Semiconductor Solutions Corporation +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions +# are met: +# +# 1. Redistributions of source code must retain the above copyright +#notice, this list of conditions and the following disclaimer. +# 2. Redistributions in binary form must reproduce the above copyright +#notice, this list of conditions and the following disclaimer in +#the documentation and/or other materials provided with the +#distribution. +# 3. Neither the name of Sony Semiconductor Solutions Corporation nor +#the names of its contributors may be used to endorse or promote +#products derived from this software without specific prior written +#permission. +# +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS +# FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE +# COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, +# INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, +# BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS +# OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED +# AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT +# LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN +# ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE +# POSSIBILITY OF SUCH DAMAGE. +# + Review comment: I am seeing this error in the automated build runs: Configuration/Tool: spresense/audio,CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL Cleaning... Configuring... Copy files Select CONFIG_HOST_LINUX=y Refreshing... Disabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL Enabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL Refreshing... Building NuttX... platform/camera/Make.defs:1: *** missing separator. Stop. platform/camera/Make.defs:1: *** missing separator. Stop. make: *** [drivers/libdrivers.a] Error 2 make: *** Waiting for unfinished jobs make: *** wait: No child processes. Stop. ##[error]Process completed with exit code 2. Reference: https://github.com/apache/incubator-nuttx/runs/491609128 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #456: CXD56: move isx012 driver to board specific drivers
patacongo commented on a change in pull request #456: CXD56: move isx012 driver to board specific drivers URL: https://github.com/apache/incubator-nuttx/pull/456#discussion_r389213012 ## File path: boards/arm/cxd56xx/drivers/camera/Make.defs ## @@ -0,0 +1,42 @@ + +# boards/arm/cxd56xx/drivers/sensors/Make.defs +# +# Copyright 2018 Sony Semiconductor Solutions Corporation +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions +# are met: +# +# 1. Redistributions of source code must retain the above copyright +#notice, this list of conditions and the following disclaimer. +# 2. Redistributions in binary form must reproduce the above copyright +#notice, this list of conditions and the following disclaimer in +#the documentation and/or other materials provided with the +#distribution. +# 3. Neither the name of Sony Semiconductor Solutions Corporation nor +#the names of its contributors may be used to endorse or promote +#products derived from this software without specific prior written +#permission. +# +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS +# FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE +# COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, +# INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, +# BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS +# OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED +# AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT +# LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN +# ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE +# POSSIBILITY OF SUCH DAMAGE. +# + Review comment: I am seeing this error in the automated build runs: Configuration/Tool: spresense/audio,CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL Cleaning... Configuring... Copy files Select CONFIG_HOST_LINUX=y Refreshing... Disabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL Enabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL Refreshing... Building NuttX... platform/camera/Make.defs:1: *** missing separator. Stop. platform/camera/Make.defs:1: *** missing separator. Stop. make: *** [drivers/libdrivers.a] Error 2 make: *** Waiting for unfinished jobs make: *** wait: No child processes. Stop. ##[error]Process completed with exit code 2. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #467: arch/z80/src/ez80/ez80_spi.c: Correct oversight in previous commit
patacongo commented on issue #467: arch/z80/src/ez80/ez80_spi.c: Correct oversight in previous commit URL: https://github.com/apache/incubator-nuttx/pull/467#issuecomment-596024410 Hey, the checkpatch stuff worked perfectly. I said I had a line that too long... It was right (probably because of different -m options on nxstyle). I fixed that line and forced pushed. The test ran again and passed. Good job! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo opened a new pull request #467: arch/z80/src/ez80/ez80_spi.c: Correct oversight in previous commit
patacongo opened a new pull request #467: arch/z80/src/ez80/ez80_spi.c: Correct oversight in previous commit URL: https://github.com/apache/incubator-nuttx/pull/467 Commit 797e45d6bfc467743a3ff350858d2169cad5126e attempted to reduce the frequency of SPI reconfiguration by keeping track of the current frequency and mode settings and changing these settings only when the new settings differ from the old settings. However, the original commit neglected to save the new frequency setting and, hence, was not effective in what it was trying to do: Every time the SPI setfrequency() method was called, it still looked like a new frequency and the frequency was still reconfigured, even though it hadn't really changed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated: arch/arm/src/sama5/hardware/_sama5d3x_memorymap.h: Restore lines (#464)
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 2478d12 arch/arm/src/sama5/hardware/_sama5d3x_memorymap.h: Restore lines (#464) 2478d12 is described below commit 2478d12a0a31b67a6ac98e01f99da20361183563 Author: Adam Feuer AuthorDate: Fri Mar 6 14:49:50 2020 -0800 arch/arm/src/sama5/hardware/_sama5d3x_memorymap.h: Restore lines (#464) Restore lines from bad nxstyle fixes; restore file to previous state --- arch/arm/src/sama5/hardware/_sama5d3x_memorymap.h | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/arch/arm/src/sama5/hardware/_sama5d3x_memorymap.h b/arch/arm/src/sama5/hardware/_sama5d3x_memorymap.h index bcee8ac..4cfbe24 100644 --- a/arch/arm/src/sama5/hardware/_sama5d3x_memorymap.h +++ b/arch/arm/src/sama5/hardware/_sama5d3x_memorymap.h @@ -103,6 +103,7 @@ # define SAM_ISI_OFFSET 0x00034000 /* 0x00034000-0x00037fff: ISI */ # define SAM_SFR_OFFSET 0x00038000 /* 0x00038000-0x0003bfff: SFR */ /* 0x0003c000-0x07ff: Reserved */ +#define SAM_PERIPHB_PSECTION 0xf800 /* 0xf800-0xbfff: Internal Peripherals B */ # define SAM_HSMCI1_OFFSET 0x /* 0x-0x0fff: HSMCI1 */ # define SAM_HSMCI2_OFFSET 0x4000 /* 0x4000-0x7fff: HSMCI2 */ # define SAM_SPI1_OFFSET0x8000 /* 0x8000-0xbfff: SPI1 */ @@ -121,6 +122,7 @@ # define SAM_TDES_OFFSET0x0003c000 /* 0x0003c000-0x0003: TDES */ # define SAM_TRNG_OFFSET0x0004 /* 0x0004-0x00043fff: TRNG */ /* 0x00044000-0x00ffbfff: Reserved */ +#define SAM_SYSC_PSECTION0xfff0 /* 0xfff0-0x: System Controller */ # define SAM_SYSC_PADDR 0xc000 /* 0xc000-0x: System Controller */ # define SAM_SYSC_OFFSET0x /* 0x0fffc000-0x0fff: System Controller */ @@ -130,6 +132,7 @@ #define SAM_HSMC_OFFSET 0x /* 0x-0x0fff: HSMC */ /* 0x1000-0x23ff: Reserved */ +#define SAM_FUSE_OFFSET 0x2400 /* 0x2400-0x25ff: FUSE */ #define SAM_DMAC0_OFFSET 0x2600 /* 0x2600-0x27ff: DMAC0 */ #define SAM_DMAC1_OFFSET 0x2800 /* 0x2800-0x29ff: DMAC1 */ #define SAM_MPDDRC_OFFSET0x2a00 /* 0x2a00-0x2bff: MPDDRC */ @@ -146,11 +149,13 @@ #define SAM_RSTC_OFFSET 0x3e00 /* 0x3e00-0x3e0f: RSTC */ #define SAM_SHDC_OFFSET 0x3e10 /* 0x3e10-0x3e1f: SHDC */ /* 0x3e20-0x3e2f: Reserved */ +#define SAM_PITC_OFFSET 0x3e30 /* 0x3e30-0x3e3f: PITC */ #define SAM_WDT_OFFSET 0x3e40 /* 0x3e40-0x3e4f: WDT */ #define SAM_SCKCR_OFFSET 0x3e50 /* 0x3e50-0x3e53: SCKCR */ #define SAM_BSC_OFFSET 0x3e54 /* 0x3e54-0x3e5f: BSC */ #define SAM_GPBR_OFFSET 0x3e60 /* 0x3e60-0x3e6f: GPBR */ /* 0x3e70-0x3eaf: Reserved */ +#define SAM_RTCC_OFFSET 0x3eb0 /* 0x3eb0-0x3edf: RTCC */ /* 0x3ee0-0x3fff: Reserved */ /* Sizes of memory regions in bytes. @@ -161,6 +166,7 @@ */ /* 0x-0x0fff: Internal Memories */ +#define SAM_BOOTMEM_SIZE (1*1024*1024) /* 0x-0x000f: Boot memory */ #define SAM_ROM_SIZE (1*1024*1024) /* 0x0010-0x001f: ROM */ #define SAM_NFCSRAM_SIZE (1*1024*1024) /* 0x0020-0x002f: NFC SRAM */ /* 0x0030-0x003f: SRAM0 and SRAM1 */ @@ -174,6 +180,7 @@ #define SAM_DAP_SIZE (1*1024*1024) /* 0x0090-0x009f: DAP */ #define SAM_NFCCR_SIZE (256*1024*1024) /* 0x7000-0x7fff: NFC Command Registers */ /* 0xf000-0x: Internal Peripherals */ +#define SAM_PERIPHA_SIZE (240*1024) /* 0xf000-0xf003bfff: Internal Peripherals */ #define SAM_PERIPHB_SIZE (272*1024) /* 0xf800-0xf8043fff: Internal Peripherals */ #define SAM_SYSC_SIZE(1*1024*1024) /* 0xfff0-0x0edf: Internal Peripherals */ @@ -355,8 +362,8 @@ #define SAM_PERIPH_VSECTION 0xf000 /* 0xf000-0x: Internal Peripherals */ # define SAM_PERIPHA_VSECTION 0xf000 /* 0xf000-0xf7ff: Internal Peripherals A */ # define SAM_PERIPHB_VSECTION 0xf800 /* 0xf800-0xffef:
[GitHub] [incubator-nuttx] patacongo merged pull request #464: restore lines from bad nxstyle fixes
patacongo merged pull request #464: restore lines from bad nxstyle fixes URL: https://github.com/apache/incubator-nuttx/pull/464 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch pr464 created (now 797e45d)
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch pr464 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. at 797e45d z20x: SPI and timer fixes No new revisions were added by this update.
[GitHub] [incubator-nuttx] adamfeuer commented on issue #449: Add Apache 2.0 License headers to SAMA5 C files — no code changes
adamfeuer commented on issue #449: Add Apache 2.0 License headers to SAMA5 C files — no code changes URL: https://github.com/apache/incubator-nuttx/pull/449#issuecomment-595997151 Thanks @Ouss4. I updated my tool to create the paths correctly for next time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #464: restore lines from bad nxstyle fixes
adamfeuer commented on a change in pull request #464: restore lines from bad nxstyle fixes URL: https://github.com/apache/incubator-nuttx/pull/464#discussion_r389176623 ## File path: arch/arm/src/sama5/hardware/_sama5d3x_memorymap.h ## @@ -103,6 +103,8 @@ # define SAM_ISI_OFFSET 0x00034000 /* 0x00034000-0x00037fff: ISI */ # define SAM_SFR_OFFSET 0x00038000 /* 0x00038000-0x0003bfff: SFR */ /* 0x0003c000-0x07ff: Reserved */ + Review comment: @patacongo Fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #464: restore lines from bad nxstyle fixes
adamfeuer commented on a change in pull request #464: restore lines from bad nxstyle fixes URL: https://github.com/apache/incubator-nuttx/pull/464#discussion_r389175201 ## File path: arch/arm/src/sama5/hardware/_sama5d3x_memorymap.h ## @@ -103,6 +103,8 @@ # define SAM_ISI_OFFSET 0x00034000 /* 0x00034000-0x00037fff: ISI */ # define SAM_SFR_OFFSET 0x00038000 /* 0x00038000-0x0003bfff: SFR */ /* 0x0003c000-0x07ff: Reserved */ + Review comment: @patacongo Will fix. Re: nxstyle bug, I'm confused about what nxstyle errors to fix or not fix. It seems like if we are going to use a tool, it should report correctly. Is there someone in the nuttx community who knows the best way to fix this bug? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 merged pull request #466: z20x: SPI and timer fixes
Ouss4 merged pull request #466: z20x: SPI and timer fixes URL: https://github.com/apache/incubator-nuttx/pull/466 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated (8b1dc28 -> 797e45d)
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 8b1dc28 Update nxstyle.c add 797e45d z20x: SPI and timer fixes No new revisions were added by this update. Summary of changes: arch/z80/src/ez80/ez80_spi.c | 135 +- arch/z80/src/ez80/ez80_timerisr.c | 27 arch/z80/src/ez80/ez80f92.h | 4 +- 3 files changed, 94 insertions(+), 72 deletions(-)
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #464: restore lines from bad nxstyle fixes
patacongo commented on a change in pull request #464: restore lines from bad nxstyle fixes URL: https://github.com/apache/incubator-nuttx/pull/464#discussion_r389118727 ## File path: arch/arm/src/sama5/hardware/_sama5d3x_memorymap.h ## @@ -103,6 +103,8 @@ # define SAM_ISI_OFFSET 0x00034000 /* 0x00034000-0x00037fff: ISI */ # define SAM_SFR_OFFSET 0x00038000 /* 0x00038000-0x0003bfff: SFR */ /* 0x0003c000-0x07ff: Reserved */ + Review comment: Note that the spaces added after the right comments are incorrect. They should be removed. This is documented bug in nxstyle. It is reporting that a blank line is needed, but that is a bug. No blank line should be added: See Issue #120 Please remove these extra blank lines. You are corrupted an otherwise correct file due to an error in nxstyle. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated: Update nxstyle.c
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 8b1dc28 Update nxstyle.c
8b1dc28 is described below
commit 8b1dc2825f02ed620a2f0fab350af7e9b36ddbe2
Author: David Sidrane
AuthorDate: Fri Mar 6 12:14:23 2020 -0800
Update nxstyle.c
---
tools/nxstyle.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/nxstyle.c b/tools/nxstyle.c
index 5a993c3..0ac395c 100644
--- a/tools/nxstyle.c
+++ b/tools/nxstyle.c
@@ -404,11 +404,11 @@ static int block_comment_width(char *line)
static int get_line_width(FILE *instream)
{
char line[LINE_SIZE]; /* The current line being examined */
- int max = 0;
- int min = INT_MAX;
- int lineno = 0;
- int lineno_max;
- int lineno_min;
+ int max= 0;
+ int min= INT_MAX;
+ int lineno = 0;
+ int lineno_max = 0;
+ int lineno_min = 0;
int len;
while (fgets(line, LINE_SIZE, instream))
[GitHub] [incubator-nuttx] patacongo merged pull request #465: Update nxstyle.c
patacongo merged pull request #465: Update nxstyle.c URL: https://github.com/apache/incubator-nuttx/pull/465 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo opened a new pull request #466: z20x: SPI and timer fixes
patacongo opened a new pull request #466: z20x: SPI and timer fixes URL: https://github.com/apache/incubator-nuttx/pull/466 arch/z80/src/ez80/ez80_spi.c: Add logic checks to eliminate unnecessary SPI reconfiguration. arch/z80/src/ez80/ez80_timerisr.c and arch/z80/src/ez80/ez80f92.h: Fix numerous places where configurations began with CONFIGS_ instead of CONFIG_ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] 01/01: Update nxstyle.c
This is an automated email from the ASF dual-hosted git repository.
davids5 pushed a commit to branch nxstyleFix-warning
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 00b38887f22529b684832d1ab5243ef3aef76c5e
Author: David Sidrane
AuthorDate: Fri Mar 6 12:14:23 2020 -0800
Update nxstyle.c
---
tools/nxstyle.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/nxstyle.c b/tools/nxstyle.c
index 5a993c3..0ac395c 100644
--- a/tools/nxstyle.c
+++ b/tools/nxstyle.c
@@ -404,11 +404,11 @@ static int block_comment_width(char *line)
static int get_line_width(FILE *instream)
{
char line[LINE_SIZE]; /* The current line being examined */
- int max = 0;
- int min = INT_MAX;
- int lineno = 0;
- int lineno_max;
- int lineno_min;
+ int max= 0;
+ int min= INT_MAX;
+ int lineno = 0;
+ int lineno_max = 0;
+ int lineno_min = 0;
int len;
while (fgets(line, LINE_SIZE, instream))
[GitHub] [incubator-nuttx] davids5 opened a new pull request #465: Update nxstyle.c
davids5 opened a new pull request #465: Update nxstyle.c URL: https://github.com/apache/incubator-nuttx/pull/465 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch nxstyleFix-warning created (now 00b3888)
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a change to branch nxstyleFix-warning in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. at 00b3888 Update nxstyle.c This branch includes the following new commits: new 00b3888 Update nxstyle.c The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[incubator-nuttx] branch master updated: z20x: Fix some SPI/W25/Timer issues.
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new ee9949a z20x: Fix some SPI/W25/Timer issues. ee9949a is described below commit ee9949a72425f486191b58f583d8d06f4f43cfe2 Author: Gregory Nutt AuthorDate: Fri Mar 6 13:01:57 2020 -0600 z20x: Fix some SPI/W25/Timer issues. arch/z80/src/ez80/ez80_spi.c: Do not configure SPI chip select pin. It is not used by the driver and configuring it just clobbers other usage of that pin. Add some additional debug outputs; correct some exiting debug outputs. drivers/mtd/w25.c: Add some debug output. boards/z80/ez80/z20x/src/ez80_w25.c: Correct SPI bus number used in initialization. Only SPI1 is supported. arch/z80/src/ez80/ez80_timerisr.c: Some initial timer configuration fixes. --- arch/z80/src/ez80/ez80_spi.c| 68 - arch/z80/src/ez80/ez80_timerisr.c | 98 + boards/z80/ez80/z20x/src/ez80_w25.c | 2 +- drivers/mtd/w25.c | 42 ++-- 4 files changed, 104 insertions(+), 106 deletions(-) diff --git a/arch/z80/src/ez80/ez80_spi.c b/arch/z80/src/ez80/ez80_spi.c index 559da04..208fa08 100644 --- a/arch/z80/src/ez80/ez80_spi.c +++ b/arch/z80/src/ez80/ez80_spi.c @@ -1,36 +1,20 @@ / * arch/z80/src/ez80/ez80_spi.c * - * Copyright (C) 2009-2010, 2016-2017, 2019 Gregory Nutt. All rights - * reserved. - * Author: Gregory Nutt - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions - * are met: - * - * 1. Redistributions of source code must retain the above copyright - *notice, this list of conditions and the following disclaimer. - * 2. Redistributions in binary form must reproduce the above copyright - *notice, this list of conditions and the following disclaimer in - *the documentation and/or other materials provided with the - *distribution. - * 3. Neither the name NuttX nor the names of its contributors may be - *used to endorse or promote products derived from this software - *without specific prior written permission. - * - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS - * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT - * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS - * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE - * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, - * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, - * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS - * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED - * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT - * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN - * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE - * POSSIBILITY OF SUCH DAMAGE. + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. * / @@ -64,13 +48,18 @@ / #if defined(CONFIG_ARCH_CHIP_EZ80F91) || defined(CONFIG_ARCH_CHIP_EZ80F92) + +/* PB2/#SS is controlled by board specific logic and is not used by this + * driver. This permits supporting multiple, different devices with + * different chip selects on the bus. + */ + # define GPIOB_SPI_SS (1 << 2) /* PB2: /SS (not used by driver) */ # define GPIOB_SPI_SCK (1 << 3) /* PB3: SCK */ # define GPIOB_SPI_MISO(1 << 6) /* PB6: MISO */ # define GPIOB_SPI_MOSI(1 << 7) /* PB7: MOSI */ -# define GPIOB_SPI_PINSET (GPIOB_SPI_SS | GPIOB_SPI_SCK | GPIOB_SPI_MISO | \ - GPIOB_SPI_MOSI) +# define GPIOB_SPI_PINSET (GPIOB_SPI_SCK | GPIOB_SPI_MISO | GPIOB_SPI_MOSI) #else # error "Check GPIO
[GitHub] [incubator-nuttx] Ouss4 merged pull request #463: z20x: Fix some SPI/W25/Timer issues.
Ouss4 merged pull request #463: z20x: Fix some SPI/W25/Timer issues. URL: https://github.com/apache/incubator-nuttx/pull/463 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #464: restore lines from bad nxstyle fixes
patacongo commented on a change in pull request #464: restore lines from bad nxstyle fixes URL: https://github.com/apache/incubator-nuttx/pull/464#discussion_r389118727 ## File path: arch/arm/src/sama5/hardware/_sama5d3x_memorymap.h ## @@ -103,6 +103,8 @@ # define SAM_ISI_OFFSET 0x00034000 /* 0x00034000-0x00037fff: ISI */ # define SAM_SFR_OFFSET 0x00038000 /* 0x00038000-0x0003bfff: SFR */ /* 0x0003c000-0x07ff: Reserved */ + Review comment: No that the spaces adder after the right commcomments are incorrect. They should be removed. This is documented bug in nxstyle. It is reporting that a blank line is needed, but that is a bug. No blank line should be added: See Issue #120 Please remove these extra blank lines. You are corrupted an otherwise correct file due to an error in nxstyle. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer commented on issue #444: SAMA5D27 peripheral support - USB Host working
adamfeuer commented on issue #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#issuecomment-595927381 @liuguo09 The fix is in #464, will you check it out and see if it works for you? It builds and runs ok on my SAMA5D3-Xplained board. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer commented on issue #464: restore lines from bad nxstyle fixes
adamfeuer commented on issue #464: restore lines from bad nxstyle fixes URL: https://github.com/apache/incubator-nuttx/pull/464#issuecomment-595926745 @liuguo09 @patacongo This is the fix for the SAMA5D3 build break. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer opened a new pull request #464: restore lines from bad nxstyle fixes
adamfeuer opened a new pull request #464: restore lines from bad nxstyle fixes URL: https://github.com/apache/incubator-nuttx/pull/464 ### Summary * Fix for SAMA5D3 build break introduced in #444 * Lines were mistakenly deleted during nxstyle fixes or a bad merge ### Impact * SAMA5D3 build is unbroken ### Detail * arch/arm/src/sama5/hardware/_sama5d3x_memorymap.h file is restored to its previous state ### Testing * Compiled and ran the build on a SAMA5D3-Xplained board This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #448: Add a sample of git pre-commit hook
davids5 commented on a change in pull request #448: Add a sample of git pre-commit hook URL: https://github.com/apache/incubator-nuttx/pull/448#discussion_r389099219 ## File path: tools/git-hooks/pre-commit ## @@ -0,0 +1,30 @@ +#!/bin/sh + + +# tools/git-hooks/pre-commit +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# + + +# This file is intended to be used as .git/hooks/pre-commit + +if ! type nxstyle > /dev/null 2>&1; then Review comment: >i'd like to suggest checkpatch.sh minimum. do not install tools, or set up git hooks. instead, introduce a separate script to do those "heavy" jobs. how do you think? +1 - have a separate script for assing the hook I would add the formatting to make "make check_format " - Hide the tooling from the user. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] maht commented on issue #437: Support to run NuttX on ESP32 QEMU
maht commented on issue #437: Support to run NuttX on ESP32 QEMU URL: https://github.com/apache/incubator-nuttx/pull/437#issuecomment-595924961 > @maht you can define POSTBUILD function to provide the special post process with this patch now: > #457 > Of course, it's better to make ELF image loadable in QEMU if it's possible. Yes, I will try to modify accordingly to #457 and ELF image if possible. I just need to find some spare time, but if there some hurry on this let me know. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] maht commented on issue #437: Support to run NuttX on ESP32 QEMU
maht commented on issue #437: Support to run NuttX on ESP32 QEMU URL: https://github.com/apache/incubator-nuttx/pull/437#issuecomment-595923482 > @maht, thanks for sending this PR. I confirmed that nuttx works on ESP32 QEMU. (SMP configuration also works!) > > However, I noticed that the difference between nsh/defconfig and qemu-nsh/defconfig is just the following setting. > > CONFIG_SUPPRESS_UART_CONFIG=y > > Actually I noticed that this setting works with ESP32-DevKitC board. (Perhaps, bootloader already set UART clock correctly). So I think we should apply the above settings to all configurations so that we can run all configurations on QEMU and also remove qemu-nsh/defconfig. > > What do you think? Yes, I agree. If it does not interfere with running on the real board it would be simpler to include in all of them and remove special cases. Thanks for trying it and the feedback. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] maht commented on a change in pull request #437: Support to run NuttX on ESP32 QEMU
maht commented on a change in pull request #437: Support to run NuttX on ESP32 QEMU URL: https://github.com/apache/incubator-nuttx/pull/437#discussion_r389096387 ## File path: tools/Makefile.unix ## @@ -501,6 +501,23 @@ ifeq ($(CONFIG_UBOOT_UIMAGE),y) cp -f uImage /tftpboot/uImage; \ fi endif +ifeq ($(CONFIG_ESP32_BINARY),y) + @echo "MKIMAGE: ESP32 binary" + $(Q) if ! esptool.py version | grep "v2[.]"; then \ Review comment: Thanks for the info, I will try, it could be a simpler way than the current approach. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer commented on issue #444: SAMA5D27 peripheral support - USB Host working
adamfeuer commented on issue #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#issuecomment-595921500 @liuguo09 @patacongo This is my mistake, I am sorry! I'm working on a fix for this file right now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo opened a new pull request #463: z20x: Fix some SPI/W25 issues.
patacongo opened a new pull request #463: z20x: Fix some SPI/W25 issues. URL: https://github.com/apache/incubator-nuttx/pull/463 arch/z80/src/ez80/ez80_spi.c: Do not configure SPI chip select pin. It is not used by the driver and configuring it just clobbers other usage of that pin. Add some additional debug outputs; correct some exiting debug outputs. drivers/mtd/w25.c: Add some debug output. boards/z80/ez80/z20x/src/ez80_w25.c: Correct SPI bus number used in initialization. Only SPI1 is supported. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #457: Build System: Resolve CPU-specific logic in common build files
patacongo edited a comment on issue #457: Build System: Resolve CPU-specific logic in common build files URL: https://github.com/apache/incubator-nuttx/pull/457#issuecomment-595893663 Overriding the define's in tools/Config.mk is a very powerful customization technique. You could do many different things there, such as copying binaries onto and TFTP server, compressing binaries, etc. ... whatever meets the needs of the platform. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #457: Build System: Resolve CPU-specific logic in common build files
patacongo commented on issue #457: Build System: Resolve CPU-specific logic in common build files URL: https://github.com/apache/incubator-nuttx/pull/457#issuecomment-595893663 Overriding the define's in tools/Config.mk is a very powerful customization technique. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #437: Support to run NuttX on ESP32 QEMU
xiaoxiang781216 commented on issue #437: Support to run NuttX on ESP32 QEMU URL: https://github.com/apache/incubator-nuttx/pull/437#issuecomment-595892243 @maht you can define POSTBUILD function to provide the special post process with this patch now: https://github.com/apache/incubator-nuttx/pull/457 Of course, it's better to make ELF image loadable in QEMU if it's possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #457: Build System: Resolve CPU-specific logic in common build files
xiaoxiang781216 commented on issue #457: Build System: Resolve CPU-specific logic in common build files URL: https://github.com/apache/incubator-nuttx/pull/457#issuecomment-595891897 > > should I merge it or do you want to wait for the second opinion? > > My preference would be to do the merge now. My only hesitation is that Xiang did offer a different solution. This solution is superior to the one Xiang offered, however. > > But perhaps he is not available due to the time difference. In that case, I would elect to continue with the merge. Then we can get the ESP32 PR on the way too. This solution look very good, I can migrate our internal post build process to this elegant mechanism now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #437: Support to run NuttX on ESP32 QEMU
patacongo commented on a change in pull request #437: Support to run NuttX on ESP32 QEMU URL: https://github.com/apache/incubator-nuttx/pull/437#discussion_r389057282 ## File path: tools/Makefile.unix ## @@ -501,6 +501,23 @@ ifeq ($(CONFIG_UBOOT_UIMAGE),y) cp -f uImage /tftpboot/uImage; \ fi endif +ifeq ($(CONFIG_ESP32_BINARY),y) + @echo "MKIMAGE: ESP32 binary" + $(Q) if ! esptool.py version | grep "v2[.]"; then \ + echo ""; \ + echo "Please install ESP-IDF tools"; \ + echo ""; \ + echo "Check https://docs.espressif.com/projects/esp-idf/en/v4.0/get-started/index.html#installation-step-by-step or run the following command"; \ + echo ""; \ + echo "cd tools/esp32 && make && cd ../.."; \ + echo ""; \ + echo "run make again to create the nuttx.bin image."; \ +else \ + echo "Generating: $(NUTTXNAME).bin (ESP32 compatible)"; \ + esptool.py --chip esp32 elf2image --flash_mode dio --flash_size 4MB -o nuttx.bin nuttx && \ + echo "Generated: $(NUTTXNAME).bin (ESP32 compatible)"; \ + fi +endif Review comment: OK.. PR #457 has been merged. Can you please follow the example there there to implement the POSTBUILD hook for the ESP32. You only need to look at: https://github.com/apache/incubator-nuttx/blob/master/boards/arm/cxd56xx/scripts/Config.mk - New file needed containing the POSTBUILD operations and https://github.com/apache/incubator-nuttx/blob/master/boards/arm/cxd56xx/spresense/scripts/Make.defs - Add only like to to include the above file AFTER including tools/Conflg.mk And that is it! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated (3ee1af5 -> 3ee9180)
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 3ee1af5 Build System: Resolve CPU-specific logic in common build files add 3ee9180 fs/littlefs: correct some code format in lfs.h by running checkpatch.sh No new revisions were added by this update. Summary of changes: fs/littlefs/lfs.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)
[GitHub] [incubator-nuttx] btashton opened a new issue #462: Inlined documentation files for the wiki should be built by CI
btashton opened a new issue #462: Inlined documentation files for the wiki should be built by CI URL: https://github.com/apache/incubator-nuttx/issues/462 Right now when the documentation files are updated they have to be manually built and upload to the wiki. This build step is a done manually by a commiter today and while simple requires npm which not everyone here if familier. WIth github actions we can do the build an generate the artifacts that can be downloaded and uploaded to the Wiki by any commiter. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch pr461 updated: fs/littlefs: correct some code format in lfs.h by running checkpatch.sh
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a commit to branch pr461 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/pr461 by this push: new e320dec fs/littlefs: correct some code format in lfs.h by running checkpatch.sh e320dec is described below commit e320dec816720721084b9fdac5f360e5efa81a08 Author: liuhaitao AuthorDate: Fri Mar 6 23:53:43 2020 +0800 fs/littlefs: correct some code format in lfs.h by running checkpatch.sh Signed-off-by: liuhaitao --- fs/littlefs/lfs.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/littlefs/lfs.h b/fs/littlefs/lfs.h index ef039dd..a597593 100644 --- a/fs/littlefs/lfs.h +++ b/fs/littlefs/lfs.h @@ -283,10 +283,9 @@ struct lfs_info_s /* Name of the file stored as a null-terminated string */ - char name[LFS_NAME_MAX+1]; + char name[LFS_NAME_MAX + 1]; }; - /* littlefs data structures */ typedef struct lfs_entry_s @@ -308,7 +307,7 @@ typedef struct lfs_entry_s } file; lfs_block_t dir[2]; } u; - } d; + } d; } lfs_entry_t; typedef struct lfs_cache_s @@ -554,7 +553,8 @@ lfs_soff_t lfs_file_seek(FAR lfs_t *lfs, FAR lfs_file_t *file, * Returns a negative error code on failure. */ -int lfs_file_truncate(FAR FAR lfs_t *lfs, FAR lfs_file_t *file, lfs_off_t size); +int lfs_file_truncate(FAR lfs_t *lfs, FAR lfs_file_t *file, + lfs_off_t size); /* Return the position of the file * @@ -629,7 +629,7 @@ int lfs_dir_seek(FAR lfs_t *lfs, FAR lfs_dir_t *dir, lfs_off_t off); * The returned offset is only meant to be consumed by seek and may not make * sense, but does indicate the current position in the directory iteration. * - * Returns the position of the directory, or a negative error code on failure. + * Returns the position of the directory, or a negative error code on failure */ lfs_soff_t lfs_dir_tell(FAR lfs_t *lfs, FAR lfs_dir_t *dir); @@ -667,7 +667,7 @@ int lfs_traverse(FAR lfs_t *lfs, CODE int (*cb)(FAR void *, lfs_block_t), int lfs_deorphan(FAR lfs_t *lfs); #ifdef __cplusplus -} /* extern "C" */ +} #endif #endif /* __FS_LITTLEFS_LFS_H */
[GitHub] [incubator-nuttx] patacongo merged pull request #461: fs/littlefs: correct some code format in lfs.h by running checkpatch.sh
patacongo merged pull request #461: fs/littlefs: correct some code format in lfs.h by running checkpatch.sh URL: https://github.com/apache/incubator-nuttx/pull/461 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #461: fs/littlefs: correct some code format in lfs.h by running checkpatch.sh
patacongo commented on issue #461: fs/littlefs: correct some code format in lfs.h by running checkpatch.sh URL: https://github.com/apache/incubator-nuttx/pull/461#issuecomment-595885959 > one config of arm07 build breaks, it should be fixed to pass check build : ( That is not relevant to this change, is it? That is a SAMA5Dx and has nothing to do with LittleFS. I will continue with the merge. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch pr461 created (now 3ee1af5)
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch pr461 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. at 3ee1af5 Build System: Resolve CPU-specific logic in common build files No new revisions were added by this update.
[GitHub] [incubator-nuttx-website] btashton opened a new issue #17: Add github action to do website deployment
btashton opened a new issue #17: Add github action to do website deployment URL: https://github.com/apache/incubator-nuttx-website/issues/17 Right now there is a manual step post merge to master that has to be done to build and deploy the website. Lets move this into a simple GitHub Action This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx-website] btashton opened a new issue #16: Readme includes a lot of template content that is not relevant
btashton opened a new issue #16: Readme includes a lot of template content that is not relevant URL: https://github.com/apache/incubator-nuttx-website/issues/16 Readme includes a lot of template content that is not relevant especially the bit about SVN and javadocs, let clear that out This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #457: Build System: Resolve CPU-specific logic in common build files
patacongo commented on issue #457: Build System: Resolve CPU-specific logic in common build files URL: https://github.com/apache/incubator-nuttx/pull/457#issuecomment-595882823 Thanks. Just saw the PR trigger running. Nice job guys! Congratulations! That was a lot of work. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated (d7fa6a9 -> 3ee1af5)
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from d7fa6a9 Initial checkin nuttx github action CI workflow
add 3ee1af5 Build System: Resolve CPU-specific logic in common build
files
No new revisions were added by this update.
Summary of changes:
.../src/Makefile => arm/cxd56xx/scripts/Config.mk} | 44 ++
boards/arm/cxd56xx/spresense/scripts/Make.defs | 1 +
boards/z16/z16f/z16f2800100zcog/scripts/Make.defs | 2 +-
boards/z80/ez80/ez80f910200kitg/scripts/Make.defs | 2 +-
boards/z80/ez80/ez80f910200zco/scripts/Make.defs | 2 +-
boards/z80/ez80/makerlisp/scripts/Make.defs| 2 +-
boards/z80/ez80/z20x/scripts/Make.defs | 2 +-
boards/z80/z8/z8encore000zco/scripts/Make.defs | 2 +-
boards/z80/z8/z8f64200100kit/scripts/Make.defs | 2 +-
tools/Config.mk| 11 +-
tools/Makefile.unix| 14 +--
tools/Makefile.win | 14 +--
tools/zds/{zds_Config.mk => Config.mk} | 2 +-
tools/zds/README.txt | 8 ++--
14 files changed, 44 insertions(+), 64 deletions(-)
copy boards/{z80/ez80/z20x/src/Makefile => arm/cxd56xx/scripts/Config.mk} (56%)
rename tools/zds/{zds_Config.mk => Config.mk} (99%)
[GitHub] [incubator-nuttx] xiaoxiang781216 closed issue #442: tools/Makefile.unix: Remove FORBIDDEN CXD56 code in common Makefile.
xiaoxiang781216 closed issue #442: tools/Makefile.unix: Remove FORBIDDEN CXD56 code in common Makefile. URL: https://github.com/apache/incubator-nuttx/issues/442 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #457: Build System: Resolve CPU-specific logic in common build files
xiaoxiang781216 merged pull request #457: Build System: Resolve CPU-specific logic in common build files URL: https://github.com/apache/incubator-nuttx/pull/457 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #457: Build System: Resolve CPU-specific logic in common build files
patacongo commented on issue #457: Build System: Resolve CPU-specific logic in common build files URL: https://github.com/apache/incubator-nuttx/pull/457#issuecomment-595881967 @xiaoxiang781216 Updated. Please review and merge if possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx-website] btashton closed issue #14: Website has "incubator" in URLs for mail list archives
btashton closed issue #14: Website has "incubator" in URLs for mail list archives URL: https://github.com/apache/incubator-nuttx-website/issues/14 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx-website] branch master updated: Change @incubator.apache.org to @apache.org
This is an automated email from the ASF dual-hosted git repository. btashton pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/master by this push: new 6c98771 Change @incubator.apache.org to @apache.org 6c98771 is described below commit 6c98771f4f25ca1461709bf48c50dd909c53901c Author: Xiang Xiao AuthorDate: Tue Feb 18 22:32:01 2020 +0800 Change @incubator.apache.org to @apache.org fix #14 Signed-off-by: Xiang Xiao --- _data/project.yml | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/_data/project.yml b/_data/project.yml index 33ebc27..edf548e 100644 --- a/_data/project.yml +++ b/_data/project.yml @@ -25,11 +25,11 @@ description: Apache NuttX is a mature, real-time embedded operating system (RTOS download: /download latest_release: 8.2 -dev_list: d...@nuttx.incubator.apache.org -dev_list_subscribe: dev-subscr...@nuttx.incubator.apache.org -dev_list_unsubscribe: dev-unsubscr...@nuttx.incubator.apache.org +dev_list: d...@nuttx.apache.org +dev_list_subscribe: dev-subscr...@nuttx.apache.org +dev_list_unsubscribe: dev-unsubscr...@nuttx.apache.org dev_list_archive: http://mail-archives.apache.org/mod_mbox/nuttx-dev/ -dev_list_archive_mailarchive: https://www.mail-archive.com/dev@nuttx.incubator.apache.org/ +dev_list_archive_mailarchive: https://www.mail-archive.com/dev@nuttx.apache.org/ dev_list_archive_markmail: user_list: @@ -39,11 +39,11 @@ user_list_archive: user_list_archive_mailarchive: user_list_archive_markmail: -commits_list: comm...@nuttx.incubator.apache.org -commits_list_subscribe: commits-subscr...@nuttx.incubator.apache.org -commits_list_unsubscribe: commits-unsubscr...@nuttx.incubator.apache.org +commits_list: commits@nuttx.apache.org +commits_list_subscribe: commits-subscr...@nuttx.apache.org +commits_list_unsubscribe: commits-unsubscr...@nuttx.apache.org commits_list_archive: http://mail-archives.apache.org/mod_mbox/nuttx-commits/ -commits_list_archive_mailarchive: https://www.mail-archive.com/commits@nuttx.incubator.apache.org/ +commits_list_archive_mailarchive: https://www.mail-archive.com/commits@nuttx.apache.org/ commits_list_archive_markmail: jira: NUTTX
[GitHub] [incubator-nuttx-website] btashton merged pull request #15: Change @incubator.apache.org to @apache.org
btashton merged pull request #15: Change @incubator.apache.org to @apache.org URL: https://github.com/apache/incubator-nuttx-website/pull/15 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on issue #461: fs/littlefs: correct some code format in lfs.h by running checkpatch.sh
liuguo09 commented on issue #461: fs/littlefs: correct some code format in lfs.h by running checkpatch.sh URL: https://github.com/apache/incubator-nuttx/pull/461#issuecomment-595879809 one config of arm07 build breaks, it should be fixed to pass check build : ( Configuration/Tool: sama5d3x-ek/nsh,CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL Configuring... Copy files Select CONFIG_HOST_LINUX=y Refreshing... Disabling CONFIG_ARMV7A_TOOLCHAIN_GNU_EABIL Enabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL Refreshing... Building NuttX... chip/sam_memories.c: In function 'periphb_physregaddr': chip/sam_memories.c:86:5: warning: "SAM_PERIPHB_PSECTION" is not defined, evaluates to 0 [-Wundef] 86 | #if SAM_PERIPHB_PSECTION != SAM_PERIPHB_VSECTION | ^~~~ chip/sam_memories.c:95:10: error: 'SAM_PERIPHB_PSECTION' undeclared (first use in this function); did you mean 'SAM_PERIPHA_PSECTION'? 95 | return SAM_PERIPHB_PSECTION + sectoffset; | ^~~~ | SAM_PERIPHA_PSECTION chip/sam_memories.c:95:10: note: each undeclared identifier is reported only once for each function it appears in chip/sam_memories.c: In function 'sysc_physregaddr': chip/sam_memories.c:149:5: warning: "SAM_SYSC_PSECTION" is not defined, evaluates to 0 [-Wundef] 149 | #if SAM_SYSC_PSECTION != SAM_SYSC_VSECTION | ^ chip/sam_memories.c:158:10: error: 'SAM_SYSC_PSECTION' undeclared (first use in this function); did you mean 'SAM_SYSC_VSECTION'? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx-apps] branch master updated: Initial checkin nuttx-apps github action CI workflow
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 7f20375 Initial checkin nuttx-apps github action CI workflow
7f20375 is described below
commit 7f203759ca7d0290c18881e6ef7c2e59c5406426
Author: liuhaitao
AuthorDate: Wed Mar 4 15:41:50 2020 +0800
Initial checkin nuttx-apps github action CI workflow
Github action CI workflow steps as below:
1. Use docker container with build essential tools preinstalled
2. nxstyle check pull request with checkpatch.sh
3. Call testing cibuild.sh to do jobs matrix check builds
Signed-off-by: liuhaitao
---
.github/workflows/main.yml | 83 ++
1 file changed, 83 insertions(+)
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
new file mode 100644
index 000..bcab659
--- /dev/null
+++ b/.github/workflows/main.yml
@@ -0,0 +1,83 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: PR Check CI
+
+on:
+ pull_request:
+
+jobs:
+ check:
+runs-on: ubuntu-18.04
+container: liuguo09/ubuntu-nuttx:18.04
+
+steps:
+- name: Checkout apps repo
+ uses: actions/checkout@v2
+ with:
+path: apps
+fetch-depth: 0
+
+- name: Checkout nuttx repo
+ uses: actions/checkout@v2
+ with:
+repository: apache/incubator-nuttx
+path: nuttx
+fetch-depth: 0
+
+- name: Check Pull Request
+ run: |
+cd apps
+ranges=`git log -1 --merges --pretty=format:%P | awk -F" " '{ print $1
".." $2 }'`
+git log --oneline $ranges
+commits=`git log --reverse --format=format:%H $ranges`
+echo "../nuttx/tools/checkpatch.sh -g $commits"
+../nuttx/tools/checkpatch.sh -g $commits
+
+ build:
+needs: check
+runs-on: ubuntu-18.04
+container: liuguo09/ubuntu-nuttx:18.04
+
+strategy:
+ matrix:
+boards: [arm-01, arm-02, arm-03, arm-04, arm-05, arm-06, arm-07,
arm-08, arm-09, arm-10, arm-11, arm-12, arm-13, arm-14, arm-15, mips-riscv-x86,
sim]
+
+steps:
+- name: Checkout apps repo
+ uses: actions/checkout@v2
+ with:
+path: apps
+fetch-depth: 0
+
+- name: Checkout nuttx repo
+ uses: actions/checkout@v2
+ with:
+repository: apache/incubator-nuttx
+path: nuttx
+fetch-depth: 0
+
+- name: Fetch nuttx tags
+ run: |
+cd nuttx
+git fetch --tags
+
+- name: Checkout testing repo
+ uses: actions/checkout@v2
+ with:
+repository: apache/incubator-nuttx-testing
+path: testing
+
+- name: Run builds
+ run: |
+cd testing
+./cibuild.sh -x testlist/${{matrix.boards}}.dat
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #113: Initial checkin nuttx-apps github action CI workflow
xiaoxiang781216 merged pull request #113: Initial checkin nuttx-apps github action CI workflow URL: https://github.com/apache/incubator-nuttx-apps/pull/113 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 opened a new pull request #461: fs/littlefs: correct some code format in lfs.h by running checkpatch.sh
liuguo09 opened a new pull request #461: fs/littlefs: correct some code format in lfs.h by running checkpatch.sh URL: https://github.com/apache/incubator-nuttx/pull/461 Signed-off-by: liuhaitao This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #457: Build System: Resolve CPU-specific logic in common build files
patacongo commented on a change in pull request #457: Build System: Resolve
CPU-specific logic in common build files
URL: https://github.com/apache/incubator-nuttx/pull/457#discussion_r389041728
##
File path: boards/arm/cxd56xx/spresense/scripts/Make.defs
##
@@ -35,6 +35,7 @@
include ${TOPDIR}/.config
include ${TOPDIR}/tools/Config.mk
+include ${TOPDIR}/boards/arm/cxd56xx/scripts/cxd56xx_Config.mk
Review comment:
Okay. Doing that now. Should also change zds_Config.mk for the same
reason. I was following the pattern set by zds_Config.mk. I will push new
changes momentarily.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #447: ESP32 module support
xiaoxiang781216 commented on a change in pull request #447: ESP32 module support
URL: https://github.com/apache/incubator-nuttx/pull/447#discussion_r389037949
##
File path: libs/libc/machine/xtensa/arch_elf.c
##
@@ -154,6 +161,57 @@ int up_relocate(FAR const Elf32_Rel *rel, FAR const
Elf32_Sym *sym,
int up_relocateadd(FAR const Elf32_Rela *rel, FAR const Elf32_Sym *sym,
uintptr_t addr)
{
- berr("ERROR: RELA relocation not supported\n");
- return -ENOSYS;
+ unsigned int relotype;
+ unsigned char *p;
+ uint32_t value;
+
+ relotype = ELF32_R_TYPE(rel->r_info);
+ value = sym->st_value + rel->r_addend;
+
+ /* Handle the relocation by relocation type */
+
+ switch (relotype)
+{
+case R_XTENSA_32:
+ (*(uint32_t *)addr) += value;
+ break;
+
+case R_XTENSA_ASM_EXPAND:
+ bwarn("ERROR: Ignoring RELA relocation R_XTENSA_ASM_EXPAND %u\n",
+ relotype);
+ break;
+
+case R_XTENSA_SLOT0_OP:
+ p = (unsigned char *)addr;
Review comment:
FAR unsigned char *
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #447: ESP32 module support
xiaoxiang781216 commented on a change in pull request #447: ESP32 module support
URL: https://github.com/apache/incubator-nuttx/pull/447#discussion_r389037803
##
File path: libs/libc/machine/xtensa/arch_elf.c
##
@@ -154,6 +161,57 @@ int up_relocate(FAR const Elf32_Rel *rel, FAR const
Elf32_Sym *sym,
int up_relocateadd(FAR const Elf32_Rela *rel, FAR const Elf32_Sym *sym,
uintptr_t addr)
{
- berr("ERROR: RELA relocation not supported\n");
- return -ENOSYS;
+ unsigned int relotype;
+ unsigned char *p;
+ uint32_t value;
+
+ relotype = ELF32_R_TYPE(rel->r_info);
+ value = sym->st_value + rel->r_addend;
+
+ /* Handle the relocation by relocation type */
+
+ switch (relotype)
+{
+case R_XTENSA_32:
+ (*(uint32_t *)addr) += value;
Review comment:
FAR uint32_t *?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #457: Build System: Resolve CPU-specific logic in common build files
xiaoxiang781216 commented on a change in pull request #457: Build System:
Resolve CPU-specific logic in common build files
URL: https://github.com/apache/incubator-nuttx/pull/457#discussion_r389032275
##
File path: boards/arm/cxd56xx/spresense/scripts/Make.defs
##
@@ -35,6 +35,7 @@
include ${TOPDIR}/.config
include ${TOPDIR}/tools/Config.mk
+include ${TOPDIR}/boards/arm/cxd56xx/scripts/cxd56xx_Config.mk
Review comment:
How about remove cxd56xx_ prefix? because:
1.The path already have cxd56xx
2.Align with tools/Config.mk
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #457: Build System: Resolve CPU-specific logic in common build files
xiaoxiang781216 commented on a change in pull request #457: Build System: Resolve CPU-specific logic in common build files URL: https://github.com/apache/incubator-nuttx/pull/457#discussion_r389032509 ## File path: boards/arm/cxd56xx/scripts/cxd56xx_Config.mk ## @@ -0,0 +1,41 @@ + +# board/arm/cxd56xx/script/cxd56xx_Config.defs Review comment: defs to mk This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated (a4e0b23 -> d7fa6a9)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from a4e0b23 Prevents NuttX crashing if MM_REGIONS is too small. add d7fa6a9 Initial checkin nuttx github action CI workflow No new revisions were added by this update. Summary of changes: .github/workflows/main.yml | 83 ++ 1 file changed, 83 insertions(+) create mode 100644 .github/workflows/main.yml
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #261: Initial checkin nuttx github action CI workflow
xiaoxiang781216 merged pull request #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on issue #444: SAMA5D27 peripheral support - USB Host working
liuguo09 commented on issue #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#issuecomment-595864937 It seems this PR build breaks sama5d3x-ek:nsh config as below: It is mainly because of arch/arm/src/sama5/hardware/_sama5d3x_memorymap.h update in this PR. chip/sam_memories.c: In function 'periphb_physregaddr': chip/sam_memories.c:86:5: warning: "SAM_PERIPHB_PSECTION" is not defined, evaluates to 0 [-Wundef] 86 | #if SAM_PERIPHB_PSECTION != SAM_PERIPHB_VSECTION | ^~~~ chip/sam_memories.c:95:10: error: 'SAM_PERIPHB_PSECTION' undeclared (first use in this function); did you mean 'SAM_PERIPHA_PSECTION'? 95 | return SAM_PERIPHB_PSECTION + sectoffset; | ^~~~ | SAM_PERIPHA_PSECTION chip/sam_memories.c:95:10: note: each undeclared identifier is reported only once for each function it appears in chip/sam_memories.c: In function 'sysc_physregaddr': chip/sam_memories.c:149:5: warning: "SAM_SYSC_PSECTION" is not defined, evaluates to 0 [-Wundef] 149 | #if SAM_SYSC_PSECTION != SAM_SYSC_VSECTION | ^ chip/sam_memories.c:158:10: error: 'SAM_SYSC_PSECTION' undeclared (first use in this function); did you mean 'SAM_SYSC_VSECTION'? 158 | return SAM_SYSC_PSECTION + sectoffset; | ^ | SAM_SYSC_VSECTION chip/sam_memories.c: In function 'sam_physregaddr': chip/sam_memories.c:701:45: error: 'SAM_PERIPHA_SIZE' undeclared (first use in this function); did you mean 'SAM_PERIPHB_SIZE'? 701 | virtregaddr < (SAM_PERIPHA_VSECTION + SAM_PERIPHA_SIZE)) | ^~~~ | SAM_PERIPHB_SIZE make[1]: *** [sam_memories.o] Error 1 make: *** [arch/arm/src/libarch.a] Error 2 make: *** Waiting for unfinished jobs ##[error]Process completed with exit code 2. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #459: stm32h7: support SDRAM via FMC peripherial
davids5 commented on a change in pull request #459: stm32h7: support SDRAM via
FMC peripherial
URL: https://github.com/apache/incubator-nuttx/pull/459#discussion_r389018630
##
File path: arch/arm/src/stm32h7/stm32_allocateheap.c
##
@@ -246,6 +249,14 @@ void up_allocate_heap(FAR void **heap_start, size_t
*heap_size)
up_heap_color(*heap_start, *heap_size);
#endif
+
+#if defined(CONFIG_DEBUG_FEATURES)
+
+ /* Display memory ranges to help debugging */
+
+ _info("%uKb of SRAM at %p\n", *heap_size / 1024, *heap_start);
Review comment:
In practice the underscore version is not use directly. see debug.h minfo()
would be used here.
```suggestion
minfo("%uKb of SRAM at %p\n", *heap_size / 1024, *heap_start);
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo removed a comment on issue #459: stm32h7: support SDRAM via FMC peripherial
patacongo removed a comment on issue #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-595846947 > They are used in stm32_fmc.c (modreg32). Okay, thanks. I did not see that because Github in all its wisdom collapses large files and so the references were not found in tha search. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #459: stm32h7: support SDRAM via FMC peripherial
patacongo commented on issue #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-595846998 > They are used in stm32_fmc.c (modreg32). Okay, thanks. I did not see that because Github in all its wisdom collapses large files and so the references were not found in tha search. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #459: stm32h7: support SDRAM via FMC peripherial
patacongo commented on issue #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-595846947 > They are used in stm32_fmc.c (modreg32). Okay, thanks. I did not see that because Github in all its wisdom collapses large files and so the references were not found in tha search. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] anpaza commented on issue #459: stm32h7: support SDRAM via FMC peripherial
anpaza commented on issue #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-595844421 They are used in stm32_fmc.c (modreg32). I think it is easier to read this: modreg32 (BOARD_FMC_CLK, RCC_D1CCIPR_FMCSEL_MASK, STM32_RCC_D1CCIPR); than the old-style equivalent: regval = getreg32(STM32_RCC_D1CCIPR); regval = (regval & ~RCC_D1CCIPR_FMCSEL_MASK) | BOARD_FMC_CLK; putreg32(regval, STM32_RCC_D1CCIPR); Also I have pending changes to e.g. stm32_ethernet.c using these macros. I noted that there's a new family of functions modifyreg*() (that were not available on nuttx-8.2 I was working on), but they introduce extra cost for every call, and won't protect anything in my case (and many other cases, as usually modifications to several registers have to be atomic, not individual register modifications). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] anpaza commented on a change in pull request #459: stm32h7: support SDRAM via FMC peripherial
anpaza commented on a change in pull request #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#discussion_r388998837 ## File path: arch/arm/src/common/up_arch.h ## @@ -58,6 +58,12 @@ # define getreg32(a) (*(volatile uint32_t *)(a)) # define putreg32(v,a)(*(volatile uint32_t *)(a) = (v)) +/* Non-atomic, but more effective modification of registers */ + +# define modreg8(v,m,a) putreg8((getreg8(a) & ~(m)) | ((v) & (m)), a) +# define modreg16(v,m,a) putreg16((getreg16(a) & ~(m)) | ((v) & (m)), a) +# define modreg32(v,m,a) putreg32((getreg32(a) & ~(m)) | ((v) & (m)), a) + Review comment: They are used in stm32_fmc.c (modreg32). I think it is easier to read this: modreg32 (BOARD_FMC_CLK, RCC_D1CCIPR_FMCSEL_MASK, STM32_RCC_D1CCIPR); than the old-style equivalent: regval = getreg32(STM32_RCC_D1CCIPR); regval = (regval & ~RCC_D1CCIPR_FMCSEL_MASK) | BOARD_FMC_CLK; putreg32(regval, STM32_RCC_D1CCIPR); Also I have pending changes to e.g. stm32_ethernet.c using these macros. I noted that there's a new family of functions modifyreg*() (that were not available on nuttx-8.2 I was working on), but they introduce extra cost for every call, and won't protect anything in my case (and many other cases, as usually modifications to several registers have to be atomic, not individual register modifications). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] anpaza commented on a change in pull request #459: stm32h7: support SDRAM via FMC peripherial
anpaza commented on a change in pull request #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#discussion_r388998837 ## File path: arch/arm/src/common/up_arch.h ## @@ -58,6 +58,12 @@ # define getreg32(a) (*(volatile uint32_t *)(a)) # define putreg32(v,a)(*(volatile uint32_t *)(a) = (v)) +/* Non-atomic, but more effective modification of registers */ + +# define modreg8(v,m,a) putreg8((getreg8(a) & ~(m)) | ((v) & (m)), a) +# define modreg16(v,m,a) putreg16((getreg16(a) & ~(m)) | ((v) & (m)), a) +# define modreg32(v,m,a) putreg32((getreg32(a) & ~(m)) | ((v) & (m)), a) + Review comment: They are used in stm32_fmc.c (modreg32). I think it is easier to read this: modreg32 (BOARD_FMC_CLK, RCC_D1CCIPR_FMCSEL_MASK, STM32_RCC_D1CCIPR); than the old-style equivalent: regval = getreg32(STM32_RCC_D1CCIPR); regval = (regval & ~RCC_D1CCIPR_FMCSEL_MASK) | BOARD_FMC_CLK; putreg32(regval, STM32_RCC_D1CCIPR); Also I have pending changes to e.g. stm32_ethernet.c using these macros. I noted that there's a new family of functions modifyreg*() (that were not available on nuttx-8.2 I was working on), but they introduce extra cost for every call, and won't protect anything in my case (and many other cases, as usually modifications to several registers have to be atomic, not individual register modifications). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #459: stm32h7: support SDRAM via FMC peripherial
patacongo commented on a change in pull request #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#discussion_r388991575 ## File path: arch/arm/src/common/up_arch.h ## @@ -58,6 +58,12 @@ # define getreg32(a) (*(volatile uint32_t *)(a)) # define putreg32(v,a)(*(volatile uint32_t *)(a) = (v)) +/* Non-atomic, but more effective modification of registers */ + +# define modreg8(v,m,a) putreg8((getreg8(a) & ~(m)) | ((v) & (m)), a) +# define modreg16(v,m,a) putreg16((getreg16(a) & ~(m)) | ((v) & (m)), a) +# define modreg32(v,m,a) putreg32((getreg32(a) & ~(m)) | ((v) & (m)), a) + Review comment: Remove these. They are not used any where. This is just noice. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated: Prevents NuttX crashing if MM_REGIONS is too small.
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new a4e0b23 Prevents NuttX crashing if MM_REGIONS is too small.
a4e0b23 is described below
commit a4e0b23f4fe5e7c9459e5010c55e66fe2ae2ed24
Author: Андрей Заболотный
AuthorDate: Thu Mar 5 19:15:18 2020 +0300
Prevents NuttX crashing if MM_REGIONS is too small.
Added a DEBUGASSERT and a runtime check so that mm_region will not
overwrite critical heap data if user incorrectly defines MM_REGIONS.
---
mm/mm_heap/mm_initialize.c | 48 --
1 file changed, 21 insertions(+), 27 deletions(-)
diff --git a/mm/mm_heap/mm_initialize.c b/mm/mm_heap/mm_initialize.c
index d979408..7786a74 100644
--- a/mm/mm_heap/mm_initialize.c
+++ b/mm/mm_heap/mm_initialize.c
@@ -1,35 +1,20 @@
/
* mm/mm_heap/mm_initialize.c
*
- * Copyright (C) 2007, 2009, 2011, 2013 Gregory Nutt. All rights reserved.
- * Author: Gregory Nutt
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
*
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
+ * http://www.apache.org/licenses/LICENSE-2.0
*
- * 1. Redistributions of source code must retain the above copyright
- *notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *notice, this list of conditions and the following disclaimer in
- *the documentation and/or other materials provided with the
- *distribution.
- * 3. Neither the name NuttX nor the names of its contributors may be
- *used to endorse or promote products derived from this software
- *without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
- * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
- * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
- * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
- * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
- * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
- * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
- * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
- * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
- * POSSIBILITY OF SUCH DAMAGE.
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
*
/
@@ -75,6 +60,15 @@ void mm_addregion(FAR struct mm_heap_s *heap, FAR void
*heapstart,
uintptr_t heapend;
#if CONFIG_MM_REGIONS > 1
int IDX = heap->mm_nregions;
+
+ /* Writing past CONFIG_MM_REGIONS would have catastrophic consequences */
+
+ DEBUGASSERT(IDX < CONFIG_MM_REGIONS);
+ if (IDX >= CONFIG_MM_REGIONS)
+{
+ return;
+}
+
#else
# define IDX 0
#endif
[GitHub] [incubator-nuttx] patacongo merged pull request #460: Prevents NuttX crashing if MM_REGIONS is too small.
patacongo merged pull request #460: Prevents NuttX crashing if MM_REGIONS is too small. URL: https://github.com/apache/incubator-nuttx/pull/460 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch pr460 created (now 94a73a8)
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch pr460 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. at 94a73a8 cxd56: add configuration for SPECIFIC_DRIVERS No new revisions were added by this update.
[incubator-nuttx] branch pr460 updated: Prevents NuttX crashing if MM_REGIONS is too small.
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch pr460
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/pr460 by this push:
new 31a0a94 Prevents NuttX crashing if MM_REGIONS is too small.
31a0a94 is described below
commit 31a0a9469910abaa1e24e488106154c894065959
Author: Андрей Заболотный
AuthorDate: Thu Mar 5 19:15:18 2020 +0300
Prevents NuttX crashing if MM_REGIONS is too small.
Added a DEBUGASSERT and a runtime check so that mm_region will not
overwrite critical heap data if user incorrectly defines MM_REGIONS.
---
mm/mm_heap/mm_initialize.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/mm/mm_heap/mm_initialize.c b/mm/mm_heap/mm_initialize.c
index d979408..76ae030 100644
--- a/mm/mm_heap/mm_initialize.c
+++ b/mm/mm_heap/mm_initialize.c
@@ -75,6 +75,13 @@ void mm_addregion(FAR struct mm_heap_s *heap, FAR void
*heapstart,
uintptr_t heapend;
#if CONFIG_MM_REGIONS > 1
int IDX = heap->mm_nregions;
+
+ /* Writing past CONFIG_MM_REGIONS would have catastrophic consequences */
+ DEBUGASSERT(IDX < CONFIG_MM_REGIONS);
+ if (IDX >= CONFIG_MM_REGIONS)
+{
+ return;
+}
#else
# define IDX 0
#endif
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #460: Prevents NuttX crashing if MM_REGIONS is too small.
patacongo commented on a change in pull request #460: Prevents NuttX crashing if MM_REGIONS is too small. URL: https://github.com/apache/incubator-nuttx/pull/460#discussion_r388982165 ## File path: mm/mm_heap/mm_initialize.c ## @@ -75,6 +75,13 @@ void mm_addregion(FAR struct mm_heap_s *heap, FAR void *heapstart, uintptr_t heapend; #if CONFIG_MM_REGIONS > 1 int IDX = heap->mm_nregions; + + /* Writing past CONFIG_MM_REGIONS would have catastrophic consequences */ + DEBUGASSERT(IDX < CONFIG_MM_REGIONS); Review comment: Coding standard requires a blank line after each comment. tools/nxstyle should have caught this. I will go ahead with the merge and correct that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #460: Prevents NuttX crashing if MM_REGIONS is too small.
patacongo commented on a change in pull request #460: Prevents NuttX crashing if MM_REGIONS is too small. URL: https://github.com/apache/incubator-nuttx/pull/460#discussion_r388982165 ## File path: mm/mm_heap/mm_initialize.c ## @@ -75,6 +75,13 @@ void mm_addregion(FAR struct mm_heap_s *heap, FAR void *heapstart, uintptr_t heapend; #if CONFIG_MM_REGIONS > 1 int IDX = heap->mm_nregions; + + /* Writing past CONFIG_MM_REGIONS would have catastrophic consequences */ + DEBUGASSERT(IDX < CONFIG_MM_REGIONS); Review comment: Coding standard requires a blank line after each comment. tools/nxstyle should have caught this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] anpaza opened a new pull request #460: Prevents NuttX crashing if MM_REGIONS is too small.
anpaza opened a new pull request #460: Prevents NuttX crashing if MM_REGIONS is too small. URL: https://github.com/apache/incubator-nuttx/pull/460 Added a DEBUGASSERT and a runtime check so that mm_region will not overwrite critical heap data if user incorrectly defines MM_REGIONS. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow
liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388980135 ## File path: .github/workflows/main.yml ## @@ -0,0 +1,85 @@ +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +name: PR Check CI + +on: + pull_request: Review comment: There is also the nightly build to make the full build although it's per day. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] anpaza opened a new pull request #459: stm32h7: support SDRAM via FMC peripherial
anpaza opened a new pull request #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459 Fixed everything said in my previous merge attempt. nxstyle passes on new code. Only FMC-related changes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #261: Initial checkin nuttx github action CI workflow
btashton commented on a change in pull request #261: Initial checkin nuttx
github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388970119
##
File path: .github/workflows/main.yml
##
@@ -0,0 +1,85 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: PR Check CI
+
+on:
+ pull_request:
+branches:
+ - master
+
+jobs:
+ check:
+runs-on: ubuntu-18.04
+container: liuguo09/ubuntu-nuttx:18.04
+
+steps:
+- name: Checkout nuttx repo
+ uses: actions/checkout@v2
+ with:
+path: nuttx
+fetch-depth: 0
+
+- name: Checkout apps repo
+ uses: actions/checkout@v2
+ with:
+repository: apache/incubator-nuttx-apps
+path: apps
+fetch-depth: 0
+
+- name: Check Pull Request
+ run: |
+cd nuttx
+git log --oneline -5
+ranges=`git log -1 --merges --pretty=format:%P | awk -F" " '{ print $1
".." $2 }'`
+commits=`git log --reverse --format=format:%H $ranges`
+echo "./tools/checkpatch.sh -g $commits"
+./tools/checkpatch.sh -g $commits
+
+ build:
+needs: check
+runs-on: ubuntu-18.04
+container: liuguo09/ubuntu-nuttx:18.04
+
+strategy:
+ matrix:
+boards: [sim, mips-riscv-x86, arm-01, arm-02, arm-03, arm-04, arm-05,
arm-06, arm-07, arm-08, arm-09, arm-10, arm-11, arm-12, arm-13, arm-14, arm-15]
+
+steps:
+- name: Checkout nuttx repo
+ uses: actions/checkout@v2
+ with:
+path: nuttx
+fetch-depth: 0
+
+- name: Fetch nuttx tags
+ run: |
+cd nuttx
+git fetch --tags
Review comment:
I guess the cost is low for the two steps, but other examples there like
submodules show two run lines which I think makes sense to just get everything
done. But these are really later optimizations.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #261: Initial checkin nuttx github action CI workflow
btashton commented on a change in pull request #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388968701 ## File path: .github/workflows/main.yml ## @@ -0,0 +1,85 @@ +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +name: PR Check CI + +on: + pull_request: Review comment: I think it captures the merge situation which is what I'm worried about. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow
liuguo09 commented on a change in pull request #261: Initial checkin nuttx
github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388966235
##
File path: .github/workflows/main.yml
##
@@ -0,0 +1,85 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: PR Check CI
+
+on:
+ pull_request:
+branches:
+ - master
+
+jobs:
+ check:
+runs-on: ubuntu-18.04
+container: liuguo09/ubuntu-nuttx:18.04
+
+steps:
+- name: Checkout nuttx repo
+ uses: actions/checkout@v2
+ with:
+path: nuttx
+fetch-depth: 0
+
+- name: Checkout apps repo
+ uses: actions/checkout@v2
+ with:
+repository: apache/incubator-nuttx-apps
+path: apps
+fetch-depth: 0
+
+- name: Check Pull Request
+ run: |
+cd nuttx
+git log --oneline -5
+ranges=`git log -1 --merges --pretty=format:%P | awk -F" " '{ print $1
".." $2 }'`
+commits=`git log --reverse --format=format:%H $ranges`
+echo "./tools/checkpatch.sh -g $commits"
+./tools/checkpatch.sh -g $commits
+
+ build:
+needs: check
+runs-on: ubuntu-18.04
+container: liuguo09/ubuntu-nuttx:18.04
+
+strategy:
+ matrix:
+boards: [sim, mips-riscv-x86, arm-01, arm-02, arm-03, arm-04, arm-05,
arm-06, arm-07, arm-08, arm-09, arm-10, arm-11, arm-12, arm-13, arm-14, arm-15]
+
+steps:
+- name: Checkout nuttx repo
+ uses: actions/checkout@v2
+ with:
+path: nuttx
+fetch-depth: 0
+
+- name: Fetch nuttx tags
+ run: |
+cd nuttx
+git fetch --tags
Review comment:
I have checked that the instructions in the
https://github.com/actions/checkout#fetch-all-tags run two steps too.
So it doesn't make much sense to use same as it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow
liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388956981 ## File path: .github/workflows/main.yml ## @@ -0,0 +1,85 @@ +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +name: PR Check CI + +on: + pull_request: Review comment: Update on trigger pull request for all branches. As to push event, I think it may be not necessary since there is no committer push master directly. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] anpaza commented on a change in pull request #458: stm32h7: support SDRAM via FMC peripherial
anpaza commented on a change in pull request #458: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/458#discussion_r388956487 ## File path: arch/arm/src/stm32h7/stm32_fmc.c ## @@ -39,40 +39,387 @@ #include +#if defined(CONFIG_STM32H7_FMC) + #include "stm32.h" -#if defined(CONFIG_STM32H7_FMC) +#include + +//#include "stm32_fmc.h" +//#include "hardware/stm32_pinmap.h" +//#include "stm32_gpio.h" +//#include "stm32_rcc.h" Review comment: Sorry, its a leftover from the merge from my other git repo, and forgot to remove them after checking that it works. Will fix that now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated (45a8edd -> 94a73a8)
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 45a8edd nxstyle: Output line numbers when complaining on block
comments length
add 34f274f cxd56: move ISX012 camera sensor driver
add 94a73a8 cxd56: add configuration for SPECIFIC_DRIVERS
No new revisions were added by this update.
Summary of changes:
boards/arm/cxd56xx/drivers/Kconfig | 9 +
boards/arm/cxd56xx/drivers/Make.defs | 1 +
.../arm/cxd56xx/drivers/camera}/Kconfig| 5 +--
.../arm/cxd56xx/drivers/camera/Make.defs | 22 +---
.../arm/cxd56xx/drivers/camera}/isx012.c | 41 +++---
boards/arm/cxd56xx/drivers/sensors/Kconfig | 1 -
drivers/video/Kconfig | 5 ---
drivers/video/Make.defs| 4 ---
8 files changed, 35 insertions(+), 53 deletions(-)
copy {libs/libnx/nxglib => boards/arm/cxd56xx/drivers/camera}/Kconfig (70%)
copy include/sys/file.h => boards/arm/cxd56xx/drivers/camera/Make.defs (71%)
rename {drivers/video => boards/arm/cxd56xx/drivers/camera}/isx012.c (98%)
[GitHub] [incubator-nuttx] patacongo merged pull request #456: CXD56: move isx012 driver to board specific drivers
patacongo merged pull request #456: CXD56: move isx012 driver to board specific drivers URL: https://github.com/apache/incubator-nuttx/pull/456 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #458: stm32h7: support SDRAM via FMC peripherial
davids5 commented on issue #458: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/458#issuecomment-595804682 ehmm @patacongo - Do you want more contributions? Please read what I wrote. >Thank you. These all have great merit. But the coupling is problematic. In looking at this it should be 3 PRs for the 3 commits. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #458: stm32h7: support SDRAM via FMC peripherial
patacongo edited a comment on issue #458: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/458#issuecomment-595800665 @davids5 This change MUST BE DECLINED. It makes extensive modification to mm/mm_initialize.c tools/Makefile.unix, tools/Makefile.win, and tools/Config.mk. That cannot be allowed! The nature of the changes or also incorrect and ill-informed. We cannot have this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #458: stm32h7: support SDRAM via FMC peripherial
patacongo edited a comment on issue #458: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/458#issuecomment-595801571 This may be reopened if changes to mm./mm_initialize.c, tools/Makefile.win, Makefile.unix, and Config.mk are REMOVED. Those are shit changes and have nothing to do with STM32H7 FMC. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #458: stm32h7: support SDRAM via FMC peripherial
patacongo commented on issue #458: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/458#issuecomment-595801571 This may be reopened if changes to tools/Makefile.win, Makefile.unix, and Config.mk are REMOVED. Those are shit changes and have nothing to do with STM32H7 FMC. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
