anchao commented on code in PR #11805:
URL: https://github.com/apache/nuttx/pull/11805#discussion_r1507126830
##
include/nuttx/list.h:
##
@@ -44,15 +44,28 @@
* Included Files
/
-#include
-
wengzhe commented on code in PR #11804:
URL: https://github.com/apache/nuttx/pull/11804#discussion_r1507114720
##
net/local/local_sendmsg.c:
##
@@ -417,14 +426,7 @@ ssize_t local_sendmsg(FAR struct socket *psock, FAR struct
msghdr *msg,
if (len < 0 && count > 0)
{
xiaoxiang781216 commented on code in PR #11804:
URL: https://github.com/apache/nuttx/pull/11804#discussion_r1507103899
##
net/local/local_sendmsg.c:
##
@@ -58,6 +58,18 @@
/
#ifdef
xiaoxiang781216 commented on code in PR #11804:
URL: https://github.com/apache/nuttx/pull/11804#discussion_r1507103428
##
net/local/local_sendmsg.c:
##
@@ -124,19 +135,11 @@ static int local_sendctl(FAR struct local_conn_s *conn,
}
net_unlock();
-
return count;
xiaoxiang781216 commented on code in PR #11804:
URL: https://github.com/apache/nuttx/pull/11804#discussion_r1507100414
##
net/local/local_sendmsg.c:
##
@@ -417,14 +426,7 @@ ssize_t local_sendmsg(FAR struct socket *psock, FAR struct
msghdr *msg,
if (len < 0 && count > 0)
wengzhe commented on code in PR #11804:
URL: https://github.com/apache/nuttx/pull/11804#discussion_r1507082013
##
net/local/local_sendmsg.c:
##
@@ -417,14 +426,7 @@ ssize_t local_sendmsg(FAR struct socket *psock, FAR struct
msghdr *msg,
if (len < 0 && count > 0)
{
wengzhe commented on code in PR #11804:
URL: https://github.com/apache/nuttx/pull/11804#discussion_r1507071171
##
net/local/local_sendmsg.c:
##
@@ -124,19 +135,11 @@ static int local_sendctl(FAR struct local_conn_s *conn,
}
net_unlock();
-
return count;
fail:
-
xiaoxiang781216 commented on code in PR #11805:
URL: https://github.com/apache/nuttx/pull/11805#discussion_r1507039000
##
include/nuttx/list.h:
##
@@ -44,15 +44,28 @@
* Included Files
/
-#include
xiaoxiang781216 commented on code in PR #11777:
URL: https://github.com/apache/nuttx/pull/11777#discussion_r1507038069
##
include/nuttx/sched.h:
##
@@ -480,6 +533,9 @@ struct task_group_s
/* Thread local storage ***/
anchao commented on code in PR #11777:
URL: https://github.com/apache/nuttx/pull/11777#discussion_r1506919987
##
include/nuttx/sched.h:
##
@@ -480,6 +533,9 @@ struct task_group_s
/* Thread local storage ***/
+#ifndef
anchao opened a new pull request, #11805:
URL: https://github.com/apache/nuttx/pull/11805
## Summary
nuttx/list: rename container_of to _container_of from public header
Use private naming to avoid conflicts with user applications
In file included from
anchao commented on code in PR #11777:
URL: https://github.com/apache/nuttx/pull/11777#discussion_r1506896154
##
include/nuttx/sched.h:
##
@@ -412,6 +419,52 @@ struct binary_s;/* Forward reference
/* Defined in
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 896200191 Publishing web:
JorgeGzm commented on issue #11800:
URL: https://github.com/apache/nuttx/issues/11800#issuecomment-1969731878
Hi @takayoshi-k,
Check the microhobby repository, maybe can solve your problem.
https://github.com/microhobby/vscode-nuttx
```
$ grep -R "showOpenDialog" ./
xiaoxiang781216 commented on code in PR #11777:
URL: https://github.com/apache/nuttx/pull/11777#discussion_r1506391344
##
include/nuttx/sched.h:
##
@@ -412,6 +419,52 @@ struct binary_s;/* Forward reference
/* Defined in
xiaoxiang781216 opened a new pull request, #11804:
URL: https://github.com/apache/nuttx/pull/11804
## Summary
- local: correct shutdown state when use UDP mode
- net/local: Remove the unused lc_psock from local_conn_s
- net/local: Initialize lc_crefs to 1
- net/local: Remove
acassis commented on issue #11800:
URL: https://github.com/apache/nuttx/issues/11800#issuecomment-1969565192
@JorgeGzm @microhobby did you guys face this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
acassis commented on code in PR #11799:
URL: https://github.com/apache/nuttx/pull/11799#discussion_r1506377755
##
arch/arm/src/cxd56xx/cxd56_nxaudio.c:
##
@@ -2698,7 +2699,7 @@ static int cxd56_getcaps(struct audio_lowerhalf_s *lower,
int type,
*
xiaoxiang781216 commented on PR #2316:
URL: https://github.com/apache/nuttx-apps/pull/2316#issuecomment-1969366684
this is testing code to demo the problem, @acassis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
acassis commented on issue #11803:
URL: https://github.com/apache/nuttx/issues/11803#issuecomment-1969270260
@yf13 I think you already used it, any idea about what is happening?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
shijogeorge24 commented on issue #11763:
URL: https://github.com/apache/nuttx/issues/11763#issuecomment-1969268623
Here is my .config file
[config.txt](https://github.com/apache/nuttx/files/14436392/config.txt)
example using
shijogeorge24 commented on issue #11763:
URL: https://github.com/apache/nuttx/issues/11763#issuecomment-1969245729
#
# License Setup
#
# CONFIG_ALLOW_BSD_COMPONENTS is not set
# CONFIG_ALLOW_GPL_COMPONENTS is not set
# CONFIG_ALLOW_MIT_COMPONENTS is not set
# end of
jerpelea commented on PR #2317:
URL: https://github.com/apache/nuttx-apps/pull/2317#issuecomment-1969243631
+1 for 80 characters limit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mlyszczek commented on PR #11798:
URL: https://github.com/apache/nuttx/pull/11798#issuecomment-1969226469
Yes, in stm32 datasheet they refer to pins as PA, PB etc.
but board refers to them as A, B... I'm pretty sure it's
to save space on PCB, as they would not fit PA, PB...
Here is
mlyszczek commented on PR #2317:
URL: https://github.com/apache/nuttx-apps/pull/2317#issuecomment-1969204654
I am all game for 80ch line width. Shorter lines are way
easier to read than longer. Hell, I think newspapers keep it
down at 40 characters or so, their columns are always so
acassis commented on PR #11798:
URL: https://github.com/apache/nuttx/pull/11798#issuecomment-1969204177
> Hmm... you think? I named them exactly as they are printed on the PCB.
Hmm, ok! In the datasheet they are referenced as PA*, PB*, PC*, etc
--
This is an automated message from
GUIDINGLI commented on PR #11797:
URL: https://github.com/apache/nuttx/pull/11797#issuecomment-1969198040
@masayuki2009
Thanks for the feeding back.
I have updated the PR, please try again.
--
This is an automated message from the Apache Git Service.
To respond to the
acassis commented on PR #2316:
URL: https://github.com/apache/nuttx-apps/pull/2316#issuecomment-1969166787
What is this "[Don't submit]" ? Is this how Xiaomi defines which patches
shouldn't be contributed to mainline? Please remove this name from the commit
name
--
This is an automated
acassis commented on PR #2317:
URL: https://github.com/apache/nuttx-apps/pull/2317#issuecomment-1969162349
> I think it looks kinda bad, it's harder to see how output is going to be
printed and is hard to grep later on. Even Linux allows for long strings
without breaking.
>
> How
tmedicci opened a new issue, #11803:
URL: https://github.com/apache/nuttx/issues/11803
## Summary
Debug assertions are asserting when enabled for `rv-virt:knsh32` defconfig:
```
ABC
NuttShell (NSH) NuttX-10.4.0
nsh> /system/bin/hello
Hello, World!!
nsh> [
xiaoxiang781216 commented on code in PR #11737:
URL: https://github.com/apache/nuttx/pull/11737#discussion_r1505862092
##
arch/arm/src/xmc4/xmc4_ccu4.c:
##
@@ -0,0 +1,195 @@
+/
+ *
xiaoxiang781216 commented on PR #11676:
URL: https://github.com/apache/nuttx/pull/11676#issuecomment-1968858611
@simbit18 let's squash into one patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
xiaoxiang781216 commented on code in PR #11676:
URL: https://github.com/apache/nuttx/pull/11676#discussion_r1505850365
##
tools/ci/platforms/darwin.sh:
##
@@ -0,0 +1,449 @@
+#!/usr/bin/env bash
+
+#
jerpelea commented on PR #11765:
URL: https://github.com/apache/nuttx/pull/11765#issuecomment-1968857831
+1 for merging now
design optimization can be done in a later PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
xiaoxiang781216 commented on PR #11765:
URL: https://github.com/apache/nuttx/pull/11765#issuecomment-1968848258
@acassis shoul we merge this patch first and refine the layout late?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
This is an automated email from the ASF dual-hosted git repository.
jerpelea pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 1665114fd1 xtensa/esp32: Fix issue of system blocking when SPIRAM is
used as stack
add 9f62947d40 build/cmake:
jerpelea merged PR #11788:
URL: https://github.com/apache/nuttx/pull/11788
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
37 matches
Mail list logo
