xiaoxiang781216 merged PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
TimJTi commented on PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#issuecomment-1966894501
I have not been able to work for 6 weeks after emergency eye surgery and I
have only just been able to revisit this.
I have made changes as per all comments and don't seem to
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1504493355
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1504403710
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1504402781
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1504393324
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1504390151
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1504324469
##
examples/settings/Kconfig:
##
@@ -0,0 +1,61 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1504323739
##
examples/settings/Kconfig:
##
@@ -0,0 +1,61 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1504321899
##
examples/settings/settings_main.c:
##
@@ -0,0 +1,301 @@
+/
+ *
acassis commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1491109249
##
examples/settings/Kconfig:
##
@@ -0,0 +1,61 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1426799510
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1426798852
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1426797703
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1426745789
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1426722618
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1426713345
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1426712560
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1426708536
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1426709523
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1426707159
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1426669043
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1426669043
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
fjpanag commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1426667551
##
include/system/storage.h:
##
@@ -0,0 +1,66 @@
+/
Review Comment:
It seems better
fjpanag commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1426665939
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1426660892
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
fjpanag commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1426656979
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
fjpanag commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1426654083
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
fjpanag commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1426653062
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
fjpanag commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1426649974
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
fjpanag commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1426643856
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
fjpanag commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1426643032
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
fjpanag commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1426637311
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
fjpanag commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1426635365
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
fjpanag commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1426633027
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
fjpanag commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1426631705
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
fjpanag commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1426614207
##
include/system/settings.h:
##
@@ -0,0 +1,346 @@
+/
+ * apps/include/system/settings.h
fjpanag commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1426610437
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
fjpanag commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1426607481
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
fjpanag commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1426603066
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425478790
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425460328
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425460328
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425455310
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425454363
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425448690
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425442373
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425439744
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425429896
##
system/settings/storage_text.c:
##
@@ -0,0 +1,468 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425428949
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425430654
##
system/settings/storage_text.c:
##
@@ -0,0 +1,468 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425430330
##
system/settings/storage_text.c:
##
@@ -0,0 +1,468 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425427411
##
system/settings/storage_text.c:
##
@@ -0,0 +1,468 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425427071
##
include/system/settings.h:
##
@@ -0,0 +1,346 @@
+/
+ * apps/include/system/settings.h
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425426282
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425422304
##
system/settings/storage_eeprom.c:
##
@@ -0,0 +1,408 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425420903
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425421340
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425419697
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425420410
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425408867
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425409917
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425405253
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425399793
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425355959
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425353604
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425351874
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425347811
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425336581
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425332388
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425329100
##
include/system/settings.h:
##
@@ -0,0 +1,346 @@
+/
+ * apps/include/system/settings.h
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1425328494
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1424512060
##
include/system/settings.h:
##
@@ -0,0 +1,346 @@
+/
+ * apps/include/system/settings.h
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1424386549
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1424386549
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1424341724
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1424335532
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1424330938
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1424329448
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#issuecomment-1852420562
> @TimJTi If you need to reduce the memory use of the map, why don't you try
to use an [RLE](https://en.wikipedia.org/wiki/Run-length_encoding) or a
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1424282005
##
system/settings/storage_eeprom.c:
##
@@ -0,0 +1,408 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1424275728
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1424277974
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1424273313
##
include/system/storage.h:
##
@@ -0,0 +1,66 @@
+/
Review Comment:
Yes, agreed.
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1424268982
##
system/settings/storage_eeprom.c:
##
@@ -0,0 +1,408 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1424266413
##
system/settings/storage_eeprom.c:
##
@@ -0,0 +1,408 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1424261309
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1424254866
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1424253039
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
TimJTi commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1424248218
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
fjpanag commented on code in PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#discussion_r1424132629
##
system/settings/settings.c:
##
@@ -0,0 +1,1717 @@
+/
+ *
fjpanag commented on PR #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228#issuecomment-1852331724
@TimJTi If you need to reduce the memory use of the map, why don't you try
to use an [RLE](https://en.wikipedia.org/wiki/Run-length_encoding) or a
TimJTi opened a new pull request, #2228:
URL: https://github.com/apache/nuttx-apps/pull/2228
## Summary
Last year @fjpanag offered to donate some code to the repo. This is my
(second) attempt at making his "settings" functions NuttX compatible along with
an example app to check it
TimJTi closed pull request #2178: Add Settings Utility and Example App
URL: https://github.com/apache/nuttx-apps/pull/2178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
TimJTi commented on PR #2178:
URL: https://github.com/apache/nuttx-apps/pull/2178#issuecomment-1807164400
Due to lack of interest. Will work on my own variant and maybe try and
resubmit in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message,
TimJTi commented on code in PR #2178:
URL: https://github.com/apache/nuttx-apps/pull/2178#discussion_r1389711438
##
system/settings/settings.c:
##
@@ -0,0 +1,1432 @@
+/
+ *
TimJTi commented on code in PR #2178:
URL: https://github.com/apache/nuttx-apps/pull/2178#discussion_r1387868147
##
examples/settings/Kconfig:
##
@@ -0,0 +1,53 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX
hartmannathan commented on code in PR #2178:
URL: https://github.com/apache/nuttx-apps/pull/2178#discussion_r1385520784
##
examples/settings/Kconfig:
##
@@ -0,0 +1,53 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in
TimJTi commented on code in PR #2178:
URL: https://github.com/apache/nuttx-apps/pull/2178#discussion_r1385371081
##
system/settings/settings.c:
##
@@ -0,0 +1,1432 @@
+/
+ *
TimJTi commented on code in PR #2178:
URL: https://github.com/apache/nuttx-apps/pull/2178#discussion_r1385266096
##
system/settings/settings.c:
##
@@ -0,0 +1,1432 @@
+/
+ *
1 - 100 of 141 matches
Mail list logo