Re: [PR] mm/gran: remove size limitation [nuttx]

acassis merged PR #12095: URL: https://github.com/apache/nuttx/pull/12095 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] mm/gran: remove size limitation [nuttx]

yf13 commented on PR #12095: URL: https://github.com/apache/nuttx/pull/12095#issuecomment-2060310131 @xiaoxiang781216 the `mm_gran.c` has been split into three files as you requested. both patch description and commit message are updated with explanations about the changes. please give a

Re: [PR] mm/gran: remove size limitation [nuttx]

acassis commented on PR #12095: URL: https://github.com/apache/nuttx/pull/12095#issuecomment-2057042220 > @acassis thanks for mentioning the uncrustify.cfg thing! The tool can save us a lot time. However, it seems that the latest version of `tools/uncrustify.cfg` is wrong about block

Re: [PR] mm/gran: remove size limitation [nuttx]

yf13 commented on PR #12095: URL: https://github.com/apache/nuttx/pull/12095#issuecomment-2054262450 @acassis thanks for mentioning the uncrustify.cfg thing! The tool can save us a lot code formatting time. However, it seems that the `tools/uncrustify.cfg` is wrong about block comments

Re: [PR] mm/gran: remove size limitation [nuttx]

acassis commented on code in PR #12095: URL: https://github.com/apache/nuttx/pull/12095#discussion_r1564957380 ## mm/mm_gran/mm_granalloc.c: ## @@ -25,226 +25,46 @@ #include #include +#include #include #include "mm_gran/mm_gran.h" +#include

Re: [PR] mm/gran: remove size limitation [nuttx]

acassis commented on code in PR #12095: URL: https://github.com/apache/nuttx/pull/12095#discussion_r1564957380 ## mm/mm_gran/mm_granalloc.c: ## @@ -25,226 +25,46 @@ #include #include +#include #include #include "mm_gran/mm_gran.h" +#include

Re: [PR] mm/gran: remove size limitation [nuttx]

acassis commented on PR #12095: URL: https://github.com/apache/nuttx/pull/12095#issuecomment-2054203027 > @xiaoxiang781216 @btashton @pkarashchenko Seems like there is a fail in our nxstyle coding check, it is allowing single line if () without { }, as requested:

Re: [PR] mm/gran: remove size limitation [nuttx]

yf13 commented on code in PR #12095: URL: https://github.com/apache/nuttx/pull/12095#discussion_r1564955711 ## mm/mm_gran/mm_granalloc.c: ## @@ -25,226 +25,46 @@ #include #include +#include #include #include "mm_gran/mm_gran.h" +#include "mm_gran/mm_grantable.h"

Re: [PR] mm/gran: remove size limitation [nuttx]

acassis commented on PR #12095: URL: https://github.com/apache/nuttx/pull/12095#issuecomment-2054201129 @xiaoxiang781216 @btashton @pkarashchenko Seems like there is a fail in our nxstyle coding check, it is allowing single line if () without { }, as requested:

Re: [PR] mm/gran: remove size limitation [nuttx]

acassis commented on code in PR #12095: URL: https://github.com/apache/nuttx/pull/12095#discussion_r1564950994 ## mm/mm_gran/mm_grantable.c: ## @@ -0,0 +1,251 @@ +/ + * mm/mm_gran/mm_grantable.c + * + *

Re: [PR] mm/gran: remove size limitation [nuttx]

xiaoxiang781216 commented on code in PR #12095: URL: https://github.com/apache/nuttx/pull/12095#discussion_r1564745012 ## mm/mm_gran/mm_gran.c: ## @@ -0,0 +1,138 @@ +/ + * mm/mm_gran/mm_gran.c + * + *

Re: [PR] mm/gran: remove size limitation [nuttx]

xiaoxiang781216 commented on code in PR #12095: URL: https://github.com/apache/nuttx/pull/12095#discussion_r1561310877 ## mm/mm_gran/mm_gran2.c: ## @@ -0,0 +1,138 @@ +/ + * mm/mm_gran/mm_gran2.c Review