phoenix git commit: PHOENIX-3853 Local Index - Writes to local index are twice as slow as global and get exponentially slower with PHOENIX-3827_v2 patch(Rajeshbabu)
Repository: phoenix Updated Branches: refs/heads/4.x-HBase-1.2 aae94a053 -> 10670d339 PHOENIX-3853 Local Index - Writes to local index are twice as slow as global and get exponentially slower with PHOENIX-3827_v2 patch(Rajeshbabu) Project: http://git-wip-us.apache.org/repos/asf/phoenix/repo Commit: http://git-wip-us.apache.org/repos/asf/phoenix/commit/10670d33 Tree: http://git-wip-us.apache.org/repos/asf/phoenix/tree/10670d33 Diff: http://git-wip-us.apache.org/repos/asf/phoenix/diff/10670d33 Branch: refs/heads/4.x-HBase-1.2 Commit: 10670d3399b92b7aec5f5c90dba6d046fe1561d4 Parents: aae94a0 Author: Rajeshbabu ChintaguntlaAuthored: Wed May 24 15:05:29 2017 +0530 Committer: Rajeshbabu Chintaguntla Committed: Wed May 24 15:05:29 2017 +0530 -- .../org/apache/phoenix/hbase/index/Indexer.java | 25 1 file changed, 5 insertions(+), 20 deletions(-) -- http://git-wip-us.apache.org/repos/asf/phoenix/blob/10670d33/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java -- diff --git a/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java b/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java index 15e53a3..ab8c434 100644 --- a/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java +++ b/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java @@ -96,6 +96,11 @@ import com.google.common.collect.Multimap; * nothing does. Currently, we do not support mixed-durability updates within a single batch. If you * want to have different durability levels, you only need to split the updates into two different * batches. + * + * We don't need to implement {@link #postPut(ObserverContext, Put, WALEdit, Durability)} and + * {@link #postDelete(ObserverContext, Delete, WALEdit, Durability)} hooks because + * Phoenix always does batch mutations. + * */ public class Indexer extends BaseRegionObserver { @@ -366,26 +371,6 @@ public class Indexer extends BaseRegionObserver { } @Override - public void postPut(ObserverContext e, Put put, WALEdit edit, - final Durability durability) throws IOException { - if (this.disabled) { - super.postPut(e, put, edit, durability); - return; -} -doPost(edit, put, durability); - } - - @Override - public void postDelete(ObserverContext e, Delete delete, - WALEdit edit, final Durability durability) throws IOException { - if (this.disabled) { - super.postDelete(e, delete, edit, durability); - return; -} -doPost(edit, delete, durability); - } - - @Override public void postBatchMutateIndispensably(ObserverContext c, MiniBatchOperationInProgress miniBatchOp, final boolean success) throws IOException { if (this.disabled) {
phoenix git commit: PHOENIX-3853 Local Index - Writes to local index are twice as slow as global and get exponentially slower with PHOENIX-3827_v2 patch(Rajeshbabu)
Repository: phoenix Updated Branches: refs/heads/4.x-HBase-0.98 f57a97a08 -> 8182ee32a PHOENIX-3853 Local Index - Writes to local index are twice as slow as global and get exponentially slower with PHOENIX-3827_v2 patch(Rajeshbabu) Project: http://git-wip-us.apache.org/repos/asf/phoenix/repo Commit: http://git-wip-us.apache.org/repos/asf/phoenix/commit/8182ee32 Tree: http://git-wip-us.apache.org/repos/asf/phoenix/tree/8182ee32 Diff: http://git-wip-us.apache.org/repos/asf/phoenix/diff/8182ee32 Branch: refs/heads/4.x-HBase-0.98 Commit: 8182ee32a2c08f2ff428fabcb68c2803a0b038ec Parents: f57a97a Author: Rajeshbabu ChintaguntlaAuthored: Wed May 24 15:03:43 2017 +0530 Committer: Rajeshbabu Chintaguntla Committed: Wed May 24 15:03:43 2017 +0530 -- .../org/apache/phoenix/hbase/index/Indexer.java | 25 1 file changed, 5 insertions(+), 20 deletions(-) -- http://git-wip-us.apache.org/repos/asf/phoenix/blob/8182ee32/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java -- diff --git a/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java b/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java index 748779f..22facd4 100644 --- a/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java +++ b/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java @@ -96,6 +96,11 @@ import com.google.common.collect.Multimap; * nothing does. Currently, we do not support mixed-durability updates within a single batch. If you * want to have different durability levels, you only need to split the updates into two different * batches. + * + * We don't need to implement {@link #postPut(ObserverContext, Put, WALEdit, Durability)} and + * {@link #postDelete(ObserverContext, Delete, WALEdit, Durability)} hooks because + * Phoenix always does batch mutations. + * */ public class Indexer extends BaseRegionObserver { @@ -366,26 +371,6 @@ public class Indexer extends BaseRegionObserver { } @Override - public void postPut(ObserverContext e, Put put, WALEdit edit, - final Durability durability) throws IOException { - if (this.disabled) { - super.postPut(e, put, edit, durability); - return; -} -doPost(edit, put, durability); - } - - @Override - public void postDelete(ObserverContext e, Delete delete, - WALEdit edit, final Durability durability) throws IOException { - if (this.disabled) { - super.postDelete(e, delete, edit, durability); - return; -} -doPost(edit, delete, durability); - } - - @Override public void postBatchMutateIndispensably(ObserverContext c, MiniBatchOperationInProgress miniBatchOp, final boolean success) throws IOException { if (this.disabled) {
phoenix git commit: PHOENIX-3853 Local Index - Writes to local index are twice as slow as global and get exponentially slower with PHOENIX-3827_v2 patch(Rajeshbabu)
Repository: phoenix Updated Branches: refs/heads/4.x-HBase-1.1 e0ed3e34c -> b0c89849d PHOENIX-3853 Local Index - Writes to local index are twice as slow as global and get exponentially slower with PHOENIX-3827_v2 patch(Rajeshbabu) Project: http://git-wip-us.apache.org/repos/asf/phoenix/repo Commit: http://git-wip-us.apache.org/repos/asf/phoenix/commit/b0c89849 Tree: http://git-wip-us.apache.org/repos/asf/phoenix/tree/b0c89849 Diff: http://git-wip-us.apache.org/repos/asf/phoenix/diff/b0c89849 Branch: refs/heads/4.x-HBase-1.1 Commit: b0c89849dcd978b6909c8e72c920bce4e88f51fd Parents: e0ed3e3 Author: Rajeshbabu ChintaguntlaAuthored: Wed May 24 15:02:13 2017 +0530 Committer: Rajeshbabu Chintaguntla Committed: Wed May 24 15:02:13 2017 +0530 -- .../org/apache/phoenix/hbase/index/Indexer.java | 25 1 file changed, 5 insertions(+), 20 deletions(-) -- http://git-wip-us.apache.org/repos/asf/phoenix/blob/b0c89849/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java -- diff --git a/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java b/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java index 15e53a3..ab8c434 100644 --- a/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java +++ b/phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java @@ -96,6 +96,11 @@ import com.google.common.collect.Multimap; * nothing does. Currently, we do not support mixed-durability updates within a single batch. If you * want to have different durability levels, you only need to split the updates into two different * batches. + * + * We don't need to implement {@link #postPut(ObserverContext, Put, WALEdit, Durability)} and + * {@link #postDelete(ObserverContext, Delete, WALEdit, Durability)} hooks because + * Phoenix always does batch mutations. + * */ public class Indexer extends BaseRegionObserver { @@ -366,26 +371,6 @@ public class Indexer extends BaseRegionObserver { } @Override - public void postPut(ObserverContext e, Put put, WALEdit edit, - final Durability durability) throws IOException { - if (this.disabled) { - super.postPut(e, put, edit, durability); - return; -} -doPost(edit, put, durability); - } - - @Override - public void postDelete(ObserverContext e, Delete delete, - WALEdit edit, final Durability durability) throws IOException { - if (this.disabled) { - super.postDelete(e, delete, edit, durability); - return; -} -doPost(edit, delete, durability); - } - - @Override public void postBatchMutateIndispensably(ObserverContext c, MiniBatchOperationInProgress miniBatchOp, final boolean success) throws IOException { if (this.disabled) {