[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4388: Adding support for Map type fields

kishoreg commented on a change in pull request #4388: Adding support for Map type fields URL: https://github.com/apache/incubator-pinot/pull/4388#discussion_r305207961 ## File path:

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4399: Moving handling of NULL values from RecordReaders to NullValueTransfo…

kishoreg commented on a change in pull request #4399: Moving handling of NULL values from RecordReaders to NullValueTransfo… URL: https://github.com/apache/incubator-pinot/pull/4399#discussion_r305207199 ## File path:

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4399: Moving handling of NULL values from RecordReaders to NullValueTransfo…

kishoreg commented on a change in pull request #4399: Moving handling of NULL values from RecordReaders to NullValueTransfo… URL: https://github.com/apache/incubator-pinot/pull/4399#discussion_r305207309 ## File path:

[GitHub] [incubator-pinot] jihaozh merged pull request #4443: [TE] Detection and alert config formatters

jihaozh merged pull request #4443: [TE] Detection and alert config formatters URL: https://github.com/apache/incubator-pinot/pull/4443 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-pinot] branch master updated: [TE] Detection and alert config formatters (#4443)

This is an automated email from the ASF dual-hosted git repository. jihao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 365ee85 [TE] Detection and alert

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r305152506 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r305150720 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r305149082 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/HashUtil.java

[GitHub] [incubator-pinot] jihaozh merged pull request #4437: [TE] frontend - harleyjj/preview - provide custom time range before p…

jihaozh merged pull request #4437: [TE] frontend - harleyjj/preview - provide custom time range before p… URL: https://github.com/apache/incubator-pinot/pull/4437 This is an automated message from the Apache Git Service. To

[incubator-pinot] branch master updated: [TE] frontend - harleyjj/preview - provide custom time range before previewing (#4437)

This is an automated email from the ASF dual-hosted git repository. jihao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 85b07f3 [TE] frontend -

[incubator-pinot] branch refactor_kafka updated (a93a3d1 -> 66124eb)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch refactor_kafka in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard a93a3d1 Refactor pinot-connectors to break the dependencies from kafka 0.9 add 66124eb

[GitHub] [incubator-pinot] jihaozh opened a new pull request #4448: [TE] anomaly filters potential inconsistency issue fix

jihaozh opened a new pull request #4448: [TE] anomaly filters potential inconsistency issue fix URL: https://github.com/apache/incubator-pinot/pull/4448 Currently, the anomaly filters will re-fetch data from the data source to get the current value for anomalies. This works fine in most

[GitHub] [incubator-pinot] fx19880617 commented on issue #4445: Refactor pinot-connectors to break the dependencies from kafka 0.9

fx19880617 commented on issue #4445: Refactor pinot-connectors to break the dependencies from kafka 0.9 URL: https://github.com/apache/incubator-pinot/pull/4445#issuecomment-512988296 I've tested hybrid and realtime quick start. Both of them work.

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4445: Refactor pinot-connectors to break the dependencies from kafka 0.9

kishoreg commented on a change in pull request #4445: Refactor pinot-connectors to break the dependencies from kafka 0.9 URL: https://github.com/apache/incubator-pinot/pull/4445#discussion_r305112825 ## File path:

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4443: [TE] Detection and alert config formatters

xiaohui-sun commented on a change in pull request #4443: [TE] Detection and alert config formatters URL: https://github.com/apache/incubator-pinot/pull/4443#discussion_r305100866 ## File path:

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4443: [TE] Detection and alert config formatters

xiaohui-sun commented on a change in pull request #4443: [TE] Detection and alert config formatters URL: https://github.com/apache/incubator-pinot/pull/4443#discussion_r305100939 ## File path:

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4443: [TE] Detection and alert config formatters

xiaohui-sun commented on a change in pull request #4443: [TE] Detection and alert config formatters URL: https://github.com/apache/incubator-pinot/pull/4443#discussion_r305100866 ## File path:

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4443: [TE] Detection and alert config formatters

jihaozh commented on a change in pull request #4443: [TE] Detection and alert config formatters URL: https://github.com/apache/incubator-pinot/pull/4443#discussion_r305100042 ## File path:

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4443: [TE] Detection and alert config formatters

jihaozh commented on a change in pull request #4443: [TE] Detection and alert config formatters URL: https://github.com/apache/incubator-pinot/pull/4443#discussion_r305100014 ## File path:

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4443: [TE] Detection and alert config formatters

jihaozh commented on a change in pull request #4443: [TE] Detection and alert config formatters URL: https://github.com/apache/incubator-pinot/pull/4443#discussion_r305100337 ## File path:

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4443: [TE] Detection and alert config formatters

jihaozh commented on a change in pull request #4443: [TE] Detection and alert config formatters URL: https://github.com/apache/incubator-pinot/pull/4443#discussion_r305100079 ## File path:

[incubator-pinot] branch master updated: Add comments and fix typo for the SegmentCompletionTest. (#4447)

This is an automated email from the ASF dual-hosted git repository. mcvsubbu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new cd579b1 Add comments and fix typo

[GitHub] [incubator-pinot] mcvsubbu merged pull request #4447: Add comments and fix typo for the SegmentCompletionTest.

mcvsubbu merged pull request #4447: Add comments and fix typo for the SegmentCompletionTest. URL: https://github.com/apache/incubator-pinot/pull/4447 This is an automated message from the Apache Git Service. To respond to

[incubator-pinot] branch refactor_kafka updated (2f2b89c -> a93a3d1)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch refactor_kafka in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 2f2b89c Refactor pinot-connectors to break the dependencies from kafka 0.9 add a93a3d1

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r305083234 ## File path:

[incubator-pinot] branch refactor_kafka updated (e1ecbc4 -> 2f2b89c)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch refactor_kafka in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard e1ecbc4 Refactor pinot-connectors to break the dependencies from kafka 0.9 add 2f2b89c

[incubator-pinot] branch refactor_kafka updated (b2f93f1 -> e1ecbc4)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch refactor_kafka in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. omit b2f93f1 Refactor pinot-connectors to break the dependencies from kafka 0.9 add e1ecbc4

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4323: [Controller Separation] Add logic for lead controller resource

codecov-io edited a comment on issue #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#issuecomment-502327426 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4323?src=pr=h1) Report >

[incubator-pinot] branch refactor_kafka updated (6daa154 -> b2f93f1)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch refactor_kafka in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. omit 6daa154 Refactor pinot-connectors to break the dependencies from kafka 0.9 add b2f93f1

[GitHub] [incubator-pinot] chenboat opened a new pull request #4447: Add comments and fix typo for the SegmentCompletionTest.

chenboat opened a new pull request #4447: Add comments and fix typo for the SegmentCompletionTest. URL: https://github.com/apache/incubator-pinot/pull/4447 Add comments and fix typo for the SegmentCompletionTest. This is an

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4323: [Controller Separation] Add logic for lead controller resource

codecov-io edited a comment on issue #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#issuecomment-502327426 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4323?src=pr=h1) Report >

[incubator-pinot] branch add-logic-for-lead-controller-resource updated (8525403 -> 823ea01)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-logic-for-lead-controller-resource in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. omit 8525403 Address PR comments add 823ea01 Address PR comments This

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r305043418 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r305043353 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r305043502 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/HashUtils.java

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r305043464 ## File path:

[incubator-pinot] branch add-logic-for-lead-controller-resource updated (ff23581 -> 8525403)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-logic-for-lead-controller-resource in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from ff23581 Move murmur2 functions to an util class in pinot-common add

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r305043145 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r305043106 ## File path:

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4443: [TE] Detection and alert config formatters

akshayrai commented on a change in pull request #4443: [TE] Detection and alert config formatters URL: https://github.com/apache/incubator-pinot/pull/4443#discussion_r305036096 ## File path:

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4443: [TE] Detection and alert config formatters

akshayrai commented on a change in pull request #4443: [TE] Detection and alert config formatters URL: https://github.com/apache/incubator-pinot/pull/4443#discussion_r305034431 ## File path:

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4443: [TE] Detection and alert config formatters

akshayrai commented on a change in pull request #4443: [TE] Detection and alert config formatters URL: https://github.com/apache/incubator-pinot/pull/4443#discussion_r305007669 ## File path:

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4443: [TE] Detection and alert config formatters

akshayrai commented on a change in pull request #4443: [TE] Detection and alert config formatters URL: https://github.com/apache/incubator-pinot/pull/4443#discussion_r304691386 ## File path:

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4443: [TE] Detection and alert config formatters

jihaozh commented on a change in pull request #4443: [TE] Detection and alert config formatters URL: https://github.com/apache/incubator-pinot/pull/4443#discussion_r305035418 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r305035262 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r305035262 ## File path:

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4443: [TE] Detection and alert config formatters

jihaozh commented on a change in pull request #4443: [TE] Detection and alert config formatters URL: https://github.com/apache/incubator-pinot/pull/4443#discussion_r305035104 ## File path:

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4443: [TE] Detection and alert config formatters

jihaozh commented on a change in pull request #4443: [TE] Detection and alert config formatters URL: https://github.com/apache/incubator-pinot/pull/4443#discussion_r305034612 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r305032488 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r305032488 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r305032488 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4446: Add support in the rebalancer for the user to provide minimum number of serving replicas

siddharthteotia commented on a change in pull request #4446: Add support in the rebalancer for the user to provide minimum number of serving replicas URL: https://github.com/apache/incubator-pinot/pull/4446#discussion_r305030073 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4446: Add support in the rebalancer for the user to provide minimum number of serving replicas

siddharthteotia commented on a change in pull request #4446: Add support in the rebalancer for the user to provide minimum number of serving replicas URL: https://github.com/apache/incubator-pinot/pull/4446#discussion_r305029885 ## File path:

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4443: [TE] Detection and alert config formatters

xiaohui-sun commented on a change in pull request #4443: [TE] Detection and alert config formatters URL: https://github.com/apache/incubator-pinot/pull/4443#discussion_r305022439 ## File path:

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4443: [TE] Detection and alert config formatters

xiaohui-sun commented on a change in pull request #4443: [TE] Detection and alert config formatters URL: https://github.com/apache/incubator-pinot/pull/4443#discussion_r305026168 ## File path:

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4443: [TE] Detection and alert config formatters

xiaohui-sun commented on a change in pull request #4443: [TE] Detection and alert config formatters URL: https://github.com/apache/incubator-pinot/pull/4443#discussion_r305024900 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r305026100 ## File path:

[GitHub] [incubator-pinot] siddharthteotia opened a new pull request #4446: Add support in the rebalancer for the user to provide minimum number of serving replicas

siddharthteotia opened a new pull request #4446: Add support in the rebalancer for the user to provide minimum number of serving replicas URL: https://github.com/apache/incubator-pinot/pull/4446 The current implementation of no-downtime rebalancing keeps up at least 1 serving replica up

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r305014192 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r305012494 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r305004059 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r304999023 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/HashUtils.java

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r305008716 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r304999654 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r305007686 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r305013493 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r30474 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r305011365 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r305003650 ## File path:

[GitHub] [incubator-pinot] codecov-io commented on issue #4445: [WIP]Refactor pinot-connectors to break the dependencies from kafka 0.9

codecov-io commented on issue #4445: [WIP]Refactor pinot-connectors to break the dependencies from kafka 0.9 URL: https://github.com/apache/incubator-pinot/pull/4445#issuecomment-512749613 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4445?src=pr=h1) Report >

[incubator-pinot] branch refactor_kafka updated (1549f5b -> 6daa154)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch refactor_kafka in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 1549f5b Refactor pinot-connectors to break the dependencies from kafka 0.9 add 6daa154

[incubator-pinot] branch refactor_kafka updated (3226348 -> 1549f5b)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch refactor_kafka in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 3226348 Refactor pinot-connectors to break the dependencies from kafka 0.9 add 1549f5b