[GitHub] [incubator-pinot] codecov-io commented on issue #4532: Expose a method to determine if a QueryExceptionErrorCode represents a client-side error

codecov-io commented on issue #4532: Expose a method to determine if a QueryExceptionErrorCode represents a client-side error URL: https://github.com/apache/incubator-pinot/pull/4532#issuecomment-522854033 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4532?src=pr=h1)

[incubator-pinot] branch master updated: Expose a method to determine if a QueryExceptionErrorCode represents a client-side error (#4532)

This is an automated email from the ASF dual-hosted git repository. sunithabeeram pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 83cc88d Expose a method to

[GitHub] [incubator-pinot] sunithabeeram merged pull request #4532: Expose a method to determine if a QueryExceptionErrorCode represents a client-side error

sunithabeeram merged pull request #4532: Expose a method to determine if a QueryExceptionErrorCode represents a client-side error URL: https://github.com/apache/incubator-pinot/pull/4532 This is an automated message from

[GitHub] [incubator-pinot] snleee merged pull request #4537: Fixing metrics aggregation logic for Float and Double

snleee merged pull request #4537: Fixing metrics aggregation logic for Float and Double URL: https://github.com/apache/incubator-pinot/pull/4537 This is an automated message from the Apache Git Service. To respond to the

[incubator-pinot] branch master updated: Fixing metrics aggregation logic for Float and Double (#4537)

This is an automated email from the ASF dual-hosted git repository. snlee pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 3d9bd65 Fixing metrics aggregation

[incubator-pinot] branch rename_replica_group deleted (was ff902b1)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch rename_replica_group in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. was ff902b1 [Instance Assignment] Rename instance level replica to replica-group The revisions

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #4536: [Instance Assignment] Rename instance level replica to replica-group

Jackie-Jiang merged pull request #4536: [Instance Assignment] Rename instance level replica to replica-group URL: https://github.com/apache/incubator-pinot/pull/4536 This is an automated message from the Apache Git Service.

[incubator-pinot] branch master updated: [Instance Assignment] Rename instance level replica to replica-group (#4536)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new f3893c9 [Instance Assignment] Rename

[incubator-pinot] branch rename_replica_group updated (54c3beb -> ff902b1)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch rename_replica_group in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 54c3beb [Instance Assignment] Rename instance level replica to replica-group add

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4536: [Instance Assignment] Rename instance level replica to replica-group

codecov-io edited a comment on issue #4536: [Instance Assignment] Rename instance level replica to replica-group URL: https://github.com/apache/incubator-pinot/pull/4536#issuecomment-522775059 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4536?src=pr=h1) Report >

[incubator-pinot] branch null_value_support deleted (was 469fc7d)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch null_value_support in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. was 469fc7d Fix the record reader for multi-value with null element The revisions that were on

[incubator-pinot] branch master updated (0d69302 -> 9f276fc)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 0d69302 [Instance Assignment] De-couple assignment strategy from SegmentAssignment (#4533) add

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #4541: Fix the record reader for multi-value with null element

Jackie-Jiang merged pull request #4541: Fix the record reader for multi-value with null element URL: https://github.com/apache/incubator-pinot/pull/4541 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-pinot] codecov-io commented on issue #4541: Fix the record reader for multi-value with null element

codecov-io commented on issue #4541: Fix the record reader for multi-value with null element URL: https://github.com/apache/incubator-pinot/pull/4541#issuecomment-522830877 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4541?src=pr=h1) Report > Merging

[incubator-pinot] branch rename_replica_group updated (a204a6f -> 54c3beb)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch rename_replica_group in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard a204a6f [Instance Assignment] Rename instance level replica to replica-group add

[incubator-pinot] branch rename_replica_group updated (46d2ac1 -> a204a6f)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch rename_replica_group in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 46d2ac1 [Instance Assignment] Rename instance level replica to replica-group add

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4536: [Instance Assignment] Rename instance level replica to replica-group

Jackie-Jiang commented on a change in pull request #4536: [Instance Assignment] Rename instance level replica to replica-group URL: https://github.com/apache/incubator-pinot/pull/4536#discussion_r315484705 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #4541: Fix the record reader for multi-value with null element

Jackie-Jiang opened a new pull request #4541: Fix the record reader for multi-value with null element URL: https://github.com/apache/incubator-pinot/pull/4541 For multi-valued column, ignore all the null values This is an

[incubator-pinot] branch null_value_support created (now 469fc7d)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch null_value_support in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 469fc7d Fix the record reader for multi-value with null element No new revisions were added

[incubator-pinot] branch bugfixing_orderby updated (a9db65b -> 71b10d6)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch bugfixing_orderby in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard a9db65b Fixing the issue of selection order by won't give correct ordering add 71b10d6

[incubator-pinot] branch bugfixing_orderby updated (6239c65 -> a9db65b)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch bugfixing_orderby in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 6239c65 Fixing the issue of selection order by won't give correct ordering add a9db65b

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #4540: Fixing the issue of selection order by won't give correct ordering

fx19880617 opened a new pull request #4540: Fixing the issue of selection order by won't give correct ordering URL: https://github.com/apache/incubator-pinot/pull/4540 This is an automated message from the Apache Git

[incubator-pinot] branch bugfixing_orderby created (now 6239c65)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch bugfixing_orderby in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 6239c65 Fixing the issue of selection order by won't give correct ordering This branch

[incubator-pinot] 01/01: Fixing the issue of selection order by won't give correct ordering

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch bugfixing_orderby in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 6239c655d4d9bfe9b36661231a06adea4f82b90f Author: Xiang Fu AuthorDate: Mon Aug 19 18:44:28 2019

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4539: [TE] Make HTTPS redirection configurable

xiaohui-sun commented on a change in pull request #4539: [TE] Make HTTPS redirection configurable URL: https://github.com/apache/incubator-pinot/pull/4539#discussion_r315471069 ## File path: thirdeye/thirdeye-frontend/config/environment.js ## @@ -23,6 +23,8 @@

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4539: [TE] Make HTTPS redirection configurable

jihaozh commented on a change in pull request #4539: [TE] Make HTTPS redirection configurable URL: https://github.com/apache/incubator-pinot/pull/4539#discussion_r315459940 ## File path: thirdeye/thirdeye-frontend/config/environment.js ## @@ -23,6 +23,8 @@ module.exports

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4539: [TE] Make HTTPS redirection configurable

xiaohui-sun commented on a change in pull request #4539: [TE] Make HTTPS redirection configurable URL: https://github.com/apache/incubator-pinot/pull/4539#discussion_r315459350 ## File path: thirdeye/thirdeye-frontend/config/environment.js ## @@ -23,6 +23,8 @@

[GitHub] [incubator-pinot] jihaozh opened a new pull request #4539: [TE] Make HTTPS redirection configurable

jihaozh opened a new pull request #4539: [TE] Make HTTPS redirection configurable URL: https://github.com/apache/incubator-pinot/pull/4539 Make HTTPS redirection configurable. By default set to false. This is an automated

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4536: [Instance Assignment] Rename instance level replica to replica-group

mcvsubbu commented on a change in pull request #4536: [Instance Assignment] Rename instance level replica to replica-group URL: https://github.com/apache/incubator-pinot/pull/4536#discussion_r315449791 ## File path:

[GitHub] [incubator-pinot] mayankshriv closed pull request #4538: Fix bug in updating of metrics of float/double type in realtime

mayankshriv closed pull request #4538: Fix bug in updating of metrics of float/double type in realtime URL: https://github.com/apache/incubator-pinot/pull/4538 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-pinot] mayankshriv commented on issue #4538: Fix bug in updating of metrics of float/double type in realtime

mayankshriv commented on issue #4538: Fix bug in updating of metrics of float/double type in realtime URL: https://github.com/apache/incubator-pinot/pull/4538#issuecomment-522793466 Closing as another fix was filed in #4537

[GitHub] [incubator-pinot] mayankshriv opened a new pull request #4538: Fix bug in updating of metrics of float/double type in realtime

mayankshriv opened a new pull request #4538: Fix bug in updating of metrics of float/double type in realtime URL: https://github.com/apache/incubator-pinot/pull/4538 The current code has a bug where it is not updating the metrics of float/double types correctly. This PR fixes the bug.

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4537: Fixing metrics aggregation logic for Float and Double

codecov-io edited a comment on issue #4537: Fixing metrics aggregation logic for Float and Double URL: https://github.com/apache/incubator-pinot/pull/4537#issuecomment-522777615 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4537?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] icefury71 commented on issue #4537: Fixing metrics aggregation logic for Float and Double

icefury71 commented on issue #4537: Fixing metrics aggregation logic for Float and Double URL: https://github.com/apache/incubator-pinot/pull/4537#issuecomment-522780828 Added a unit test for Float type metric This is an

[GitHub] [incubator-pinot] codecov-io commented on issue #4537: Fixing metrics aggregation logic for Float and Double

codecov-io commented on issue #4537: Fixing metrics aggregation logic for Float and Double URL: https://github.com/apache/incubator-pinot/pull/4537#issuecomment-522777615 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4537?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io commented on issue #4536: [Instance Assignment] Rename instance level replica to replica-group

codecov-io commented on issue #4536: [Instance Assignment] Rename instance level replica to replica-group URL: https://github.com/apache/incubator-pinot/pull/4536#issuecomment-522775059 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4536?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4532: Expose a method to determine if a QueryExceptionErrorCode represents a client-side error

mcvsubbu commented on a change in pull request #4532: Expose a method to determine if a QueryExceptionErrorCode represents a client-side error URL: https://github.com/apache/incubator-pinot/pull/4532#discussion_r315427168 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4532: Expose a method to determine if a QueryExceptionErrorCode represents a client-side error

mcvsubbu commented on a change in pull request #4532: Expose a method to determine if a QueryExceptionErrorCode represents a client-side error URL: https://github.com/apache/incubator-pinot/pull/4532#discussion_r315426758 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4532: Expose a method to determine if a QueryExceptionErrorCode represents a client-side error

mcvsubbu commented on a change in pull request #4532: Expose a method to determine if a QueryExceptionErrorCode represents a client-side error URL: https://github.com/apache/incubator-pinot/pull/4532#discussion_r315425960 ## File path:

[GitHub] [incubator-pinot] icefury71 opened a new pull request #4537: Fixing metrics aggregation logic for Float and Double

icefury71 opened a new pull request #4537: Fixing metrics aggregation logic for Float and Double URL: https://github.com/apache/incubator-pinot/pull/4537 There seems to an issue with metrics aggregation for float and double type columns. The current code seems to ignore the value of the

[incubator-pinot] branch rename_replica_group updated (46bb458 -> 46d2ac1)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch rename_replica_group in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 46bb458 [Instance Assignment] Rename instance level replica to replica-group add

[incubator-pinot] 01/01: [Instance Assignment] Rename instance level replica to replica-group

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch rename_replica_group in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 46bb4585b274b548b353441f845595c3d83d9e74 Author: Jackie (Xiaotian) Jiang AuthorDate: Mon Aug 19

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #4536: [Instance Assignment] Rename instance level replica to replica-group

Jackie-Jiang opened a new pull request #4536: [Instance Assignment] Rename instance level replica to replica-group URL: https://github.com/apache/incubator-pinot/pull/4536 To reduce the confusion of the code: - Replica-group: a set of instances that serves one replica of all the

[incubator-pinot] branch rename_replica_group created (now 46bb458)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch rename_replica_group in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 46bb458 [Instance Assignment] Rename instance level replica to replica-group This branch

[GitHub] [incubator-pinot] siddharthteotia commented on issue #4511: Change the way we compute end-time of realtime consuming segments

siddharthteotia commented on issue #4511: Change the way we compute end-time of realtime consuming segments URL: https://github.com/apache/incubator-pinot/issues/4511#issuecomment-522757360 Will work on this. This is an

[GitHub] [incubator-pinot] siddharthteotia commented on issue #4034: Support variable byte no dictionary columns in Consuming segments

siddharthteotia commented on issue #4034: Support variable byte no dictionary columns in Consuming segments URL: https://github.com/apache/incubator-pinot/issues/4034#issuecomment-522757448 Will work on this This is an

[incubator-pinot] branch update_selection_query_1 updated (fab60e9 -> a5dee3f)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch update_selection_query_1 in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard fab60e9 update with more checks add a5dee3f update with more checks This update

[incubator-pinot] branch master updated: [Instance Assignment] De-couple assignment strategy from SegmentAssignment (#4533)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 0d69302 [Instance Assignment]

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #4533: [Instance Assignment] De-couple assignment strategy from SegmentAssignment

Jackie-Jiang merged pull request #4533: [Instance Assignment] De-couple assignment strategy from SegmentAssignment URL: https://github.com/apache/incubator-pinot/pull/4533 This is an automated message from the Apache Git

[incubator-pinot] branch segment_assignment deleted (was 4c39f35)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch segment_assignment in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. was 4c39f35 [Instance Assignment] De-couple assignment strategy from SegmentAssignment The

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4533: [Instance Assignment] De-couple assignment strategy from SegmentAssignment

Jackie-Jiang commented on a change in pull request #4533: [Instance Assignment] De-couple assignment strategy from SegmentAssignment URL: https://github.com/apache/incubator-pinot/pull/4533#discussion_r315414688 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4532: Expose a method to determine if a QueryExceptionErrorCode represents a client-side error

mcvsubbu commented on a change in pull request #4532: Expose a method to determine if a QueryExceptionErrorCode represents a client-side error URL: https://github.com/apache/incubator-pinot/pull/4532#discussion_r315388985 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4532: Expose a method to determine if a QueryExceptionErrorCode represents a client-side error

mcvsubbu commented on a change in pull request #4532: Expose a method to determine if a QueryExceptionErrorCode represents a client-side error URL: https://github.com/apache/incubator-pinot/pull/4532#discussion_r315388244 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315381026 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/IntermediateResultsBlock.java

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315385262 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/DefaultAggregationExecutor.java

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315385290 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315381026 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/IntermediateResultsBlock.java

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315384521 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/OutputColumnListAstNode.java

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315356244 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/SelectAstNode.java ## @@

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315384417 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/FunctionCallAstNode.java ##

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315384386 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/FunctionCallAstNode.java ##

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315383718 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/AggregationFunctionContext.java

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315382449 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/TransformPlanNode.java ## @@ -124,6

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315382449 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/TransformPlanNode.java ## @@ -124,6

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315382449 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/TransformPlanNode.java ## @@ -124,6

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315381929 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/TransformPlanNode.java ## @@ -76,7

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315381026 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/IntermediateResultsBlock.java

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315381026 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/IntermediateResultsBlock.java

[incubator-pinot] branch update_selection_query_1 updated (702710f -> fab60e9)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch update_selection_query_1 in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 702710f update column data type cast during inter merge add fab60e9 update with

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315356244 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/SelectAstNode.java ## @@

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315355301 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/FunctionCallAstNode.java ##

[incubator-pinot] branch update_selection_query_1 updated (eeb7721 -> 702710f)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch update_selection_query_1 in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard eeb7721 update column data type cast during inter merge add 702710f update column

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4533: [Instance Assignment] De-couple assignment strategy from SegmentAssignment

mcvsubbu commented on a change in pull request #4533: [Instance Assignment] De-couple assignment strategy from SegmentAssignment URL: https://github.com/apache/incubator-pinot/pull/4533#discussion_r315353815 ## File path:

[incubator-pinot] branch update_selection_query_1 updated (905ada5 -> eeb7721)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch update_selection_query_1 in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. omit 905ada5 update column data type cast during inter merge add eeb7721 update column

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315338961 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/OutputColumnListAstNode.java

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315338961 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/OutputColumnListAstNode.java

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315336815 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/DataBlockCache.java ## @@ -366,4

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315338961 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/OutputColumnListAstNode.java

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315336815 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/DataBlockCache.java ## @@ -366,4

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315334415 ## File path: pinot-common/src/thrift/request.thrift ## @@ -155,6 +155,7 @@ struct BrokerRequest { 16:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause

siddharthteotia commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315334415 ## File path: pinot-common/src/thrift/request.thrift ## @@ -155,6 +155,7 @@ struct BrokerRequest { 16:

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4535: Implement DISTINCT clause

mayankshriv commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315312401 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/FunctionCallAstNode.java ## @@

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4535: Implement DISTINCT clause

mayankshriv commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315323073 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/EmptyAggregationFunction.java

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4535: Implement DISTINCT clause

mayankshriv commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315321793 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/AggregationFunctionContext.java

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4535: Implement DISTINCT clause

mayankshriv commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315321161 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/TransformPlanNode.java ## @@ -76,7 +83,19

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4535: Implement DISTINCT clause

mayankshriv commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315313078 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/OutputColumnListAstNode.java ##

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4535: Implement DISTINCT clause

mayankshriv commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315314108 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/SelectAstNode.java ## @@

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4535: Implement DISTINCT clause

mayankshriv commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315318434 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/DataBlockCache.java ## @@ -366,4 +366,74

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4535: Implement DISTINCT clause

mayankshriv commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315311644 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/FunctionCallAstNode.java ## @@

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4535: Implement DISTINCT clause

mayankshriv commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315322506 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/DefaultAggregationExecutor.java

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4535: Implement DISTINCT clause

mayankshriv commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315315831 ## File path: pinot-common/src/thrift/request.thrift ## @@ -155,6 +155,7 @@ struct BrokerRequest { 16:

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4535: Implement DISTINCT clause

mayankshriv commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315321493 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/TransformPlanNode.java ## @@ -124,6 +143,10

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4535: Implement DISTINCT clause

mayankshriv commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315313490 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/OutputColumnListAstNode.java ##

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4535: Implement DISTINCT clause

mayankshriv commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315319936 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/IntermediateResultsBlock.java ##

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4535: Implement DISTINCT clause

mayankshriv commented on a change in pull request #4535: Implement DISTINCT clause URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r315310489 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/FunctionCallAstNode.java ## @@

[GitHub] [incubator-pinot] xiaohui-sun merged pull request #4483: [TE] frontend - harleyjj/create-alert - add link for onboarding mysql…

xiaohui-sun merged pull request #4483: [TE] frontend - harleyjj/create-alert - add link for onboarding mysql… URL: https://github.com/apache/incubator-pinot/pull/4483 This is an automated message from the Apache Git

[incubator-pinot] branch master updated: [TE] frontend - harleyjj/create-alert - add link for onboarding mysql and presto metrics (#4483)

This is an automated email from the ASF dual-hosted git repository. xhsun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new d120f4d [TE] frontend -

[GitHub] [incubator-pinot] xiaohui-sun commented on issue #4527: Group by with order by

xiaohui-sun commented on issue #4527: Group by with order by URL: https://github.com/apache/incubator-pinot/pull/4527#issuecomment-522637507 Great work @npawar. This can help ThirdEye since we use top k to filter on results a lot.