[GitHub] [incubator-pinot] chenboat commented on issue #4686: Pinot-server getting timedout with zookeeper and it is not reconnecting back

chenboat commented on issue #4686: Pinot-server getting timedout with zookeeper and it is not reconnecting back URL: https://github.com/apache/incubator-pinot/issues/4686#issuecomment-539830511 Do you know why the Pinot server's connection to zookeeper got timeout? We ran into similar

[GitHub] [incubator-pinot] snleee opened a new pull request #4687: Remove "refresh" usecase check in RoutingTableBuilderFactory

snleee opened a new pull request #4687: Remove "refresh" usecase check in RoutingTableBuilderFactory URL: https://github.com/apache/incubator-pinot/pull/4687 We have created "DefaultOfflineRoutingTableBuilder" when the use case is a refresh use case. Since PartitionAwareOffline

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

Jackie-Jiang commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r332783799 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

Jackie-Jiang commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r332764404 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

Jackie-Jiang commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r332781939 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

Jackie-Jiang commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r332778952 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/table/SimpleIndexedTable.java

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

Jackie-Jiang commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r332779790 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

Jackie-Jiang commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r332764719 ## File path: pinot-common/src/main/java/org/apache/pinot/common/response/broker/ResultTable.java

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4602: First pass of GROUP BY with ORDER BY support

codecov-io edited a comment on issue #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#issuecomment-530129911 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4602?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #4608: Unit tests and bug fixes for DeleteTable rest API for controller.

Jackie-Jiang merged pull request #4608: Unit tests and bug fixes for DeleteTable rest API for controller. URL: https://github.com/apache/incubator-pinot/pull/4608 This is an automated message from the Apache Git Service. To

[incubator-pinot] branch master updated (2d20c64 -> ce298ba)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 2d20c64 Possible fix for NPE seen in this test. (#4684) add ce298ba Unit tests and bug fixes for

[GitHub] [incubator-pinot] chenboat commented on issue #4608: Unit tests and bug fixes for DeleteTable rest API for controller.

chenboat commented on issue #4608: Unit tests and bug fixes for DeleteTable rest API for controller. URL: https://github.com/apache/incubator-pinot/pull/4608#issuecomment-539694652 > Please address the comments and we will merge the change Done. Please take another look.

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

npawar commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r332713325 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/table/Record.java ## @@ -43,4

[GitHub] [incubator-pinot] vincentchenjl commented on a change in pull request #4685: [TE] handle data insufficient exceptions in the detection pipeline

vincentchenjl commented on a change in pull request #4685: [TE] handle data insufficient exceptions in the detection pipeline URL: https://github.com/apache/incubator-pinot/pull/4685#discussion_r332664162 ## File path:

[GitHub] [incubator-pinot] vincentchenjl commented on a change in pull request #4685: [TE] handle data insufficient exceptions in the detection pipeline

vincentchenjl commented on a change in pull request #4685: [TE] handle data insufficient exceptions in the detection pipeline URL: https://github.com/apache/incubator-pinot/pull/4685#discussion_r332662501 ## File path:

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

mayankshriv commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r332620855 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/table/Record.java ## @@

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

mayankshriv commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r332618635 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/table/ConcurrentIndexedTable.java