chenboat commented on a change in pull request #5444:
URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r431615072
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/docidsets/AndDocIdSet.java
##
@@ -0,0 +1,156 @@
+/**
+ * Licensed to the A
chenboat commented on pull request #5444:
URL: https://github.com/apache/incubator-pinot/pull/5444#issuecomment-635136647
This PR is too big to review effectively IMO. 89 files in total. Can you
break it down to 3-4 smaller PRs for review: one covering method removal; 1 or
2 PR each cover
chenboat commented on a change in pull request #5444:
URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r431606971
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/BlockMultiValIterator.java
##
@@ -18,33 +18,15 @@
*/
package org.apache.p
chenboat commented on a change in pull request #5444:
URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r431606505
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/BlockValIterator.java
##
@@ -20,9 +20,23 @@
public interface BlockValIter
chenboat commented on a change in pull request #5444:
URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r431604976
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/BlockSingleValIterator.java
##
@@ -18,37 +18,17 @@
*/
package org.apache.
chenboat commented on a change in pull request #5444:
URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r431604799
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/BlockDocIdSet.java
##
@@ -21,6 +21,4 @@
public interface BlockDocIdSet {
chenboat commented on a change in pull request #5444:
URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r431604484
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/BlockMultiValIterator.java
##
@@ -18,33 +18,15 @@
*/
package org.apache.p
fx19880617 edited a comment on pull request #5456:
URL: https://github.com/apache/incubator-pinot/pull/5456#issuecomment-635100955
This is an automated message from the Apache Git Service.
To respond to the message, please log
fx19880617 commented on pull request #5456:
URL: https://github.com/apache/incubator-pinot/pull/5456#issuecomment-635100955
> I think the real issue is BrokerRequest is incapable of storing
expressions correctly, it converts them to String. This seems like a temp
workaround (approving it o
This is an automated email from the ASF dual-hosted git repository.
kishoreg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 7f10c5c Single Quote String Literal
kishoreg merged pull request #5456:
URL: https://github.com/apache/incubator-pinot/pull/5456
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
mayankshriv edited a comment on pull request #5456:
URL: https://github.com/apache/incubator-pinot/pull/5456#issuecomment-635099149
I think the real issue is BrokerRequest is incapable of storing expressions
correctly, it converts them to String. This seems like a temp workaround
(approvin
mayankshriv commented on pull request #5456:
URL: https://github.com/apache/incubator-pinot/pull/5456#issuecomment-635099149
I think the real issue is BrokerRequest is incapable of storing expressions
correctly, it converts them to String. This seems like a temp workaround
(approving it on
This is an automated email from the ASF dual-hosted git repository.
haibow pushed a change to tag release-0.4.0
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
at 3f81191 (commit)
No new revisions were added by this update.
akshayrai merged pull request #5458:
URL: https://github.com/apache/incubator-pinot/pull/5458
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
akshayrai09 pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 4988d72 [TE] add back frontend as submodule (#5457)
add b6cb44c [TE] clean up somce code and dis
vincentchenjl commented on a change in pull request #5435:
URL: https://github.com/apache/incubator-pinot/pull/5435#discussion_r431529266
##
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/AnomalyResource.java
##
@@ -101,21 +99,18
vincentchenjl commented on a change in pull request #5435:
URL: https://github.com/apache/incubator-pinot/pull/5435#discussion_r431528717
##
File path:
thirdeye/thirdeye-pinot/src/test/java/org/apache/pinot/thirdeye/datalayer/DaoTestUtils.java
##
@@ -275,22 +273,6 @@ public st
vincentchenjl commented on a change in pull request #5435:
URL: https://github.com/apache/incubator-pinot/pull/5435#discussion_r431528040
##
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/AnomalyResource.java
##
@@ -101,21 +99,18
vincentchenjl commented on a change in pull request #5435:
URL: https://github.com/apache/incubator-pinot/pull/5435#discussion_r431527731
##
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/ThirdEyeDashboardApplication.java
##
@@ -160,14 +15
vincentchenjl commented on a change in pull request #5435:
URL: https://github.com/apache/incubator-pinot/pull/5435#discussion_r431526938
##
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/ThirdEyeDashboardApplication.java
##
@@ -160,14 +15
vincentchenjl commented on a change in pull request #5435:
URL: https://github.com/apache/incubator-pinot/pull/5435#discussion_r431522638
##
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/anomaly/task/TaskConstants.java
##
@@ -26,15 +26,8 @@
DE
Jackie-Jiang opened a new pull request #5459:
URL: https://github.com/apache/incubator-pinot/pull/5459
We only have one SegmentOnlineOfflineStateModel, so there is no value
keeping both of them
## Description
Add a description of your PR here.
A good description should incl
akshayrai opened a new pull request #5458:
URL: https://github.com/apache/incubator-pinot/pull/5458
* Move all the task creation methods under TaskUtils
* Disable SLA alerts and wait till the experiment/ramp feature
---
akshayrai merged pull request #5457:
URL: https://github.com/apache/incubator-pinot/pull/5457
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
akshayrai09 pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from d8ea89c Create PULL_REQUEST_TEMPLATE.md (#5345)
add 4988d72 [TE] add back frontend as submodule
vincentchenjl opened a new pull request #5457:
URL: https://github.com/apache/incubator-pinot/pull/5457
This PR is to achieve the following items.
- Fix open source build by adding back frontend as submodule.
- Ensure that frontend is built based on packages from open source NPM.
---
mcvsubbu merged pull request #5345:
URL: https://github.com/apache/incubator-pinot/pull/5345
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
mcvsubbu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from cee2b23 [TE] add mock events loader to pinot-thirdeye docker defaults
(#5454)
add d8ea89c Create P
fx19880617 commented on pull request #5456:
URL: https://github.com/apache/incubator-pinot/pull/5456#issuecomment-634954131
> looks like this fix is a workaround to hide the actual problem in
transform function?
>
> What would be the exception/error in transformfunction without this
kishoreg commented on pull request #5456:
URL: https://github.com/apache/incubator-pinot/pull/5456#issuecomment-634948647
looks like this fix is a workaround to hide the actual problem in transform
function?
What would be the exception/error in transformfunction without this fix
-
fx19880617 opened a new pull request #5456:
URL: https://github.com/apache/incubator-pinot/pull/5456
This fix the issue that of function invoker string output breaks query
syntax.
E.g.
query: `SELECT toDateTime(now(), '-MM-dd z') FROM mytable` becomes:
`SELECT 2020-05-27 UTC F
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch
single_quote_string_literal_for_function_invoke_result
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
at 948062a Single Quote String Literal for function invoker
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch
single_quote_string_literal_for_function_invoke_result
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit 948062aa5f82a2fb508b5f3990e64bd10ccfa553
Author: Xiang Fu
Aut
npawar opened a new pull request #5455:
URL: https://github.com/apache/incubator-pinot/pull/5455
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new cee2b23 [TE] add mock events loader t
apucher merged pull request #5454:
URL: https://github.com/apache/incubator-pinot/pull/5454
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
This is an automated email from the ASF dual-hosted git repository.
mcvsubbu pushed a change to branch adding-pr-template
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from ebfad8f Update PULL_REQUEST_TEMPLATE.md
add 7b2b0a8 Update PULL_REQUEST_TEMPLATE.md
No
apucher opened a new pull request #5454:
URL: https://github.com/apache/incubator-pinot/pull/5454
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a change to branch mock-events-for-pinot-thirdeye-docker
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
at b218d32 [TE] add mock events loader to pinot-thirdeye docker defaults
This
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a commit to branch mock-events-for-pinot-thirdeye-docker
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit b218d32bd4e9731d90c2abfd71e1e0331e2f08cd
Author: Alexander Pucher
AuthorDate: W
npawar closed issue #5269:
URL: https://github.com/apache/incubator-pinot/issues/5269
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
npawar merged pull request #5293:
URL: https://github.com/apache/incubator-pinot/pull/5293
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
nehapawar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new b69453e Adding support for Protobuf
npawar commented on pull request #5293:
URL: https://github.com/apache/incubator-pinot/pull/5293#issuecomment-634850943
Linking to issue https://github.com/apache/incubator-pinot/issues/5269
This is an automated message from
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 008be2d Make Literal transformer return string literals (#5453)
add 3514a17 Add PinotServiceManager
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 008be2d Make Literal transformer return string literals (#5453)
add 3514a17 Add PinotServiceManager
fx19880617 commented on pull request #5266:
URL: https://github.com/apache/incubator-pinot/pull/5266#issuecomment-634823281
> We will fix the incompat at our end. If for some reason we need some
changes, we will come back with those. thanks
Thanks for taking time to review on this !
fx19880617 merged pull request #5266:
URL: https://github.com/apache/incubator-pinot/pull/5266
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
KKcorps commented on a change in pull request #5293:
URL: https://github.com/apache/incubator-pinot/pull/5293#discussion_r431309682
##
File path:
pinot-plugins/pinot-input-format/pinot-protobuf/src/main/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufRecordReader.java
##
jamesyfshao commented on pull request #5394:
URL: https://github.com/apache/incubator-pinot/pull/5394#issuecomment-634800807
@kishoreg @mcvsubbu @Jackie-Jiang appreciated if you guys can take a look at
the diff this week when you have time
-
npawar commented on a change in pull request #5293:
URL: https://github.com/apache/incubator-pinot/pull/5293#discussion_r431285868
##
File path:
pinot-plugins/pinot-input-format/pinot-protobuf/src/main/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufRecordReader.java
###
fx19880617 merged pull request #5453:
URL: https://github.com/apache/incubator-pinot/pull/5453
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 008be2d Make Literal transformer retu
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to annotated tag pinot-0.4.0
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
*** WARNING: tag pinot-0.4.0 was modified! ***
from fb62e74 (commit)
to 22452aa (tag)
tagg
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch release-0.4.0-rc1
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/release-0.4.0-rc1 by this push:
new 3f81191 [maven-
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch release-0.4.0-rc1
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/release-0.4.0-rc1 by this push:
new fb62e74 [maven-
fx19880617 commented on a change in pull request #5266:
URL: https://github.com/apache/incubator-pinot/pull/5266#discussion_r430928817
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java
##
@@ -43,17 +44,79 @@
*/
@SuppressWarnings("unus
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new ac443f4 [TE] fix dockerfile to accoun
fx19880617 merged pull request #5452:
URL: https://github.com/apache/incubator-pinot/pull/5452
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch fixing_literal_in_selection
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard ca63e41 Make Literal transformer return string literals
add 04c437a Make Litera
kishoreg commented on pull request #5453:
URL: https://github.com/apache/incubator-pinot/pull/5453#issuecomment-634469047
Add a test case please
This is an automated message from the Apache Git Service.
To respond to the mes
62 matches
Mail list logo