[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6148: UI integration of instance and segment operations

codecov-io edited a comment on pull request #6148: URL: https://github.com/apache/incubator-pinot/pull/6148#issuecomment-710728658 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6148?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io commented on pull request #6148: UI integration of instance and segment operations

codecov-io commented on pull request #6148: URL: https://github.com/apache/incubator-pinot/pull/6148#issuecomment-710728658 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6148?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] npawar commented on a change in pull request #6124: RealtimeToOfflineSegments task generator

npawar commented on a change in pull request #6124: URL: https://github.com/apache/incubator-pinot/pull/6124#discussion_r506778282 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/RealtimeToOfflineSegmentsMinionClusterIntegrationTest.java

[GitHub] [incubator-pinot] npawar commented on a change in pull request #6124: RealtimeToOfflineSegments task generator

npawar commented on a change in pull request #6124: URL: https://github.com/apache/incubator-pinot/pull/6124#discussion_r506778177 ## File path: pinot-core/src/test/java/org/apache/pinot/core/segment/processing/framework/SegmentMapperTest.java ## @@ -275,7 +275,7 @@ public

[GitHub] [incubator-pinot] npawar commented on a change in pull request #6124: RealtimeToOfflineSegments task generator

npawar commented on a change in pull request #6124: URL: https://github.com/apache/incubator-pinot/pull/6124#discussion_r506777945 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/MinionConstants.java ## @@ -62,16 +62,35 @@ private MinionConstants() {

[GitHub] [incubator-pinot] npawar commented on a change in pull request #6124: RealtimeToOfflineSegments task generator

npawar commented on a change in pull request #6124: URL: https://github.com/apache/incubator-pinot/pull/6124#discussion_r506777846 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/ClusterInfoProvider.java ## @@ -93,6 +97,38 @@ public

[GitHub] [incubator-pinot] npawar commented on a change in pull request #6124: RealtimeToOfflineSegments task generator

npawar commented on a change in pull request #6124: URL: https://github.com/apache/incubator-pinot/pull/6124#discussion_r50680 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/generator/RealtimeToOfflineSegmentsTaskGenerator.java

[GitHub] [incubator-pinot] npawar commented on a change in pull request #6124: RealtimeToOfflineSegments task generator

npawar commented on a change in pull request #6124: URL: https://github.com/apache/incubator-pinot/pull/6124#discussion_r506777684 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/generator/RealtimeToOfflineSegmentsTaskGenerator.java

[GitHub] [incubator-pinot] npawar commented on a change in pull request #6124: RealtimeToOfflineSegments task generator

npawar commented on a change in pull request #6124: URL: https://github.com/apache/incubator-pinot/pull/6124#discussion_r506777612 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/generator/RealtimeToOfflineSegmentsTaskGenerator.java

[GitHub] [incubator-pinot] vincentchenjl opened a new pull request #6151: [TE] Remove maven-shade-plugin in thirdeye-dashboard

vincentchenjl opened a new pull request #6151: URL: https://github.com/apache/incubator-pinot/pull/6151 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6094: Implement the segment merge task generator

codecov-io edited a comment on pull request #6094: URL: https://github.com/apache/incubator-pinot/pull/6094#issuecomment-709807920 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6094?src=pr=h1) Report > Merging

[incubator-pinot] branch adding_grpc_port_to_instance updated (9796cbf -> 845320e)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch adding_grpc_port_to_instance in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 9796cbf Adding grpcPort in controller instance API response add 845320e

[incubator-pinot] branch adding_grpc_port_to_instance updated (9796cbf -> 845320e)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch adding_grpc_port_to_instance in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 9796cbf Adding grpcPort in controller instance API response add 845320e

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #6150: Adding grpcPort in controller instance API response

fx19880617 commented on a change in pull request #6150: URL: https://github.com/apache/incubator-pinot/pull/6150#discussion_r506740047 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotInstanceRestletResource.java ## @@ -101,6 +101,7

[GitHub] [incubator-pinot] jtao15 commented on issue #6111: StartMinionCommand

jtao15 commented on issue #6111: URL: https://github.com/apache/incubator-pinot/issues/6111#issuecomment-710623371 I'll work on this. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-pinot] snleee closed issue #5804: File processing errors during `CreateSegment` does not print the name of the bad file

snleee closed issue #5804: URL: https://github.com/apache/incubator-pinot/issues/5804 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-pinot] snleee commented on issue #5804: File processing errors during `CreateSegment` does not print the name of the bad file

snleee commented on issue #5804: URL: https://github.com/apache/incubator-pinot/issues/5804#issuecomment-710588651 Closing the issue since the fix is merged This is an automated message from the Apache Git Service. To

[GitHub] [incubator-pinot] jackjlli commented on pull request #6139: Remove tyrus dependencies in pinot-tools module

jackjlli commented on pull request #6139: URL: https://github.com/apache/incubator-pinot/pull/6139#issuecomment-710561408 > Isn't this just a version conflict? Does excluding this conflicting library from one of the library work? We cannot exclude either one of them because `tyrus`

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #6139: Remove tyrus dependencies in pinot-tools module

Jackie-Jiang commented on pull request #6139: URL: https://github.com/apache/incubator-pinot/pull/6139#issuecomment-710553719 Isn't this just a version conflict? Does excluding this conflicting library from one of the library work?

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6150: Adding grpcPort in controller instance API response

Jackie-Jiang commented on a change in pull request #6150: URL: https://github.com/apache/incubator-pinot/pull/6150#discussion_r506685742 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotInstanceRestletResource.java ## @@ -101,6

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #6139: Remove tyrus dependencies in pinot-tools module

Jackie-Jiang commented on pull request #6139: URL: https://github.com/apache/incubator-pinot/pull/6139#issuecomment-710493714 @mayankshriv @jackjlli I'm okay using static file for testing purpose only, but if we remove `tyrus`, does that mean we can no longer consume real streaming events

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6094: Implement the segment merge task generator

codecov-io edited a comment on pull request #6094: URL: https://github.com/apache/incubator-pinot/pull/6094#issuecomment-709807920 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6094?src=pr=h1) Report > Merging

[incubator-pinot] branch master updated (44fcf1e -> 1750548)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 44fcf1e add query option of disabling upsert during query (#6141) add 1750548 add validation for

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #6149: add validation for upsert tables

Jackie-Jiang merged pull request #6149: URL: https://github.com/apache/incubator-pinot/pull/6149 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] snleee commented on a change in pull request #6124: RealtimeToOfflineSegments task generator

snleee commented on a change in pull request #6124: URL: https://github.com/apache/incubator-pinot/pull/6124#discussion_r506672510 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/RealtimeToOfflineSegmentsMinionClusterIntegrationTest.java

[GitHub] [incubator-pinot] fx19880617 commented on pull request #6150: Adding grpcPort in controller instance API response

fx19880617 commented on pull request #6150: URL: https://github.com/apache/incubator-pinot/pull/6150#issuecomment-710290647 > > ## Description > > Adding field "grpcPort" in controller's /instance API responses. > > So external services can get the grpc port used for the given pinot

[GitHub] [incubator-pinot] siddharthteotia commented on pull request #6150: Adding grpcPort in controller instance API response

siddharthteotia commented on pull request #6150: URL: https://github.com/apache/incubator-pinot/pull/6150#issuecomment-710222993 > ## Description > Adding field "grpcPort" in controller's /instance API responses. > So external services can get the grpc port used for the given pinot

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #6150: Adding grpcPort in controller instance API response

fx19880617 opened a new pull request #6150: URL: https://github.com/apache/incubator-pinot/pull/6150 ## Description Adding field "grpcPort" in controller's /instance API responses. So external services can get the grpc port used for the given pinot server.

[incubator-pinot] branch adding_grpc_port_to_instance created (now 9796cbf)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch adding_grpc_port_to_instance in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 9796cbf Adding grpcPort in controller instance API response This branch includes

[incubator-pinot] 01/01: Adding grpcPort in controller instance API response

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch adding_grpc_port_to_instance in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 9796cbfcebe167ad6c5ad4f8029c85fa266614af Author: Xiang Fu AuthorDate: Fri Oct 16

[GitHub] [incubator-pinot] harleyjj commented on a change in pull request #6101: [TE] web-api - endpoint for getting performance metrics of detection …

harleyjj commented on a change in pull request #6101: URL: https://github.com/apache/incubator-pinot/pull/6101#discussion_r506594997 ## File path: thirdeye/thirdeye-spi/src/main/java/org/apache/pinot/thirdeye/detection/performance/PerformanceMetrics.java ## @@ -0,0 +1,136 @@

[GitHub] [incubator-pinot] mayankshriv commented on pull request #6139: Remove tyrus dependencies in pinot-tools module

mayankshriv commented on pull request #6139: URL: https://github.com/apache/incubator-pinot/pull/6139#issuecomment-710176443 > I'm against changing the data to a static file. The purpose of the quick start is letting the user play with Pinot and they should be able to see the latest