[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6728: Unify data type conversion and formatting

2021-04-01 Thread GitBox
Jackie-Jiang commented on a change in pull request #6728: URL: https://github.com/apache/incubator-pinot/pull/6728#discussion_r60605 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/PinotDataType.java ## @@ -40,22 +41,22 @@ BOOLEAN {

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6728: Unify data type conversion and formatting

2021-03-31 Thread GitBox
Jackie-Jiang commented on a change in pull request #6728: URL: https://github.com/apache/incubator-pinot/pull/6728#discussion_r605186834 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/JsonExtractScalarTransformFunction.java ## @@

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6728: Unify data type conversion and formatting

2021-03-31 Thread GitBox
Jackie-Jiang commented on a change in pull request #6728: URL: https://github.com/apache/incubator-pinot/pull/6728#discussion_r605139108 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/FieldSpec.java ## @@ -398,6 +390,58 @@ public boolean isFixedWidth() {

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6728: Unify data type conversion and formatting

2021-03-31 Thread GitBox
Jackie-Jiang commented on a change in pull request #6728: URL: https://github.com/apache/incubator-pinot/pull/6728#discussion_r605137900 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/selection/SelectionOperatorUtils.java ## @@ -490,82 +491,13 @@ public

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6728: Unify data type conversion and formatting

2021-03-31 Thread GitBox
Jackie-Jiang commented on a change in pull request #6728: URL: https://github.com/apache/incubator-pinot/pull/6728#discussion_r605137651 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java ## @@ -127,62 +126,41 @@ public static

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6728: Unify data type conversion and formatting

2021-03-31 Thread GitBox
Jackie-Jiang commented on a change in pull request #6728: URL: https://github.com/apache/incubator-pinot/pull/6728#discussion_r605136714 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java ## @@ -127,62 +126,41 @@ public static

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6728: Unify data type conversion and formatting

2021-03-31 Thread GitBox
Jackie-Jiang commented on a change in pull request #6728: URL: https://github.com/apache/incubator-pinot/pull/6728#discussion_r605135579 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java ## @@ -127,62 +126,41 @@ public static

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6728: Unify data type conversion and formatting

2021-03-31 Thread GitBox
Jackie-Jiang commented on a change in pull request #6728: URL: https://github.com/apache/incubator-pinot/pull/6728#discussion_r605133627 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java ## @@ -127,62 +126,41 @@ public static

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6728: Unify data type conversion and formatting

2021-03-31 Thread GitBox
Jackie-Jiang commented on a change in pull request #6728: URL: https://github.com/apache/incubator-pinot/pull/6728#discussion_r605132173 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/PinotDataType.java ## @@ -634,7 +754,7 @@ public PinotDataType

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6728: Unify data type conversion and formatting

2021-03-31 Thread GitBox
Jackie-Jiang commented on a change in pull request #6728: URL: https://github.com/apache/incubator-pinot/pull/6728#discussion_r605099417 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/PinotDataType.java ## @@ -439,27 +440,55 @@ public String

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6728: Unify data type conversion and formatting

2021-03-31 Thread GitBox
Jackie-Jiang commented on a change in pull request #6728: URL: https://github.com/apache/incubator-pinot/pull/6728#discussion_r605099417 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/PinotDataType.java ## @@ -439,27 +440,55 @@ public String

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6728: Unify data type conversion and formatting

2021-03-31 Thread GitBox
Jackie-Jiang commented on a change in pull request #6728: URL: https://github.com/apache/incubator-pinot/pull/6728#discussion_r605096611 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/DataSchema.java ## @@ -241,11 +244,179 @@ public boolean