Jackie-Jiang commented on a change in pull request #6728:
URL: https://github.com/apache/incubator-pinot/pull/6728#discussion_r605132173
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/PinotDataType.java
##########
@@ -634,7 +754,7 @@ public PinotDataType getSingleValueType() {
}
public static PinotDataType getPinotDataType(FieldSpec fieldSpec) {
- FieldSpec.DataType dataType = fieldSpec.getDataType();
+ DataType dataType = fieldSpec.getDataType();
Review comment:
We expect `Object[]` in `GenericRow` when ingesting data, but use
primitive array internally for query execution. I'll rename the method and put
some comments describing the behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
